From nobody Mon Feb 9 08:28:27 2026 Received: from mail-oa1-f68.google.com (mail-oa1-f68.google.com [209.85.160.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08B512F5305 for ; Wed, 14 Jan 2026 01:59:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768355974; cv=none; b=p65LmUX45jZdqJhZJbcdqQwhvINerpxWtANjNd5mhorcH6JsTQLMQzAkSWKM4GxrbZSJWrMWHmHN5Ba4DLfnnpOFSJbbv55JqZnEf0UGQFf2nTEN1yljpJv6cuVVncuf2ShRWjr7ruOgYiENcZ5XOHINWx+jOImRyrh8Oubp+yg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768355974; c=relaxed/simple; bh=KZmY7t1nCms4fl3dBwXkSTLPAQxgaCZAAwmDCUvbFS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sxOgSeH09KiHr6JiITkHIwokVfb2PIkD1/857guqUhAHA/+im4s7HxTTrB64PggsUOtSs/tZikM/Hllgv8JoqpPj7bsbCKat+1y4XNaFkeaG0KbxzWEj3y8Tb7GvrwJN+i4ITW41FRFVl8essORtA0k2GG8FI6tpudHjG4f+mmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OICpYnHX; arc=none smtp.client-ip=209.85.160.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OICpYnHX" Received: by mail-oa1-f68.google.com with SMTP id 586e51a60fabf-3e7f68df436so352949fac.1 for ; Tue, 13 Jan 2026 17:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768355972; x=1768960772; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OmSrywNj94qh5LuqDwB/XOVQgrfMaP0ThWQZPNx1I5w=; b=OICpYnHXVN3S6pro8unnb4NdqN87mprfPDO6A3tChIi5uBWOtghlkHpWYGqKb9/VQH JwWh22chh0StkkKIBBsr20sZXydI0ouAYcQ1vq2fWmF7Er6jfhGOVjN0isoWBanpmwHg LF/cM51guBSC/CfVmOEeOW0RX5wWYBJjGItt24XVQgK+8WapOi2gOzf+RXb5LnrZ0ZFR ReSooi4TCjb+CDKgPP8Mo05E+I2ZVFDLQ6wr7IsS/LJcLqwu18/HDbyqtPcXHwji4ekn B6RzK4oBU6NqehrI2PiEDSbfZna300MUrJ41VAQyL2h+LTstAMkW6S9mWcGXsgQZ4ZC+ AAug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768355972; x=1768960772; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OmSrywNj94qh5LuqDwB/XOVQgrfMaP0ThWQZPNx1I5w=; b=j8568SXeREkACIIgoIaAwCOFuQr75TTsK0LqSqzJa9Vx7ZVpL1I/9J0mmKBrQVjepI U0Yu5/gHwRUhEbXKTBhPTsBvKe5u0qgUhe5V70D5643sGJ7Vgbi4QKPfyv7NRLJNYfGU vWEK3mvQb4WCQMBnezrDqDN0W131xM57wTXonzEbw0uC+O7T/h4oOpIz32EyUHczIjoq CNI3RbCI32Cwqd/wjvzB2/O/K1cUoAJ1HKRrBlyeexH1Ua9UaVGKyua9tOM3burcAj/5 nRcstkzwwI1Jiv9N+iMWCch//2KsO7Yjjj2UyWSQJwp/TJHg9BTlX6jzru2iAbplFGVE v4WQ== X-Forwarded-Encrypted: i=1; AJvYcCUBIGh9Lj0higV+VOxHalEryjSRBU2of3aiXF2ahg9vO8fZGhdZFkbDPnLBEv1jxEiVtWGdNzd9yDMLR7w=@vger.kernel.org X-Gm-Message-State: AOJu0YyM+crHRW6yCvH7fEseemMM0aReMHHa6QL16Vzlup1Zacp/hif1 ul4F+TYe1UrUSvdLH70qBO0Smtlb5NrbirUlhtikT6SEcruaIIGYqqhm X-Gm-Gg: AY/fxX4fQXmE8NTO9JIMximYOpG5+9aaIT/Cmx8+oZyL/2IZdgvypqXIRG6xAXcm6QT Qiir+xuDpg183beSBCV/T3sw4kueAiIVED5eN5e43gBdQt/iNeH59PhpDDcQO2Auc+IU41yCM8K yRjWJRbvqZWDgdPIYytI1WA2vBxyRhn9m4dtgMaPnGgEoEX0L7ygJgxG4pjSa+c7CTFHxURfsvu HqKvQu4sjkXONxsmsXZRq9kz4/OjYQS6A2lUFSkNG+ucZD+RO22YAODImJODjIV5TO0E3m6SvIR Ou08Qys3BWY38v3lbAC5oeeXFw4HMRAq/Xz0XX2rLoGR+ODbpNEQ01J+5KFuYdxRgh9fIlg1iWe u09i9p4KBN7LM2FxVNvpwIdLkUUegAv//iaOow76xhhGT6PQzQKcpFa6tuhR/S9xGCQ5D3tI67m NjElMan/13Qk+vaC3VeTIX2ObIuYl7kJJlCzf/OTOkDE7RIoZF4cdX1bEBLg== X-Received: by 2002:a05:6871:2013:b0:3e8:9b72:5cda with SMTP id 586e51a60fabf-4006e417334mr2886940fac.11.1768355971874; Tue, 13 Jan 2026 17:59:31 -0800 (PST) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 586e51a60fabf-4040cba2d2asm342105fac.5.2026.01.13.17.59.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 17:59:31 -0800 (PST) From: Jim Cromie To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: Jim Cromie , Jason Baron , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Louis Chauvet , Bagas Sanjaya , Dave Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Petr Mladek , Shuah Khan , linux-doc@vger.kernel.org, Steven Rostedt , "Liam R. Howlett" Subject: [PATCH v8 12/31] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Date: Tue, 13 Jan 2026 18:57:28 -0700 Message-ID: <20260114015815.1565725-13-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260114015815.1565725-1-jim.cromie@gmail.com> References: <20260114015815.1565725-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" old_bits arg is currently a pointer to the input bits, but this could allow inadvertent changes to the input by the fn. Disallow this. And constify new_bits while here. Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 64d69f5cba1b..db0559763e60 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -606,7 +606,8 @@ static int ddebug_exec_queries(char *query, const char = *modname) =20 /* apply a new class-param setting */ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, - unsigned long *new_bits, unsigned long *old_bits, + const unsigned long *new_bits, + const unsigned long old_bits, const char *query_modname) { #define QUERY_SIZE 128 @@ -615,12 +616,12 @@ static int ddebug_apply_class_bitmap(const struct dde= bug_class_param *dcp, int matches =3D 0; int bi, ct; =20 - if (*new_bits !=3D *old_bits) + if (*new_bits !=3D old_bits) v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); =20 for (bi =3D 0; bi < map->length; bi++) { - if (test_bit(bi, new_bits) =3D=3D test_bit(bi, old_bits)) + if (test_bit(bi, new_bits) =3D=3D test_bit(bi, &old_bits)) continue; =20 snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], @@ -632,9 +633,9 @@ static int ddebug_apply_class_bitmap(const struct ddebu= g_class_param *dcp, v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, ct, map->class_names[bi], *new_bits); } - if (*new_bits !=3D *old_bits) + if (*new_bits !=3D old_bits) v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, - *old_bits, query_modname ?: "'*'"); + old_bits, query_modname ?: "'*'"); =20 return matches; } @@ -690,7 +691,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa continue; } curr_bits ^=3D BIT(cls_id); - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits, NULL); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, *dcp->bits, NULL); *dcp->bits =3D curr_bits; v2pr_info("%s: changed bit %d:%s\n", KP_NAME(kp), cls_id, map->class_names[cls_id]); @@ -700,7 +701,7 @@ static int param_set_dyndbg_classnames(const char *inst= r, const struct kernel_pa old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); curr_bits =3D CLASSMAP_BITMASK(cls_id + (wanted ? 1 : 0 )); =20 - totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits, NULL); + totct +=3D ddebug_apply_class_bitmap(dcp, &curr_bits, old_bits, NULL); *dcp->lvl =3D (cls_id + (wanted ? 1 : 0)); v2pr_info("%s: changed bit-%d: \"%s\" %lx->%lx\n", KP_NAME(kp), cls_id, map->class_names[cls_id], old_bits, curr_bits); @@ -754,7 +755,7 @@ static int param_set_dyndbg_module_classes(const char *= instr, inrep &=3D CLASSMAP_BITMASK(map->length); } v2pr_info("bits:0x%lx > %s.%s\n", inrep, mod_name ?: "*", KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, mod_name); + totct +=3D ddebug_apply_class_bitmap(dcp, &inrep, *dcp->bits, mod_name); *dcp->bits =3D inrep; break; case DD_CLASS_TYPE_LEVEL_NUM: @@ -767,7 +768,7 @@ static int param_set_dyndbg_module_classes(const char *= instr, old_bits =3D CLASSMAP_BITMASK(*dcp->lvl); new_bits =3D CLASSMAP_BITMASK(inrep); v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); - totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, mod_name= ); + totct +=3D ddebug_apply_class_bitmap(dcp, &new_bits, old_bits, mod_name); *dcp->lvl =3D inrep; break; default: --=20 2.52.0