From nobody Mon Feb 9 10:27:48 2026 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D7212F4A05 for ; Wed, 14 Jan 2026 01:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768355971; cv=none; b=FcM154GEo9fvru0l1mPp8/5JyIzMLAmR5E8PgGs0t+JOFzrCtAhtMGIp1tKe+fiFsvOA7GvZDqJn+6dxHRXlXGaUErQZ66OvC3eJKGf6dOJaPOjGWASXElPUKhzVw/Wvgjn5jgefyQAaYXmFvaOZ4kyct0Tup0L9qrFrYU4K5C0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768355971; c=relaxed/simple; bh=a7QzjZykrf+nhpVu0FMe0jqhJkw6SImZcec8zbEQ0hM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KfHHvDU+uAn7lEwDrgYoqRYsSVrSXxeMbhhhb5xkjCJM1rBlgqYKvRngMcpgTLU8D1G7yyhRKy8TSsOlkqbhRW3yE/94/R9LGSdjy3SjOSIvz4TmFjkXrshj0M9acDtscddjsBeKixxjmGyPAuqpj+cKyuOLek/6I4OOrN2nIvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OXR9e8gX; arc=none smtp.client-ip=209.85.161.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OXR9e8gX" Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-65cfddebfd0so4077891eaf.0 for ; Tue, 13 Jan 2026 17:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768355964; x=1768960764; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kB9XGvfi6ObodyigSZBf40IoYnb1xkrL/FFwh/sfSnM=; b=OXR9e8gXcY3x1YldMw97J7zXMnH04IszzQ2MvGxvvZsRtgk9rf2oSBYVe16QgFl4Gn D0RM7/p5yp2g66mX6YoWJ8EGBHdQEluUpbJTAVrtAq039lWoO2BCKPjCbUEDV336FW3X y5VpTQoEr0hsJQASSeiYhEKCngeTLTdf4/HJk5gojYDCleAPSCr5v0Ll1mE50CGJ4hZ7 QJsBkDlyHjzPSE1Jy8efBNtomC/LPAMiNRanTdQbngDgmg4sS6TVaCDXDIfKRExS5D0e eDXQ2pUQnUEtvw9jW+SsMGWo2khJFYsmT01d/W7OvLt7F185Er+pymEOzIdiI4xW9635 f15w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768355964; x=1768960764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kB9XGvfi6ObodyigSZBf40IoYnb1xkrL/FFwh/sfSnM=; b=rGp4mrWPS+pTTyTWhA5LiOukGJsV0YDJh15Tjvp/L77IGAccCNEoJHRKk3kIE0z9Yh OuW0swUe/H2iLoaQlbcU0I69GZksBXziPZTvDPSC0Y1CygMLMAu0vQNVDS8apYrMNJCl 65xj3wWEs5+gIQObdNSSV9h6FVdIOYMZ1GBNXr7rIMm/gpDYrWRA1PXb8siealh2nK1P 2Am5Mb5kMEnD3UwzhM5UWp8WSsGU7zBzlLbRUiEau2vAa/6dh+EciEDgEapKzZ5kQYVM vakyEolB5/vq8vz/gA/7SqTahtZTRdD/APwSg25xigMJyALLgRoCztQTATedNkhPK3Dr huBA== X-Forwarded-Encrypted: i=1; AJvYcCXJcFfIOc19h+wHEW/5dLcVTkEnZ4nsAyY5Gue69sC2J/UB/WpdlSWzPx4L+7MyY/dTC7q3ViugrqzyWDI=@vger.kernel.org X-Gm-Message-State: AOJu0YzPIqHAFeNuSwVfdWdbvVZW34Jv+uI3wiZFFiR/axunpIMbU97r 8Ga0S8/t6TBZyMUrd3URn9CdyAB/gA5zLzv+iLMAXG5UjDnhoAkyLXOC X-Gm-Gg: AY/fxX5/O06velNja7woEGp9eX14s7AO56htOSwts8NP/OD+IczqyEbr3MR6yL04ojv 1LD46t4MOQElXvw/u1QzT/6/ER3Ar/vBKamX6Ho1jB+20rdY/S3USR104LDkSQfOUGBOy4EOOOa 6Su3Im20+7MN3RVWaKyPEqe6e8aeOsW3Im6c6SYF50AXFjzNasxrkqyMqth9ZcQg5V6s0a/TK60 Qb6HpG+HMvowiY/GMONFuYBhO+e4n9XPAb7SjGogveneBPvsP9bRT/oQAnPDAowRq0TK2VRsMPx IhdSeTbUfk+WEjm2MVgmEiLaOfumyKnq+5pjz2OXv81MDh/iqpcmZnN16PM2yiKmzSliehq4rxN w73vdZUbGsw1OmMNLDeZccck4cJPKZ0OICdNxf6TFRtxqCEkKlo4GPc3S+swgBWTKWF6b97pbyZ bztnCwp66+wt3zeRIxszzFhYlRVK3E1j2B1uYf X-Received: by 2002:a05:6820:430e:b0:65d:4d4:e7c4 with SMTP id 006d021491bc7-661006d3539mr639488eaf.38.1768355963839; Tue, 13 Jan 2026 17:59:23 -0800 (PST) Received: from frodo (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id 006d021491bc7-65f48ccf24esm9067492eaf.14.2026.01.13.17.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 17:59:23 -0800 (PST) From: Jim Cromie To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: Jim Cromie , Jason Baron , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Louis Chauvet , Bagas Sanjaya , Dave Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, Petr Mladek , Shuah Khan , linux-doc@vger.kernel.org, Steven Rostedt , "Liam R. Howlett" Subject: [PATCH v8 10/31] dyndbg: reduce verbose/debug clutter Date: Tue, 13 Jan 2026 18:57:26 -0700 Message-ID: <20260114015815.1565725-11-jim.cromie@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260114015815.1565725-1-jim.cromie@gmail.com> References: <20260114015815.1565725-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" currently, for verbose=3D3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' dyndbg: flags=3D0x1 dyndbg: *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: parsed: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0 c= lass=3D... dyndbg: no matches for query dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' flags=3D0x1 *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs Also reduce verbose=3D3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Reviewed-by: Louis Chauvet Signed-off-by: Jim Cromie --- lib/dynamic_debug.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 21c1db7e8705..1db2f627237a 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -275,9 +275,6 @@ static int ddebug_change(const struct ddebug_query *que= ry, } mutex_unlock(&ddebug_lock); =20 - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } =20 @@ -510,7 +507,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op=3D'%c'\n", op); =20 for (; *str ; ++str) { for (i =3D ARRAY_SIZE(opt_array) - 1; i >=3D 0; i--) { @@ -524,7 +520,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=3D0x%x\n", modifiers->flags); =20 /* calculate final flags, mask based upon op */ switch (op) { @@ -540,7 +535,7 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) modifiers->flags =3D 0; break; } - v3pr_info("*flagsp=3D0x%x *maskp=3D0x%x\n", modifiers->flags, modifiers->= mask); + v3pr_info("op=3D'%c' flags=3D0x%x maskp=3D0x%x\n", op, modifiers->flags, = modifiers->mask); =20 return 0; } @@ -550,7 +545,7 @@ static int ddebug_exec_query(char *query_string, const = char *modname) struct flag_settings modifiers =3D {}; struct ddebug_query query =3D {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; =20 nwords =3D ddebug_tokenize(query_string, words, MAXWORDS); @@ -568,10 +563,7 @@ static int ddebug_exec_query(char *query_string, const= char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound =3D ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } =20 /* handle multiple queries in query string, continue on error, return @@ -1245,11 +1237,10 @@ static int ddebug_add_module(struct _ddebug_info *d= i, const char *modname) { struct ddebug_table *dt; =20 - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); =20 dt =3D kzalloc(sizeof(*dt), GFP_KERNEL); if (dt =3D=3D NULL) { --=20 2.52.0