From nobody Mon Feb 9 17:57:48 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27C23A0E87 for ; Wed, 14 Jan 2026 15:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404641; cv=none; b=bbC5mn6RlAHsjvhSm59z85PybjYfHKfw3yjvd80xZZH/4eeUZaqJRK0tkIPd4JrFeVElBV29bo6w52zbn8SHzi9wawMsQA68+8IPm2Q3iatXyfFGTxDP1S8AKV2oOyQV7Usrl2HqzrsLXfPtBoNu+00iR2MZsGgiH3RsrezLDKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404641; c=relaxed/simple; bh=Hz6iLmKEfxDKfrrjH8upUbRNGTU/avM3tmt35o0Wjvc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lBHz0M34qwRFRDyuZU3mhkicVSjgep2U1VyYsffU44qLLh5QGCIOs4PBZeJ77QCv54bzYVKYXNRcjAMKE8rIESSVYnE1gLRuMAnZ7A8K9pLwByFtdyJ35IkecZSomUqzQr39T/TGUkK++14dfqAJjI1NP6Z6JzIoQEklIC5c9pw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oI7iubuJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UT+hN3h0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oI7iubuJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UT+hN3h0" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EFL0bp1943016 for ; Wed, 14 Jan 2026 15:30:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= taXBNyuQJxmj4iOFqIUfDmb0YEDOzZ29KLE4Dq+0LV4=; b=oI7iubuJrJC0fgMI lUkAMQMVAzmfEMIfufrp9rsjWsXcH2o+6+++OU+t1AgtWvYToBTqLzfCTJ5hbWWc zsOmvaBPgp/FPEP8JHQwucbS/WuYShGxyW+lgPoVyVgGAfV3FaYqJ4LDeQjsxxWb Hp+0cgOkI35fRxgRp+kIaZ0O0Kq0Jd8CNCAK9GvKzPufghCvcwz0vq6alk+/IZLN +Yvdv6h3DUvdafI+5Fb+qaCxdCVOlggJXoBSasoUUjTrHxP+nU8ZL9/9fuBl7ZXb GOHzOvBGPL3LIchFN7uT6MG6DvhW9TaYkkitzZ1yRJ71Tmhn3kONflVTlxvRYGfg EW4g6A== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp7b6sjr4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:38 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-890587d4e87so221019966d6.0 for ; Wed, 14 Jan 2026 07:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404638; x=1769009438; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=taXBNyuQJxmj4iOFqIUfDmb0YEDOzZ29KLE4Dq+0LV4=; b=UT+hN3h04eYUzyRpvc4prXX1UR+mocev5REzAu1FUxZm4J6hn0IkintnooACOiskE7 Jz94jDhvdL7QTLB3kcVSIdKXVG9QAfbINX0ECuP4YbBuSktinbIk4rOe2artVlf+yEzn 0rNUAKkOTGpAi4Bb+AHVZucFRrmUyH5cQCp4BOR+KTJsh85C0IdN2bVCJ5i0la7MeIkX 8FNW7Q5OR3SsN/TboCH2etzV/ECn8pLSdf8VpfIfdK147gnf103kiJ3+QzJtA9CXXQs5 E2nnEtEcY20w9VE00o0S74dLlYgk4HCCdQxycFuPqmF2ZrLGnWuihaUTqmE8gJeLUNh0 920w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404638; x=1769009438; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=taXBNyuQJxmj4iOFqIUfDmb0YEDOzZ29KLE4Dq+0LV4=; b=XJgoh54YBzhS/NHwuDq1fOkKr8GUrgrUKMAtChfog4b0hRuocNohDq6ELsTXfnl1p4 5DclTlegE/TrTmpU5b4E2jgqkXjuku144cK+ey1HZmDS5Nue37x2HrBRD0Yg9c0QQV9C hPgzho2eIUE9ooonEfqjS08+HfHmS+ZxelaF/LS37cF/8gvlv9SST+pmISa5ydoVZkD/ 2+awNxGhhujTu3REOtBZtmxbv5lqt/V+CKxlKGGN/r9/JiBrZVENwrM260+Hg/WHwnCd WiHUY0XZ1eRXCEm0hsi4SicRHtAuM0kYnIofXm8jnapXrJ6T9z5UYSr1wp8to+BVIYSN SrRg== X-Forwarded-Encrypted: i=1; AJvYcCUOrE7OjxcxGQaM9EgZ8cjtQ2CewQhRDulQOSGIca0wSp2gJqdUE2P8zcuOk0OBSkWIb06ayMND/v+bCqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyRUGFFlxB0aaVMgISZwLXeRJuKR/z3YPB4dVr3Py2OBMb5S2MC MuboLs7wHuh1qNWLpST3/74ftcAjG5fJ6U0m+9aGR3n77goXg15/s19eEIyZ4jKxGarUUUnU3Y4 xTJpRWxZ3svGIjaQlmYyX4h5FkMws/b8zvEP91bBfPAI6PXz6Mvr1u3DUt1sBrEXWRpA= X-Gm-Gg: AY/fxX7qKELdqmc4GTCrNTvIPL6Pnio3ROpmoAH/RG5zpdXqrGJNS0CD15razwp/Pcr eyMbkdX1kH9qxrSFFeZQqWiS3ii7TU0oRhoXc5NGUt+puNNbb0t3KbTNugXhouV/8dijxBi2DvE 9H0TELRBYH9lENcGKZYd9GBSo+/wdicOb2jAX7RL54agyqd7fCZixQnf8ymX4USK8T0g8Ykp+Hw qxqsNXAFLvjqmuSKGTYKvl4Nwvt39J46CRhdHzMWT7X2d+ynsXnHrpJ49hVB1tJ3gsrDJyj5Zt5 peTwiYBqELGTSaW6F34+z1agBhB907ylPsIRKcEn0w8dP/JK9CScyoYi63itSELauflMKUPAXma cN1LZTytcSdBqCdxMjjHVKy1p2CRB+2nnDg== X-Received: by 2002:a05:620a:6ccd:b0:89f:5a59:bf30 with SMTP id af79cd13be357-8c52fbffa64mr413617585a.78.1768404638374; Wed, 14 Jan 2026 07:30:38 -0800 (PST) X-Received: by 2002:a05:620a:6ccd:b0:89f:5a59:bf30 with SMTP id af79cd13be357-8c52fbffa64mr413605785a.78.1768404637689; Wed, 14 Jan 2026 07:30:37 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:37 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:10 +0100 Subject: [PATCH 09/11] pinctrl: tegra-xusb: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-9-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1933; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Hz6iLmKEfxDKfrrjH8upUbRNGTU/avM3tmt35o0Wjvc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aHavwX9VGYJNPXqlYS557XrI51pw+HBiAgS ksF1auZQ8aJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hwAKCRDBN2bmhouD 14N6D/4u0Ishpad2NsggJaHhekQq6iqnAlDq+P4aUzZ2je0asU428AUXHgBNvCHiiaRNuJ7peKn kZaXFhOLRJL4lxXomi8DHl1w9D1wmI2dmJY6uuG7+xE0WxinMpd5kVfeW2Xtb54zER0cJh1D5bI sVk4n6tZOECbNOeSCkDuz9iEmckynK/jzlrOtYLy0nBFnaMx4id35WfzzlMbiT2y/C/eloosWov Hmaa4SZ3MfGPYTu36FG2d+rvHNNb9+WSIuzkjv+VTj3cK17PThBorYGBp/w0aJ8TZSzhi06ZV9p muZ8lj8SdZ97AguyfiMxk+Bn7pnrY1uffQ50Y+89Q0MUkED8IzjqPDYMxxlEPSUsTi4rcPT/Nwf YjxycS6wVR7jaqPzsW9sPjVnOGg4m4RSiiD1UI2kij+foiDbWUDEcdzMktasIlpA2SELsmvfpKe NkKfC/MRbCi7phtLl2BQz7sIegR3+lh5wHlWf5Bp+vdP/TwV+uSXTTrwiRsQhuSaTR+J7imqz7v rKwBAo7jL18AC5SjN42i/KN+kBPDr1ukX+5zCgQGI6rTDSkYOwuTeWTgHMyLQmymCwjNAz4SbuG wHlm83t3XUAC1jznj2naoOonPyr+Xpa9qqPg4IfTnnixh13WCTfgidggeW++iXeRSKLA/Q1o09+ FxL7I1nczulzGhg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: qEZSK2GuKIndR7qrEgzbU1jdnXmuF97Z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfXxYxqFx3jRH2h iN+JG/CuwJ1mSb0W8xnuV/+QCK3FcK1yHgzOL2Crs5xThY7HGLTFaYisyKK29rSTlr6uJ+o2bcH B+9HCezli1JnabvVvHqW4tn1CTyvmG4BAIWNKJwenFXNc5yWMgV53mkD08aF3QE+3dcIwQ7w7ZJ FzizjuAM23qQ4274kfrG2UG7grXHRxpGOIaoXS1U5B1KE7f3kl14Z41Z9qblyH2YbwF25xV8mZR 7sfoZc3gQZV+d6KfKytVAUQGdYjQ6AskAlc71sTSFC8sZGrZqH1AWV36R9eeCWHIljqiAJBLgzW MEu5HbKdhS8IZNUt3Yp25fD6812KzGVZA4iPrjlWI0GbCvVL+8c9ZMrH5GX/LU/Uinjs0uT/6oZ pcAg+1hTIMe7wgX/b/SzjvJC1BoD5Tf5/U7VChKutMRJfY7A9Eu/e9pwqN/HurWowC0YgLNoLjf j4q5cL7Kb+Lbfyy1rEg== X-Authority-Analysis: v=2.4 cv=W+w1lBWk c=1 sm=1 tr=0 ts=6967b69f cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=aRO1tsgHJH1V1zxVpf4A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: qEZSK2GuKIndR7qrEgzbU1jdnXmuF97Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/t= egra/pinctrl-tegra-xusb.c index 34a373f7e04d..855f708ce510 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c @@ -478,10 +478,10 @@ static void tegra_xusb_padctl_enable(struct tegra_xus= b_padctl *padctl) { u32 value; =20 - mutex_lock(&padctl->lock); + guard(mutex)(&padctl->lock); =20 if (padctl->enable++ > 0) - goto out; + return; =20 value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value &=3D ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN; @@ -499,7 +499,6 @@ static void tegra_xusb_padctl_enable(struct tegra_xusb_= padctl *padctl) value &=3D ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN; padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM); =20 -out: mutex_unlock(&padctl->lock); } =20 @@ -507,13 +506,13 @@ static void tegra_xusb_padctl_disable(struct tegra_xu= sb_padctl *padctl) { u32 value; =20 - mutex_lock(&padctl->lock); + guard(mutex)(&padctl->lock); =20 if (WARN_ON(padctl->enable =3D=3D 0)) - goto out; + return; =20 if (--padctl->enable > 0) - goto out; + return; =20 value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value |=3D XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN; @@ -530,9 +529,6 @@ static void tegra_xusb_padctl_disable(struct tegra_xusb= _padctl *padctl) value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value |=3D XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN; padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM); - -out: - mutex_unlock(&padctl->lock); } =20 static int tegra_xusb_phy_init(struct phy *phy) --=20 2.51.0