From nobody Mon Feb 9 17:57:37 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7E683A0B32 for ; Wed, 14 Jan 2026 15:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404637; cv=none; b=ck7pwcruUlLc4C8FQLn9JtNp2+ds3VqjGrunD1cuKu29ulB+iwv7sWzxlR47g732Vu6RCR4ob6pFYo4C0UVxOoDq4GIFaqcnXzAdcZfbReNbRayKMXgOGfg8v05LgHkBWDWOG8Q2wxG5cFbq86rcd83mNV1g04m6z9dvpGIsVP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404637; c=relaxed/simple; bh=adtV57CgOwnY60Si6YEP4k65ve4WmCO5x4rzf1ZqeaM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BGaWkB517SeZby9f4UXn/BFkj4aowHZSf+rhh/mXHvsgvmw92tP1GTNMsB/i+M0N6CwlG1V3oYG7rez5UZKp+jUutZSbFEn8nz6rw8jbCfCsQeJXCQGWMmDsLteaEVfHjwSNYSBcDEVrG9zbxYF2EsWdZrXiErnoUsLwrpgc1Z8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I6kkEHcw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RFaNvOtN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I6kkEHcw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RFaNvOtN" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E9jnI53296152 for ; Wed, 14 Jan 2026 15:30:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=I6kkEHcwYHnmLqcC bCog3zsSNQt83q1g15rqSXMAHoCS6ayKBCuK/od57mJZRARRmEKWePBZ++KRDRFf nA/wQ3gmm9OmhEdA75fhn5wCblufkPBQS4FPjA1MLG8XjHUW5rpj3ThuLbR54inW ZC5Wo+bUgahzHKYqqo6mScjg1mnK/iL0PhMHXVhGcvGY9zbAELUEeRa23OKCvh3x urMzRY5AmgIdBLrvSeX0LZzwdcJr7L2+2n1AHSumMEuqSkZsHx4g6FgrUQB+0/FM xIJf0EElVUNgq68df0rWEdMcPXSuVq5wvOXdMLZwdMvExgqGYam5JXWk6HI6mWVO XotTrg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8t2s5qk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:34 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8bb0ae16a63so1031598185a.3 for ; Wed, 14 Jan 2026 07:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404634; x=1769009434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=RFaNvOtNfeWXdJJi/fhkzJWAgQg0baqtTYYa0gPSxPv4nyN/QK/9XfvirnbH0OCEJj 08BJSrls4RiUv5NtiCOTFBtbQqHMY9w+wXkmf+17Sp0bilAKxnbN5QqZ+XCguBhoMG0f 3yVDKXR+QMr39+fW26KlhrBel67r1NhQJaVmp7YT9OXsHwFBMDuljmC18+baZbjzZMqg OIm6XWXzT5p12QKsCHPF0VHLRb5GvBtbuq9HztgibS00NlW0m1PWedrD5JkRaw2T+AIq 8C/sofa9/b0rmS8572P1dhm72NGXyLkrYAn4t9RZ7RgJ0Toa7eHoNoyUbB1wSnFTIAaK NK9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404634; x=1769009434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=ek/HNO00pxa3qEv0PUPIUWP1gZpvDMBNzSB9OXMBmN0G8bHF3pvVh2SYTCefbpbMdQ XcHUjzyxCiGLzoc3B0pInzLS4U+A1RkUiW+neodLelMnd425iUNMHw4TLwfb8iiwizMw 8pHp79KlCRffEmYflqWq4ikEwMIyhTADLLZzA48S1hip1Xg1boo0gKl0q1H65M0TQIYU 8t/JkrTgZf1Rxd07BQk0VaVUWys99Axjy/fPcbKWqSFuON1G9LRtuGiAxjerm29wevXE tdR/VWs0wdeJmLnC5MiovMStRV/M2FuAGFZGydo9GjvP82h/LcMdZ2ZmNLfIrkJL6RCB lR+Q== X-Forwarded-Encrypted: i=1; AJvYcCX1pcSP7rxvnkP/8pTyhv0nCHmV2u2kC07EjrTz54zaDEZzlgnC6BuWH32SIhUoReKHTgXxmuEIbJ7WlwU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu223FadAMcOj0rUCKXf2Lk214Aib7o07Y7nqhkKPc6PwesXbT 1no1qD85txpQEQGWTNpLxlYtha3pR/stXvwQyrWCdJxNIS7Pe6q1AAOODivL5DBVkuYGDROiEIg 7U52rquMUzqICtoehwJAhilKKdvFIs3cDrmj1O0aTOY9eOGGr3xSI+wYlDHNQ7G+xeCk= X-Gm-Gg: AY/fxX7SAzcxdtANH1kK4SEK3wqmoKDynpWQlXhLjP4sB4bpXcM8OoV+LnkVtJoL9eP EmKGzNBqXPs/bWsY1YyP1cJb1d6N6gggjjByFNFLO5wLBwoYl421xLqigQeE1LCnGxwBrtEhCXB oSXKP4qNKCJ1HarEUF8Slz6kdn/99Vs4waQD+oZv8M4I0Ns63TDTkyp/3E/fhyCA1+5rjKleSTV bUw4UJoavHaePGEDlCU7riEWR3BI4bta/d+5hvcstq/m0gABgqQr1rBfGHaao6PLoBn4dv4G5vR 2t3xjrX92hplE/gyVUIrc+U33QDGMSdf9tMepuq0Ee8aM3iro/Mu5y7BascXsYRWPZX4ajGmAeu T7aBnfn14STJ0/JlCg7EQO3rArxt/RlmGFQ== X-Received: by 2002:a05:620a:4101:b0:8b2:d56a:f301 with SMTP id af79cd13be357-8c52fb32b67mr343232585a.14.1768404634210; Wed, 14 Jan 2026 07:30:34 -0800 (PST) X-Received: by 2002:a05:620a:4101:b0:8b2:d56a:f301 with SMTP id af79cd13be357-8c52fb32b67mr343223385a.14.1768404633459; Wed, 14 Jan 2026 07:30:33 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:32 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:08 +0100 Subject: [PATCH 07/11] pinctrl: tb10x: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-7-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2163; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=adtV57CgOwnY60Si6YEP4k65ve4WmCO5x4rzf1ZqeaM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aFRdTPwiFL/h2YLFk/n9wL4n9QTdVBj0L6r 8aUJ0hOsNiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hQAKCRDBN2bmhouD 15BvD/4sSskWeqqie+QnWNfV5njoEI/Dxm+OQU6hvQfAn6W+mFLEoVNCYY1DYciSU2Abpt2R3nR +qvBID4STILG6i8SyHTuaGcand6oW9yUTQpRJAmZLQwTU6t5Txha1TR6xku+5Oy8NyzMaHRuJTv +q5GGceQij71KHq+iN7y+f2Kh47ZLjY4bh5UEgUQ2UIoWQOKsKGVqFMR4D+URpgUMijJNLMK1eY OiA7jL0EBA0jRXolicdtAQTBVHk5WKJIlq2dKAIVzHYv12gvTtggiJd6gKyNR8t5tX+yOxZqM0D Jd4RwOyuhKazwxCfXv+bUlaqLfNnifpec2mksBSbNjseAfzxvkqxCt+VMZHZVoZ9mzpRmAppP30 i9SP4gbwW16v6PBBhPIiLG0HrWfQ9XJ2JH7MYWKjn2JypFxHEA9Db766OZxcFqNRKVlsMAtIK06 ZKalbIjY3hmQO2RLFsbhmE9qgNQm5n6vPYCORIFGTSFmcIKyeFghhXkkuZqhqTORTVXwOoPyhnb rrCyYVw4Twlq3ASI88CvQgLBkMD2dmqaPlhTZ37MJzVXVgufCKwBDhrq6xhuAlBI1vufryly9SE iw2aWK83dO7QfgeR/uYrjPKYMLwUfoTt6nq5Ph8Apc8jGok5zHX7/Xej2gYuXZnBbrTOGD48Hiy LRCCfd8e1rw2F9w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=YPaSCBGx c=1 sm=1 tr=0 ts=6967b69a cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=fB2tTgKqvhDdEbG57mcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfX+zDr2ME39Mtp UcqKIHqE9h8I9mVQ2FjSbKjLw+TQutHWStchqSBF3ojIZxwShq+IC+5tmoCZ1BZo86xyDetYMZ0 UAgPcGI1UT8p4eoOc1fInAFReU7blRwy+mmZXnfCBjyrpH4tUVh4/by4/DeWrcUKRqhNkEv3nC+ xQqSfIzrVIPe05vZNrUfNkl3Ru1o8brd192CrcYyKXTvEvXa1Y4fkcqtOCkk9x5e1l8q3b3+M/X 0ztbcU5Z9EnCndmIerqbWiGrc/qnexydQXQIDP1Nj7g/nXzQFJxazGbiOma/pPfVdBftMKE6JQt q5xxlRYp0Y4P/Npel6qN1yvs4YvMogEiJABg04M3Eg5LJMUL9HI+q1tA2xGQEp2NCW+rkAeW9JW cCZHDRHtvyht9svWwptRBWjJxvXdTscUJ4G0yHcYuPXDeeP32BrKexE5GuPxNcz9UEEyw2MP7FJ uuMrFmPuqX7w0gIJr3w== X-Proofpoint-GUID: 6T2zsPgpxTLK7TkzkJMwQFpHCgXOOZ1Z X-Proofpoint-ORIG-GUID: 6T2zsPgpxTLK7TkzkJMwQFpHCgXOOZ1Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling (less code in error case) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-tb10x.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10= x.c index 129fa51d13b1..3f581404a9b9 100644 --- a/drivers/pinctrl/pinctrl-tb10x.c +++ b/drivers/pinctrl/pinctrl-tb10x.c @@ -607,7 +607,7 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, int muxmode =3D -1; int i; =20 - mutex_lock(&state->mutex); + guard(mutex)(&state->mutex); =20 /* * Figure out to which port the requested GPIO belongs and how to @@ -642,7 +642,6 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, * Error: The requested pin is already * used for something else. */ - mutex_unlock(&state->mutex); return -EBUSY; } break; @@ -667,8 +666,6 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, if (muxport >=3D 0) tb10x_pinctrl_set_config(state, muxport, muxmode); =20 - mutex_unlock(&state->mutex); - return 0; } =20 @@ -695,34 +692,28 @@ static int tb10x_pctl_set_mux(struct pinctrl_dev *pct= l, if (grp->port < 0) return 0; =20 - mutex_lock(&state->mutex); + guard(mutex)(&state->mutex); =20 /* * Check if the requested function is compatible with previously * requested functions. */ if (state->ports[grp->port].count - && (state->ports[grp->port].mode !=3D grp->mode)) { - mutex_unlock(&state->mutex); + && (state->ports[grp->port].mode !=3D grp->mode)) return -EBUSY; - } =20 /* * Check if the requested function is compatible with previously * requested GPIOs. */ for (i =3D 0; i < grp->pincnt; i++) - if (test_bit(grp->pins[i], state->gpios)) { - mutex_unlock(&state->mutex); + if (test_bit(grp->pins[i], state->gpios)) return -EBUSY; - } =20 tb10x_pinctrl_set_config(state, grp->port, grp->mode); =20 state->ports[grp->port].count++; =20 - mutex_unlock(&state->mutex); - return 0; } =20 --=20 2.51.0