From nobody Mon Feb 9 20:10:58 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295C039E6F1 for ; Wed, 14 Jan 2026 15:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404635; cv=none; b=p5ajOsUkIiMxKjqs365kaFkaSui1rm2lW2kvR9b6q4ozxdVnZBDDtfTUqdn/twPJYL/V/T4rGxHkLm01b+rB58I17yFzgFDpVKdnR8nM4EhZz4D2Xlvr82MnIyjUhzSjv9rs/k3Fq56CTEiowJ1CkU1PtQAPT9uxsGiug8N81rk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404635; c=relaxed/simple; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EAD2YhY0wDQpTTbAt79AhJwwzUVlqeB15k6UFh63v6K0NgMr4WKlb6EkePLmuqQHbnuGUAF0Stiw0WPCECvbCwFUcQqQyHoWJ+4IZw4yv3HFp4BwodCcMaAk4ncOIXlUPEl8VC0YMyyFM0b69K4xqnCCi5cAZvRVSz0EOX++SFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HcXKAq+n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LcCB8x1Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HcXKAq+n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LcCB8x1Z" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EChWO23925461 for ; Wed, 14 Jan 2026 15:30:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=HcXKAq+nTSgWrzSK w1a4GoUXM/XuGU5b7mwyhHaftes3dWz2FIYh0ZaE3kTLg6bSA5zLrYkRq0l7d56I Zm46EvXyUcb4YHxT4q3XQ2xwvlv169s2XhxgxhrLV9wGHbn/acVHWUrKL9WeiN34 oxI+nkOmlEgGJ40GzzFOPwIfQ1plkTis7W6XEwSy+BEcDfNNCKZeJK6ntJDy2gJT 7cNvU/N9ASdtjEEo+ywOMZabQlMvmsZWBwHPkVfHcbdvH7QZIMXscPa1ebEWAwza qmm4xfI7i4asmD1X0oDozzuRdnBuTqOGzH+RTAb0dKUgJPvntm6VZtTm/Ycu5NDd OjjOJQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bpbdbrh93-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:32 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52c921886so197323685a.2 for ; Wed, 14 Jan 2026 07:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404632; x=1769009432; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=LcCB8x1Z+kPSITM0k3ftUsw9PDhGUMHP6H9u12TANr4lzOJNQPlaq1LMkWaO25itHR 61yn10xcs94FrGOElCaB92JsC5RUxuYjXrJ/O5F/G2dMw9KkG4swnQKTRgt5qICqq7+8 ZDHyFCb0Y/ZeDI04jKiEFjYqL0T3djuqjvUgKBWTq4xIASEzwsH3qADa2GjKcokmcgRf 52tXglrINxxaDO7uFWGGZDiuds85o15SegnyFOQPPIVuBxuiI52gObeZklCRLieWKgyS f7L7OhBaA2J2xS2/ExLoE6SqdH57kX6L6PLkwqNYDx+qyxblVg4amgzWQaH8apE2ouSj ccZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404632; x=1769009432; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=OYt8FicjKa1CQ3oPl1OQz/6uKXXcg5bn4BseUHv21rria4DojRQ7UG3AENJzEYwRC4 F+WPJtYJ981CPCLojvtktGzZ7BpuqxdEDbWvC56vC4VpmYIPeME5KKDTrJR36ir18EZN SwpbdU6DqjFtHgBvRfEsnWzYZcI8leDqGI1agBvs7pdkNbuggEZ3dXRCpxlRlr+jc7xb 92wlV5T89W0+J/rOPyKydCScGe81AHu+46Ik/tFOSmjUYQ8r6jO+iqmtEaksmZBtQVB8 wiluF1Aksg8YhktWG00xm2RmyXWEpTq3zNT+g0/qn3rgLM+QZpPtyjXxbwoksLcEaoeB Y6UQ== X-Forwarded-Encrypted: i=1; AJvYcCVkcofI1XtnhP7kgrJ+5+BNETcv/hfx3YMXDtRGP6gCnbvw6BCE59TIEf0p2mzZhk8YQ0gVUFNPDkf1OS0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4UhEiDbDQ7AQ6n90lOWMabapALdvFJSuF/JYIr1BG9nxZL5Vr WoXVK871AioiMSBrvYnvz5/uD7kOcSRQOP7F3AzMOdlIzU4CV4STx+k6faJpb7v0jgcAbVcvW32 syuYaN50+Aq12QZ8t1Kk1owt4bR+CBFKge8DZtiPQF17bMwtqUMRlv4kuIzWdltpKFbU= X-Gm-Gg: AY/fxX7zIzu5EvDPZkTNpz05RGayumfecGo9T/S5pMqSZfDN0Xwg5uYMeerO3o8q3BF hwRBQvyPxMzqlE7H4J6dXyLHSzGBb8onzrNJV6qTXMh2dJO9niD/N14HlDIjEWGf87I7UOK5t7G bWdPkCs14iBeqAlPoD340xxhvScJMwzAoWw9Gjei1S7sQxeLHS8tGpFFy/9k9XADgBIXRE7C7Nq R9llHOHQCKPEH6cx+WMsFkn8AOdClZ0fCkgYBX80QxBMWpZJ5SjOKQLZh8UfptDREiVeeYGuYHD Yv4F2PoAUGG3MuT0n1n+orZrajEKtfaa6TSNq8Ls91uK4u+x5mefLhTkcasjxCmOpP59M/ZuDxl CqtUECEtcOtBSfjiWNKfc4U/4pGDY8zi6Gw== X-Received: by 2002:a05:620a:46a6:b0:8c5:2ce6:dc9 with SMTP id af79cd13be357-8c52fb4f058mr411708285a.23.1768404632286; Wed, 14 Jan 2026 07:30:32 -0800 (PST) X-Received: by 2002:a05:620a:46a6:b0:8c5:2ce6:dc9 with SMTP id af79cd13be357-8c52fb4f058mr411698485a.23.1768404631550; Wed, 14 Jan 2026 07:30:31 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:30 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:07 +0100 Subject: [PATCH 06/11] pinctrl: microchip-sgpio: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-6-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aFcSlR3KaVGiIyNYG8oZHo4izzrC/c7v2QI ELyljV0aeOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hQAKCRDBN2bmhouD 1/c+D/9JCP7uMMFoU+h75eykrt0KHmHUnHV3rqtg3g7Ut1d2/As83e5bk85vikvVmZM/NczFXe7 tQxswgbhKLPilQU4gCP3Ga6silueQpxzqiLbJaccYmtFmcy4rr0I3ATIJuzeZ+xjLqKsMvlDsBN 5CciXjKG5O5Br5wwG9eSTc/INEM73B0rn+881EzVNAJtEBSP1fNhWwkx5nIiBvGhEp49M99L5nS Bxm1JS8AA76I0eJm+s3lVShXx6sccqHmnDTkkB6m8kAdFeJ7lqn0UpVpX6q93orxxxwlAPeVs92 gp4l4zUpAWVSv5rvRJCGzn3CRbKUXlJ+XXT3EVZsRL4mvrX4OY18izt1M0rKQ2jLVDxHs7pKBKF WZMNHrrcyTlCIQ7WSfVzTKuXZaeUtqQezfcYz4QJu73AoUPusr4JilaxDmzkvLOvxaeGWx1aQA3 XxTSCpYcLEW+07K8mVmDNCtsc3UUybPPwSxVRYBMSHfr0R/Yq+w13B92RZUz3SvitQ1RsSGFGPP tZPDshniy8mMJMUivX7pjR39HjGg1DJXYUG1sch9D6IG+YQgxZvHQ5G9tDMnhlrjry3n+cjsAxb tBNq5GvN/JX4WDvzpXbCaXdN9IH2zgxN5gPkt0cindxysAHiXqL0N4ohP4zkibgluS7P0+DFsIC uJx7nBKwy1ooASQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=NvncssdJ c=1 sm=1 tr=0 ts=6967b698 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6VTnscBjb5kX48BWP-sA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: 1k2JHqqj9kDnOKcb9flpLxRaDoKp1lRH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfX+KmWm0slsX85 5LzCsQZF1mF8R3lMUYm5rq+PvwOGnFtDxaOfhbLl7bFRt9Usmocrck+vESqNwy7TcmvuqU1GgWF lkhXBDrj9y8M5jO2rZEC6i9f7PZ7trCHXfubMqW2i141nRyuQKg92C2msi9scyWUESu6hJIsQ/o AM39QvIGy8hQ8yfNMuoDrGJAf5SngvdxaRcmPpaGLiPJZpqBEgU++Vaod8AmQ0T4PxeqeZpgqsO WqMe0G1FMLCtn2MHFNs9xm/DQFcrG/vJwf+MfLh6+b7friykU4xa0ArZuPhwIZF7nAPUYTa7Q/l nmWmcDA/ikxlROL6q75jTfwV5I9YF/3KpMPIijsXAO5uy0UE+AiYtxSJTxusCaKeF9KngT1DMA4 ViKY2a3rpQ/jw9k/LRndALXHPgs/lyUME2VA32BgxoZPcCcaIycgwmGQMUfR/Yv+8EZT5OR7xc1 yT25RbZOxqEaIPTVyRA== X-Proofpoint-GUID: 1k2JHqqj9kDnOKcb9flpLxRaDoKp1lRH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pi= nctrl-microchip-sgpio.c index b6363f3cdce9..7a6cb5f502b0 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -264,19 +264,17 @@ static int sgpio_single_shot(struct sgpio_priv *priv) * setting. * After the manual burst, reenable the auto repeat mode again. */ - mutex_lock(&priv->poll_lock); + guard(mutex)(&priv->poll_lock); ret =3D regmap_update_bits(priv->regs, addr, single_shot | auto_repeat, single_shot); if (ret) - goto out; + return ret; =20 ret =3D regmap_read_poll_timeout(priv->regs, addr, ctrl, !(ctrl & single_shot), 100, 60000); =20 /* reenable auto repeat mode even if there was an error */ ret2 =3D regmap_update_bits(priv->regs, addr, auto_repeat, auto_repeat); -out: - mutex_unlock(&priv->poll_lock); =20 return ret ?: ret2; } --=20 2.51.0