From nobody Tue Feb 10 01:31:51 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35FB3A1A55 for ; Wed, 14 Jan 2026 15:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404646; cv=none; b=IYZHNmnc0UULOklN/ayKi83eKMyjT8ecMjcGKMeQiU5THsF+bocyWb8cyzjd1zkcH2z5t/Ei8lt2ztrU283na+LOMfjbkdH1/ChKT0hqPvQo004zixRodfsNDLKRSWMbSIOrfo/D+37MT4grw853PKNabGewcRjd3Q0DP4auR4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404646; c=relaxed/simple; bh=SjKuvqUidPJ5fm3b34nm9zaMItl1NLBQXfR5LWGDZIg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oTIjSfFM/4W8LTHnJTTuwEsxJh3USMxSzVG3lLnhXcxWS61FXB4O7mEZpyjsj2FTFoGMa0qf/GOai/HjppfLRjbPajI8Ajn10dZxzDSacHscq9+6zvR6yji1RC/xolksmmBVsrfFxQhphVaPPfIQAQrkgyvxvZBlUtP+Ih2IDAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CymxLC2N; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EMiRdVPb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CymxLC2N"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EMiRdVPb" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E9jvft3296429 for ; Wed, 14 Jan 2026 15:30:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YA3VmuPxJ2L3DtrIn8wKabMcttC/MOL2mTB3zxLU6Gg=; b=CymxLC2Nh+Yhitd8 i2VCkipA2Jvgf58dNARhSsT8C3NBVFuhB0in5/s3k2byqbKN2anrEGds2yvZ0cT3 HsKWrN1azY5/EbZtPj1RgkYGi7uNgFYsmUNZvbzqrQF1UBcNuIOhSJoSKpPFum/u QjvnNThfwoYjH1wOtZj1emLDqD3KisvQGrK3TjABDHrH8oCkwD7M3Cq2ycUIUVLo EyImefGOULzlqVV38fX0afy7dTmZn9JKe32HxRjrZxhMeDK6l9+WPDORB5pf1SjK 8mf1eqt4rMwywhewmr9BDmuYFEvSD8GHa8Z4iL0KPBcfA91OEd6GMxp5lCqwlV7t kPXvzw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8t2s5rc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:43 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52f07fbd0so439523685a.2 for ; Wed, 14 Jan 2026 07:30:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404643; x=1769009443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YA3VmuPxJ2L3DtrIn8wKabMcttC/MOL2mTB3zxLU6Gg=; b=EMiRdVPbexrxe1BDkE31eiwI0DJf0hNBAPH7GRtJUsTtCz1bbeKcnuPK9+N3OVIvXF i8VQQEguu6p7EN5sxtAuv5bUE3d7rIMpF44Q5dydroHueQoJ1u15OolGzrlEeQyghFT7 6sVPDTvp3wuqSb5sMuCA8DpLQDiqp87SF1vuXy2KDkSdaHJ4CsDFJDzNdF5Zf849bhKJ iQG2rix5FlFmtgQFfjkzkiWdopyTPSbN2Ri7HuDuJcnk0XOjeXy3XgtuNrhuZ4qkzak4 B2DQlbPYd1QrJdgI8qUaStFH9swwjfYC24JWJ/EpdPdhHXDXaeUSyvZAUi/jWs0eKRGD 26Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404643; x=1769009443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YA3VmuPxJ2L3DtrIn8wKabMcttC/MOL2mTB3zxLU6Gg=; b=JLpuUTsXd5YaGjHQpO8HczzceXySJKistMf3H78n/oNWSzddTQGKpQSxm+ZVK7/iWs b0KWHvvMRgiKyOujdqLJVnq8KhLlasS/s0QUk/oXOgY/Q5UKR9yT5RU1CKHGlYRaKS/I V0P9cFISWk5BdfMfdDBVg4SMAm4o39t2n1a2ND+mCz94V3tvJVqUTExEy9ZWBzSr3O3v 8lhcZ4LgiisPhP/Z4tBeSwKQt5P7MTbzuN7Ot2voekogkCCwJ5Qkg9ATD9UQoahMYriU 5akihCrggrp5DCLpwvKIlpMs1L40dfLHppwqIvR9FTVy6+1gq+z3lnrFpm9/WZyzgIIj C1Sg== X-Forwarded-Encrypted: i=1; AJvYcCUMfzTPOTZfIZ2U8uMFNgFm2C4zKM/3Kl0c2KywYJ7WerI4xqe591D7mt+vklp30RePCYv9hU0yJRkxFGM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHrSB5ZXBqIZZG59w+mgse53w7LF+5wAYnDafbN0M8tTWq+3mW ADX0Pk3xBiZWKsd3hRiLn5gE9G5ijDjMogu6wmWUlNV5sOBKFzA8e45TTCQJpGHieLZW60fSNB4 kRskTcTkm8pNTOKnt1HyvhoH4eYBwkqhSwg7u3/Qz0uA8KU1m104kBJzrAeiJoywloLU= X-Gm-Gg: AY/fxX7sPWfdwkzAwHwLb+F/Ux634ZV/QDKMv+l4zayRerbnhQcnRNnZ9MGaDnZl6lj tDuhmqhLBRuU4KwLyIJ69q4q2fzVFL2f96Up/fe1M0dBoL2f96Bs1CFHnLkUuOID5gJSkegtK0k 5ggfoxm5hUJgdOtnbs6lxTtUCzsr37LoY+Je69RCMAThouH6mfz1WvT2QPwWYSaTNw6vOx7j5Tl 6FOAXxhs1+yzxbs3UJKxc4IRkaIifCgJqBGMnMLditXUUL1T1L3ntYtDQlUCFT6oAna2R10zlo/ ZB1fS3lfMGbDyDg69F8qtEe9OLnvIF/pY35in7a8ZvkJuLfTzDpX5H2jB7bL214brbiuh8gZot6 3FfRI+hL/Y3+gDH1ZCGkav6DkS08smzol2w== X-Received: by 2002:a05:620a:489:b0:8c5:305e:e9f1 with SMTP id af79cd13be357-8c5305eed0fmr269950185a.35.1768404642868; Wed, 14 Jan 2026 07:30:42 -0800 (PST) X-Received: by 2002:a05:620a:489:b0:8c5:305e:e9f1 with SMTP id af79cd13be357-8c5305eed0fmr269941485a.35.1768404641970; Wed, 14 Jan 2026 07:30:41 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:41 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:12 +0100 Subject: [PATCH 11/11] pinctrl: st: Annotate st_pinconf_dbg_show() as holding mutex Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-11-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1163; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=SjKuvqUidPJ5fm3b34nm9zaMItl1NLBQXfR5LWGDZIg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aJM3IeY1gDdJ/me5IBtT+aPwzcq14pNkWtM OPOQAst1h+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2iQAKCRDBN2bmhouD 157+D/46tj+ZWnUE7RsMD2CztKOGVGuOYzCPiW602Pq4QhElA9PrVOh9VIyCLBB4SAqk59lZVYO MlOwyygoSEozBQN91oQ75iEXnJ2aFkB8b20ULI/EMUFnyX6NdIMSpVnIDtcXgX1RxtvmdcYlupv d08RjFjuwR7LM07n725h6qKS9ZYbGJXlWsH7hlmPWz9uaBnMvZzlvEiGRcxJvRoIWynscL9CB/e eFLs1++3wid48u19QEMpcRMV1MeZTv9QEZFnOFzKRAoK1CYtDEfXVYfNebfDK7IZVx8Zqe5vmF1 thvHVTfdbWtXtejVJI80z4+iO3us+I+e5+NIqhB1sFl/hejmicbZHh7MTevMq6l7Dx61o72dT3b BhdNFYKwza+3RNldEDuAhvQRBjg2Osn6flZIO1CR3aOlo144cLI4IOzTKuAabhDB5TNFikqrvrL 0xDWRzt5IGOfkrJc8g9H+D5W9i+gkNFuirIpoXQ5tVjSuxdX3YHfj3OMC8Y6n7eAVVx6cqYfgR6 nkcpzSTEOenPtMlHZzvr6whjmpwnN8lLQtvA85ZpjgGBavOqUfo3Q+2StXsTFS59+ZZMsU481OL hkwcnNi21sXwyD/y/MMq0KvbGR+S3+SbDRux5b96048SW88pN3twiCfZ3TKPRiPTnwc8noN8qv/ lE5bKl/wMPXzUNw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=YPaSCBGx c=1 sm=1 tr=0 ts=6967b6a3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=RIxbnQC35JVfspY8PfAA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfXwddgppd8Q9UP xRp06gaFAZNc95To3RYmky4T/P0K9FCz5IpS2FhFGGynbfmLit00zEn6ne8PcdXIiOzEoaYi82Y EN6D7tAMWF9azJgTR5blretXqykz7heGPkAE0VG7nDOV7fmsxrYnF8vCysENCZG8yVHzX66owtF CypYdnMTpZd/navlZLQEmN2Q8sRYYWzUObqrQ8dnme0mOW+puNv75kg4FqL0avKLbM8mOKMKhPF vP6kKqv7TV3HxWmAsTASxNy/NCk1aUN+gzMBtoZ4ATdZ7MzufNpB4+yzx/p0WUtcigRTkPHSrV8 /tNYc1aZ26KmBBuL784DzdJx4A0ZjPvrOAGdgePosiDZWleuCp9bBV4Rnw78Qz0ic8mc3Q+r/CV KhwM28KeNy0cgPz9zlkRqEwFD5uWQ82NKwz/wiNlEpsQtr6AghaOnt0DKL+iGmewe5pUy3cSn0m lYBJxlHTtXaaX5h38kg== X-Proofpoint-GUID: T99O_OC-r8tXMUYIfbJGti1Ys6XTKsoA X-Proofpoint-ORIG-GUID: T99O_OC-r8tXMUYIfbJGti1Ys6XTKsoA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 st_pinconf_dbg_show() unlocks and locks the pinctrl_dev mutex, so it must be called by the pinctrl core with the mutex hold. Annotate the function with sparse __must_hold, so any changes in pinctrl locking will be statically detected. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Patrice Chotard --- I think this is still useful, although maybe a bit pointless if core explicitly always locks every pin_config_dbg_show() call? Anyway, pattern of unlock+lock feels to me like something worth annotating. I left the patch at the end of the set so it can be nicely discarded. --- drivers/pinctrl/pinctrl-st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index d3cea3437d7f..8ce88e591f47 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -987,6 +987,7 @@ static int st_pinconf_get(struct pinctrl_dev *pctldev, =20 static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s, unsigned pin_id) + __must_hold(&pctldev->mutex) { struct st_pio_control *pc; unsigned long config; --=20 2.51.0