From nobody Sun Feb 8 22:22:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27C6737F74E for ; Wed, 14 Jan 2026 15:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404626; cv=none; b=cQupROc9D84xb3aWoAmJ0qGcAo7LR1d4InG42uVP4LT/pQXxuNqFh7CtjaLuhbK+Iq/NMsYeryer2AspgeWQkTwuODq7ilCInmG72STloMnAgHorPIHH5U0N3bAbzxVLaDpng/rfW/G77oueO7lJHpC4p7j/WK6Iz4VY1WJshnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404626; c=relaxed/simple; bh=BOg98/1JJXf+vGTTUwHW2mMQjVbfd13nI6bPXirGFB4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=i+MfUzdnlE8aUkn8DxDkMCEuAbzlA8+QsOgH0qV8ZDpzEEY/Ak0Dn3EjbRvfuk4ooq9KL9ik4iOaanv8chn20gf7XkyozWMZwsx1Z0JGoKwb4JGNzLoEsol8e5MhC57L8HinFkkBcoGnhrOtSItX0L1cxSvoU9i8EDdsii2cLfs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AzCSBoD9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GbZ5YuQS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AzCSBoD9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GbZ5YuQS" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EE2pYk2497462 for ; Wed, 14 Jan 2026 15:30:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RTM8QP4WDE86GBG0NkZNuey0Iun+lulG+w2rdXJWnfI=; b=AzCSBoD9J/kAgn5b NYPVaY6w6+Qs5o+wVDPdmbCawKNIhRSVPAqH4gl4pai6bAKuHoVYlq7/WKsYLNjB KQrB6jYs0vWaY6+W+3SN1noeudRgeyidixzfP+OYATvIPWpHkiBDpg3e23JWTX1p 4fhGq2IJnlZ5KJqbzP+NLxCB5Fc1xLFL8bw49SWoU1rGDiQ5rHou2y4mHufOcRST Ob3AkdvukE7IKJsynwD1ZBbOatQM6y+aklUfu6NiWhUft8INyUsny/4bx+2bR/QX ghWJPg8SbaF1jmdhlrH19G4Z/HY6XW41soqrc0WF1wihTWOXPxte9gbGFoCEMnSl JSycfQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp16x2xud-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:24 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8b2de6600c0so2463324485a.1 for ; Wed, 14 Jan 2026 07:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404623; x=1769009423; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RTM8QP4WDE86GBG0NkZNuey0Iun+lulG+w2rdXJWnfI=; b=GbZ5YuQSGdY2Q7OwINIfvTMFTKpQg7dD6FoD5orzAiXOEm6ATbfDNLzdkbdzE1iDfG TE3PDBYIOfGKWNH5AgTUEDKJiqnjIR4SlvYY4DeAUWoZcqW+QGr6jfJYEL2YxMs3XaRy gCQ6uOVzePUKvUAGLzaGsoFDuEI/3vq9OMky2MGM7MecUMahB4XgoeYphMYIJFmiSK8V ckysUan2se+yFYq+ytrxHflJu5MD3a7x8x01XNVytA1f/PmWMlWL4GFUYiiM4SxOxxHY k8EJe3dt/IGVZXFzVrdSmGZXVY8jc1s7HjQ5/1TU5Au5eoO0JpnoIf2d3n+TrLziz6M/ W5qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404623; x=1769009423; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RTM8QP4WDE86GBG0NkZNuey0Iun+lulG+w2rdXJWnfI=; b=H2H5lCNlpzKwJWxn9Okl8Vjn32pzEGhJHG3AFhhIQ5/BocQLiZGwpKKy9anxJiXNup 1bS0WoNcShNhr4dkesiuAEHotnyPpkEQ+JRH6+lMXVnNX8DJfhvlGv50/MtgnT5taUDB 75SbeJPPxdkE6DAqySvH0D99UshfT4jUZDCCShd4W9Fso1OQE0ZoouRcaYEDVQGDvRYT ySWrUhi4BylRe4Mi1q5exOx1yrAERaH55v9Pce6CZ+fzgrGEo7XQxbbpZi3eg4WWEd/D 2Kyt5cIP3XItZ2//Uxxh2tCPldxNQnkOKlBnxj2yqounkGELMqoigUkBRLGY8c1PTY9b 7lDg== X-Forwarded-Encrypted: i=1; AJvYcCWvB8NVkHt8Uq8JKx9h2Cm7AOftjlGfeOnfVUdZWE3IFohUOhBTEzzzorVfIpFmnXF3/1a0CL8/gfAIvr0=@vger.kernel.org X-Gm-Message-State: AOJu0YzU2OmtcF6oQjCs2W+Da6BRLizdimxXsDKlNZZqvf/3E2eBLI82 szgu7ljT2YdewkZ02Pgf6/liHBLKQhvLwYoUTe8jFu9KXPJTuNJ/ZHlQ3cteHDF+Lq8A5OpphYY vB4wSTe1eIK9qQ+ZiG0m8f++b3kYBg/Z22NIm9CJISsYtiRzi6yIETWbVY8RaXE2ZW9U= X-Gm-Gg: AY/fxX5IISulPfGAkJZdsWhxqInv/eJAE4d48yRkJ4EoqPpeOefXzp9SyEZPWrdqX7N wX6ZjcD5R4R5WNr7jGEgS+I+Fd/wQRaQe8BJlJVsucK6yRKL0WFjsYZervSUG5TmU5nI6k38A2u ROErzJucjzMIxGU+ALfON/HMztzCMTVoL40iEsiERCpCdUZdO/YmOIE47UqhKADP34AA2QDaq2f HZdAcAIi+/CNfIwGm8tYn2k207zEzS7mjpaY3wVqboaaIQXEQH6MhP5UKc14n+WYYgzu/5NZcCl 8npviGGU12W+tsxcr6cHB7s8Bh3TMBlgeqaSXfyha1cI626ss+DA3M7otlwTKQ2rYsvYgqJ+zkv +cPp5J/ABPq19yTJRAL6ao19AyxSvzR65dg== X-Received: by 2002:a05:620a:2556:b0:8b2:d72d:e41b with SMTP id af79cd13be357-8c52fbdd3aamr433309085a.44.1768404623514; Wed, 14 Jan 2026 07:30:23 -0800 (PST) X-Received: by 2002:a05:620a:2556:b0:8b2:d72d:e41b with SMTP id af79cd13be357-8c52fbdd3aamr433288585a.44.1768404622116; Wed, 14 Jan 2026 07:30:22 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:21 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:02 +0100 Subject: [PATCH 01/11] pinctrl: aspeed: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-1-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2516; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=BOg98/1JJXf+vGTTUwHW2mMQjVbfd13nI6bPXirGFB4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aA2bajX7HJFoPmqSFCGOiGBqLJt6NM8LzAd XAIqmeyi3uJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2gAAKCRDBN2bmhouD 1zSHD/97RdnKd17RjQ4GZXnl1GK1sM4fAIbv/Er4l/nCYrCsRStOmpsNfQQNQ7KbiFIy6ka6EQQ RmCybnj6DI01+PJ7LKfZjIhsVOdQRCKSSRsSOzZ2sWtH7UtF7Qco6eaNduwhfUDaSknYVE8yIKS q89qtgMa00kGUI0EqHfiZ8qCSnSWxZL+xPFwD+VaK2PMANj3eijWok9TKqlbKkGTmMKho7c3WOD kkTSfcVXpAaccbQNmgEAkCUer3aTG6Z0QKWdyinivpOZRSpzni6zy3iZTvH5qnQ5okqQ8+u1yVL ZcUZ45bRE9Lxm2YaqTb/8FMSOpMAAXKgnB8X6QA+InLQGRJSNoaNEwmu6nNF/vR2K8ztj6axVXY 0vmcCDYOnJbcX5YBUAIDooVFlUG0XDfrGrUzdObWOPhSE4k/LWR6KvxxHSM13yiEttuiUh5j5Wc uyOWQQHPn+CHVSxzd/HqrsGACkpKblq5HaElBupSYgsEcP/sLU1GEEwHHqCpdn+EPpwcITg6hft gzyvN7ZCzN1S8gDsA7ykKbGnB5dKBWHADzwQtqQEP8YvZiOnvQuPH0X2k8Vbd6e0GSxIUydR1xh u9u70zyMvvsb2RcwG5zaIi3AprWfNihRSpPswPd5WpF2M6sS9zQbZzeHDly67NBW2wG1jPitQdo U7H9zvpSdKlaUmA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: 2vqIdqQsb8r69SdIt1gVdQa3Q5CDOUZB X-Proofpoint-ORIG-GUID: 2vqIdqQsb8r69SdIt1gVdQa3Q5CDOUZB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEyOSBTYWx0ZWRfX6SZtdA0auYFJ DbN7M0zUhFvTImMJX6pHROMQ+7jfUf4wQmQVhq7k4oCmxS6raBTDolUXkOeQEzRAA7xg1x8GEFG DZYqU51ZyZMR5VaGwuEAc6rnabmOSfxY/u0W6gl1HbpK2sr/lRC7F8gDBtJiPOqO+Uz4qbd3Ah8 wTrxs3vgTGvaWHxkHpMRx7XTeFu74kJ9g6gxPdnQyWxr4H/Ukndo28QgCNyf9pj1iCFhScxbe+n KhPEB1vL2xwiJ6MM1APlO8Mtlorha2qYpdSws+SDsOUUuZZczMSXvGk8XzpGyVgZU40qDslGFHP HWXTmD/5+AbUE1kPWcGCNkRMAiix0yN1QzuyAXOhhNbEf0ci0HibV8yHo2KAQpOPsFPu+MzPorp WQlvADbuFOCiq3e+LSH8657BnrBNtX8GJD5feuyOwzGE/vBu8q+4nWqBrZmjamuvd9Ovw+R/XYP vB50VG44maaSMpjLXcQ== X-Authority-Analysis: v=2.4 cv=JvT8bc4C c=1 sm=1 tr=0 ts=6967b690 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KvQaFmux51imLjMCrhIA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140129 Remove unused includes (no mutexes, string functions, no OF functions) and bring directly used mod_devicetable.h (previously pulled via of.h). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andrew Jeffery --- drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c | 4 +--- drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 3 +-- drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 5 +---- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c b/drivers/pinctrl/a= speed/pinctrl-aspeed-g4.c index cb295856dda1..f9d8fb1ab1ec 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g4.c @@ -6,14 +6,12 @@ #include #include #include -#include -#include +#include #include #include #include #include #include -#include #include =20 #include "../core.h" diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c b/drivers/pinctrl/a= speed/pinctrl-aspeed-g5.c index 792089628362..9934ef6205d6 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c @@ -7,14 +7,13 @@ #include #include #include -#include +#include #include #include #include #include #include #include -#include #include =20 #include "../core.h" diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/a= speed/pinctrl-aspeed-g6.c index b0c7e4f6df9c..8cf61aab81b1 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c @@ -4,13 +4,10 @@ #include #include #include -#include -#include -#include +#include #include #include #include -#include #include =20 #include "../core.h" --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4267239C65F for ; Wed, 14 Jan 2026 15:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404631; cv=none; b=GL+zBbC+rpMDhpa87pAqFoharzyzU3Y28RC/9slECikUTlMIh52unccyDqJwnw+Yz6cNQk5lZXSOpk8Z7uaCA2E54cShhLzbIEYar8AkqIzKR3n315VHJoB5ezK+MkkQ1yTotzxsME/oA3N9aJ/EbnIW8e+FXxgePKmGis7h8oc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404631; c=relaxed/simple; bh=vQTc4Cx1cuzPah8LLXL26kybe/0nRvPEYAbDNlVXaL0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cEIBlY2HGQoW16JHgEbW4nFJNtt80Z7/qT46eAIGhyfpFfAFAwN1ZwygHx82QDynlKTjMFg3GhV+KbVtkexDW/TzdEaT+VNV7psE4PFdj4A7NLJnPPXjYS1zunMrJF86ytxnrOFhjbQqPREcxExTht7yuzUwgDr1nb1P0bPIpbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Nd+c0nG/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NBCkinxZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Nd+c0nG/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NBCkinxZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EF45BQ1943025 for ; Wed, 14 Jan 2026 15:30:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TQOWmZ4i8qr9JpAuK61Y9RoWdOmJcEUPWfdU+wHADeY=; b=Nd+c0nG/FDs7XoIV szExDaUVSYkyrbiaHalQ7Ap9+Ae6UJ/LuHmENsYmw2Y917XAkpOSA5PDn/ucsIXw RLjTwBfwp+vw9JlBmnZtHYYPA+nuxAqdd1pB4mQdMxi8gLqJiqMqFue9dtxzWhhw z2Mh4kP3YONo/VwuqMbCWqIdg2ZulAZiBjr4/v+VsHOzRPeea0BMSLLBuepXEfaK 4TcnFo8VnR36XVqUEY+VzZlVDB5GSRQreJSVMoii0SAdOXRljAxbNb1718WPAMnT H1EH+vCGRqzwWc6iLgCOM8ppr/Cv0FkS9cCCOv2YBPPewR6rimIDRchIvZsKHfwn UwREZQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp7b6sjpp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:27 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52fd4cca2so247824285a.3 for ; Wed, 14 Jan 2026 07:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404626; x=1769009426; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=TQOWmZ4i8qr9JpAuK61Y9RoWdOmJcEUPWfdU+wHADeY=; b=NBCkinxZKeXMDWkesMxQMbkNJAWqBFUFeed37Ol5aYgNeI2gF4HyjMLoxTvX11ijiz io+wzqzcI1vzZK8gRDJkNzJbJaaM3b0HxeWX8zaPJJFeB0OoQuKtT34iCPmkcBZFMu7I 6BFG26Qwtylw0OvMAnF/DKG1U3Jfh2XGYczaVQGOhqB7pmPsfVm+TA48mQQyIaBjkcA7 wOsoJ+ZVpXSbXWcKgx7g5cOUVkNNcmqw4EOZWgg4/uVVNpAB5Mjuqm6xxZn+vOqUWBp4 alLIIgxV/WJJfc7bRd9GerLEggftZ5873MdnzZZ56UfLlGoev1iRrSq6IU1LfJi3zFm5 +aMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404626; x=1769009426; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=TQOWmZ4i8qr9JpAuK61Y9RoWdOmJcEUPWfdU+wHADeY=; b=DsMas2gYqREAyjJ8542n1t8Iz2Z9yyXJvCqi8qCNEI0LFAsYyVSH3Z3BAGCmx/Tj9c 40Hgy3ZQxwUd84vdzAvTR9OiVyum/wytYSfu1Q3kwYIir78KP0EpnJBIm33NNm4o9F0A 8sPKCUZ5Y+9RwNdfogIWHrt9KyLgTcf84aZH0phCIw0O5Qldmyv5YM9jo0k8P3eoG8T9 j1nvvbR4dUBKtToe/9TS1BqdRXeSErWU2N6j142A9zZgCy+l9QayM69ta6Lrgnpems1y e9BAco0AfwbInaPojNEU1nxrGhAsgWwHZeXUZS0tNbPrW/NGZo19TmW3gxXfvasxAczE DB1w== X-Forwarded-Encrypted: i=1; AJvYcCW+WVX/GAZxk8KKJgOokOGLvLhIOj4WnaVCALt5naKdcmMHpIi4n71PHwZ/d8OlmwI7werHa5VI/WtvS6o=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4MaxYhnJxHIf7D/8eN29tTepLlPtlxoljow7dVTU8gVIX3AYc doFU4MfQRTXfsZrjcTSu3LbWcGN6Dj+LY7z4LaqjC6AvJYeKyIbNybFPiSE+xFHygAHbi4LFRCb ytKLS4vsCjJCN8v0rHqQeD0l7NKN8MDVWANb5kgszMVf1wXOX/F7ZuH5sFpZGauC9zJQ= X-Gm-Gg: AY/fxX5gtWy6coKEY5MvUqffGSm0NaFfVg9h6vNaTQJKB1/tXqPt6FJodNTKiIcBs0L eEMUnJSEvj0MpNegri6B7tzWyV6jrVPkDxaKRtba1gHfXZjfvO+/bPrcNdFbbbdDN9mAx+7gL+g F6f4oVpBreNA3f4BbBi5SN/53VpykMGVpPfMPmbqT/bGSlGtX9zo/tQAfgeLbEsOe2JS9BFgoVZ wzO70pf4XEt0cll6wmlpF+sKcdRZJb2w9eD1Q2DqsEJ5J3vtBMbfeYv2l4hW1SCs/xG9JW9nvvV fZ90/wNxrfEXbhe0uk/UWMsZpbmI5RqLPjXh3rFY8VKb6z3mTeVpCoNvbMvMCK9pobPIjSLSbV9 1dOw6HCXer9AnGaw7pkdQM9TGqdnu9j0NTw== X-Received: by 2002:a05:620a:44c4:b0:8ba:5255:107 with SMTP id af79cd13be357-8c52fb2406emr386806085a.18.1768404625695; Wed, 14 Jan 2026 07:30:25 -0800 (PST) X-Received: by 2002:a05:620a:44c4:b0:8ba:5255:107 with SMTP id af79cd13be357-8c52fb2406emr386788385a.18.1768404624120; Wed, 14 Jan 2026 07:30:24 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:23 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:03 +0100 Subject: [PATCH 02/11] pinctrl: starfive: jh7110-sys: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-2-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=906; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=vQTc4Cx1cuzPah8LLXL26kybe/0nRvPEYAbDNlVXaL0=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aBbIM2DWPBQNuBnGlAmRqfublmk+ABnSOCP +eX7CJ/kqCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2gQAKCRDBN2bmhouD 13B7D/9HNpUgwKflmRiVEQKiqAHJlihytGsm6xhqvuPk0OXM6g4wK8KWJ7AoXqklkhVGJfLYvjS EVoKICEkLULEFDlMFEFKdNqN/uGc1TUwNp5gMcRJRrlIE+ZYvRo4LIknCsvHV1jT9i+Y2L23c3p +uDVB8dH2uwJv3IuhJUnA1gGMQM4xpw4ac7NB+UCOk2LnfcACtKncHKQ7jr4vbc3O0f3pfTQpJp dZkWVtWxp4BQm+5d1XuZwVzvgj4b/xAJcvhU0BzFKw41RORAakfzsVxAkTHHtP62LHFxnKZSwKi E8XvqOwq5O+74OFdv+vHFLcG/6f+rPsNDMLHCxupzCLkx6Pwqg6qJp9qYbsQJCEuj1EJyrotryy ANOtROt7QabL1HCVBOeWE7/I1c/PzdUslygkZyhowuMmtTrgMAsawR3fzOXHuQOQhjeKsN9lt/M fx0zuszc+shjokj+huAOTlufmrLlWzFxqM4Hu67hEma3ScG2iv485ncOEg87MQQpuFfjrtb+vDK ICaUVJAoHNSRifaTDmw6lMDG1ZAAU7vvujZpio8eHVdgOh3jPCnAMmeTePFgqI8N3JIJ+bkQyuz 2wHidhJCNQckjPlFZ10HKxqor1PXsDvliPHX6i68yW1W61YZ+wIbn5bOmZ0GIDO6/jOlooNoy63 tkrtX+1GbUIJE4Q== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: eza-2n-WDDwiPcUXj6PFig--S3SxVhWl X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEyOSBTYWx0ZWRfX0G9wQo7uFz57 aAh/rauiUanIzauar8iyV87Ip7dippGQGKFsZrISuKE3Z46aoFMkCS0Gr7ZbaVfgFQthsaD8o9Q eD01zZ4jIVaYrXzpJXCQOAhzD9jsc7sJxjNyBOD2Ash5oMEbIOr/tzkSS9qqmSc116/MDmb8ZG+ 4+Gya+5WyFPA30N/HEB2dH5LDHWItlAODjjhhWaTLMuJ92yiQ49TbnXAH9FektwAWiG8hGZZUYz x0wiyFLK5z6+ZrAdOQkiAhMW0Wpo3xDkK5D3XLeL4PrvmIzyH0e5l/Kmqm3OoODjP3XFyPt2UP+ W2HV4TS+8qq+VYO7JK80d5oam3ct0/vdMbsh63eIdux0CaNIScbLaTXK4cHiJ9bWeyM2j3rwXjL dNdMpa3UHBypokcter6x60AqWWlFExRUbZdy3z5zVPe8dmUo/6Mk7X0OFWkkMJFjomAGlG1LF9d 9HIVlYdUtVxVfRplY0g== X-Authority-Analysis: v=2.4 cv=W+w1lBWk c=1 sm=1 tr=0 ts=6967b693 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=b-TtO4hhcUHcL_E8iecA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: eza-2n-WDDwiPcUXj6PFig--S3SxVhWl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140129 Remove unused includes: no clocks, mutexes and resets. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c b/drive= rs/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c index 9b67063a0b0b..44f84e4c29bf 100644 --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7110-sys.c @@ -7,14 +7,11 @@ */ =20 #include -#include #include #include #include #include -#include #include -#include #include =20 #include --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAFE639C645 for ; Wed, 14 Jan 2026 15:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404631; cv=none; b=IPhLK6f8WZIi18fyBarbrzpOGnqiBs4o3gaG+nTCC3NVRWF7WlmwMCGPbFXBOnZ1N/zoZ4pPfCPMz1BNjn7lF7APrQpP3kx3ymVvUs7OHdXEhxBFxpo6rmpAL24w2w3BNOeID+FklJm8veRM+gd1P60uuGvSr5ZzXDBqipHpbwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404631; c=relaxed/simple; bh=4PObio8XO1Yv8S6gHkX3VQh/PJ6tCJixfC8ij3DGRyo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fLKs9o5QTNj5DvBZdokDifooMuhwXxBh7gvppwGbvGSN/fyXbTYfLXLy8wobnyF9sdkKeP+LWs7ibTufrZKMvxozm6thYi3Ot3rVeN5t+azEsQC0fhFQdHhWKPpeUy7p7JgFXUD9Ovn9gKtzb92TT6aTsk3r/egg+QDP7lf5hyA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m9guE2VH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GRYHo8YB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m9guE2VH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GRYHo8YB" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EDV2BT3551506 for ; Wed, 14 Jan 2026 15:30:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Td023EyNphU3HomQn2sLFQM9CKKDLSqiy1q/KAZbFDo=; b=m9guE2VH4qUM/cRJ F9CSne1yWYFXLejgSGprT79ctgmVOvU0Un8d+0E8aaesqKyWhy39p/Y5Nk+zgulz Nj6F97jEeXMdB7O/77IKakV+NC9vzbhiwyv0+JxNix0O24cIR3nPDmsy2ToeuooL eg5rtcsqs5cHJVQRQsNOMX2C29hm+J9lhkLUgwwKjku/sN51CRNUJXXhiP0Sqfoy ypK0q0R2Lu2+oyU+x76U7mJA9dHP9si/D0jfLUBBlngAHXOWYjQdmWkUXTJ/Cuy6 hpIlMQ2m9ih2/r4ADu+T3z57erTicOBqKkLRdQ9hDxgyp6sNsVw+p5Or6YsQ+5tK PtqQ8w== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bpc3jrd41-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:28 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c2bcf21a58so2381924785a.3 for ; Wed, 14 Jan 2026 07:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404627; x=1769009427; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Td023EyNphU3HomQn2sLFQM9CKKDLSqiy1q/KAZbFDo=; b=GRYHo8YB8tZir6lr8zk+U4hHlGXYDV89KkHKo2f6BP63Z52VcWcUrrzkecGUlfDswQ VoHEZjfKWWGYgKhnh+E/yBz6cgOIr1r75nuaQuSfwTKq/wZPbMSo12LBUhSmlp56F8Es qLIRHXrn2tvFKYhQh0G/LwA//cH8IX+aaZ6MqlUALHidAlvB4HuZXZyojprHufsy9zyS f5EPmNhazBl1HdgQWGQRdeylC2yWsvtn9e+Hz3PkSqmHBgD6JOyrLkFu8SbiYNhoeoKP qeSZHerjBfzvnpJfVbLL+A4WZ0JxK4LLKMI7ULBvnBiiQANsNaBa+cvdgSCCtX04Scls obbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404627; x=1769009427; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Td023EyNphU3HomQn2sLFQM9CKKDLSqiy1q/KAZbFDo=; b=vSLw2tl8tsqKAH45uO0KIdrSexP+FVRFAUu8JFmoj+Xz09bAjJPClm08D5vZuoMHKN P5SfLljmux4QFpqM2vU2YclyNK6KW6cPnpA08o/4WQc58owtLv7+pOKLUJBXyR5AjDPg 1nfUYFc55G1NpgG+73SZIW5pXEBFf4VNaHlP0YCp0g/Q21fpKQ0eEVarmrDnE1/3e8k+ 9pD2YhUWC3xTjDegUIAHS6huSHD+hhico2Vm25v5LjNv6oONXJ1hB+HfhlBfjYkxxlwd Y+4izewl+QyvKK8W1q/Qw8K3FqEKiOdheXcEpnCtkkD+dHmaVoFB4upgHcNHXsSS9LjR RRvQ== X-Forwarded-Encrypted: i=1; AJvYcCXv0T6fZL/uwIR4G8F7nK7MP7iVw27+odWfIL7+3fESnmeqHRJKaI9HdMxO1+1zkyCYwwvXEsnSDYxs1ZY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu/vSZF+SdQE440pUQhBcEHMqG1aTsjuuL/R02hzzjqyqivO3T 22RZ9iwKQwRRu/ipKNqHUvXTkb5flsHNcaIyMtIJ51DwoWDyi1KLGq0Rq43zIzK+swOkYJltYUW h9NdWtwPH0trKgdAriOVwN9hb8wCP1vGDDvKzG0KpGOMOBRK7GUeNAZWMh+LJ+rNrfw8nGAbSEy Q= X-Gm-Gg: AY/fxX6tlGpD10s9T15BNhMBeiLG8v+GVkwSfOvO1rFp6FhMZ62kaDPTklKYtdcGwsa 2P74i39dl6vv+C/ECEFRCpatcJ/IthGHFMWJRehg7pVWnMO/UKhGfi1bTCZC47d8gaV6jqZD0cj c6q8bQrxd/tFjx3Ztd7usWdCDNrlqNHw+JQxVrn35+qjLKTwvswIlilloQEyQLG4UZk1StJFztM DSVgPp4Mgw1EY97ziBvedTuxTd5hKVzGoQlVq6K9Wit8/ybJqvXPjvclCwLERkGShsmxlR6sfmX vboZhH0Lpblfh08D6ExQcttBWFFL83PYDOCVqG2GyE+PECrAIWqnP+IJHU3vXCUvSJckFARVvTF IG9P7bW3oJDsDrDxxkvnNe4N5rQQKqHY5gw== X-Received: by 2002:a05:620a:178a:b0:8b2:63ed:dd10 with SMTP id af79cd13be357-8c531817444mr270063085a.78.1768404626615; Wed, 14 Jan 2026 07:30:26 -0800 (PST) X-Received: by 2002:a05:620a:178a:b0:8b2:63ed:dd10 with SMTP id af79cd13be357-8c531817444mr270052985a.78.1768404625897; Wed, 14 Jan 2026 07:30:25 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:25 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:04 +0100 Subject: [PATCH 03/11] pinctrl: sophgo: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-3-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1597; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=4PObio8XO1Yv8S6gHkX3VQh/PJ6tCJixfC8ij3DGRyo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aCHz5EDoUoqxZYrNILSL7sGe0v1k0RWIrht 2xoRozKYP6JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2ggAKCRDBN2bmhouD 1w/tD/4gze1JdYhn1yRw9z1Dt7upNwMEXwviunBaUWTiyScupfZYrZZ+mi8XAQ3h7sV+pqVxDTa PlkvxnU6zlG9dkymlIE0QgQwLo9fLEkTv385MPjlesnC9lrc/f4FDfX+4dPN/oXA39A4biQkB+c +amG/ZurwftY7LyIH7q30PDuDYI4vF65nRj/b1+hVgqxfAvp9gAvZSRqpQHvBejFn4Y/0jwRz9U a/edRO1L1nMLZLFNbB8+8W6lcAPnWlYV4bma5tTKPxGMBTZSNBHmnLG78ad7y2kuVLduxRIgZZL BGStla564Uwnso8MjSs87/BMaJR+GTfNwesX1/LRok3T6S4JdM6K1/KHCtI/jz/+gWrLYZokrkU ecfBDZj08Vkc/2LTaQ5kpQDxJdktYM9STLZFAlNercSl7aVzW8OmmGBOw+iLV3swzbnsI1tUfQf kFwmjYQ0S4oqnI7TBdpuzYuPOn9N71vc66VV3r2ngU9DZFiWSO1ZhGwyfvLqDUvvLW1+JElj8Db jdcFgyCm0Tzu8bpsTC+DfNskjK/kXhSqapyyboNwAEEnFX0NZ34wopWT0mmkUiYg36PGz5siF3w nIvRqmBVbenaq9nzL8bCWZLjfudHFcAUvDUbRkL6uD45begdv/TVys2yD0mRpm6Z8qUVqmIDry0 uvlzYRfNG+QaVoQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfXyTn9GS9HKUYr MFuup+khx9XGPW7MFKXIJoyUHpKxR6iJA+mTDKBgDtF4GIWXXnTPx6VaqxtEZcNjwaHwifhGM2I i/34MCGZcpOSAtGVCr7XpY3BNz1IZmLhqrD0TPbcB5XyPHKi3sagGuwJ9o4Lx8JaLBovmBZPhct CjJhCMAKzEiZ7gS7OEvmEevPClKceZ1xbXzQKZiHJ1BoBLYrDU63/wow8C5rIRLIHxaJIiCXJsW h+3LlrOuA99U8Vj88nxmNS6l1LddGT0uXuBCG8qZvXznltzaYFKcRwx/8TjcRPtdDKJgXof0aiO cggf3qmAC2yAHfjelEVJySvpIudh+1toU4ALpCp4rd4VYaWaHm6qD0XJvKOupFDa85ghmc1LilT 6mfsok7SFODTq6aHLo0Dz8883OUKUWeG3+6oNGyMTusKXhpF6NXBDfcxw1P7Gwg1yAkPB/NIMgx imTiPj1+EQsErtGISsA== X-Authority-Analysis: v=2.4 cv=RLO+3oi+ c=1 sm=1 tr=0 ts=6967b694 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=XMepgddcWT0EFqeyVMQA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: hHNfwgxgsuF9t6hpyjC6EgpnDjCl2DVv X-Proofpoint-ORIG-GUID: hHNfwgxgsuF9t6hpyjC6EgpnDjCl2DVv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Remove unused includes from internal headers, because they do not have following: bit manipulations, mutexes, spinlocks and struct devices. These headers are included by actual C files, which seem to have all necessary includes. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Inochi Amaoto --- drivers/pinctrl/sophgo/pinctrl-cv18xx.h | 4 ---- drivers/pinctrl/sophgo/pinctrl-sg2042.h | 6 ------ 2 files changed, 10 deletions(-) diff --git a/drivers/pinctrl/sophgo/pinctrl-cv18xx.h b/drivers/pinctrl/soph= go/pinctrl-cv18xx.h index 759c0e604acf..973ab9a38fcf 100644 --- a/drivers/pinctrl/sophgo/pinctrl-cv18xx.h +++ b/drivers/pinctrl/sophgo/pinctrl-cv18xx.h @@ -6,11 +6,7 @@ #ifndef _PINCTRL_SOPHGO_CV18XX_H #define _PINCTRL_SOPHGO_CV18XX_H =20 -#include #include -#include -#include -#include #include #include =20 diff --git a/drivers/pinctrl/sophgo/pinctrl-sg2042.h b/drivers/pinctrl/soph= go/pinctrl-sg2042.h index d481973fcf97..1a2b00dde1fa 100644 --- a/drivers/pinctrl/sophgo/pinctrl-sg2042.h +++ b/drivers/pinctrl/sophgo/pinctrl-sg2042.h @@ -6,12 +6,6 @@ #ifndef _PINCTRL_SOPHGO_SG2042_H #define _PINCTRL_SOPHGO_SG2042_H =20 -#include -#include -#include -#include -#include -#include #include #include =20 --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E19F39E6C1 for ; Wed, 14 Jan 2026 15:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404633; cv=none; b=OVV/dFYDSq14ieWQppKZqd4KgPBSU6gIOQtSsxobHbTxAJhEN6Il6yP9+al+nL06yhVEQEjAsIU2DKZoTXM7R+PCyYT4RL9SBDvumCjt6XmJzvrcWPI18Z+wsFV7cBz3p7GEs8Nc7kKg4pAH25LEuMFdWVaJ++eHsiZ9f90NhHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404633; c=relaxed/simple; bh=KS2A41254/IzptP8+yKUiwH8wnfKT/gY+cirH/V2Wao=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rKP1sCzQqk5bVtGz8yWh2V95LU5ag8Q2i9eIFPCznPK9iyw458AkJKARiitsdDHMTN/eD/PKRWWvBLkH5QGM4yqwWGVcH+b/codGJGwU0M1Od+QlbLkUZW4aSdaBrD8H/3qYP4tcawNkz02L28VXW2KNhNxvaIXZJPvCINCy6Vg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ja6yf+55; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gga5LKdv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ja6yf+55"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gga5LKdv" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E9I8Mu2552697 for ; Wed, 14 Jan 2026 15:30:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Mv0nQD2Fz+xmN887PWY6S7g+L/xnSZWABnal0geai9Y=; b=Ja6yf+55fHq9cr9+ 3BmQxbt5bpN7SHtBWVenCY2tSp/rN7yEiuQCqdkiBXi67+06a/9pLEqUAeXLTdNc a1grs8LrblCreo1vw7SXp2xl5M9w4EIMROi0sTqscq5x2HqimEYP+t9LG7NSfIN0 oW0mJSmKZfsrffOl10LCS9I+c68oIPg6PMdbu9NWlAbfYeIljtZ5LwgkSSYHwo0I 3JOnKWXYOoVsAlspcsRJg5tELpY5u/wJniUo+jZfwG6wj8mYx63YcXGrOMDwboK7 SOhO1+6gPKgS8ghvVXEQWk1ZVwZqbf1Hap0Q/5oJrgreJR5QtLCL1pFJaKpiTSIP 2G8J/Q== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8d318as-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:29 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8bb9f029f31so2434660385a.2 for ; Wed, 14 Jan 2026 07:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404629; x=1769009429; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Mv0nQD2Fz+xmN887PWY6S7g+L/xnSZWABnal0geai9Y=; b=Gga5LKdvbS35dlHvvjmxzyZ194z6b8Ov47nk5tBOtH9rfPWKF2NmeU0Lk0Ehdg+kC4 UiMqrudBXHucLWo/LUqm4pGXbY33xqBzvCtL2ocglJ8MbMuYfxi6So2BQwaqmXH60l6p 07D9G9UaivzeuQfZNKEI/Y4Dwt6CjECDvtKVWgqL3ApiPujoBUyaHVeKhSUFQvaw3uqd 3UBy1Qn8aLXBdbCszZYeKY1RvS6E1jS4gtFEs6JCMNq5LQO79SIjIWceVYpg+mrtf4XM cCiTbM8e8PZbO+NPeZi/7e5OIOk0Bd9FEPEw22MJmpu/r1TDWu+TA8NZR6JWQNQfG/+W ON0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404629; x=1769009429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Mv0nQD2Fz+xmN887PWY6S7g+L/xnSZWABnal0geai9Y=; b=UsUV/lLd6jjT3bGzSOKpmVvFz4SNWPUzHe/NbekrIGiwzTBJg4wqkgB14YImyRxkRd lfXzsqPzx1pR6ax1yszKqg/c4HYv6sPvyfRSGd+PyW3HCE0pkaCETB6h3+CC8v6NjiKK v0AOcAwM/1w/sw6PjFgCDiwABLZH4iklPSm/vLQ8SOXm+opf7rKGWnpR7Ey1StrOWNCx Un1lAsmnkC6mqBnUVTjWDcQLhsi/pi1xc1QW2L66u4mA6ydeV/70hBW5AKT/vTtkdGgt i1V9vdGkBNvXWKBsCykqVV15ghbis9ZK74rjLmvWnw909OkHgnE8a/QLWcEDFePVATRz k1Dg== X-Forwarded-Encrypted: i=1; AJvYcCXqQGMQCU7oDpA4ua5GczVY2pwF/+SgHfQEdOxGwYtLU8PEnHCyd7i/LUEGUHJSD9wTOa4eo4MqyIJlVzg=@vger.kernel.org X-Gm-Message-State: AOJu0YzdBHo/ZVuwbQDvAxe/0hj4eO50RrKd2tNTaNKSoUSx/2HKpgJj Ae+ObQxXal+lIirffwFNm+mwU54LagkeeqtVY63kUfx8A1TlBD7hwFF07IE4kacuaTAgW0ifXui jYB4skjqsrY4QTrKHOW/wZJMu1yIKXGGfBoVv8ZoHEHA1kB8MUOi7N59LurbePcZSn0A= X-Gm-Gg: AY/fxX6vJgGxvvDJ1cKQFsy/revFpHDhvwfh10Z8zDmidgsyx1uHyiE6nHbcqvBR9sW wZf3e9EUugqoFNBgL+BCPR9L6pusb8edrEL8kJjpyUr9VHhE2NptIvXB+rOvB4ReNDxNT7Jx5e0 j/Vz6Nrf/+JBSM2o1/gNeytsOZHkJynPeeptqC0uH8MTIJ7f8B++vTgKhidn6yiX5GJpV1Hg2qz U8D6zNSJbAVRkYWX1l8pWVztfjFK7TXxCg7glUtih7hMx7uQP9bRIqVHv/ZcbH14BSCLDtzpRTj 2dzsLNaINZTHZToHm8z9j6pm+Z2UGP4XaIz7VB/g5WSOleL1QRe0dj9UIGOUxy1PMRvF+PfcQco xdTaKwDI0MxLzJwye/v+cqRtTGQYFRoB6+w== X-Received: by 2002:a05:620a:4443:b0:8c5:2dbc:6244 with SMTP id af79cd13be357-8c52fbcf013mr422896585a.47.1768404628271; Wed, 14 Jan 2026 07:30:28 -0800 (PST) X-Received: by 2002:a05:620a:4443:b0:8c5:2dbc:6244 with SMTP id af79cd13be357-8c52fbcf013mr422891285a.47.1768404627841; Wed, 14 Jan 2026 07:30:27 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:27 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:05 +0100 Subject: [PATCH 04/11] pinctrl: amd: Cleanup header includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-4-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=775; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=KS2A41254/IzptP8+yKUiwH8wnfKT/gY+cirH/V2Wao=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aDV+noj7ZcYLzGFw85urth6DKCl65+zERGB 6whzCjLMW2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2gwAKCRDBN2bmhouD 13ELD/9w2SYmYalYA5vFc6Rf1PTVYZ4B1dYRonz1b2DQNyOu2VbPve8mcP3qP5S8Lunlmu9pnM9 XxA6ShVzZzR8X9u1+aHI18FkeFftaZO1X/ipHiRgWYmwxHee50F43GoRYkUKtL5EeGs+pgVFtvS N35v5ZOaS4dRcJ97oRggrrqF3+rewugdNfcOjABy9z+5McTb/al3fNFk7obz1H3xjL77Jo3RQcb jKwvKaJYn+puhraiSHisoI1Q8H0GnWywr6Yq12zvOzY10VAU828u15UF1rvvfdSZBMNoDaZN8YR MY/C4aYFC0Y84PtJu62kmJ4n4v4JBd/PrIYVnOSEvIoAZkqMo4it79WoNtuEoNx+OhSQ0P0+FTw ncPMJVQ0RwPTjUhmgU+Siqc1uuFokQOIgc8sWxA187rXXifisB8e0Qz8cofr4vT2YdFLTDQlTtb DsVJhtQvL20afD8ktEE3e9SBn/kC2U5XBha9yUQiLszF7/SkefUvWkoLphBJoHJQesPlcSGwLES 8ZjODkLNTik+YIzT+y6r9oBPDa+Ft1z/sPRZtZpjZCeGeSqLeOkBl2iH5kgzmgSjGANsVseb/1k xn+gb1RtR8rDo4/67L+lt6mr4ki4euFWZMFfg8c6VM8c7ZQonmBPCX9sGdbGnfFG3z8Loh8tgWe NlXvgC6SiJVTR6A== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: lj7x52Djy2_qkGhgnJ6TdNPVP0xfjQP_ X-Authority-Analysis: v=2.4 cv=fbWgCkQF c=1 sm=1 tr=0 ts=6967b695 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=tMXyHTyi87mTYQFNLaMA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: lj7x52Djy2_qkGhgnJ6TdNPVP0xfjQP_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfX4/GwgkQcCf/J akUuDCVs70UjTxvrSD1GFAjylOp+UGKqRaEftez/nDkXfEn2GXsNy96R9CguZIq/sjmwg61KhEO TDCEkZ/ocDYyXfcpyUi0O5ztcavRDcpCUThIILzuZ7Uv8rRNjj/o6dP+xLG23M8hvw8RTRG+yaB MAk+OJBADCZpPoLbh3pCthfwDiTxnpmn+uo8PFUoksAgxYzIvIBDgGugsYAWjqbesGNmzoqwyLn nrSJISDXh8nb4LIea5ktDIMEnybQNZMoERA5F4v0zpC0mworxO/LgH3o4IyER4BSkBDUjNr4lQ6 8MlhsQae/2zBhfSy5dsCTLni84bekdJvE1XD8AyaOrrs8Q/AqhYLU29g4THHT3tyR7qqGdPn/eh uzwVnzq6kYjcE/oKrnbgJ3LxdIu/KkY3wAPPJkVNz869UgaYa1BFVShFZIFzuk08h7OXr92sgme 6X6+g4ckNZDKzUurBuw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Remove unused includes: no lists and mutexes. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-amd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 2dac5c71eb00..2af94ef56434 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -21,11 +21,9 @@ #include #include #include -#include #include #include #include -#include #include #include #include --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AD1339E165 for ; Wed, 14 Jan 2026 15:30:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404634; cv=none; b=W0IFw8gMGYIzDKLKAL8+HAJq2842EmC66oikoohn+tfhcMQ4kP2aowZRzlJxuLEy21wG1qlWR76KMXhJHG0EVoVTkqfj0Q1C2keRKqdd3cr6FhFugCQ6+B1UnMN1vpYyIbqT4cqD1cxameQS+YXQuR44Zy7ekUYGWnlbedlcmao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404634; c=relaxed/simple; bh=Y+FQmd4rABqYPyTPKLcnkK9CTadziXSgsQ+69hWhimA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uwgl02QpDH1sfL2Q6UzMcyOM5SCHWolVZfAnO3GEIvZzE2YfUifH2YWJqamPdGQadGpqMK3oZiKGJhQ1k/yrjz0J65F0Q3sZ8jy5DTkFiYoKMHIhS0N7LCNOmKYORdhqjQB4PijwxOue/lkfjM4AOY9aJnFbjq4Yn9ZT1LbSUkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=L1bLn2gb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=USRXZ/5v; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="L1bLn2gb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="USRXZ/5v" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E9I7fc2552672 for ; Wed, 14 Jan 2026 15:30:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LXncEA4jW+AgdDM8Dn/nTshgL+Kv2q2dFOJVpt182v4=; b=L1bLn2gbhX1VQr5S DBrqZ854pXa6x0jHP6ADw0uJYdtEFgDvE4gD9u6gpzd62HMPmU14Zz2Yz+ffZGY8 VY/nvssh6dZj5GnrLthMKJcVupO8HTQMojR7ZkiDkKR0XFxxqvBJUeKWNMxYJry8 NwvqTbbKWLT75tdRH/42GO0jHIG6tsYxJZYxIt3+vwRt9jLFxqCKxsZvqH+nzhSP P37BGhyoY19MnsR0mwirGBB8vtCkN84A5wrbld369kXozOtYajjOcHWpNhrbOtSR u9dn/SmYXI+2ecIuTkyBKquonCEcC6bun8mA6WiUKZcz7VQzS0X7Qy1Zb+WncMs5 /6FpjQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8d318av-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:30 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8bc4493d315so2259800585a.1 for ; Wed, 14 Jan 2026 07:30:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404630; x=1769009430; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LXncEA4jW+AgdDM8Dn/nTshgL+Kv2q2dFOJVpt182v4=; b=USRXZ/5vyyc03G4RmQx0GeAdbEjVic2Sn4FXzEtVVrYnETjHx1Q8Xq395cVV8fXE0N jrJ7mUt76ESQJxrjumop1bJgYYUGzNPqstGSXjm8+Svjx1iiFCKnUeKsHBQMtwlH5XK7 w4xfH7uQxn+RiGx8IeShtU1zVnptbPGcFHKQtHQAzU3m86w6VIW0H4oWtxHnUN28Koim D2RFyZbzURLZR/QgI0zHUf/RPOHmN/X6QByMzH5JIQ+j3zG+Dz9TRsGv21di1M/KLa6C j7zNtH258w5+mOKsSKBZCgKtAt73UqvC7lpD5o7pgZyu4ZZx85+qsFubYPONNUmnyuHH 8MKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404630; x=1769009430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=LXncEA4jW+AgdDM8Dn/nTshgL+Kv2q2dFOJVpt182v4=; b=ix0Y3BAEglWrRas/zrYgS673gypr/XvWOvNG5Fi8V8gH2sS0fof29mZrbxJkBwCJPH rNW+N66EM8X9IBxgmN0VcqJanfKAiWkEHCZWXXvsZMK0rrzCT1kTGbKh+KKNNQ+JndQs yObJBucF0oluxWKn85zmv5twr99RCJPNf5X1QCg4giCEJc697A9OdhBeP5uR0+FcHwqE lsPUlQq6hF0wA77I2zo+VjgkWidomfEAUb9Z1MjhxATBUXX1MyhdvdWZvdf3bt7FEjlE RxSYc0j7307eHvNdEUjJVhRBBW/Vxo7MOMlssZSPtmH/obLX38NmsM7OUhoX1lsBZOzt 8Hdg== X-Forwarded-Encrypted: i=1; AJvYcCVpGV1iHS1gSzyd0MkDEn5Xff2LZvgUvw5c8XZyKahgu5yURCf/jB7cnau5j/ZpYXPqqJ1e2cxiCZ+ZJjY=@vger.kernel.org X-Gm-Message-State: AOJu0YxoG+i5PzIS5BUuNfI3A1fFbqQ6Gsu920NvsGEf5S6pbGjtS3AT 6l/+MY9yz9v5N3JzQV+po+5WTrZkSYREUg/uxz4MCFBottMr60K7tF3Se641dUVhpJq1PcTKceU m8QsRjK619nYq1gV5HtAuqhCYwvD7u+YeWVS8jEmyykK34rfJPj1vv9Pcb9QhiE2FR+I= X-Gm-Gg: AY/fxX6RWxIwHYkIuyNOtjmuvcNwCNuVD0eOcUgqNhjLWXwhmYVy0R+NgZ+lhLOQpuz XuwEgL7LZ6jEInqCYFlsDlufbCitwQig5AL8kT/0HQzVpnbb/9WFXdBU5L14PQrvR8h5tslFtvQ BIgY4/VqBwggRnxPMxapxQLCkW7qukNcDnfu4zqnJAWPrEQgnpk5cVjLAfzrtGFGD3Geha+x72t bJp7kFUiEhCSPgyIDK27JRK6HD/oYwvoClljwao38sF7f7Cn1xYdsj824CVBj7nFHfJ71fsvPmS yOQ2lChnSI0Zqgy0c3/wC8LJf2d+a3qG9MtUYwUjoD8gJIdAZRBfypA0z67ylDjlDZWsCO62mCO rhqcMPOf+XvUP4FHGRW6bu/OWSOIwRe6ttw== X-Received: by 2002:a05:620a:4804:b0:8c5:1fb5:1631 with SMTP id af79cd13be357-8c52fbcf18fmr431954485a.76.1768404630168; Wed, 14 Jan 2026 07:30:30 -0800 (PST) X-Received: by 2002:a05:620a:4804:b0:8c5:1fb5:1631 with SMTP id af79cd13be357-8c52fbcf18fmr431947685a.76.1768404629608; Wed, 14 Jan 2026 07:30:29 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:29 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:06 +0100 Subject: [PATCH 05/11] pinctrl: aw9523: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-5-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4481; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Y+FQmd4rABqYPyTPKLcnkK9CTadziXSgsQ+69hWhimA=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aELAglkIA71S9aDHg8tY0ki5ruKpcTIipIp 9RdX4NrwWOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hAAKCRDBN2bmhouD 1/igD/9PwYlGol1XFHKqtfTdSYI+oQLSjl0z2sqJC/KrK4RW/0UQiErzillTKszLs1fzun100dI EhV3/cNFb7EkGAiUv0DOTJm2rLXXXAEKq4sfHj2AvOo4AOdm1Vhzaxohnqhz8lbieU5tgItO8kM CikX6JY0DNIPuK8tFa3jeDEczOXlluE7E41BjdvQjxbKKo8CAfks/3wwtIsxd1meu0Uh7pDT24v aYd+vgDxKOiXkiRG+CUevINMLknU969di7fKX4meZYuzU3R9984ZwT3wKVcWI1thioeP3d0iKIZ BLsydRVePUf0VtejFOq22/8mIaGexs7h91zpasohVsgWexuKGuKJNsUuVOnAKfAxsGZjauTVDrL 18hpyd0FGakefMHY330a0Z2lqwnCW9k43rDquioM3Bdk17JEYl8zl6Ke/SDgqPsWJjHmhjt99ld hGunGrieUUrlWbMED9RW+3E0q0mHN8hMeN8k3fFjaBxIE0ScSmF/3Ln/vbtAuQF19W3wAWGZaJY GtZjFlirhF09jNZdVRAU8jaxTE4Y1Xh+h4BXysH0im9u+xRCGpdGx49RemYsLFWX5SsXtSUWzJE 4DUYUyd6Czhj6ON/2GFFww6B8ToMmkk78qjK6kFM6DwCDfpPDItQEKm0PHRqNap0/QZwJwiIuvB W8opp7AXG42HEmA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: J3bMuom1REVTGmJpUwOYjtC9fYDhtrZs X-Authority-Analysis: v=2.4 cv=fbWgCkQF c=1 sm=1 tr=0 ts=6967b697 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=sJPWbbE6un6nfY-uGV8A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: J3bMuom1REVTGmJpUwOYjtC9fYDhtrZs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfX0GVTnOsH8F7x 3YORVxuSkhqYpGhqg3bIoEvT33u1ATiHWghsTrl/5FCTjO5NJvzygKJ4wnO6RUiWQ7xjgjKIvsZ vcgd77gDAn/CJluWTiGZWrQNOq2a1rE0FzvoaFZFHU0lt6UpZXmJT2OMFlVuGOd11uokdsDAyJs AIFwxBtj7sFNQ3c23H19e2/kR3pBcxDvRYO/1WBS7vci/UGSeBwfR+2tmh/L53rFrU49PdSgLp1 fwJBpAzJrJ79nBLhwtUjQRqlbeqTmdsyxb7x44vD3JUFfCOxi7O/8zOHdtqgbsfQLmweewBPPRh HYkOi9KGMCUrVbNVtp2BgjWBruOBBbsjzcmgd8/ZokLJYYusg7ENsyIJZpV8aUlWA7wIUYXMz1S S3dsbOm1sjgh7PE2ehfAcmeAM1pbEIeHn0pRxAabgIfAoFdlhwfHJDi5+m2KS9WUaLzl7Rzb88n Reatoxxr5vVqz4KO5Xg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling (less gotos) over locks with guard() which also removes possibility (at least by reading the code) of returning uninitialized rc/ret value in aw9523_pconf_set() and aw9523_gpio_get_multiple() functions. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-aw9523.c | 53 +++++++++++++++++-------------------= ---- 1 file changed, 23 insertions(+), 30 deletions(-) diff --git a/drivers/pinctrl/pinctrl-aw9523.c b/drivers/pinctrl/pinctrl-aw9= 523.c index 479553a79216..02a24ac87ea4 100644 --- a/drivers/pinctrl/pinctrl-aw9523.c +++ b/drivers/pinctrl/pinctrl-aw9523.c @@ -291,14 +291,14 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctld= ev, unsigned int pin, unsigned int mask, val; int i, rc; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); for (i =3D 0; i < num_configs; i++) { param =3D pinconf_to_config_param(configs[i]); arg =3D pinconf_to_config_argument(configs[i]); =20 rc =3D aw9523_pcfg_param_to_reg(param, pin, ®); if (rc) - goto end; + return rc; =20 switch (param) { case PIN_CONFIG_LEVEL: @@ -307,7 +307,7 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctldev= , unsigned int pin, AW9523_REG_CONF_STATE(pin), BIT(regbit), 0); if (rc) - goto end; + return rc; =20 /* Then, fall through to config output level */ fallthrough; @@ -323,10 +323,9 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctlde= v, unsigned int pin, break; case PIN_CONFIG_DRIVE_OPEN_DRAIN: /* Open-Drain is supported only on port 0 */ - if (pin >=3D AW9523_PINS_PER_PORT) { - rc =3D -ENOTSUPP; - goto end; - } + if (pin >=3D AW9523_PINS_PER_PORT) + return -ENOTSUPP; + mask =3D AW9523_GCR_GPOMD_MASK; val =3D 0; break; @@ -341,17 +340,15 @@ static int aw9523_pconf_set(struct pinctrl_dev *pctld= ev, unsigned int pin, val =3D AW9523_GCR_GPOMD_MASK; break; default: - rc =3D -ENOTSUPP; - goto end; + return -ENOTSUPP; } =20 rc =3D regmap_update_bits(awi->regmap, reg, mask, val); if (rc) - goto end; + return rc; } -end: - mutex_unlock(&awi->i2c_lock); - return rc; + + return 0; } =20 static const struct pinconf_ops aw9523_pinconf_ops =3D { @@ -599,14 +596,14 @@ static int aw9523_gpio_get_multiple(struct gpio_chip = *chip, u8 m, state =3D 0; int ret; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); =20 /* Port 0 (gpio 0-7) */ m =3D *mask; if (m) { ret =3D _aw9523_gpio_get_multiple(awi, 0, &state, m); if (ret) - goto out; + return ret; } *bits =3D state; =20 @@ -616,13 +613,12 @@ static int aw9523_gpio_get_multiple(struct gpio_chip = *chip, ret =3D _aw9523_gpio_get_multiple(awi, AW9523_PINS_PER_PORT, &state, m); if (ret) - goto out; + return ret; =20 *bits |=3D (state << 8); } -out: - mutex_unlock(&awi->i2c_lock); - return ret; + + return 0; } =20 static int aw9523_gpio_set_multiple(struct gpio_chip *chip, @@ -632,30 +628,28 @@ static int aw9523_gpio_set_multiple(struct gpio_chip = *chip, struct aw9523 *awi =3D gpiochip_get_data(chip); u8 mask_lo, mask_hi, bits_lo, bits_hi; unsigned int reg; - int ret =3D 0; + int ret; =20 mask_lo =3D *mask; mask_hi =3D *mask >> 8; bits_lo =3D *bits; bits_hi =3D *bits >> 8; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); if (mask_hi) { reg =3D AW9523_REG_OUT_STATE(AW9523_PINS_PER_PORT); ret =3D regmap_write_bits(awi->regmap, reg, mask_hi, bits_hi); if (ret) - goto out; + return ret; } if (mask_lo) { reg =3D AW9523_REG_OUT_STATE(0); ret =3D regmap_write_bits(awi->regmap, reg, mask_lo, bits_lo); if (ret) - goto out; + return ret; } =20 -out: - mutex_unlock(&awi->i2c_lock); - return ret; + return 0; } =20 static int aw9523_gpio_set(struct gpio_chip *chip, unsigned int offset, @@ -695,16 +689,15 @@ static int aw9523_direction_output(struct gpio_chip *= chip, u8 regbit =3D offset % AW9523_PINS_PER_PORT; int ret; =20 - mutex_lock(&awi->i2c_lock); + guard(mutex)(&awi->i2c_lock); ret =3D regmap_update_bits(awi->regmap, AW9523_REG_OUT_STATE(offset), BIT(regbit), value ? BIT(regbit) : 0); if (ret) - goto end; + return ret; =20 ret =3D regmap_update_bits(awi->regmap, AW9523_REG_CONF_STATE(offset), BIT(regbit), 0); -end: - mutex_unlock(&awi->i2c_lock); + return ret; } =20 --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 295C039E6F1 for ; Wed, 14 Jan 2026 15:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404635; cv=none; b=p5ajOsUkIiMxKjqs365kaFkaSui1rm2lW2kvR9b6q4ozxdVnZBDDtfTUqdn/twPJYL/V/T4rGxHkLm01b+rB58I17yFzgFDpVKdnR8nM4EhZz4D2Xlvr82MnIyjUhzSjv9rs/k3Fq56CTEiowJ1CkU1PtQAPT9uxsGiug8N81rk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404635; c=relaxed/simple; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EAD2YhY0wDQpTTbAt79AhJwwzUVlqeB15k6UFh63v6K0NgMr4WKlb6EkePLmuqQHbnuGUAF0Stiw0WPCECvbCwFUcQqQyHoWJ+4IZw4yv3HFp4BwodCcMaAk4ncOIXlUPEl8VC0YMyyFM0b69K4xqnCCi5cAZvRVSz0EOX++SFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HcXKAq+n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LcCB8x1Z; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HcXKAq+n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LcCB8x1Z" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EChWO23925461 for ; Wed, 14 Jan 2026 15:30:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=HcXKAq+nTSgWrzSK w1a4GoUXM/XuGU5b7mwyhHaftes3dWz2FIYh0ZaE3kTLg6bSA5zLrYkRq0l7d56I Zm46EvXyUcb4YHxT4q3XQ2xwvlv169s2XhxgxhrLV9wGHbn/acVHWUrKL9WeiN34 oxI+nkOmlEgGJ40GzzFOPwIfQ1plkTis7W6XEwSy+BEcDfNNCKZeJK6ntJDy2gJT 7cNvU/N9ASdtjEEo+ywOMZabQlMvmsZWBwHPkVfHcbdvH7QZIMXscPa1ebEWAwza qmm4xfI7i4asmD1X0oDozzuRdnBuTqOGzH+RTAb0dKUgJPvntm6VZtTm/Ycu5NDd OjjOJQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bpbdbrh93-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:32 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52c921886so197323685a.2 for ; Wed, 14 Jan 2026 07:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404632; x=1769009432; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=LcCB8x1Z+kPSITM0k3ftUsw9PDhGUMHP6H9u12TANr4lzOJNQPlaq1LMkWaO25itHR 61yn10xcs94FrGOElCaB92JsC5RUxuYjXrJ/O5F/G2dMw9KkG4swnQKTRgt5qICqq7+8 ZDHyFCb0Y/ZeDI04jKiEFjYqL0T3djuqjvUgKBWTq4xIASEzwsH3qADa2GjKcokmcgRf 52tXglrINxxaDO7uFWGGZDiuds85o15SegnyFOQPPIVuBxuiI52gObeZklCRLieWKgyS f7L7OhBaA2J2xS2/ExLoE6SqdH57kX6L6PLkwqNYDx+qyxblVg4amgzWQaH8apE2ouSj ccZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404632; x=1769009432; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=N8rDVtwaqFFOKGAdA8c98jUQvXsuqYrjM/OKm05D9ak=; b=OYt8FicjKa1CQ3oPl1OQz/6uKXXcg5bn4BseUHv21rria4DojRQ7UG3AENJzEYwRC4 F+WPJtYJ981CPCLojvtktGzZ7BpuqxdEDbWvC56vC4VpmYIPeME5KKDTrJR36ir18EZN SwpbdU6DqjFtHgBvRfEsnWzYZcI8leDqGI1agBvs7pdkNbuggEZ3dXRCpxlRlr+jc7xb 92wlV5T89W0+J/rOPyKydCScGe81AHu+46Ik/tFOSmjUYQ8r6jO+iqmtEaksmZBtQVB8 wiluF1Aksg8YhktWG00xm2RmyXWEpTq3zNT+g0/qn3rgLM+QZpPtyjXxbwoksLcEaoeB Y6UQ== X-Forwarded-Encrypted: i=1; AJvYcCVkcofI1XtnhP7kgrJ+5+BNETcv/hfx3YMXDtRGP6gCnbvw6BCE59TIEf0p2mzZhk8YQ0gVUFNPDkf1OS0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4UhEiDbDQ7AQ6n90lOWMabapALdvFJSuF/JYIr1BG9nxZL5Vr WoXVK871AioiMSBrvYnvz5/uD7kOcSRQOP7F3AzMOdlIzU4CV4STx+k6faJpb7v0jgcAbVcvW32 syuYaN50+Aq12QZ8t1Kk1owt4bR+CBFKge8DZtiPQF17bMwtqUMRlv4kuIzWdltpKFbU= X-Gm-Gg: AY/fxX7zIzu5EvDPZkTNpz05RGayumfecGo9T/S5pMqSZfDN0Xwg5uYMeerO3o8q3BF hwRBQvyPxMzqlE7H4J6dXyLHSzGBb8onzrNJV6qTXMh2dJO9niD/N14HlDIjEWGf87I7UOK5t7G bWdPkCs14iBeqAlPoD340xxhvScJMwzAoWw9Gjei1S7sQxeLHS8tGpFFy/9k9XADgBIXRE7C7Nq R9llHOHQCKPEH6cx+WMsFkn8AOdClZ0fCkgYBX80QxBMWpZJ5SjOKQLZh8UfptDREiVeeYGuYHD Yv4F2PoAUGG3MuT0n1n+orZrajEKtfaa6TSNq8Ls91uK4u+x5mefLhTkcasjxCmOpP59M/ZuDxl CqtUECEtcOtBSfjiWNKfc4U/4pGDY8zi6Gw== X-Received: by 2002:a05:620a:46a6:b0:8c5:2ce6:dc9 with SMTP id af79cd13be357-8c52fb4f058mr411708285a.23.1768404632286; Wed, 14 Jan 2026 07:30:32 -0800 (PST) X-Received: by 2002:a05:620a:46a6:b0:8c5:2ce6:dc9 with SMTP id af79cd13be357-8c52fb4f058mr411698485a.23.1768404631550; Wed, 14 Jan 2026 07:30:31 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:30 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:07 +0100 Subject: [PATCH 06/11] pinctrl: microchip-sgpio: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-6-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1197; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=7TcfQldnwsgDeNj9THUL7ZJpvo8wBH6EB0ftex+EuCs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aFcSlR3KaVGiIyNYG8oZHo4izzrC/c7v2QI ELyljV0aeOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hQAKCRDBN2bmhouD 1/c+D/9JCP7uMMFoU+h75eykrt0KHmHUnHV3rqtg3g7Ut1d2/As83e5bk85vikvVmZM/NczFXe7 tQxswgbhKLPilQU4gCP3Ga6silueQpxzqiLbJaccYmtFmcy4rr0I3ATIJuzeZ+xjLqKsMvlDsBN 5CciXjKG5O5Br5wwG9eSTc/INEM73B0rn+881EzVNAJtEBSP1fNhWwkx5nIiBvGhEp49M99L5nS Bxm1JS8AA76I0eJm+s3lVShXx6sccqHmnDTkkB6m8kAdFeJ7lqn0UpVpX6q93orxxxwlAPeVs92 gp4l4zUpAWVSv5rvRJCGzn3CRbKUXlJ+XXT3EVZsRL4mvrX4OY18izt1M0rKQ2jLVDxHs7pKBKF WZMNHrrcyTlCIQ7WSfVzTKuXZaeUtqQezfcYz4QJu73AoUPusr4JilaxDmzkvLOvxaeGWx1aQA3 XxTSCpYcLEW+07K8mVmDNCtsc3UUybPPwSxVRYBMSHfr0R/Yq+w13B92RZUz3SvitQ1RsSGFGPP tZPDshniy8mMJMUivX7pjR39HjGg1DJXYUG1sch9D6IG+YQgxZvHQ5G9tDMnhlrjry3n+cjsAxb tBNq5GvN/JX4WDvzpXbCaXdN9IH2zgxN5gPkt0cindxysAHiXqL0N4ohP4zkibgluS7P0+DFsIC uJx7nBKwy1ooASQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=NvncssdJ c=1 sm=1 tr=0 ts=6967b698 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6VTnscBjb5kX48BWP-sA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: 1k2JHqqj9kDnOKcb9flpLxRaDoKp1lRH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfX+KmWm0slsX85 5LzCsQZF1mF8R3lMUYm5rq+PvwOGnFtDxaOfhbLl7bFRt9Usmocrck+vESqNwy7TcmvuqU1GgWF lkhXBDrj9y8M5jO2rZEC6i9f7PZ7trCHXfubMqW2i141nRyuQKg92C2msi9scyWUESu6hJIsQ/o AM39QvIGy8hQ8yfNMuoDrGJAf5SngvdxaRcmPpaGLiPJZpqBEgU++Vaod8AmQ0T4PxeqeZpgqsO WqMe0G1FMLCtn2MHFNs9xm/DQFcrG/vJwf+MfLh6+b7friykU4xa0ArZuPhwIZF7nAPUYTa7Q/l nmWmcDA/ikxlROL6q75jTfwV5I9YF/3KpMPIijsXAO5uy0UE+AiYtxSJTxusCaKeF9KngT1DMA4 ViKY2a3rpQ/jw9k/LRndALXHPgs/lyUME2VA32BgxoZPcCcaIycgwmGQMUfR/Yv+8EZT5OR7xc1 yT25RbZOxqEaIPTVyRA== X-Proofpoint-GUID: 1k2JHqqj9kDnOKcb9flpLxRaDoKp1lRH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pi= nctrl-microchip-sgpio.c index b6363f3cdce9..7a6cb5f502b0 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -264,19 +264,17 @@ static int sgpio_single_shot(struct sgpio_priv *priv) * setting. * After the manual burst, reenable the auto repeat mode again. */ - mutex_lock(&priv->poll_lock); + guard(mutex)(&priv->poll_lock); ret =3D regmap_update_bits(priv->regs, addr, single_shot | auto_repeat, single_shot); if (ret) - goto out; + return ret; =20 ret =3D regmap_read_poll_timeout(priv->regs, addr, ctrl, !(ctrl & single_shot), 100, 60000); =20 /* reenable auto repeat mode even if there was an error */ ret2 =3D regmap_update_bits(priv->regs, addr, auto_repeat, auto_repeat); -out: - mutex_unlock(&priv->poll_lock); =20 return ret ?: ret2; } --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7E683A0B32 for ; Wed, 14 Jan 2026 15:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404637; cv=none; b=ck7pwcruUlLc4C8FQLn9JtNp2+ds3VqjGrunD1cuKu29ulB+iwv7sWzxlR47g732Vu6RCR4ob6pFYo4C0UVxOoDq4GIFaqcnXzAdcZfbReNbRayKMXgOGfg8v05LgHkBWDWOG8Q2wxG5cFbq86rcd83mNV1g04m6z9dvpGIsVP8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404637; c=relaxed/simple; bh=adtV57CgOwnY60Si6YEP4k65ve4WmCO5x4rzf1ZqeaM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BGaWkB517SeZby9f4UXn/BFkj4aowHZSf+rhh/mXHvsgvmw92tP1GTNMsB/i+M0N6CwlG1V3oYG7rez5UZKp+jUutZSbFEn8nz6rw8jbCfCsQeJXCQGWMmDsLteaEVfHjwSNYSBcDEVrG9zbxYF2EsWdZrXiErnoUsLwrpgc1Z8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I6kkEHcw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RFaNvOtN; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I6kkEHcw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RFaNvOtN" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E9jnI53296152 for ; Wed, 14 Jan 2026 15:30:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=I6kkEHcwYHnmLqcC bCog3zsSNQt83q1g15rqSXMAHoCS6ayKBCuK/od57mJZRARRmEKWePBZ++KRDRFf nA/wQ3gmm9OmhEdA75fhn5wCblufkPBQS4FPjA1MLG8XjHUW5rpj3ThuLbR54inW ZC5Wo+bUgahzHKYqqo6mScjg1mnK/iL0PhMHXVhGcvGY9zbAELUEeRa23OKCvh3x urMzRY5AmgIdBLrvSeX0LZzwdcJr7L2+2n1AHSumMEuqSkZsHx4g6FgrUQB+0/FM xIJf0EElVUNgq68df0rWEdMcPXSuVq5wvOXdMLZwdMvExgqGYam5JXWk6HI6mWVO XotTrg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8t2s5qk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:34 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8bb0ae16a63so1031598185a.3 for ; Wed, 14 Jan 2026 07:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404634; x=1769009434; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=RFaNvOtNfeWXdJJi/fhkzJWAgQg0baqtTYYa0gPSxPv4nyN/QK/9XfvirnbH0OCEJj 08BJSrls4RiUv5NtiCOTFBtbQqHMY9w+wXkmf+17Sp0bilAKxnbN5QqZ+XCguBhoMG0f 3yVDKXR+QMr39+fW26KlhrBel67r1NhQJaVmp7YT9OXsHwFBMDuljmC18+baZbjzZMqg OIm6XWXzT5p12QKsCHPF0VHLRb5GvBtbuq9HztgibS00NlW0m1PWedrD5JkRaw2T+AIq 8C/sofa9/b0rmS8572P1dhm72NGXyLkrYAn4t9RZ7RgJ0Toa7eHoNoyUbB1wSnFTIAaK NK9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404634; x=1769009434; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VMrQrzLzDincZEvSf3IY0LWe8Yq0vnY3RbOd9IgAleU=; b=ek/HNO00pxa3qEv0PUPIUWP1gZpvDMBNzSB9OXMBmN0G8bHF3pvVh2SYTCefbpbMdQ XcHUjzyxCiGLzoc3B0pInzLS4U+A1RkUiW+neodLelMnd425iUNMHw4TLwfb8iiwizMw 8pHp79KlCRffEmYflqWq4ikEwMIyhTADLLZzA48S1hip1Xg1boo0gKl0q1H65M0TQIYU 8t/JkrTgZf1Rxd07BQk0VaVUWys99Axjy/fPcbKWqSFuON1G9LRtuGiAxjerm29wevXE tdR/VWs0wdeJmLnC5MiovMStRV/M2FuAGFZGydo9GjvP82h/LcMdZ2ZmNLfIrkJL6RCB lR+Q== X-Forwarded-Encrypted: i=1; AJvYcCX1pcSP7rxvnkP/8pTyhv0nCHmV2u2kC07EjrTz54zaDEZzlgnC6BuWH32SIhUoReKHTgXxmuEIbJ7WlwU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu223FadAMcOj0rUCKXf2Lk214Aib7o07Y7nqhkKPc6PwesXbT 1no1qD85txpQEQGWTNpLxlYtha3pR/stXvwQyrWCdJxNIS7Pe6q1AAOODivL5DBVkuYGDROiEIg 7U52rquMUzqICtoehwJAhilKKdvFIs3cDrmj1O0aTOY9eOGGr3xSI+wYlDHNQ7G+xeCk= X-Gm-Gg: AY/fxX7SAzcxdtANH1kK4SEK3wqmoKDynpWQlXhLjP4sB4bpXcM8OoV+LnkVtJoL9eP EmKGzNBqXPs/bWsY1YyP1cJb1d6N6gggjjByFNFLO5wLBwoYl421xLqigQeE1LCnGxwBrtEhCXB oSXKP4qNKCJ1HarEUF8Slz6kdn/99Vs4waQD+oZv8M4I0Ns63TDTkyp/3E/fhyCA1+5rjKleSTV bUw4UJoavHaePGEDlCU7riEWR3BI4bta/d+5hvcstq/m0gABgqQr1rBfGHaao6PLoBn4dv4G5vR 2t3xjrX92hplE/gyVUIrc+U33QDGMSdf9tMepuq0Ee8aM3iro/Mu5y7BascXsYRWPZX4ajGmAeu T7aBnfn14STJ0/JlCg7EQO3rArxt/RlmGFQ== X-Received: by 2002:a05:620a:4101:b0:8b2:d56a:f301 with SMTP id af79cd13be357-8c52fb32b67mr343232585a.14.1768404634210; Wed, 14 Jan 2026 07:30:34 -0800 (PST) X-Received: by 2002:a05:620a:4101:b0:8b2:d56a:f301 with SMTP id af79cd13be357-8c52fb32b67mr343223385a.14.1768404633459; Wed, 14 Jan 2026 07:30:33 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:32 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:08 +0100 Subject: [PATCH 07/11] pinctrl: tb10x: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-7-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2163; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=adtV57CgOwnY60Si6YEP4k65ve4WmCO5x4rzf1ZqeaM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aFRdTPwiFL/h2YLFk/n9wL4n9QTdVBj0L6r 8aUJ0hOsNiJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hQAKCRDBN2bmhouD 15BvD/4sSskWeqqie+QnWNfV5njoEI/Dxm+OQU6hvQfAn6W+mFLEoVNCYY1DYciSU2Abpt2R3nR +qvBID4STILG6i8SyHTuaGcand6oW9yUTQpRJAmZLQwTU6t5Txha1TR6xku+5Oy8NyzMaHRuJTv +q5GGceQij71KHq+iN7y+f2Kh47ZLjY4bh5UEgUQ2UIoWQOKsKGVqFMR4D+URpgUMijJNLMK1eY OiA7jL0EBA0jRXolicdtAQTBVHk5WKJIlq2dKAIVzHYv12gvTtggiJd6gKyNR8t5tX+yOxZqM0D Jd4RwOyuhKazwxCfXv+bUlaqLfNnifpec2mksBSbNjseAfzxvkqxCt+VMZHZVoZ9mzpRmAppP30 i9SP4gbwW16v6PBBhPIiLG0HrWfQ9XJ2JH7MYWKjn2JypFxHEA9Db766OZxcFqNRKVlsMAtIK06 ZKalbIjY3hmQO2RLFsbhmE9qgNQm5n6vPYCORIFGTSFmcIKyeFghhXkkuZqhqTORTVXwOoPyhnb rrCyYVw4Twlq3ASI88CvQgLBkMD2dmqaPlhTZ37MJzVXVgufCKwBDhrq6xhuAlBI1vufryly9SE iw2aWK83dO7QfgeR/uYrjPKYMLwUfoTt6nq5Ph8Apc8jGok5zHX7/Xej2gYuXZnBbrTOGD48Hiy LRCCfd8e1rw2F9w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=YPaSCBGx c=1 sm=1 tr=0 ts=6967b69a cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=fB2tTgKqvhDdEbG57mcA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfX+zDr2ME39Mtp UcqKIHqE9h8I9mVQ2FjSbKjLw+TQutHWStchqSBF3ojIZxwShq+IC+5tmoCZ1BZo86xyDetYMZ0 UAgPcGI1UT8p4eoOc1fInAFReU7blRwy+mmZXnfCBjyrpH4tUVh4/by4/DeWrcUKRqhNkEv3nC+ xQqSfIzrVIPe05vZNrUfNkl3Ru1o8brd192CrcYyKXTvEvXa1Y4fkcqtOCkk9x5e1l8q3b3+M/X 0ztbcU5Z9EnCndmIerqbWiGrc/qnexydQXQIDP1Nj7g/nXzQFJxazGbiOma/pPfVdBftMKE6JQt q5xxlRYp0Y4P/Npel6qN1yvs4YvMogEiJABg04M3Eg5LJMUL9HI+q1tA2xGQEp2NCW+rkAeW9JW cCZHDRHtvyht9svWwptRBWjJxvXdTscUJ4G0yHcYuPXDeeP32BrKexE5GuPxNcz9UEEyw2MP7FJ uuMrFmPuqX7w0gIJr3w== X-Proofpoint-GUID: 6T2zsPgpxTLK7TkzkJMwQFpHCgXOOZ1Z X-Proofpoint-ORIG-GUID: 6T2zsPgpxTLK7TkzkJMwQFpHCgXOOZ1Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling (less code in error case) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-tb10x.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10= x.c index 129fa51d13b1..3f581404a9b9 100644 --- a/drivers/pinctrl/pinctrl-tb10x.c +++ b/drivers/pinctrl/pinctrl-tb10x.c @@ -607,7 +607,7 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, int muxmode =3D -1; int i; =20 - mutex_lock(&state->mutex); + guard(mutex)(&state->mutex); =20 /* * Figure out to which port the requested GPIO belongs and how to @@ -642,7 +642,6 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, * Error: The requested pin is already * used for something else. */ - mutex_unlock(&state->mutex); return -EBUSY; } break; @@ -667,8 +666,6 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev= *pctl, if (muxport >=3D 0) tb10x_pinctrl_set_config(state, muxport, muxmode); =20 - mutex_unlock(&state->mutex); - return 0; } =20 @@ -695,34 +692,28 @@ static int tb10x_pctl_set_mux(struct pinctrl_dev *pct= l, if (grp->port < 0) return 0; =20 - mutex_lock(&state->mutex); + guard(mutex)(&state->mutex); =20 /* * Check if the requested function is compatible with previously * requested functions. */ if (state->ports[grp->port].count - && (state->ports[grp->port].mode !=3D grp->mode)) { - mutex_unlock(&state->mutex); + && (state->ports[grp->port].mode !=3D grp->mode)) return -EBUSY; - } =20 /* * Check if the requested function is compatible with previously * requested GPIOs. */ for (i =3D 0; i < grp->pincnt; i++) - if (test_bit(grp->pins[i], state->gpios)) { - mutex_unlock(&state->mutex); + if (test_bit(grp->pins[i], state->gpios)) return -EBUSY; - } =20 tb10x_pinctrl_set_config(state, grp->port, grp->mode); =20 state->ports[grp->port].count++; =20 - mutex_unlock(&state->mutex); - return 0; } =20 --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24DC83A0E9A for ; Wed, 14 Jan 2026 15:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404640; cv=none; b=Zv8yqjsSfGx4hShGygA136Tw6L9h9KoiJZFsX9kaE8xP4GKqix4Z1IwlAL7dSqQlIQU6mFDQ3o9CH8soWrDJp5bD+4mm2dnnDatSG1KwHfONz+ZcJmhCNsKZCNONl3+RMvMB9Khx8pMMCgtWilJYe8xQygX31E2ZWe+aStc3F+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404640; c=relaxed/simple; bh=zRGKe5UJ9yNFcA3nCyV2yle+pcJ0o698KmnQ7j+oxLg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PoloOHdZ3E1EYTf/1PLtYnlZX//ffuTHemK/nsW9O4HibQRgfwxV3j97DqXllOQSygQXOhyZCNoZepzRNdcB3CT0i4F9wGuhb36U6HxRgmtYpUzruB73rGhN6hDEqyTRLdxCSzbR/JDpT1R7UVbHz8JzR55jBIC8MfvSgkRYQcY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kk8JIzgW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WSgpfLeo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kk8JIzgW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WSgpfLeo" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EEVgsn147890 for ; Wed, 14 Jan 2026 15:30:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ssy8kvmbkidBSVa4bIF/Sg6F1PMs1iwvsiG9/WVtcJY=; b=kk8JIzgWD/bAHEgM 0ls96MNXXtEja6QlnGHg+sHWfdxg9wDNaEzJfvyQq5xMnTuFWVseT9s6RLHdO5L9 fiiRlWgh/YHepJkNkuC0AnfkwGL0Ld6YutVOHruXFFvt2zdl1KPFXN2Cdk+9raEf zVwyi4HdbYB1Qm3iEm8EXAmNAB5eexz3+aKnzn6LtAne6tKxrKfpmd2Pdf1s2JA6 PGnyZKWvZl78FlUvryh6W208cUEVgEwxQtAzboLq6Fvy6bXHKAL+r7R4mbLDWzH6 KQ/pTMq+l2VkT7Uu6Vm/oLuuz9ef9Gr2BrJAtjOSQ6YQeOgumZ7CN3XyCY0Zv1ZS hqsjxw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp6rahph9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:37 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8ba026720eeso938044685a.1 for ; Wed, 14 Jan 2026 07:30:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404636; x=1769009436; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ssy8kvmbkidBSVa4bIF/Sg6F1PMs1iwvsiG9/WVtcJY=; b=WSgpfLeoPK9O7awuR36OjKIS6QTCezcaj0Df6mpVTxJJxsVfXP+tfToXYfheIYaJo/ sLDuqYpTV2cmoZi0wJDLnZwI2wzH/v+ltQZAh1MbmkxubOZe7BfyUuOJLZrl7xepK1Mb uxMSKYkgw5BszTx4P/znYqGNMxVTh+VjCF7X04KIJkCkimhZ9qdIie0h7oLSDL5H3htV AMyC1VXEMX5iNjvXLI/fjO2OqMZBIRx6ZMVdTF4QdO+jpCHqCmZaQ+Ov1B1FYrCVsq4/ K4VxKDiQGt/1OLck9NVdhiI3S4kImH8Wvbq4QwMY0O2elqgBaHIoA5Brp6+Y0NjeI/ML 8jNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404636; x=1769009436; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ssy8kvmbkidBSVa4bIF/Sg6F1PMs1iwvsiG9/WVtcJY=; b=OTJ0SVkVXuhjcK4G6LkZwrX2G53uZ0RdKPOL+XUmoc8hFoSE0LaBCaUp9UbYG29y0F ez2gu7kqV+5tb4m8Ce/4EgIlhMd4yGLP3iKQJMWmDLHtzLiUxVgosLvM0iv7gNum+XMr +H8kJvpX/FICTsi6dgGsxbOuash3Pla+1Rbfd+mgScvY8H1ZHIhyNDa0e3de0U8IxXgR 53QetEeU/EiZydYofnSSXjiXwCW4kPEHtnAYnSAEqjHNM4XEdsBVUWqcE0Xnp8szqbNK 2HWnuhbTu3C73OWcX1wFotWht5e3GRlX0fzOq3dhxlrHA8TMY5jsCLmNlfdDkEdPQN9g 2Dwg== X-Forwarded-Encrypted: i=1; AJvYcCXlJRe/Oxn62u+0S44IkEigZvcgtJl90BwvBOzSAfLHrdXE28M7Y3AowFa2NuMPtvY1uIHj9Mo1SJBV7wc=@vger.kernel.org X-Gm-Message-State: AOJu0YxfGhYtSauIuUP3ixi7kinmjF0MhIlKBzLjXe3y4z3DkyCvKGDY m2ceOXQ4fxQtruEy7+RKtVpzTGdG+QLXVDYOfutjzH+gEuoi8piiu/5p8f9W2si2wtUqj/tpDiA CJvtXAsmpLu9jeeiKrzSz4A/c7hsNs//xVDOVT3eMBx2+k2ggTY9AOZEeOQcEsBTyP2g= X-Gm-Gg: AY/fxX5Nu2SINVTOxnDktF94yQn8UCgelScuCFfwG3qctmvVLNetUhfbUr5OsiBDR1R bRqTLQ62QXgQwdKUvHmciSRE2dVp3br5R08w5h7SSUgZ3IoMMQLbc85Sn9y5HiFPaZfSReXeKab h9nhFhpLs7PA3QYMMF0qbtONPhrBI5pwxBGNbN3PQWDfMkOgriYnumpntjAYB49ZzgZdi/2D1zU yE6UZBZoPeMCT/bvHZWMyjcmZf7iPfdQPUs7E0yJo6d7Y+EQzs5fxeH4KDM9c/VLz8fs5Kx4o5c VPUAnvxYeIHDgZmsFquA6wKauLrl3+gJvPGNSDeYKVb/BC+661WWKIN41HfSuTWwj7DDK87KNFk gJppiKVvWpvqyCRU+8rlNgeDMzocGgKJdWA== X-Received: by 2002:a05:620a:4549:b0:8b2:db27:4268 with SMTP id af79cd13be357-8c5317f0aaamr303443985a.53.1768404636301; Wed, 14 Jan 2026 07:30:36 -0800 (PST) X-Received: by 2002:a05:620a:4549:b0:8b2:db27:4268 with SMTP id af79cd13be357-8c5317f0aaamr303432485a.53.1768404635555; Wed, 14 Jan 2026 07:30:35 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:34 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:09 +0100 Subject: [PATCH 08/11] pinctrl: tegra-xusb: Return void in padctl enable/disable functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-8-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1889; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=zRGKe5UJ9yNFcA3nCyV2yle+pcJ0o698KmnQ7j+oxLg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aG1jDmkP4a6PmHCk7jxdg6pIwc6m3a2BsZu jfRoWqEDhyJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hgAKCRDBN2bmhouD 18PUEACGRm9HFTgK/BMYNlKpt3lPmWT9bCXtaAiUNJGcB6ffgJheT+i457oOaT/xTx1LOOiYEau UWjdo7vnfye/rqPz8xYcdQr+go81raUQ3IhBxe+LqfaMunA9y3Q+s3QbktSC3PldiTWJyw6MXBt uq+YFH0Vtnkbp8TC6c1687wMzaJsm5xlKxC6x3Sfmws6HwZXhBuTB4Hi0wT0my3LoS8gJTHQTNq +qkjU0hLXmrpN6ibgVT1FxGuHDuDSNeVSEIHmrFSXVlPBywSQGm5gVuLyiQCtiarsEhPhlP1a06 OD9Hmdkv9AZLGDb+Nyi9BewRwnASnSvswYKtqIMj+lA+fj+BdCmRx1CeX2CIRINVcIZXzU4+VMe uKlw9dXawo9KJHktVbqmjTBM/mP3CqYpYoLKJ/Z266veUYfVXw8zFBpEdU0xSOqRlekxTnkGZEN dOEKquxcczR8jUIAagMutrlY6GtaQG8YcU5pIdWXfU7Mmly/s9fuJlOFKiCuv78MnGkL2CIwOxF saww7DthM71jMUAZ8mCReBzVQOz3GSqWUmdqg2hOkdn6kGEQgkbdIeWBCfvFxgKmUJOw6Jx3QkV ceyz1gCkgjID4vnUSP0ziWiUhEXkrHazIzGuYyBPUGmzvaZk1w/COGY+KgPKeu7arJ/qiUw/2Iy P4nTGG0eFE6fjiA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfX+kLumwgPpSIr zuW0Thri7dip2cE/j5WQuypGn+CvBhgFkHSVW+7l2FFT6wXgQPwkOKgRSKzRtj/wg7juaAlAAkG eLybhcqvIkSl3jVQt2RidIP3n+yS/jHFKrtE2ts48iLS7HOqkm4wMJFjbpl5BZ7gviyIVVyy/Sx EMjWJemUoBxH00n19c0Y30aDrtmrsHjpR4TB2k1p9TiKKxlahZSBP1k34SNsTqEsAMo6UOwryoo NjHYPFS3MJD1jXQC2EZ+4+zy0YT/6h1FMnu2hZIM0fVoeW8Bech7atbxDSyWJrzf9aJdnq0ZdR9 bCMpx1sXYgeeDtqCCZQY0ZwUEPBVvlopaBqhQ0mGVhI9znGHqMUzjoR7A5A19Lyp2GxVRKA0LdZ 08f1Ihf8Ljbm2uwlqqMoYd21rptf1wd+tTN2pAVijmlwHwf/MfxsveRXXkeXxjYS2cKYpQ/c7y0 lnsL9AFBtErqem22EbA== X-Proofpoint-GUID: Yu9FaqWth8oQdJVI4kHdH67Q0cCwLoeD X-Proofpoint-ORIG-GUID: Yu9FaqWth8oQdJVI4kHdH67Q0cCwLoeD X-Authority-Analysis: v=2.4 cv=L/EQguT8 c=1 sm=1 tr=0 ts=6967b69d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Ed5BEzkqmhObfCaRRI0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 spamscore=0 phishscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Make the padctl functions a bit simpler by returning void instead of always '0'. The callers - phy init/exit - still need to return 0, but these are smaller function without if/branching. Signed-off-by: Krzysztof Kozlowski Acked-by: Thierry Reding Reviewed-by: Jon Hunter --- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/t= egra/pinctrl-tegra-xusb.c index 49c5edeba87f..34a373f7e04d 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c @@ -474,7 +474,7 @@ static const struct pinconf_ops tegra_xusb_padctl_pinco= nf_ops =3D { #endif }; =20 -static int tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl) +static void tegra_xusb_padctl_enable(struct tegra_xusb_padctl *padctl) { u32 value; =20 @@ -501,10 +501,9 @@ static int tegra_xusb_padctl_enable(struct tegra_xusb_= padctl *padctl) =20 out: mutex_unlock(&padctl->lock); - return 0; } =20 -static int tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl) +static void tegra_xusb_padctl_disable(struct tegra_xusb_padctl *padctl) { u32 value; =20 @@ -534,21 +533,24 @@ static int tegra_xusb_padctl_disable(struct tegra_xus= b_padctl *padctl) =20 out: mutex_unlock(&padctl->lock); - return 0; } =20 static int tegra_xusb_phy_init(struct phy *phy) { struct tegra_xusb_padctl *padctl =3D phy_get_drvdata(phy); =20 - return tegra_xusb_padctl_enable(padctl); + tegra_xusb_padctl_enable(padctl); + + return 0; } =20 static int tegra_xusb_phy_exit(struct phy *phy) { struct tegra_xusb_padctl *padctl =3D phy_get_drvdata(phy); =20 - return tegra_xusb_padctl_disable(padctl); + tegra_xusb_padctl_disable(padctl); + + return 0; } =20 static int pcie_phy_power_on(struct phy *phy) --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F27C23A0E87 for ; Wed, 14 Jan 2026 15:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404641; cv=none; b=bbC5mn6RlAHsjvhSm59z85PybjYfHKfw3yjvd80xZZH/4eeUZaqJRK0tkIPd4JrFeVElBV29bo6w52zbn8SHzi9wawMsQA68+8IPm2Q3iatXyfFGTxDP1S8AKV2oOyQV7Usrl2HqzrsLXfPtBoNu+00iR2MZsGgiH3RsrezLDKs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404641; c=relaxed/simple; bh=Hz6iLmKEfxDKfrrjH8upUbRNGTU/avM3tmt35o0Wjvc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lBHz0M34qwRFRDyuZU3mhkicVSjgep2U1VyYsffU44qLLh5QGCIOs4PBZeJ77QCv54bzYVKYXNRcjAMKE8rIESSVYnE1gLRuMAnZ7A8K9pLwByFtdyJ35IkecZSomUqzQr39T/TGUkK++14dfqAJjI1NP6Z6JzIoQEklIC5c9pw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oI7iubuJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UT+hN3h0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oI7iubuJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UT+hN3h0" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EFL0bp1943016 for ; Wed, 14 Jan 2026 15:30:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= taXBNyuQJxmj4iOFqIUfDmb0YEDOzZ29KLE4Dq+0LV4=; b=oI7iubuJrJC0fgMI lUkAMQMVAzmfEMIfufrp9rsjWsXcH2o+6+++OU+t1AgtWvYToBTqLzfCTJ5hbWWc zsOmvaBPgp/FPEP8JHQwucbS/WuYShGxyW+lgPoVyVgGAfV3FaYqJ4LDeQjsxxWb Hp+0cgOkI35fRxgRp+kIaZ0O0Kq0Jd8CNCAK9GvKzPufghCvcwz0vq6alk+/IZLN +Yvdv6h3DUvdafI+5Fb+qaCxdCVOlggJXoBSasoUUjTrHxP+nU8ZL9/9fuBl7ZXb GOHzOvBGPL3LIchFN7uT6MG6DvhW9TaYkkitzZ1yRJ71Tmhn3kONflVTlxvRYGfg EW4g6A== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp7b6sjr4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:38 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-890587d4e87so221019966d6.0 for ; Wed, 14 Jan 2026 07:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404638; x=1769009438; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=taXBNyuQJxmj4iOFqIUfDmb0YEDOzZ29KLE4Dq+0LV4=; b=UT+hN3h04eYUzyRpvc4prXX1UR+mocev5REzAu1FUxZm4J6hn0IkintnooACOiskE7 Jz94jDhvdL7QTLB3kcVSIdKXVG9QAfbINX0ECuP4YbBuSktinbIk4rOe2artVlf+yEzn 0rNUAKkOTGpAi4Bb+AHVZucFRrmUyH5cQCp4BOR+KTJsh85C0IdN2bVCJ5i0la7MeIkX 8FNW7Q5OR3SsN/TboCH2etzV/ECn8pLSdf8VpfIfdK147gnf103kiJ3+QzJtA9CXXQs5 E2nnEtEcY20w9VE00o0S74dLlYgk4HCCdQxycFuPqmF2ZrLGnWuihaUTqmE8gJeLUNh0 920w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404638; x=1769009438; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=taXBNyuQJxmj4iOFqIUfDmb0YEDOzZ29KLE4Dq+0LV4=; b=XJgoh54YBzhS/NHwuDq1fOkKr8GUrgrUKMAtChfog4b0hRuocNohDq6ELsTXfnl1p4 5DclTlegE/TrTmpU5b4E2jgqkXjuku144cK+ey1HZmDS5Nue37x2HrBRD0Yg9c0QQV9C hPgzho2eIUE9ooonEfqjS08+HfHmS+ZxelaF/LS37cF/8gvlv9SST+pmISa5ydoVZkD/ 2+awNxGhhujTu3REOtBZtmxbv5lqt/V+CKxlKGGN/r9/JiBrZVENwrM260+Hg/WHwnCd WiHUY0XZ1eRXCEm0hsi4SicRHtAuM0kYnIofXm8jnapXrJ6T9z5UYSr1wp8to+BVIYSN SrRg== X-Forwarded-Encrypted: i=1; AJvYcCUOrE7OjxcxGQaM9EgZ8cjtQ2CewQhRDulQOSGIca0wSp2gJqdUE2P8zcuOk0OBSkWIb06ayMND/v+bCqQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyRUGFFlxB0aaVMgISZwLXeRJuKR/z3YPB4dVr3Py2OBMb5S2MC MuboLs7wHuh1qNWLpST3/74ftcAjG5fJ6U0m+9aGR3n77goXg15/s19eEIyZ4jKxGarUUUnU3Y4 xTJpRWxZ3svGIjaQlmYyX4h5FkMws/b8zvEP91bBfPAI6PXz6Mvr1u3DUt1sBrEXWRpA= X-Gm-Gg: AY/fxX7qKELdqmc4GTCrNTvIPL6Pnio3ROpmoAH/RG5zpdXqrGJNS0CD15razwp/Pcr eyMbkdX1kH9qxrSFFeZQqWiS3ii7TU0oRhoXc5NGUt+puNNbb0t3KbTNugXhouV/8dijxBi2DvE 9H0TELRBYH9lENcGKZYd9GBSo+/wdicOb2jAX7RL54agyqd7fCZixQnf8ymX4USK8T0g8Ykp+Hw qxqsNXAFLvjqmuSKGTYKvl4Nwvt39J46CRhdHzMWT7X2d+ynsXnHrpJ49hVB1tJ3gsrDJyj5Zt5 peTwiYBqELGTSaW6F34+z1agBhB907ylPsIRKcEn0w8dP/JK9CScyoYi63itSELauflMKUPAXma cN1LZTytcSdBqCdxMjjHVKy1p2CRB+2nnDg== X-Received: by 2002:a05:620a:6ccd:b0:89f:5a59:bf30 with SMTP id af79cd13be357-8c52fbffa64mr413617585a.78.1768404638374; Wed, 14 Jan 2026 07:30:38 -0800 (PST) X-Received: by 2002:a05:620a:6ccd:b0:89f:5a59:bf30 with SMTP id af79cd13be357-8c52fbffa64mr413605785a.78.1768404637689; Wed, 14 Jan 2026 07:30:37 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:37 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:10 +0100 Subject: [PATCH 09/11] pinctrl: tegra-xusb: Simplify locking with guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-9-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1933; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=Hz6iLmKEfxDKfrrjH8upUbRNGTU/avM3tmt35o0Wjvc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aHavwX9VGYJNPXqlYS557XrI51pw+HBiAgS ksF1auZQ8aJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2hwAKCRDBN2bmhouD 14N6D/4u0Ishpad2NsggJaHhekQq6iqnAlDq+P4aUzZ2je0asU428AUXHgBNvCHiiaRNuJ7peKn kZaXFhOLRJL4lxXomi8DHl1w9D1wmI2dmJY6uuG7+xE0WxinMpd5kVfeW2Xtb54zER0cJh1D5bI sVk4n6tZOECbNOeSCkDuz9iEmckynK/jzlrOtYLy0nBFnaMx4id35WfzzlMbiT2y/C/eloosWov Hmaa4SZ3MfGPYTu36FG2d+rvHNNb9+WSIuzkjv+VTj3cK17PThBorYGBp/w0aJ8TZSzhi06ZV9p muZ8lj8SdZ97AguyfiMxk+Bn7pnrY1uffQ50Y+89Q0MUkED8IzjqPDYMxxlEPSUsTi4rcPT/Nwf YjxycS6wVR7jaqPzsW9sPjVnOGg4m4RSiiD1UI2kij+foiDbWUDEcdzMktasIlpA2SELsmvfpKe NkKfC/MRbCi7phtLl2BQz7sIegR3+lh5wHlWf5Bp+vdP/TwV+uSXTTrwiRsQhuSaTR+J7imqz7v rKwBAo7jL18AC5SjN42i/KN+kBPDr1ukX+5zCgQGI6rTDSkYOwuTeWTgHMyLQmymCwjNAz4SbuG wHlm83t3XUAC1jznj2naoOonPyr+Xpa9qqPg4IfTnnixh13WCTfgidggeW++iXeRSKLA/Q1o09+ FxL7I1nczulzGhg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: qEZSK2GuKIndR7qrEgzbU1jdnXmuF97Z X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfXxYxqFx3jRH2h iN+JG/CuwJ1mSb0W8xnuV/+QCK3FcK1yHgzOL2Crs5xThY7HGLTFaYisyKK29rSTlr6uJ+o2bcH B+9HCezli1JnabvVvHqW4tn1CTyvmG4BAIWNKJwenFXNc5yWMgV53mkD08aF3QE+3dcIwQ7w7ZJ FzizjuAM23qQ4274kfrG2UG7grXHRxpGOIaoXS1U5B1KE7f3kl14Z41Z9qblyH2YbwF25xV8mZR 7sfoZc3gQZV+d6KfKytVAUQGdYjQ6AskAlc71sTSFC8sZGrZqH1AWV36R9eeCWHIljqiAJBLgzW MEu5HbKdhS8IZNUt3Yp25fD6812KzGVZA4iPrjlWI0GbCvVL+8c9ZMrH5GX/LU/Uinjs0uT/6oZ pcAg+1hTIMe7wgX/b/SzjvJC1BoD5Tf5/U7VChKutMRJfY7A9Eu/e9pwqN/HurWowC0YgLNoLjf j4q5cL7Kb+Lbfyy1rEg== X-Authority-Analysis: v=2.4 cv=W+w1lBWk c=1 sm=1 tr=0 ts=6967b69f cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=aRO1tsgHJH1V1zxVpf4A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-GUID: qEZSK2GuKIndR7qrEgzbU1jdnXmuF97Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling (less gotos) over locks with guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/t= egra/pinctrl-tegra-xusb.c index 34a373f7e04d..855f708ce510 100644 --- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c +++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c @@ -478,10 +478,10 @@ static void tegra_xusb_padctl_enable(struct tegra_xus= b_padctl *padctl) { u32 value; =20 - mutex_lock(&padctl->lock); + guard(mutex)(&padctl->lock); =20 if (padctl->enable++ > 0) - goto out; + return; =20 value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value &=3D ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN; @@ -499,7 +499,6 @@ static void tegra_xusb_padctl_enable(struct tegra_xusb_= padctl *padctl) value &=3D ~XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN; padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM); =20 -out: mutex_unlock(&padctl->lock); } =20 @@ -507,13 +506,13 @@ static void tegra_xusb_padctl_disable(struct tegra_xu= sb_padctl *padctl) { u32 value; =20 - mutex_lock(&padctl->lock); + guard(mutex)(&padctl->lock); =20 if (WARN_ON(padctl->enable =3D=3D 0)) - goto out; + return; =20 if (--padctl->enable > 0) - goto out; + return; =20 value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value |=3D XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_VCORE_DOWN; @@ -530,9 +529,6 @@ static void tegra_xusb_padctl_disable(struct tegra_xusb= _padctl *padctl) value =3D padctl_readl(padctl, XUSB_PADCTL_ELPG_PROGRAM); value |=3D XUSB_PADCTL_ELPG_PROGRAM_AUX_MUX_LP0_CLAMP_EN; padctl_writel(padctl, value, XUSB_PADCTL_ELPG_PROGRAM); - -out: - mutex_unlock(&padctl->lock); } =20 static int tegra_xusb_phy_init(struct phy *phy) --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CBFA39E165 for ; Wed, 14 Jan 2026 15:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404643; cv=none; b=MzuFMo8GWO4TbgZ8nPrDgmCPNA+tgcwUo5eJaKtEtdVE/gRTS/SodhF9cXI88X7QUWwJgvlIQGE0APqxrBqwMNWq4FcpbbgTPzLSb4pvnZIW34Xv2tE5L0tbBfZGvYjJGGJEAWo+MfXXpkDNa0TuQEh0n/QQdWkaeD43iia9F7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404643; c=relaxed/simple; bh=9+1hnIFGck3b+xQzUfQOk+LUFT1gQJKcE/unZtByYAA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DCaSo6MEfd2Xta5J3F+53SIo96QfyP2O8U/oEkUxucEEMzFrQYIk66GQIK1viG1ouG9dvi769Rdo6K4pwiVE/wIzWbkCN+15f/wf6kvRpnoKWwStgr2e+x6a80fnD/bYA2YmrXEc1dH360djBS4XwyEN7Z07l4DkWOPA9HYtuYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c0gmla3n; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ba4BUjd/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c0gmla3n"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ba4BUjd/" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60EChU7s3925408 for ; Wed, 14 Jan 2026 15:30:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HcnR/89Wj03lP73SJG9uZUh4OsLus8WiGZb1fxJLAxE=; b=c0gmla3nEwW1grom dXfhMbs2CUA0nDw7P+mN/FxD+dkR3rvaLg1kj3Nh9uN83L54wADzxSvhai1Czh3o 2Z4/Gt1Ftvc2cgOWr3LZiD7Uq4ypjP8ZT+7sDuhbqb3HYJDQpZ7OrzIf81BX0H4J lF1mR5L9zhlV6RdlrxyvfNJjXvrj6xgubK3JL0usnUC2m/6pPMzEsOqSyd7zVVdT uZolIq0Q9qTwubXeuXWTAJbOaeGgW8HmvOOKNw2Z3XPfK7RiY4Nd1H40O0BGDa4R EQ1XpTh5M4lrFkiSZ1EUhg58ozURytLvOpuOMTchVUUu0v7sRbxOU/92dxJcw1iO O68bPg== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bpbdbrha0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:41 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b2194e266aso812147985a.3 for ; Wed, 14 Jan 2026 07:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404640; x=1769009440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HcnR/89Wj03lP73SJG9uZUh4OsLus8WiGZb1fxJLAxE=; b=Ba4BUjd/u96b6KLPxVsLdtDlqJEhsYRTBbMIMn3FlI1o9OAPT1C2S/pN12LZxaTcNX hA89qxbOxf4NN3eNOp2o4Wzur5VbIIIVhx1wT1iKBPC6zJ1ofG0Nb1zWjEr3TgUoY+b6 y17k+fFv4Ieo97chx9BY51kO0HcLyO/sVCWmJPDkLuFSq4NS6kOAD/EBFNi0yONoM15q APVn5nL4wOjcYKDWigXuzJKcTlLfS/PjSIcEiFYQ6BV+3z9Gu8TLj1xOxsITZNBX9kBt 7VL/0UbK0ZdRIU7CRXo8dHgZUA2j2OsPp6DoeBQM1TTaLKj8arSLwLDUwTlt/wr8hpNH 8rxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404640; x=1769009440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HcnR/89Wj03lP73SJG9uZUh4OsLus8WiGZb1fxJLAxE=; b=nWmCgt0ln3kbcdJGXUF1XVTOLEQSjBNlPtFR/2SYPaTLvc1coGrGn+BZ3gmmtbYHKB TocTMjt+3VD9KKswUkbiVRe6YTZkiwItI/QNQzM5Uqji9bjQxupXFUR5owvC+sKGeC1B 0MJQPaP6Fj5AJgRr2HUUiOgm7e2MuNQOASbmmqL/dMRy268tzP2KK7SRqSmd8IC6UuB4 L9hLUtJ9rqCcNkr5Vyt0o/8Pquou1p//eGxvsKuJDjmYu/CS/Ftu4LOy3wrFmXsMDFCG fIbWh74kEZZbmDLEPdaf58y7oudWEIbq0FWdZy1p6FAgK8O0XApkB9UtW7bn1I1qGnHx p6bg== X-Forwarded-Encrypted: i=1; AJvYcCUYQo0H3PlK9shPyLWwTkgXPf2qHa2V7jXPyv8/IP9MOw9TDPvEeC4ocFo0nJgHrwuICmfhfxZrbLpalD8=@vger.kernel.org X-Gm-Message-State: AOJu0YweX0Pm/VsWrQOlkerxNV/RD+ln75ecFkfq3YhtdaUcVnP2VpkN Gj/8HLOiQQMPP80fa6CisnT4geA90vtcyM8xdVEv7CnxB9YTzdw4XQzkweCMoh0BWAdsRI1RpFJ V1YBDIXt4HkcKPtzmnKFN6SNit+rFnTsRQpWIh3hwqgkqBgu83EMgfBNj+NeiUuD2Kkc= X-Gm-Gg: AY/fxX656gsUk65rTN6QV1KFoH9hBvZCPx82RE/GD9/qpHKCbgSBstKb1FHVCzN3Zwv BZxEeQuI/lezkaKsYaUSugUrHFCdqokV5suMtbDXF5mCSNwmLDO+DY1mCaUOLkHR8o2YUb/SFFR 44nMkRSWFPHknl4XMvx103lmEnACL7CEccM+CFtGzNLpAcfdfK7U0gdjqAFFSB9P4TjjH+A17o4 0jMwrzPaojbZJCCQSj3dWXMWSt54zV+3F4KPI+tMcDkBAZyTOjIDezr1hOllzO27FPAg56bOH85 D3wWo+hqbPIJcnR8ooB4QnEliVpPvMpjBzqHFb+VBpSqpj+z4G4jqN9PJCyGrf/0AXjv1ArRnnw remXCmb5arWameUwHwKSj3xjOwCdoSiadpg== X-Received: by 2002:a05:620a:6cc1:b0:8c3:7f27:a65d with SMTP id af79cd13be357-8c53168ec37mr311804485a.28.1768404640503; Wed, 14 Jan 2026 07:30:40 -0800 (PST) X-Received: by 2002:a05:620a:6cc1:b0:8c3:7f27:a65d with SMTP id af79cd13be357-8c53168ec37mr311794785a.28.1768404639752; Wed, 14 Jan 2026 07:30:39 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:39 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:11 +0100 Subject: [PATCH 10/11] pinctrl: rockchip: Simplify locking with scoped_guard() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-10-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1325; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=9+1hnIFGck3b+xQzUfQOk+LUFT1gQJKcE/unZtByYAA=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aIvjtMFFp1u5KZIz3s1rXIH/N4W/pA1awz0 axCd4PEfTeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2iAAKCRDBN2bmhouD 16PJD/4udox+AT0qW++6/oS92v662DKt4vHflxhkYd1Y7cNFl6VsgBSRfzaoloaz0MEHOAVFGMt 1UyMr93P+dS8fvc4VILacc5vZbJ/kr00OTwdcwQvdnsePTgGSF9jxGxB1yMVKlFjDrLF1zPkwpl 29wGLZ37hS0UH0TeGW2udTIV1YUSrFiYFUZYsEcMt39OwgRdby8TpKGWJUjQxIvBk+/3xZOt/e7 NPVy4lUSbhDTBQIXlTFIVTRce1yycOyBjEl+kvd/FhG6SHcCL61dVRC/HGbXL0M/wiiofXEdasR r9lwXPamriRLmuyjJw24hnarxswAqVCniTLhEcripalHasg+sQl3suIahqkaLyitP7Cnd/tzwbK +0IG7HVcQKU3c99Eb4MDp1+DQhaoB7hYCDuhAfVj131lDaC23kfGy82We0gW1UU3HljSGp/099i 9dIEF1tOdwQ3Fn8QJ63QNMNDQrnXvvHNhKtSsvxkruUtxPw5PxcVn3TXp4E7SFojcFSU03Vjr6P 1PerYKudeLt4fYL25YhswZnxQ55f9YEHdXOpcT6ioYr1ADvhmpbxvYqiutI5oF079O96zENLJW6 XqeT+zpnIQ6JT3SXsguxvuciBugFqYtmWU6xsPv/UBK4NLPnIsNYRhMDUmDpn3uqmgo9awP1tGd 9qrQnqhwTfT+JiA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=NvncssdJ c=1 sm=1 tr=0 ts=6967b6a1 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=zo1y7j5tH0XFdPBYKCAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: AxmSxvgzXVBSFuWpeUTRE84fTjOS4f54 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfXxGK7QT/UErnu gzdFqdXYrN8RTjNVjCSDO47FVNuXCgd/PCxFedBeouQI1DTyr9bInErVwBi+sdvw0qv3AhDXwFj b8lxvcXMuBNXPRWG6MapXjP6Ceb+mrHBmW+aAnC4SijOWEEnF7Kgndlb2YK24YvOEBl3Pea0Gmp xGugOM+U3vQTGl06lTJGol2bEKrn37DFIYXDD9Rp7bJnlFJIq4m2rxNua4/sszM+t9IS3MOu6Zc eEls2B1P/wTOUF0YOX7n0hHpVzcl40E6mDJASEIkPwSgoSplDlY+bNl4ZQmUJ8u0PpMSwzY8aCT JZfX93BawTWfvrllNYJyCCNloMqJp+IfsIoNnLjsFHibeV4ijclpaoXTjg8t8ymoGMUujYPtRBm r/hr5s2i6eQwREpwtIZOiRnWUq/qIqGIFvYNH9B8iEsM+A56a/8g+RNv1S86S45N0wUFvvcSgnO qfPJ/m8DqvtFS60dBIg== X-Proofpoint-GUID: AxmSxvgzXVBSFuWpeUTRE84fTjOS4f54 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 suspectscore=0 bulkscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 Simplify error handling by removing two mutex_unlock() calls with scoped_guard(). Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/pinctrl-rockchip.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-r= ockchip.c index e44ef262beec..bbe1cf712965 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3640,17 +3640,16 @@ static int rockchip_pinconf_set(struct pinctrl_dev = *pctldev, unsigned int pin, * The lock makes sure that either gpio-probe has completed * or the gpio driver hasn't probed yet. */ - mutex_lock(&bank->deferred_lock); - if (!gpio || !gpio->direction_output) { - rc =3D rockchip_pinconf_defer_pin(bank, pin - bank->pin_base, param, - arg); - mutex_unlock(&bank->deferred_lock); - if (rc) - return rc; - - break; + scoped_guard(mutex, &bank->deferred_lock) { + if (!gpio || !gpio->direction_output) { + rc =3D rockchip_pinconf_defer_pin(bank, + pin - bank->pin_base, + param, arg); + if (rc) + return rc; + break; + } } - mutex_unlock(&bank->deferred_lock); } =20 switch (param) { --=20 2.51.0 From nobody Sun Feb 8 22:22:28 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D35FB3A1A55 for ; Wed, 14 Jan 2026 15:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404646; cv=none; b=IYZHNmnc0UULOklN/ayKi83eKMyjT8ecMjcGKMeQiU5THsF+bocyWb8cyzjd1zkcH2z5t/Ei8lt2ztrU283na+LOMfjbkdH1/ChKT0hqPvQo004zixRodfsNDLKRSWMbSIOrfo/D+37MT4grw853PKNabGewcRjd3Q0DP4auR4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768404646; c=relaxed/simple; bh=SjKuvqUidPJ5fm3b34nm9zaMItl1NLBQXfR5LWGDZIg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oTIjSfFM/4W8LTHnJTTuwEsxJh3USMxSzVG3lLnhXcxWS61FXB4O7mEZpyjsj2FTFoGMa0qf/GOai/HjppfLRjbPajI8Ajn10dZxzDSacHscq9+6zvR6yji1RC/xolksmmBVsrfFxQhphVaPPfIQAQrkgyvxvZBlUtP+Ih2IDAM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CymxLC2N; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EMiRdVPb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CymxLC2N"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EMiRdVPb" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E9jvft3296429 for ; Wed, 14 Jan 2026 15:30:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YA3VmuPxJ2L3DtrIn8wKabMcttC/MOL2mTB3zxLU6Gg=; b=CymxLC2Nh+Yhitd8 i2VCkipA2Jvgf58dNARhSsT8C3NBVFuhB0in5/s3k2byqbKN2anrEGds2yvZ0cT3 HsKWrN1azY5/EbZtPj1RgkYGi7uNgFYsmUNZvbzqrQF1UBcNuIOhSJoSKpPFum/u QjvnNThfwoYjH1wOtZj1emLDqD3KisvQGrK3TjABDHrH8oCkwD7M3Cq2ycUIUVLo EyImefGOULzlqVV38fX0afy7dTmZn9JKe32HxRjrZxhMeDK6l9+WPDORB5pf1SjK 8mf1eqt4rMwywhewmr9BDmuYFEvSD8GHa8Z4iL0KPBcfA91OEd6GMxp5lCqwlV7t kPXvzw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8t2s5rc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 15:30:43 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52f07fbd0so439523685a.2 for ; Wed, 14 Jan 2026 07:30:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768404643; x=1769009443; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YA3VmuPxJ2L3DtrIn8wKabMcttC/MOL2mTB3zxLU6Gg=; b=EMiRdVPbexrxe1BDkE31eiwI0DJf0hNBAPH7GRtJUsTtCz1bbeKcnuPK9+N3OVIvXF i8VQQEguu6p7EN5sxtAuv5bUE3d7rIMpF44Q5dydroHueQoJ1u15OolGzrlEeQyghFT7 6sVPDTvp3wuqSb5sMuCA8DpLQDiqp87SF1vuXy2KDkSdaHJ4CsDFJDzNdF5Zf849bhKJ iQG2rix5FlFmtgQFfjkzkiWdopyTPSbN2Ri7HuDuJcnk0XOjeXy3XgtuNrhuZ4qkzak4 B2DQlbPYd1QrJdgI8qUaStFH9swwjfYC24JWJ/EpdPdhHXDXaeUSyvZAUi/jWs0eKRGD 26Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768404643; x=1769009443; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YA3VmuPxJ2L3DtrIn8wKabMcttC/MOL2mTB3zxLU6Gg=; b=JLpuUTsXd5YaGjHQpO8HczzceXySJKistMf3H78n/oNWSzddTQGKpQSxm+ZVK7/iWs b0KWHvvMRgiKyOujdqLJVnq8KhLlasS/s0QUk/oXOgY/Q5UKR9yT5RU1CKHGlYRaKS/I V0P9cFISWk5BdfMfdDBVg4SMAm4o39t2n1a2ND+mCz94V3tvJVqUTExEy9ZWBzSr3O3v 8lhcZ4LgiisPhP/Z4tBeSwKQt5P7MTbzuN7Ot2voekogkCCwJ5Qkg9ATD9UQoahMYriU 5akihCrggrp5DCLpwvKIlpMs1L40dfLHppwqIvR9FTVy6+1gq+z3lnrFpm9/WZyzgIIj C1Sg== X-Forwarded-Encrypted: i=1; AJvYcCUMfzTPOTZfIZ2U8uMFNgFm2C4zKM/3Kl0c2KywYJ7WerI4xqe591D7mt+vklp30RePCYv9hU0yJRkxFGM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHrSB5ZXBqIZZG59w+mgse53w7LF+5wAYnDafbN0M8tTWq+3mW ADX0Pk3xBiZWKsd3hRiLn5gE9G5ijDjMogu6wmWUlNV5sOBKFzA8e45TTCQJpGHieLZW60fSNB4 kRskTcTkm8pNTOKnt1HyvhoH4eYBwkqhSwg7u3/Qz0uA8KU1m104kBJzrAeiJoywloLU= X-Gm-Gg: AY/fxX7sPWfdwkzAwHwLb+F/Ux634ZV/QDKMv+l4zayRerbnhQcnRNnZ9MGaDnZl6lj tDuhmqhLBRuU4KwLyIJ69q4q2fzVFL2f96Up/fe1M0dBoL2f96Bs1CFHnLkUuOID5gJSkegtK0k 5ggfoxm5hUJgdOtnbs6lxTtUCzsr37LoY+Je69RCMAThouH6mfz1WvT2QPwWYSaTNw6vOx7j5Tl 6FOAXxhs1+yzxbs3UJKxc4IRkaIifCgJqBGMnMLditXUUL1T1L3ntYtDQlUCFT6oAna2R10zlo/ ZB1fS3lfMGbDyDg69F8qtEe9OLnvIF/pY35in7a8ZvkJuLfTzDpX5H2jB7bL214brbiuh8gZot6 3FfRI+hL/Y3+gDH1ZCGkav6DkS08smzol2w== X-Received: by 2002:a05:620a:489:b0:8c5:305e:e9f1 with SMTP id af79cd13be357-8c5305eed0fmr269950185a.35.1768404642868; Wed, 14 Jan 2026 07:30:42 -0800 (PST) X-Received: by 2002:a05:620a:489:b0:8c5:305e:e9f1 with SMTP id af79cd13be357-8c5305eed0fmr269941485a.35.1768404641970; Wed, 14 Jan 2026 07:30:41 -0800 (PST) Received: from [127.0.1.1] ([178.197.218.229]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm22812989a12.29.2026.01.14.07.30.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:30:41 -0800 (PST) From: Krzysztof Kozlowski Date: Wed, 14 Jan 2026 16:30:12 +0100 Subject: [PATCH 11/11] pinctrl: st: Annotate st_pinconf_dbg_show() as holding mutex Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-pinctrl-cleanup-guard-v1-11-a14572685cd3@oss.qualcomm.com> References: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> In-Reply-To: <20260114-pinctrl-cleanup-guard-v1-0-a14572685cd3@oss.qualcomm.com> To: Andrew Jeffery , Linus Walleij , Joel Stanley , Emil Renner Berthing , Hal Feng , Chen Wang , Inochi Amaoto , Basavaraj Natikar , Shyam Sundar S K , Bartosz Golaszewski , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Thierry Reding , Jonathan Hunter , Heiko Stuebner , Patrice Chotard Cc: linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, sophgo@lists.linux.dev, linux-tegra@vger.kernel.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1163; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=SjKuvqUidPJ5fm3b34nm9zaMItl1NLBQXfR5LWGDZIg=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpZ7aJM3IeY1gDdJ/me5IBtT+aPwzcq14pNkWtM OPOQAst1h+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaWe2iQAKCRDBN2bmhouD 157+D/46tj+ZWnUE7RsMD2CztKOGVGuOYzCPiW602Pq4QhElA9PrVOh9VIyCLBB4SAqk59lZVYO MlOwyygoSEozBQN91oQ75iEXnJ2aFkB8b20ULI/EMUFnyX6NdIMSpVnIDtcXgX1RxtvmdcYlupv d08RjFjuwR7LM07n725h6qKS9ZYbGJXlWsH7hlmPWz9uaBnMvZzlvEiGRcxJvRoIWynscL9CB/e eFLs1++3wid48u19QEMpcRMV1MeZTv9QEZFnOFzKRAoK1CYtDEfXVYfNebfDK7IZVx8Zqe5vmF1 thvHVTfdbWtXtejVJI80z4+iO3us+I+e5+NIqhB1sFl/hejmicbZHh7MTevMq6l7Dx61o72dT3b BhdNFYKwza+3RNldEDuAhvQRBjg2Osn6flZIO1CR3aOlo144cLI4IOzTKuAabhDB5TNFikqrvrL 0xDWRzt5IGOfkrJc8g9H+D5W9i+gkNFuirIpoXQ5tVjSuxdX3YHfj3OMC8Y6n7eAVVx6cqYfgR6 nkcpzSTEOenPtMlHZzvr6whjmpwnN8lLQtvA85ZpjgGBavOqUfo3Q+2StXsTFS59+ZZMsU481OL hkwcnNi21sXwyD/y/MMq0KvbGR+S3+SbDRux5b96048SW88pN3twiCfZ3TKPRiPTnwc8noN8qv/ lE5bKl/wMPXzUNw== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Authority-Analysis: v=2.4 cv=YPaSCBGx c=1 sm=1 tr=0 ts=6967b6a3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=Eb9f15NH/cHKzfGOmZSO4Q==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=RIxbnQC35JVfspY8PfAA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDEzMCBTYWx0ZWRfXwddgppd8Q9UP xRp06gaFAZNc95To3RYmky4T/P0K9FCz5IpS2FhFGGynbfmLit00zEn6ne8PcdXIiOzEoaYi82Y EN6D7tAMWF9azJgTR5blretXqykz7heGPkAE0VG7nDOV7fmsxrYnF8vCysENCZG8yVHzX66owtF CypYdnMTpZd/navlZLQEmN2Q8sRYYWzUObqrQ8dnme0mOW+puNv75kg4FqL0avKLbM8mOKMKhPF vP6kKqv7TV3HxWmAsTASxNy/NCk1aUN+gzMBtoZ4ATdZ7MzufNpB4+yzx/p0WUtcigRTkPHSrV8 /tNYc1aZ26KmBBuL784DzdJx4A0ZjPvrOAGdgePosiDZWleuCp9bBV4Rnw78Qz0ic8mc3Q+r/CV KhwM28KeNy0cgPz9zlkRqEwFD5uWQ82NKwz/wiNlEpsQtr6AghaOnt0DKL+iGmewe5pUy3cSn0m lYBJxlHTtXaaX5h38kg== X-Proofpoint-GUID: T99O_OC-r8tXMUYIfbJGti1Ys6XTKsoA X-Proofpoint-ORIG-GUID: T99O_OC-r8tXMUYIfbJGti1Ys6XTKsoA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_04,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140130 st_pinconf_dbg_show() unlocks and locks the pinctrl_dev mutex, so it must be called by the pinctrl core with the mutex hold. Annotate the function with sparse __must_hold, so any changes in pinctrl locking will be statically detected. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Patrice Chotard --- I think this is still useful, although maybe a bit pointless if core explicitly always locks every pin_config_dbg_show() call? Anyway, pattern of unlock+lock feels to me like something worth annotating. I left the patch at the end of the set so it can be nicely discarded. --- drivers/pinctrl/pinctrl-st.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index d3cea3437d7f..8ce88e591f47 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -987,6 +987,7 @@ static int st_pinconf_get(struct pinctrl_dev *pctldev, =20 static void st_pinconf_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s, unsigned pin_id) + __must_hold(&pctldev->mutex) { struct st_pio_control *pc; unsigned long config; --=20 2.51.0