From nobody Mon Feb 9 01:26:18 2026 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47A9A3191C4 for ; Wed, 14 Jan 2026 16:50:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768409438; cv=none; b=kAWVsCShxZMaPlEoAbbQZxM9JmgDk7v48JWlLzLExutwasgXq/ODl186grK40yOb+AvLOEl06Xlafu7lYIQGRIycjdpZE8lZPyNmsdc18yjuXHkU9l7mFWBjLTL9BKtGdxx3zBjBdO3pGVjePqeYFrsFzAkBSIC+846wrVIkFxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768409438; c=relaxed/simple; bh=/p6n/f+kcRp3kH9AImd77ASoHcShi/7jRC9Nq/AdHZ8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=iMDGKZDG8S4z/qR45peKnKO59ZGCv5gwCanRjRFmboWf8lnDynVdQqo4ZQVNxW9cpGvGeA2iV7fl1s2WxlG3zmP5J/48Z9isoiZvVw4tONV3nAUVEZRtnpvidko33KG01PTPplX8ULeL99F8Wtgdjh2oiQzvteC9xhj1e0aDL9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=gmUPcwmn; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="gmUPcwmn" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 9599B1A2862; Wed, 14 Jan 2026 16:50:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 682FE6074A; Wed, 14 Jan 2026 16:50:33 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0EF3910B682A0; Wed, 14 Jan 2026 17:50:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1768409432; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding; bh=FZchd0EVjeZPDpfSc5KLMc9HueJ8+rJRI0TjdGf6xTs=; b=gmUPcwmnox7arbqkymc/qtB90PaAhg2we8YkoV33vJaDAMGVKGXNW90hJDwel3tDiEEtAr +uHLWRzLz1XDiruulPXjwsx9xm4pQg2Kd7H9RkI5rxIn1RrwuFZaMN3FKxLmLNO8u0OESD TNxQfePqwfX0NUA42bZUx9nQQTcGVE53LW9jQgWvxlxkfMvgPThOkS7sh5EHvH7ZZoPGC8 5eizFw6nCyGx8GM10Mvn3h9x53w0wyY+JkUvzs0iy2RRgxbHaLt0sBu/7IpNDgKn/HKSz6 Ilb5BYrkqTikoLh0a6wDrdgOqiLHwbiIf/Rb2/mORE6JjqkRJnsDwdwVKQ0Zdg== From: Thomas Richard Date: Wed, 14 Jan 2026 17:50:23 +0100 Subject: [PATCH] phy: freescale: imx8qm-hsio: fix NULL pointer dereference Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-phy-fsl-imx8qm-hsio-fix-null-pointer-dereference-v1-1-730e941be464@bootlin.com> X-B4-Tracking: v=1; b=H4sIAE7JZ2kC/x2NwQrCMBBEf6Xs2YWk1UT8FfGg7cYspNuYaImU/ ruLhzk8hjezQaXCVOHSbVBo5cqLKNhDB2O8y5OQJ2XoTe+MtUfM8YuhJuS5nV8zRhUwcEP5pIR 5YXlTwYkKBY2MhM4/rDVuOAXvQWezVtz+l9fbvv8A6zmjQYIAAAA= X-Change-ID: 20260114-phy-fsl-imx8qm-hsio-fix-null-pointer-dereference-67b110635f77 To: Vinod Koul , Neil Armstrong , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Richard Zhu Cc: Thomas Petazzoni , linux-phy@lists.infradead.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Richard X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 During the probe the refclk_pad pointer is set to NULL if the 'fsl,refclk-pad-mode' property is not defined in the devicetree node. But in imx_hsio_configure_clk_pad() this pointer is unconditionally used which could result in a NULL pointer dereference. So check the pointer before to use it. Fixes: 82c56b6dd24f ("phy: freescale: imx8qm-hsio: Add i.MX8QM HSIO PHY dri= ver support") Signed-off-by: Thomas Richard --- drivers/phy/freescale/phy-fsl-imx8qm-hsio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c b/drivers/phy/free= scale/phy-fsl-imx8qm-hsio.c index 977d21d753a5..279b8ac7822d 100644 --- a/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c +++ b/drivers/phy/freescale/phy-fsl-imx8qm-hsio.c @@ -251,7 +251,7 @@ static void imx_hsio_configure_clk_pad(struct phy *phy) struct imx_hsio_lane *lane =3D phy_get_drvdata(phy); struct imx_hsio_priv *priv =3D lane->priv; =20 - if (strncmp(priv->refclk_pad, "output", 6) =3D=3D 0) { + if (priv->refclk_pad && strncmp(priv->refclk_pad, "output", 6) =3D=3D 0) { pll =3D true; regmap_update_bits(priv->misc, HSIO_CTRL0, HSIO_IOB_A_0_TXOE | HSIO_IOB_A_0_M1M0_MASK, --- base-commit: c537e12daeecaecdcd322c56a5f70659d2de7bde change-id: 20260114-phy-fsl-imx8qm-hsio-fix-null-pointer-dereference-67b110= 635f77 Best regards, --=20 Thomas Richard