From nobody Mon Feb 9 19:53:21 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 634393A0EAB for ; Wed, 14 Jan 2026 15:57:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406278; cv=none; b=CpIVdYdn/9Jc48HVfihsceA7iZP9+siZrpQhSytKrm6SeJMouxbAN/kNFf5D2cQxV5eYTsZjx95Sgtu0RlljNHxaeLy96sXtYlsh6fJ7Olb/ojzB4m1wnzKLSD3cwVgV6Zy+75g1DksmFURuWr2p0uhgufcTpCxT03xU49HjLxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406278; c=relaxed/simple; bh=LQArxmrJrNZZsUxSMnAWJcE4cLQNPPNILpLMGRQk8pU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Y9kiK699sBTaxm4X2PJKIEckAcRoFkuYT6PbXK8ZEJwkTf0ZM0pXbE46ffL2JthjRSdn3DX9RXPaJ7BW26ajeL6WoRKYEfyy71j0Ga9Fd2IOieEwasDAi/gNn2sQ0Xbyztp1twmtcadFZfZKYi5ToNMa1ptbKxUP5t7wB67XuCQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dpERR7tN; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dpERR7tN" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-477a219dbcaso70915535e9.3 for ; Wed, 14 Jan 2026 07:57:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768406269; x=1769011069; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=i4eLrNTmJYNZqrOFXMkgnCrs/v9XFpKSoUUWAD+1qM0=; b=dpERR7tNUvQN706R+dIH7SGWutvDSRQwq/DEUiz/xqgZT2T9w9TTAQtBTujPX0Yu3O 5vrHi8j8KNTW13sYiL/rF/Af2F0gsApV+svCHXn21nmUX2+cYVPG7W8guEZuIcM9TCGy N7DeUpVU8qpwweaeLkwNrvbDuOVidHOmK0XShanp+zgUdnqasbSysbka3mMV/ZG0pI8S NVajGdLBKD0HvMSLUdu1vDzjOLKXqPQVHJuBGm0u2q/xbVymcepLgyg6C1wR4XrZQtHv MKCgeyGzS93ETiFx/P6jSON5NrKwjphMtIJqWQpH02mSFddtv+gyiuX7jCK8tjxuqa0m Uuow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768406269; x=1769011069; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=i4eLrNTmJYNZqrOFXMkgnCrs/v9XFpKSoUUWAD+1qM0=; b=FEzH1VM+WAGRuS3HSDz90Ysf8oqUBhtp3IuoxSq7bKeUjLwOM9K7Rcfu6so/POnPCd KZertjTCN+4xgiZi4l4UFFeMl8mU/eyHm6iuEOVW2QIgfCgqZotswx3efBt2/3H9Ie6d NWsRhhkZBrk1qcVsAUfgJV5Jh+9d/l/T3+sAFdiJBuyStEITKJu9AoqDdbLm5+4qs2V0 Fl9X2elF4Gay2aJsfdJkucszqcCl0N9gCB9ZBhqPqzzuw6FdLKNa6uKBFAoKRxL+e1JC fOk7QFYdb5rrP5S5+HUCPcI7w5y6m+UFXkvQrLEzEJsnPQkZM8an7DOUMo3AWUOGWBSl QjLA== X-Forwarded-Encrypted: i=1; AJvYcCVuiyCCAX6BmODe2EbPLt0ZpeEgSbicw+y2PuSAwlajkncyd34dW9+tYbrKic1Yj+7EglpVc/oh4jqHLHA=@vger.kernel.org X-Gm-Message-State: AOJu0YyOnMTmY82PrJiI/ROxr1NBHYmv6TjuDDhCfdkaeN0pYdifoOXx f6Jx2qgUv0FcqoH6LH/iA/OQAJwWAa/NAZH5cD8hOMdzKf+ynx12tJbN67HM4Bxa088= X-Gm-Gg: AY/fxX6MWHNSaHUtPXDbwCV2K11yiSEPjuLwD2tPjUk3+Ioiv084Czy+BC/HbtvHlCY uzBd5kjjTAcwSg3z+AGdk4CmjqH3Tk1SidPDzF7w8jQBQk7FLddoOzyZLpC2ZNLTKwZolOYtsZR VQ3fCGn2YsrbV+zH2ljIqwDlRcYY6RYjzhx2xFH7xLk5FPekU60DNf9Jaw8iFpPB6cCxcfVqQue 2FPDIcDoree6MSyd1TFYgqv0RTZoiCCoDEGXWi24ujEVapE2/mdbxuf4FRmyVTZAtcKBGeITt8+ Xad+QUHYGo65Vj7r5hNfSmDS1G8a05JJInArSluR5oQaeaveyfTSdNbE4aGcl2wtWpR9uMpDc1r LEorWJ6lCFdOKKkP/DVGtxBvSyMWU+DI57v9GKYjFWQE82mCLKzIS2KGSMChO7gDdAou8pL4el6 BeXwY7+01rCcgxiAIxdQcN X-Received: by 2002:a05:600c:81c5:b0:477:755b:5587 with SMTP id 5b1f17b1804b1-47ee47bbe97mr31179035e9.8.1768406268797; Wed, 14 Jan 2026 07:57:48 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee85e8807sm7426475e9.16.2026.01.14.07.57.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:57:48 -0800 (PST) From: James Clark Date: Wed, 14 Jan 2026 15:57:21 +0000 Subject: [PATCH v5 09/14] perf tests: Test evsel__set_config_if_unset() and config change tracking Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-james-perf-config-bits-v5-9-0ef97aaf1ac0@linaro.org> References: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> In-Reply-To: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 Test that evsel__set_config_if_unset() behaves as expected. This also tests the user config change tracking mechanism as it depends on it. Reviewed-by: Ian Rogers Signed-off-by: James Clark --- tools/perf/tests/pmu.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 91 insertions(+) diff --git a/tools/perf/tests/pmu.c b/tools/perf/tests/pmu.c index cbded2c6faa4..0ebf2d7b2cb4 100644 --- a/tools/perf/tests/pmu.c +++ b/tools/perf/tests/pmu.c @@ -192,12 +192,102 @@ static int test__pmu_format(struct test_suite *test = __maybe_unused, int subtest } if (attr.config2 !=3D 0x0400000020041d07) { pr_err("Unexpected config2 value %llx\n", attr.config2); + } + + ret =3D TEST_OK; +err_out: + parse_events_terms__exit(&terms); + test_pmu_put(dir, pmu); + return ret; +} + +static int test__pmu_usr_chgs(struct test_suite *test __maybe_unused, int = subtest __maybe_unused) +{ + const char *event =3D "perf-pmu-test/config=3D15,config1=3D4,krava02=3D17= 0," + "krava03=3D1,krava11=3D27,krava12=3D1/"; + struct parse_events_terms terms; + struct parse_events_error err; + LIST_HEAD(config_terms); + struct evlist *evlist; + struct perf_pmu *pmu; + struct evsel *evsel; + int ret =3D TEST_FAIL; + char dir[PATH_MAX]; + u64 val; + + pmu =3D test_pmu_get(dir, sizeof(dir)); + if (!pmu) + return TEST_FAIL; + + evlist =3D evlist__new(); + if (evlist =3D=3D NULL) { + pr_err("Failed allocation"); + goto err_out; + } + + parse_events_terms__init(&terms); + ret =3D parse_events(evlist, event, &err); + if (ret) { + pr_debug("failed to parse event '%s', err %d\n", event, ret); + parse_events_error__print(&err, event); + if (parse_events_error__contains(&err, "can't access trace events")) + ret =3D TEST_SKIP; goto err_out; } + evsel =3D evlist__first(evlist); + + /* + * Set via config=3D15, krava01 bits 0-1 + * Set via config1=3D4, krava11 bit 1 + * Set values: krava02=3D170, krava03=3D1, krava11=3D27, krava12=3D1 + * + * Test that already set values aren't overwritten. + */ + evsel__set_config_if_unset(evsel, "krava01", 16); + evsel__get_config_val(evsel, "krava01", &val); + TEST_ASSERT_EQUAL("krava01 overwritten", (int) val, (15 & 0b11)); + + evsel__set_config_if_unset(evsel, "krava11", 45); + evsel__get_config_val(evsel, "krava11", &val); + TEST_ASSERT_EQUAL("krava11 overwritten", (int) val, (27 | (4 << 1))); + + evsel__set_config_if_unset(evsel, "krava02", 32); + evsel__get_config_val(evsel, "krava02", &val); + TEST_ASSERT_EQUAL("krava02 overwritten", (int) val, 170); + + evsel__set_config_if_unset(evsel, "krava03", 0); + evsel__get_config_val(evsel, "krava03", &val); + TEST_ASSERT_EQUAL("krava03 overwritten", (int) val, 1); + + /* + * krava13 doesn't have any bits set by either krava13=3D or config1=3D + * but setting _any_ raw value for config1 implies that krava13 + * shouldn't be overwritten. So it's value should remain as 0. + */ + evsel__set_config_if_unset(evsel, "krava13", 5); + evsel__get_config_val(evsel, "krava13", &val); + TEST_ASSERT_EQUAL("krava13 overwritten", (int) val, 0); + + /* + * Unset values: krava21, krava22, krava23 + * + * Test that unset values are overwritten. + */ + evsel__set_config_if_unset(evsel, "krava21", 13905); + evsel__get_config_val(evsel, "krava21", &val); + TEST_ASSERT_EQUAL("krava21 not overwritten", (int) val, 13905); + + evsel__set_config_if_unset(evsel, "krava22", 11); + evsel__get_config_val(evsel, "krava22", &val); + TEST_ASSERT_EQUAL("krava22 not overwritten", (int) val, 11); =20 + evsel__set_config_if_unset(evsel, "krava23", 0); + evsel__get_config_val(evsel, "krava23", &val); + TEST_ASSERT_EQUAL("krava23 not overwritten", (int) val, 0); ret =3D TEST_OK; err_out: parse_events_terms__exit(&terms); + evlist__delete(evlist); test_pmu_put(dir, pmu); return ret; } @@ -539,6 +629,7 @@ static struct test_case tests__pmu[] =3D { TEST_CASE("PMU name combining", name_len), TEST_CASE("PMU name comparison", name_cmp), TEST_CASE("PMU cmdline match", pmu_match), + TEST_CASE("PMU user config changes", pmu_usr_chgs), { .name =3D NULL, } }; =20 --=20 2.34.1