From nobody Mon Feb 9 23:16:13 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31D273A1A3D for ; Wed, 14 Jan 2026 15:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406275; cv=none; b=Np8VpRjC/eERCmqrdElkdkThmNeRZbKUBtxuCoRWN6GbOM6x2a5W2AU41UIsZAG6Mxrma8GaXboYePlLn5QBaed4CB/Uwq+G7eOSZ308SDtvuoIT+G8zEAFyZCUFbQ1Vr3f/FIK69E2yt++aIOjNGGj3UYZFNSUKMA9tPyhsOHo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406275; c=relaxed/simple; bh=7YYoqOIAjjMEaf57v2iXEXgdQFmEmn/LvBsi7H9riRc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lnj8EKbuAzp9CmJkCLS6Ws2azWrcLuq9I7v574HLZV+n7DCeI85tKW+mIW2QhQ0pxGcudKr75IzKQia3uj2wZyzNz7Icz6h27lB6+kSjBMaCPOopHoMlxquyEQQ1PR0IywYy6vRRC9iYl1NusaHIUpFR3tCN3yUuP5uLCNwr8ps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xbHr3vqs; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xbHr3vqs" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-47795f6f5c0so55945625e9.1 for ; Wed, 14 Jan 2026 07:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768406267; x=1769011067; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zxU1vsfrqBADbCFBEcH8TNvakDJOOuWqCmLiru2LKyg=; b=xbHr3vqsvyaAt2sPVLgT0OQjWL38MZ3mBPBfulhizIzNjP3Cgfvgerku7PF4Mpne/F 7r2eJDaZEnq/BlYywQAY52R4FDWgU/WGqfE+cc8ZGo0vWoJQKc+Mq+Fc391+R+9dQwBf ijtGyVR75N34TDXiCViDHX8++sKI3GXb7xJ0RyE+iJJPvn1D0ChduAcci8nt8gzUk5mY RIzeb/D6rS/OzEBpcL0+z7mTEU3dStSgvAOOyzLgqi2UELQYEcw3/cZfMYAYgBoiYZRh 2HlYHkPR7DN97Jqczc6nOave0OfPYRiLDWhuc4nPkRx629YjwlxxKQCOMBHKVy9PaV3/ hhUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768406267; x=1769011067; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zxU1vsfrqBADbCFBEcH8TNvakDJOOuWqCmLiru2LKyg=; b=nJAWpzhKFzNhCzArcon3wIr1e2pcqvMf2MkJK2eaXx8QIfMCNL5pSB0NbKqLZL9Pv7 VLC9XdmcQYK4up9EB+DWXXfJR2Iz1+t3vbuf0mvf64bnoh+wgo8bt76EVZJJlUzWt1GQ 7LyO0k7674Dj2B5ggcvPulQl1jvu7zyBu0m7BBQlh3TqT47j+lIVxgvDfOW38tQBeUMr 9cUxddKduJoV0WN5Nh/YtGOHt90GQtQ/5Ug+W5l2OZmfTBIfBcLSZskkmiRUpvTszOuc 7IQAxGQkYE3PGRDHRvJX92wA1ovOXLadjPtRQ3MbhZzLsKsIdfJGM6Ggl2lv7Hq9OIqM dWcA== X-Forwarded-Encrypted: i=1; AJvYcCUEl/L9/utZ+aHSgOuLZBx0xe/A3KUz4JLbCF3YTY3Qdwaawep/Y6kooS1duNjoCFVCbpbwQeqbwf2wVrA=@vger.kernel.org X-Gm-Message-State: AOJu0YzS0CDZldrg6qm5aRzvkfydtWf/oHNIVNIsaAlK5mnpOYyw2e7M AO3TJGkAxgSOg59kpZPsAfCDKP2X7+CkbKi1HxO4s47cs26JYstUgOzRr6ZkxP+ZNxo= X-Gm-Gg: AY/fxX7mJIF7obAdPesvTWlbnwx+GYuKRR5DssqitlAiu1Oaa3t8O8neUkvZGYE79vZ xvsiBn68vGHvtt5tFvCjGxo52p3MQCUJgOrUb2dG7uDpCf0NHXRISK2mZBstL3gXwaEQBqvF6+E 9yf3UgHdRt/jwv9SjRleu1OR92/7cmvo+xe/Grc2/axkrwvrmNPPgGC7/rG6JEEJZwwvlZdYleb 1Om0xHWlDWccwRO8IM+mFvSsiyUZI/QPBOwWmjgtreHXfaNSlbDQ527oE/G4CaGdKT9+g2vFIuR C733XpbdTHtukkbBQioqG6dCJc8jLV2wT00CAvJgTqRWxvXVncpUr72deOOwD0OuB9aXZq5AxoV dIw6cOUNyysHYQDrs4FetJ+j6sQg1w1BBB+tn4xx1SJRZZ66r/YVyiet+6SWHBR96n4Gn5DsWfJ ufE9pRd7wLK8zl2z9McjMEL9n/nEHs5Zc= X-Received: by 2002:a05:600c:3544:b0:479:2f95:5179 with SMTP id 5b1f17b1804b1-47ee335494fmr40564695e9.15.1768406267278; Wed, 14 Jan 2026 07:57:47 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee85e8807sm7426475e9.16.2026.01.14.07.57.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:57:46 -0800 (PST) From: James Clark Date: Wed, 14 Jan 2026 15:57:20 +0000 Subject: [PATCH v5 08/14] perf parse-events: Always track user config changes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-james-perf-config-bits-v5-8-0ef97aaf1ac0@linaro.org> References: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> In-Reply-To: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 Requiring the 'pmu->perf_event_attr_init_default' callback to be set to track user changes is a bit of a trap to fall in. It's hard to see that this is required when depending on the user change tracking. It's possible to want all 0 defaults so not set it, but at the same time still do some programmatic setting of configs with evsel__set_config_if_unset(). Also if a PMU reverts to 0 defaults and deletes its existing callback, it will silently break existing uses of evsel__set_config_if_unset(). One way to fix this would be to assert in evsel__set_config_if_unset() if the changes weren't tracked, but that would be a possibly untested runtime failure. Instead, always track it as it's harmless and simplifies testing too. Reviewed-by: Ian Rogers Signed-off-by: James Clark --- tools/perf/util/parse-events.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c index 1f6e2213326d..c8f2962a06c7 100644 --- a/tools/perf/util/parse-events.c +++ b/tools/perf/util/parse-events.c @@ -1528,12 +1528,8 @@ static int parse_events_add_pmu(struct parse_events_= state *parse_state, return -ENOMEM; } =20 - /* - * When using default config, record which bits of attr->config were - * changed by the user. - */ - if (pmu->perf_event_attr_init_default && - get_config_chgs(pmu, &parsed_terms, &config_terms)) { + /* Record which bits of attr->config were changed by the user. */ + if (get_config_chgs(pmu, &parsed_terms, &config_terms)) { parse_events_terms__exit(&parsed_terms); return -ENOMEM; } --=20 2.34.1