From nobody Mon Feb 9 19:53:03 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879993A0EBD for ; Wed, 14 Jan 2026 15:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406273; cv=none; b=MjJkoIOzkbVKqr/WiwXvkIV3LIJ/7o272Yt7/w292pJVUscFD6mCExJJgCGWM3dLmwgNqcSNowT09tV7iJOfwTlc3m+xuv1KhhAhNarftEAhg4PO2CQbjAAQCBpnhUYM0qL2tkPLtJTniw+25IGu+/ofsIA/8ldD+57Y29UxA2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406273; c=relaxed/simple; bh=bFg7g/rn24qLdzh570J873Kf0e3eYeBHP3QCYLVZR+s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qmG4YPT3mGJRuRHXUCAitUeiQAj7bfqVyQrmGBXql/+2wCIaJ6MBBLtnvy6YxcDf8PC9b8Khvsw8nOs44yyUVpgKtmPZhnd2/YvcI0n28Krxporpz74ENeCaAhGci/oXFitXl8y1NMz6vcvqyHhWG9i6j5zTjbQJLlf+gstpVfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=x6H5CLCx; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="x6H5CLCx" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so16196665e9.1 for ; Wed, 14 Jan 2026 07:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768406266; x=1769011066; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OmYihNLb0KLD+tzX8PoHToNOa0/csgr96GD3/RY6Ics=; b=x6H5CLCxt8gx3FQoYWwBm8/ImKpbtsXbRPiNsQwzfP281br+bWun++8VIMsa825uZi LDwSX/6RBn23K8dh3bcfEM+kWgpsHJf403krS9FZHetc9Mc4A+HOT9GSaF2GQ2mjdGOb /jK63BDqLHutKlYgEFrrFK2oJq0NXl3TPM2t6LGmo6XHjIRWgoXh+1Vp48MVlhx2R9Vd Vrcy4jHodkzEYHYzf62UxYrCYU4yfM1oe3onguEe+vBcUIM7/KxYOgHzyNHMx5aeqS21 1MHzb6MkGmbnSEpSzFQjVk016YtcaE3WZuifOTD2slpid+vQV2wBJt/14r12aH2to2zd XGnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768406266; x=1769011066; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OmYihNLb0KLD+tzX8PoHToNOa0/csgr96GD3/RY6Ics=; b=hP6iCEZhYyxRdyiPI0fqCpMlewRiUp2319T3KIkLVZjTQJHKBqdxXhMWsNIl8v+DVK D49j0xK7SW/5uImzlvffgaS+iLNYIzbeOhWK6lBGtajxTSAQHfDA/SKkotSUJVOuXjl4 Gd+sdtXL+FgYpnfAG+Iys7ik2xhLLYl29NvBVlT8dcfF5KUwp0tzMOf5oPAnHvXIAmiY N3b7hsKVfbJQbAALqMaupJdOhK9NIVN1c93qp6EQVzxV0AeF11QT9bdrD11FZVwyRbVK q5Y4g1gci8jhAok/+JBwITIJM0C+I9Srt0EJPgvpXfRmqTZ0iJUDbzcVsc/f4O1MNYbV M4UA== X-Forwarded-Encrypted: i=1; AJvYcCWMzOt15MhwKgjr/0T1P083OyhXAgEJI6Nu6birWOvOMz4J7hcCcvO55kOoI1Uh6EybuQ6ntoUW/2fNX2w=@vger.kernel.org X-Gm-Message-State: AOJu0YxHycEM3YjwYSpI+1d/dMI2VRm3sQS2q2LAh3XRhqX+umil5IDY BuH1hUjn/ViZwdKz6g/6+e4ZnNY5YSndMoP3ZfimrL34UChI7fBvjrU3MxgrRLt3vmo= X-Gm-Gg: AY/fxX4YC5vvPOiNOdYjmRLz/skJzppWBrN5QujObsAGXCrye/cccaBQGh5/eM/e4X/ abPkt+77EopwfLTFqESI2QZlxAgbOJitNxljXmH+zEc0+Hw37B9zjhvscfn8hwiVYK368OK92Un JJ6cAn04oJgv744DGke6ET4E7XH5h7Tps94RJYtrZvroZbpAxkVsrKIFAE0qx0P4fCeYHjzWiU7 vImpd3lo5pKMPgbe1rj3MourmO7tSKDjvmyYaY7ILpqwPoGx2snU5dxeyOA/6WUxjlCbyjEl55X gcFY6+j5/o64ckR35o7uU6EAHaB8bMf9XeV7YemUsY0KnJD2dYtyEpm1D69A8ioh10aAOXtzXCo 4KuBsvSDlm9qa/x7n2BLJvvJmePhb7HcnHcpc5OLImqLz32m7eiC24tgjJ70x9akq71fbZO4Qwt E1LL+XuHHVJjTbxlrHjfVB X-Received: by 2002:a05:600c:4f0b:b0:477:c71:1fc1 with SMTP id 5b1f17b1804b1-47ee4819f30mr30484755e9.19.1768406266018; Wed, 14 Jan 2026 07:57:46 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee85e8807sm7426475e9.16.2026.01.14.07.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:57:45 -0800 (PST) From: James Clark Date: Wed, 14 Jan 2026 15:57:19 +0000 Subject: [PATCH v5 07/14] perf evsel: Add a helper to get the value of a config field Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-james-perf-config-bits-v5-7-0ef97aaf1ac0@linaro.org> References: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> In-Reply-To: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 This will be used by aux PMUs to read an already written value for configuring their events and for also testing. Its helper perf_pmu__format_unpack() does the opposite of the existing pmu_format_value() so rename that one to perf_pmu__format_pack() so it's clear how they are related. Reviewed-by: Ian Rogers Signed-off-by: James Clark --- tools/perf/util/evsel.c | 42 +++++++++++++++++++++++++++++++++++++++++- tools/perf/util/evsel.h | 2 ++ tools/perf/util/pmu.c | 35 ++++++++++++++++++++++++++++------- tools/perf/util/pmu.h | 4 +++- 4 files changed, 74 insertions(+), 9 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index 3162bfc0ccfe..ec74dce3211c 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1378,7 +1378,47 @@ void evsel__set_config_if_unset(struct evsel *evsel,= const char *config_name, return; =20 /* Otherwise replace it */ - pmu_format_value(format->bits, val, vp, /*zero=3D*/true); + perf_pmu__format_pack(format->bits, val, vp, /*zero=3D*/true); +} + + +int evsel__get_config_val(const struct evsel *evsel, const char *config_na= me, + u64 *val) +{ + struct perf_pmu_format *format =3D pmu_find_format(&evsel->pmu->format, c= onfig_name); + + if (!format || bitmap_empty(format->bits, PERF_PMU_FORMAT_BITS)) { + pr_err("Unknown/empty format name: %s\n", config_name); + *val =3D 0; + return -EINVAL; + } + + switch (format->value) { + case PERF_PMU_FORMAT_VALUE_CONFIG: + *val =3D perf_pmu__format_unpack(format->bits, + evsel->core.attr.config); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG1: + *val =3D perf_pmu__format_unpack(format->bits, + evsel->core.attr.config1); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG2: + *val =3D perf_pmu__format_unpack(format->bits, + evsel->core.attr.config2); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG3: + *val =3D perf_pmu__format_unpack(format->bits, + evsel->core.attr.config3); + return 0; + case PERF_PMU_FORMAT_VALUE_CONFIG4: + *val =3D perf_pmu__format_unpack(format->bits, + evsel->core.attr.config4); + return 0; + default: + pr_err("Unknown format value: %d\n", format->value); + *val =3D 0; + return -EINVAL; + } } =20 void __weak arch_evsel__set_sample_weight(struct evsel *evsel) diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 2cf87bc67df7..95c4bd0f0f2e 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -575,6 +575,8 @@ void evsel__uniquify_counter(struct evsel *counter); ((((src) >> (pos)) & ((1ull << (size)) - 1)) << (63 - ((pos) + (size) - 1= ))) =20 u64 evsel__bitfield_swap_branch_flags(u64 value); +int evsel__get_config_val(const struct evsel *evsel, const char *config_na= me, + u64 *val); void evsel__set_config_if_unset(struct evsel *evsel, const char *config_na= me, u64 val); =20 diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index dc5dab69151f..bb399a47d2b4 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1337,6 +1337,26 @@ void perf_pmu__warn_invalid_formats(struct perf_pmu = *pmu) } } =20 +/* + * Unpacks a raw config[n] value using the sparse bitfield that defines a + * format attr. For example "config1:1,6-7,44" defines a 4 bit value acros= s non + * contiguous bits and this function returns those 4 bits as a value. + */ +u64 perf_pmu__format_unpack(unsigned long *format, u64 config_val) +{ + int val_bit =3D 0; + u64 res =3D 0; + int fmt_bit; + + for_each_set_bit(fmt_bit, format, PERF_PMU_FORMAT_BITS) { + if (config_val & (1ULL << fmt_bit)) + res |=3D BIT_ULL(val_bit); + + val_bit++; + } + return res; +} + struct perf_pmu_format *pmu_find_format(const struct list_head *formats, const char *name) { @@ -1379,7 +1399,8 @@ int perf_pmu__format_type(const struct perf_pmu *pmu,= const char *name) * Sets value based on the format definition (format parameter) * and unformatted value (value parameter). */ -void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, bool z= ero) +void perf_pmu__format_pack(unsigned long *format, __u64 value, __u64 *v, + bool zero) { unsigned long fbit, vbit; =20 @@ -1496,23 +1517,23 @@ static int pmu_config_term(const struct perf_pmu *p= mu, switch (term->type_term) { case PARSE_EVENTS__TERM_TYPE_CONFIG: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG1: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config1, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config1, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG2: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config2, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config2, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG3: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config3, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config3, zero); break; case PARSE_EVENTS__TERM_TYPE_CONFIG4: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); - pmu_format_value(bits, term->val.num, &attr->config4, zero); + perf_pmu__format_pack(bits, term->val.num, &attr->config4, zero); break; case PARSE_EVENTS__TERM_TYPE_LEGACY_HARDWARE_CONFIG: assert(term->type_val =3D=3D PARSE_EVENTS__TERM_TYPE_NUM); @@ -1650,7 +1671,7 @@ static int pmu_config_term(const struct perf_pmu *pmu, */ } =20 - pmu_format_value(format->bits, val, vp, zero); + perf_pmu__format_pack(format->bits, val, vp, zero); return 0; } =20 diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h index 7655d996090a..7ef90b54a149 100644 --- a/tools/perf/util/pmu.h +++ b/tools/perf/util/pmu.h @@ -279,12 +279,14 @@ int perf_pmu__check_alias(struct perf_pmu *pmu, struc= t parse_events_terms *head_ u64 *alternate_hw_config, struct parse_events_error *err); int perf_pmu__find_event(struct perf_pmu *pmu, const char *event, void *st= ate, pmu_event_callback cb); =20 -void pmu_format_value(unsigned long *format, __u64 value, __u64 *v, bool z= ero); +void perf_pmu__format_pack(unsigned long *format, __u64 value, __u64 *v, + bool zero); struct perf_pmu_format *pmu_find_format(const struct list_head *formats, const char *name); void perf_pmu_format__set_value(void *format, int config, unsigned long *b= its); bool perf_pmu__has_format(const struct perf_pmu *pmu, const char *name); int perf_pmu__for_each_format(struct perf_pmu *pmu, void *state, pmu_forma= t_callback cb); +u64 perf_pmu__format_unpack(unsigned long *format, u64 config_val); =20 bool is_pmu_core(const char *name); bool perf_pmu__supports_legacy_cache(const struct perf_pmu *pmu); --=20 2.34.1