From nobody Mon Feb 9 17:57:31 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD50E3A1CED for ; Wed, 14 Jan 2026 15:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406283; cv=none; b=qmf8DLbpmgU+N7bP38G42nd3MGrrn1Ijr9LcVNGMoXbQMbJhr441hGODOxMaM8YCsK3iszqiTGdG4LrlXFKAnC06T76hLJPnDR7vX7CZQYbHMLCHO7siIXnkiUgIbroWrImh36Rj2+/KDawpu42Bxqr0t1suk7DejVO5A6XYIao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768406283; c=relaxed/simple; bh=qfRSou8Gjtk8a4ox+K4x5qRrVK3aLa89yRlL85yDPKk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hkr5eZvbNqTUUIGpvdROQNAk79TESJkqbPj8HVG2vxZHPFHXWe0kCfftfieZ6IGJW3o+WgJAZU8L3WqBIvjNmqMiGL3eWyrmuJv0XUAFEbNvazLgyq7sx7aIMMJ3yQIFWoMce9zYF0fPtMGe1xkYYgpMaXNG1RuBf6MNkdeQrtI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vhTHSKfr; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vhTHSKfr" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47ee76e8656so8085e9.0 for ; Wed, 14 Jan 2026 07:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768406275; x=1769011075; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2jQ8W5nzp73oSPJlX5Jug7ze2sl2RQ53Mf0/SiitI2Y=; b=vhTHSKfrbpifs1jJvOhR32u8/UWoaS1EQTayJqLM9R0NYoVpL/KoSLLOAZj4HOGW4s VPbj36GJbaVohaA4jDQyP8tjZCaP7sqYKvBczYh8kfGzaiq8i0J217REeMLCn7YVdPWf W3ACmWSmLfdUCjD/vHID8KVCT4q2qSzE4KFsE2mgElOuQHIOvFj9mdkjyYNsdUOZ4DM4 vdBF4K+8WsPSLAFf/DKvRIEYxYaAfyRQZpjeLkUIQEIHISKcVNEHB7f9golLVmC6z8vp /RbH5REgVis7Ns2n0ulOTjZeUi3PR+KqVBG+JcQD++vMqNwMmWR/0QGG/zB99bQ4TCAX hezg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768406275; x=1769011075; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2jQ8W5nzp73oSPJlX5Jug7ze2sl2RQ53Mf0/SiitI2Y=; b=erqXwHecHnyAqB+oXlhTsmsBqUtsSYpGK8LcpQD9ci0hErEUdpXuoyGwoYdanvEUOG QpcbwIWAo5+bX8MI0QEe8D1GWCIm6BuorjmZXAmI2vKP1mKUivgpbMhaEMIhmRV3/zSN jySmW/o10OHYww9cV12o+TFg75jA9OLIYcvvwD9J4EQLI+fdCEw5jhUAYGKe9iB7vyhh 3W76XoKUKuNvPpustIV57+sP/lnS+2oBmaTBtq4B+pk28wjX5yxZO+nfOmWds7Kk375D Bq/S3YKa/gGETBD71yJxrvyzHzBa0dRyOd1P2xWkkjab9CAhbF8aZM3KlArT+US6IuOw /O8g== X-Forwarded-Encrypted: i=1; AJvYcCVYRIhHCg+zJ2+zlnnFn59k90dxxBuxnyz4a1KXoW58mKshWYuw5B26UWZSIwRipxlADT+ah+2OkZmMsdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzGNBuseDibbtPQhKogzJ5nzJORydXKndG4Q4PNmlY8uhvX8TnG 1U0Sw1OWEJ6WyFGeUcb6O177bpwMHZbitxZ4yIx5LRCse66AruBD5jpuVraVfYDhDkk= X-Gm-Gg: AY/fxX5Q3W0z++NQ1eKgMOFtxWdj1TPFIsol6KOQNzI8ihyEp72iJ+rTonGxdvRSAfC s6ZJHGID4IMDPU+zuZ0vNIxymBBionmpZEvaWACzxkXAK1gX4ZwGbHDKsHHuXAT85TTXPHPxPig 1JJoc/IEHmZ6apDgJzDRjXNr85Ss3NqQIjN8e2FxH/nHYI65kVUB0nPhXln+JSvRYIrET2ZUTGW MAod7hqA14vNpvR3RpDAhuZvCpqxkjT2yx/pcsnk6zrFgwM+jiJ5GXZ13IXfZ39lDC4dbVkUwqZ TuwGQORuNg4CZ8YOxXn8v9F9GHIxULC9+93EDtzldjWqSXbCktpqVhodkVD00QTsD35YTsv+j84 WkPDB5o0v3CVC0lsbhIKO5g38CiiMT8y3VMC1WO+iXqv8ZXW5I9OXy4OoWxP5Ti9PV3JKFxvqMT 5qmD8XMelnH/g6dS0n+c1y X-Received: by 2002:a05:600c:1c15:b0:47d:3ead:7439 with SMTP id 5b1f17b1804b1-47ee339e454mr33949925e9.37.1768406275018; Wed, 14 Jan 2026 07:57:55 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47ee85e8807sm7426475e9.16.2026.01.14.07.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 07:57:54 -0800 (PST) From: James Clark Date: Wed, 14 Jan 2026 15:57:26 +0000 Subject: [PATCH v5 14/14] perf arm-spe: Don't hard code config attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-james-perf-config-bits-v5-14-0ef97aaf1ac0@linaro.org> References: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> In-Reply-To: <20260114-james-perf-config-bits-v5-0-0ef97aaf1ac0@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.0 Use the config attribute that's published by the driver instead of hard coding "attr.config". Reviewed-by: Ian Rogers Signed-off-by: James Clark --- tools/perf/arch/arm64/util/arm-spe.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/u= til/arm-spe.c index 51014f8bff97..17ced7bbbdda 100644 --- a/tools/perf/arch/arm64/util/arm-spe.c +++ b/tools/perf/arch/arm64/util/arm-spe.c @@ -256,7 +256,7 @@ static __u64 arm_spe_pmu__sample_period(const struct pe= rf_pmu *arm_spe_pmu) =20 static void arm_spe_setup_evsel(struct evsel *evsel, struct perf_cpu_map *= cpus) { - u64 bit; + u64 pa_enable_bit; =20 evsel->core.attr.freq =3D 0; evsel->core.attr.sample_period =3D arm_spe_pmu__sample_period(evsel->pmu); @@ -288,9 +288,10 @@ static void arm_spe_setup_evsel(struct evsel *evsel, s= truct perf_cpu_map *cpus) * inform that the resulting output's SPE samples contain physical addres= ses * where applicable. */ - bit =3D perf_pmu__format_bits(evsel->pmu, "pa_enable"); - if (evsel->core.attr.config & bit) - evsel__set_sample_bit(evsel, PHYS_ADDR); + + if (!evsel__get_config_val(evsel, "pa_enable", &pa_enable_bit)) + if (pa_enable_bit) + evsel__set_sample_bit(evsel, PHYS_ADDR); } =20 static int arm_spe_setup_aux_buffer(struct record_opts *opts) @@ -397,6 +398,7 @@ static int arm_spe_recording_options(struct auxtrace_re= cord *itr, struct perf_cpu_map *cpus =3D evlist->core.user_requested_cpus; bool discard =3D false; int err; + u64 discard_bit; =20 sper->evlist =3D evlist; =20 @@ -425,9 +427,8 @@ static int arm_spe_recording_options(struct auxtrace_re= cord *itr, evlist__for_each_entry_safe(evlist, tmp, evsel) { if (evsel__is_aux_event(evsel)) { arm_spe_setup_evsel(evsel, cpus); - if (evsel->core.attr.config & - perf_pmu__format_bits(evsel->pmu, "discard")) - discard =3D true; + if (!evsel__get_config_val(evsel, "discard", &discard_bit)) + discard =3D !!discard_bit; } } =20 --=20 2.34.1