From nobody Mon Feb 9 19:30:21 2026 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE0E538B98B for ; Wed, 14 Jan 2026 10:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768387430; cv=none; b=kw/fTZe1j5h0CEyTMFokLMqYmruoa+t4eOlPEO89U7Bbpf2jrH/2J+m+ezb6Ilf3Xuq2YeMvwCs3rYMwsjYKUhn+IyBx77hfsF0Yhkl7JdLK4ggT6w621SA2tPrWI5TJJst9pk9UFEb9MHbK37JT9JPrwHIdYZj4i9Lp/SsJhOs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768387430; c=relaxed/simple; bh=4okCO5nn232mOuyf3EnlQ/xwKykNnPdvcOnvM4JNIi0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aqQ6E15fiPnadHNtiFIvkNLWUdvwaIBPR1IToKtxxpK94aQGAJyd5SC4HzFRKQ9MYKqbJCh1ldVIYRSv4NCfUMSjLqm7rWblYMdmNtZsb+TAGjkfls2qQ20zR9vEjP8n8ocyNoC7EGZDJLkZtMQF9GAWekt9dkHj1tOnMMGKiT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sub4afOo; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sub4afOo" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-42fbbc3df8fso4632746f8f.2 for ; Wed, 14 Jan 2026 02:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768387423; x=1768992223; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4so0a8WT2CR2TaRPtxXWnlX+M8XXOTE+f9HZTDZHm2s=; b=sub4afOoxjlExZZEGz/D9AYpG+djqRjDa6MHoJBTFBg/MJiaI84eJOOqf60fhEQwuM Dji2cucxLsSazIt0imf40hyArYnKI6T/RlcM+kGCgJGYF9y3Ogc4IjWvQmfRmjEZo5Ya PVoCuA2n9kiDNvqWyGpCLG7rTMUOS/lZx5WBxIz9vu3p9FWEltjVdgzN+Lk9X4A4owGk pIhsrOzup5cTNATs/Tco8L6ufC0xe6rQ08zy1tVLoqUXryTdmaDNERwLQ9c4nbc5OeFN FzBJN89p32yOrlNX2a3vESEyHhRGrlPw+KvHDdeo/8O0YccuExfuIHkiYM1fkkrf6u1f Zl5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768387423; x=1768992223; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4so0a8WT2CR2TaRPtxXWnlX+M8XXOTE+f9HZTDZHm2s=; b=L9TSGxi2IEoV4FD8qrFhG54fTX9sdToaW8PIOgruYbPXyS55i1nKcBj6gSgQv7T533 Dj+WBLrtlaNZUM/u7hLVWDq6xZv7B/g65hcjAKC7BGNLL1hnZWSQDm0XVM5VrvMpbCby CYr+kkMAPi5l4V9kPyOrP2uwdXqukZmp5qaKBtpiOVHYajDFPTZv6HU+XgPCK1caO44S a4UsgdH91wslzXm0bTRCX7kxZCsWcc/DaInIZ34KSe8Su/rz+SWpj2AuXwMyGqdQSC+U KNGU7EeVUi/5YfuzqzeoD2LiNbUinKPn0F4Kj0HTFPCG/naaYgNaLapxColP4PMeFMkG RFYw== X-Forwarded-Encrypted: i=1; AJvYcCW31lfNyb1MTTVNF3E02NGIfrZ+QQIwDiBTK16HXi0W1nXPky4SEgc8cHP0nXkltkxSNRXSf+8G6UDoLOM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3rDUfkeVUHFezI2j+XN8i2M0CCLVYWKD5M08JKsisnrHghVOX BAVFPElClQ/RStWKjVoCfE4VCtllQDxU9a1S1h9t7MYOIGYx2rWkHKg3dXZo4WKSA3o= X-Gm-Gg: AY/fxX6HugeOuZWyeSkQdaGZJd4cDhRNmKISlLg/yDza1LbDU3+IutWtdNQJgseC26k dyf63pacNoQrKbG3gdvOGpD6n13D5l1SNu0jUUPh/8plorRq4v6vTNWIlOnUtRNGq3d3fhsG3gW grntmKr69U2ypijc47jTP/ITKdKg15HPTf6lYQJumfCsZOjPeHqFa/pihdNd9KhalE4sQfjUqsY r1A6EvrKhEBWvmgLjdbg98x8eWcs2fdigChp1PPfGmAvVtrj5IBUgBGDN0gnBZ83KZRsDMu6R87 Y+1rWxdTEXw0Fc/cgo0ONMODZvcWD1FfwQJh50kyqRA+NGjCmn7kjNLI+KA/g3gxViVlev1V/hh uw6ZewHMtE++EkqZsjVkmzz36V6dwIK3jdAFxRxDpInjfpRM6MCqyW++lyuWBbz0wMjvUFO5/IJ 4e+coghcChaLDB4qVXdUxR X-Received: by 2002:a5d:588d:0:b0:432:851d:35ef with SMTP id ffacd0b85a97d-4342c547dbamr2693184f8f.42.1768387422890; Wed, 14 Jan 2026 02:43:42 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:f2cc:bd72:2de3:86cd]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-432d286cdecsm35818726f8f.7.2026.01.14.02.43.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 02:43:42 -0800 (PST) From: Jerome Brunet Date: Wed, 14 Jan 2026 11:43:12 +0100 Subject: [PATCH v3 2/2] arm64: dts: amlogic: s4: fix mmc clock assignment Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-amlogic-s4-mmc-fixup-v3-2-a4d3e136b3f2@baylibre.com> References: <20260114-amlogic-s4-mmc-fixup-v3-0-a4d3e136b3f2@baylibre.com> In-Reply-To: <20260114-amlogic-s4-mmc-fixup-v3-0-a4d3e136b3f2@baylibre.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Xianwei Zhao , Nick Xie Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1920; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=4okCO5nn232mOuyf3EnlQ/xwKykNnPdvcOnvM4JNIi0=; b=owEBbQKS/ZANAwAKAeb8Dxw38tqFAcsmYgBpZ3NYatEmmShZe3hPb4vYNDwK6REixcdUgkwbM 7DeSvwXB76JAjMEAAEKAB0WIQT04VmuGPP1bV8btxvm/A8cN/LahQUCaWdzWAAKCRDm/A8cN/La heV3D/4kz6OAG4nqNZrPcYi/eDYNZS74ELTkhDDo4ERom0PQCUECsVyo5vn7l8IBKFvvqqsWQk+ M5NzJb01Nz7F6xPZZYX/kfAEW/Ck8M5dnYntGlDw4Ql/wAYOvvXKH3VN8oyQhM85pyK4VNAYyGN /fQ9UjWakylCiuu8MFMpw9HT1NS8ZIiKPDEA/OKskz7BxDAz3B3IDW8Yqy8c0GVU9qJNaEflgSh uVjPN0P8Xfw7SYgs0oonjvPqIzI5GLPW22tVYGyPQ9alKBs/W1tJopHGRPGF0oYGKadvYm3IEJm 1ahCcoqEQprH+jIH5/0nyWLz55KwfZAgz9+0bD0OLmIkmKyFfC1mS9TCdHqokQTTJkzkPt3d7xX xgkArQtY626XXF7dw5GFHmNM0Mk+PWWsC0X1r1oHTexWL8xC8Peb0ZEvVXmIIq5evyDJsjdXWsG 0xyezinOjekluDa8T6AX2g6UvBcKz0YtPTcw9q2je9e2uQ4TinMGdMtwcSzRYxIZcT5R0l6lFSC vbXXBzqlh+sLWfWgHU31GERsUI+XGwC4IesAHUa3PuBtP78rjRc911BpPGB1mTB6Q9he0ktwgUA vckGo1SoVivU0dqGjprYsv0zOhdjwE5LvKgY0d7q0t1WOIFTVU2QaMz3py22fL4sC3NV2OObaV6 boYyUgagUYVU18w== X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 MMC A and C are mis-represented as having their "clkin0" input connected to xtal while it is actually connected to the MMC clock, probably in an attempt to provide 24MHz to the device on this input. Fix this and assign the clock to 24MHz to actually provide the required rate. Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4") Tested-by: Nick Xie Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dt= s/amlogic/meson-s4.dtsi index f314f07062ab..dfc0a30a6e61 100644 --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi @@ -819,13 +819,16 @@ sdio: mmc@fe088000 { reg =3D <0x0 0xfe088000 0x0 0x800>; interrupts =3D ; clocks =3D <&clkc_periphs CLKID_SDEMMC_A>, - <&xtal>, + <&clkc_periphs CLKID_SD_EMMC_A>, <&clkc_pll CLKID_FCLK_DIV2>; clock-names =3D "core", "clkin0", "clkin1"; resets =3D <&reset RESET_SD_EMMC_A>; cap-sdio-irq; keep-power-in-suspend; status =3D "disabled"; + + assigned-clocks =3D <&clkc_periphs CLKID_SD_EMMC_A>; + assigned-clock-rates =3D <24000000>; }; =20 sd: mmc@fe08a000 { @@ -848,13 +851,16 @@ emmc: mmc@fe08c000 { reg =3D <0x0 0xfe08c000 0x0 0x800>; interrupts =3D ; clocks =3D <&clkc_periphs CLKID_NAND>, - <&xtal>, + <&clkc_periphs CLKID_SD_EMMC_C>, <&clkc_pll CLKID_FCLK_DIV2>; clock-names =3D "core", "clkin0", "clkin1"; resets =3D <&reset RESET_NAND_EMMC>; no-sdio; no-sd; status =3D "disabled"; + + assigned-clocks =3D <&clkc_periphs CLKID_SD_EMMC_C>; + assigned-clock-rates =3D <24000000>; }; }; }; --=20 2.47.3