From nobody Tue Feb 10 05:45:20 2026 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B64537FF5C for ; Wed, 14 Jan 2026 08:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768381058; cv=none; b=q44v+Qb+U69w3EiQeIdvxWxCDg7/KKSFI3f57QprT9WCFoYlLzFIvnxu6AF8CiDoOiP4YcrQhQI/lJAxXHwi5cVTqcQxxn6vIUp3vwVl25PJlHtPJM94WNbb0qziMGtHNo1btpCjBIKCkvLwMsjflE0rTr6IL1ded3pV3JWbep8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768381058; c=relaxed/simple; bh=r6xTJIIhs4KBJzOofj3YmS5sCR9M9eszyosDM0nO4jw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ea7j4Ce3tIRrWrooM485WPzftz+iMXifnzbcgnIhdpoECayH/CZ6CQuKy1Y/GMT2ylrdnqpuDRdZzWaHguxW7LrJjIQaMj5CsG+Z8lWoodHT0gk5gzji/eqwQfRYZ6ftDkqdzzq6z6Frr8qbHhGFY04FOWn7qi75voIfTiVRgfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=HTSwrF96; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="HTSwrF96" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-432755545fcso4931856f8f.1 for ; Wed, 14 Jan 2026 00:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768381046; x=1768985846; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mbpaa7L+YJuoLVfHbsYDx/DJv0PXVpPmjwlFSpBUWBI=; b=HTSwrF963PXV+2QhZ+sePGNUcbH601Oz+JjqY/eR2cOSqxVOnMvYal5udW3tp8DCa0 WObUPBfwFOCVabicefMFwVPzeCtkscWK5dmWv+/wcIvrelPHoFyQb6dI6mqp3R/BFJUq eppZLzsTvLs3C0kUgvW2XCFZyk/LU1v5D6ewPTqDZwgMnPi7Iuql7Tr4VK3Pck87UL8i dQVUl0bf1ZGreTYsjkhrdVLJi5N3XqypsnAXNzDf6g2LfDIvefOsF1M2zsgoCg4L5NcT hCXvVaTZyU7HHRD56Cct8fpP11liyHPKqmiM51va66/8ZofgM+dwv+Lo64y/ECIQv8E7 p64w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768381046; x=1768985846; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mbpaa7L+YJuoLVfHbsYDx/DJv0PXVpPmjwlFSpBUWBI=; b=wgZq63z++7bYBLI7eao7Q6g/H7XTURF0Oh/9vMwJ54arrGnb5d9fcjBp/dzZDcg4QI J/b/Vy5jJ5l9qz3p8sPFw6y6mDudrRdQPwdfuuiasrZmNO42uQaOcHKXHvudKYuExUMS NcsT0lMd3grvWqXInw8zTtmlvNL5jBRAfmzO2I02SLkibSbX7hbiJJCSbeKbxmyzuJAa 5orScIitAzTFYccnGnoJepsxxfWrUeP49j+Zi9htPdmayAOeBxD639XOM2SnR4ckFztW /0yry3Y6ZGw+UZ6Id3A9BksfnAboZqhxcHcubzby7cxeL93Ybs57/CEQAnmvVJmzoSe6 ckJQ== X-Forwarded-Encrypted: i=1; AJvYcCXHHSkTKqbHWdxEYxF0TvRYzrmDbCkZlH1F+xCiTBO9z+qsLMMShhJGx0xJ0PiKJdOIm54stSygm2czZww=@vger.kernel.org X-Gm-Message-State: AOJu0YyP5FmfwlkMmtGlOqBsWci5ZIrMaNIrRmwKv9NQaJMAoqTRtaPp 8ALOzRqRt/wWKhV2LZAibTIApHXpkSDIBGxJYDlXmeuZjCQV6lhra2pwatw9RCja+8A= X-Gm-Gg: AY/fxX5p/90LLZhOLgi2lCEIwgYV0CZuPdDXluxO2DBuaAtn6SJ4/VvFBAoAMW2zAEy 9+r50UE2SsLK2tllfb+w0qE4gMRVgye0kR0ZkIIHe0m+Cr/tdLDB3wvJ+dqWwMqG09v2aTXKWN+ 5Uj9HsxAzq84bGNZXZ43ccbZ+wn4eSQf5gE8YsKPAvPOFODD8aRKdZTpvEFZE6jseu9zK7y6Iqx n8lw4y3JjlpbB5KFxMHhp58Q+BGCerPEsiy7hnv8t5MJpQMAllhtgS11waq7RLK9Ex31FCCdhek sQs2My/GdGdsIRNg71V+S1VF5kpQZ+hkE5zGBNJwudGu+7y1pmSGmTksfJKKM6EqcsKyNqCa/6q UhFBkVNQ4OqpdQo/Tvawe7gn+c48HOAblOT3rNK78OW9iW+KzjdIXRBQYwz+lPKDjeL7gzAzMpC a1AARv2U09JQ== X-Received: by 2002:a05:6000:220e:b0:432:84f9:95f4 with SMTP id ffacd0b85a97d-4342d5ff890mr1552392f8f.31.1768381045966; Wed, 14 Jan 2026 00:57:25 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:db84:c9f1:21bc:dca1]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-432bd0dacc5sm48674680f8f.5.2026.01.14.00.57.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 00:57:25 -0800 (PST) From: Jerome Brunet Date: Wed, 14 Jan 2026 09:56:54 +0100 Subject: [PATCH v2 2/2] arm64: dts: amlogic: s4: fix mmc clock assignment Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-amlogic-s4-mmc-fixup-v2-2-7e9ab5f12286@baylibre.com> References: <20260114-amlogic-s4-mmc-fixup-v2-0-7e9ab5f12286@baylibre.com> In-Reply-To: <20260114-amlogic-s4-mmc-fixup-v2-0-7e9ab5f12286@baylibre.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Xianwei Zhao , Nick Xie Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1993; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=r6xTJIIhs4KBJzOofj3YmS5sCR9M9eszyosDM0nO4jw=; b=owEBbQKS/ZANAwAKAeb8Dxw38tqFAcsmYgBpZ1prUpxsKi9it/0m/bgAZT2A9oFBRfTID+V7Y cqqmzLwYT+JAjMEAAEKAB0WIQT04VmuGPP1bV8btxvm/A8cN/LahQUCaWdaawAKCRDm/A8cN/La hdljEACH5P/J/ngeUurRcWIgGvlXQgv9J6Z77okYA6+NAN7TREISt7XGVzQHQUysSUKZaetZBBq pz0op8r7Ia8KK4DwPhjc1BW/5e3mw4yciOAsZBwK93wMomVOa2ZjnlLjzd9LgU6NUEW9vC5QqsW Qw+rM5L0Z8yRL8lOJjAqncw9Od2gR+h7OhdmN6azZNPK97qfOs/V24h4E27tqxPT/i8tuLLQZ8I ex7l4CQCfjVby6Ml4qnbRpeSnMLwrghHQ2ovLlX+FsjoDJ7VPtPL6tlQNTY4T5ZPREhvj4D/BrQ anoN+mMqhpYOUVoEQS+wJ19eyfnQT0aHoBNTv2tUi55G4NlbZ8XFjJvzDBUEM9FmhQkqiQuzsk+ 414yn2suP/Uu9BuvWU0BtU8xS8hvBxr93mCuSy59opxHI1xBkUHaH5u/MpAumHEb0IxbXhXz4EV c0hBwNl7/E+1e1m+LjwHnXiFpDEnBBNnqy7uW9F6paAK0M3/Vi7MEZDHk9qzHWvdy1cQTLjbPhC Yw7vV/ydHLmQ2KMz2+xdLOnuNm9Bzw8sCTVOwIniNc/ecySJ5TkgzlJia3m22t5x/Sq3FH8hmbG WhGTxxAtzQpxBTaKnnXiCvNhWlUWRZ5mmS/cCDmj4GOfyCeIqyYqSFhzhgEvsAjRiwEg9csI4Ug rMMABOA876AxKOw== X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 MMC A and C are mis-represented as having their "clkin0" input connected to xtal while it is actually connected to the MMC clock, probably in an attempt to provide 24MHz to the device on this input. Fix this and assign the clock to 24MHz to actually provide the required rate. Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4") Tested-by: Nick Xie Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dt= s/amlogic/meson-s4.dtsi index 62538fd9db6b..6324d1eb5994 100644 --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi @@ -819,13 +819,17 @@ sdio: mmc@fe088000 { reg =3D <0x0 0xfe088000 0x0 0x800>; interrupts =3D ; clocks =3D <&clkc_periphs CLKID_SDEMMC_A>, - <&xtal>, + <&clkc_periphs CLKID_SD_EMMC_A>, <&clkc_pll CLKID_FCLK_DIV2>; clock-names =3D "core", "clkin0", "clkin1"; resets =3D <&reset RESET_SD_EMMC_A>; cap-sdio-irq; keep-power-in-suspend; status =3D "disabled"; + + assigned-clocks =3D <&clkc_periphs CLKID_SD_EMMC_A>; + assigned-clock-parents =3D <0>; + assigned-clock-rates =3D <24000000>; }; =20 sd: mmc@fe08a000 { @@ -849,13 +853,17 @@ emmc: mmc@fe08c000 { reg =3D <0x0 0xfe08c000 0x0 0x800>; interrupts =3D ; clocks =3D <&clkc_periphs CLKID_NAND>, - <&xtal>, + <&clkc_periphs CLKID_SD_EMMC_C>, <&clkc_pll CLKID_FCLK_DIV2>; clock-names =3D "core", "clkin0", "clkin1"; resets =3D <&reset RESET_NAND_EMMC>; no-sdio; no-sd; status =3D "disabled"; + + assigned-clocks =3D <&clkc_periphs CLKID_SD_EMMC_C>; + assigned-clock-parents =3D <0>; + assigned-clock-rates =3D <24000000>; }; }; }; --=20 2.47.3