From nobody Tue Feb 10 06:43:02 2026 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B82E230E82B for ; Wed, 14 Jan 2026 08:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768381056; cv=none; b=VK/hA0OEcm7hmNApJ0o8Igu2j/6JRiC4pt2Kc0G83JcuuNG9uwcpIEw8K70JU8z2fvI0sN7j0i7wS1zpRVynWPBKzvT5X0X0oqUERFrAaAStW4OQaMXsBuxVMar4zxXBbRZ/+UapL49DVjlPFAGwAmJrYoMGYklVpvQpdbnXvvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768381056; c=relaxed/simple; bh=iD8WQNBzDHgOnkPSBABm76G4IHl7jfO/G08/hDGOQ48=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rjixt6Q6pzoVNn9lH4ileVrtKLl3dC5vEsKWAUBzqZwvW/ctQy3/4HRiDbnmehX8chsHVQStJeWPtpMWXCW7Ln26PmLDM/RR6mhruVMJZYGDEdB5MYH6Nl0DdXWRDeNgBcnGG+eE/jhvRky9JszaSjhPprJ2hsmZN/fs7ooKE+c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=xc9eZZI2; arc=none smtp.client-ip=209.85.128.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="xc9eZZI2" Received: by mail-wm1-f68.google.com with SMTP id 5b1f17b1804b1-47d1d8a49f5so53282645e9.3 for ; Wed, 14 Jan 2026 00:57:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768381044; x=1768985844; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0XseDb8ZHPBjuoEWbJmFo7HtvNpWYI4+BmzsvRT84Bg=; b=xc9eZZI27pev52zqMGrvV/HGrt0l96ZhXFcIjBzzGR3Vj0Nzx/Oqf0tr2PRfpLMEvU 4WiSa5E+E9CtHKQ92pwj5Da2WKQfdozECMpZ0c+ralJttskOqOi8qtYy9GScfieq2ubf yLkEmObFS9VgNyuzUYmqUSljKxmENHrpbIPY5RmUYBPG7LT88LxDYKDQXrfepU6JwRL/ 8U+bQchimwEFmZgNoMAFPHN89uNX778JFa/6Zisey/LMTJdVLKWo555+LRJ5u144cexj +Y0RiSHuXFmCE5tZ83x29+1DVI3u7vXRBZyRxYo2g25UJYSSIZfplNc6rG/Dj+rCmHXu 6W3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768381044; x=1768985844; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0XseDb8ZHPBjuoEWbJmFo7HtvNpWYI4+BmzsvRT84Bg=; b=ckIGbZJPiyMOb9obLQzJE0Zz+YKwIPP0hpU+V5MjlzdkjlvXmyukT8hz3czoY+6SKz Z7WSM6ciD4l5GG0kBLPdps/YAqqInewfkXi6qmTt5qIyz7ayGXOZjO8vqwk8bnxSZI/s YQAmpqP5iKKrgJdcHH+RPp56Nv2jyhsG06/VLSpdj2j2V49HUJ38VSqg7my6F1NCIaqv d7/eMuaMKllOUPiD9k4l8Or9ihfxACUsaOYWL59yA8i1jRKsN/d0JVWjSq4gqL4CWvC1 QJzDQwjAYRtcWdv/F9lIDutcccFkvHa1GI+4WLbSrnC7TRcyxwO6DLYEEwPNNDDTQoIy 9wGA== X-Forwarded-Encrypted: i=1; AJvYcCV9dsTcYwSNzpuZICPRTCIfklkWl+qvFYHpv/mQidVjOs588WyUjbA0jGPxmABtPmfFQ3nXgvnIk1FV6iY=@vger.kernel.org X-Gm-Message-State: AOJu0YyZzx5yNwzPzaRjsyDvM7At1Yrs2+qPRwZfpA/1nfrSTbGP3C51 nxcmsRvdRRgwX9vn3qLn2MdqnjMFv5Vc5QFlSWkvJxSL/4Ay7xs5Op8dm0CFXXr+n8g= X-Gm-Gg: AY/fxX45GmKkrcYXw3ReN+Bm1XChmGy5JIoTuRbkWmK2GXWCkFDb8iwIsaXZjavMk+1 H4l6AyM0r8k0YGSXfW20DK3iPBeabnnmHD0I8F4/8yvINdA3ffdUO6EfqRO+WOSWf++9nG4svx+ vSlssHAgz9QMJfhJhN8C0C+VNaw31bdlPekkyio5vOfl++IaObAze86AlN8vI52YcRSMaFN1o82 6Yi4ZrdQyljlZ8j/BHZCdheX/S8YgBi58AwmV3UnboSWZvdglOPf9ACJhrBfCS9+FHcD5yxYRwv ERnlr9+f+1yuyI7aPsMCSZLYYpAgMCZYG4y281TE1hvCkh79peUV4AacLwq5ZftGZJlmpFroBHl MP+D0PCQbAiCimVk2rdw57lr72uTl7a10gDUKnZAfsDuDGQuVRMoFfrk2SkoGAirUSmh6Wixasl 8iGloN5KZg9u7cMKoUPcSn X-Received: by 2002:a05:600c:8b52:b0:47e:e20e:bbbf with SMTP id 5b1f17b1804b1-47ee335646fmr21311365e9.24.1768381043978; Wed, 14 Jan 2026 00:57:23 -0800 (PST) Received: from localhost ([2a01:e0a:3c5:5fb1:db84:c9f1:21bc:dca1]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47ee563c8bbsm16828795e9.12.2026.01.14.00.57.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jan 2026 00:57:23 -0800 (PST) From: Jerome Brunet Date: Wed, 14 Jan 2026 09:56:53 +0100 Subject: [PATCH v2 1/2] arm64: dts: amlogic: s4: assign mmc b clock to 24MHz Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260114-amlogic-s4-mmc-fixup-v2-1-7e9ab5f12286@baylibre.com> References: <20260114-amlogic-s4-mmc-fixup-v2-0-7e9ab5f12286@baylibre.com> In-Reply-To: <20260114-amlogic-s4-mmc-fixup-v2-0-7e9ab5f12286@baylibre.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Xianwei Zhao , Nick Xie Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1493; i=jbrunet@baylibre.com; h=from:subject:message-id; bh=iD8WQNBzDHgOnkPSBABm76G4IHl7jfO/G08/hDGOQ48=; b=owEBbQKS/ZANAwAKAeb8Dxw38tqFAcsmYgBpZ1pqfpx3+J/u6VAXTqIHhXnYBGILsIGj6hHZ2 GgF6YplWniJAjMEAAEKAB0WIQT04VmuGPP1bV8btxvm/A8cN/LahQUCaWdaagAKCRDm/A8cN/La hW0+EACTZGM3OUj+3pT7mr8XHNiVzYYixPyBVwfOOjbaWxQEZ4ifZZe07/d2KGb4RAmGIJS5Hkg x0uDV4cHVpSrbCIYmzdwFYljZvuJ8wCjmn69opZO+/q71bmw6KwJkjvIXqnS5LyR7tz8AT/Kve6 NdGRve3pqgPUeYq/g05Y2CqZuFvYILYn4oRrTVsA+B3WgrMzPZqPNvGDHOOigqxNzOP7lbQlDrf nfxIyNLGnyzAGo+D9N5FFJgK+x88bYvGQfpWyb4ZG6H1ROhXSRkiZp1Zhm1kYBCBzrPcyEKcvW2 pceBzORj5S2db4ELPgC8AVtoDN3TmmFeTtrgdqHiSG/Wx2AJZJVxhZ7+qj41lF/+MEyBSpP7R2c I6DGZbxyln58Z9RS9Iuj5X+E6Tp3nAmqmHE8vP3ePvmmy9+sleiJR1LmbSuDreA96uKR5iHpWc8 xHrmDNCfyw8XQZe3yCDlzi5AHHrYr/mJGzkD1fcwLJxLCv1dm4bLNyu5xcTzVn0W3ZvuOkVr9LY FzMc3JfgM20WQcAIMzRz6vBRBdiOl+cbPK4i0hWonzhQ4//Kc6Ilzg1giecRFx8ZHWzmdpDnwgK NrlGydXIK/e8GG47fl3OAUlApjMIBejXDm3npc5P9K3MQeergyqqGiwygfJTflppJ87jOQRs4TS +XgthRsHN1vVSgw== X-Developer-Key: i=jbrunet@baylibre.com; a=openpgp; fpr=F29F26CF27BAE1A9719AE6BDC3C92AAF3E60AED9 The amlogic MMC driver operate with the assumption that MMC clock is configured to provide 24MHz. It uses this path for low rates such as 400kHz. This assumption did hold true until but it now, but it is apparently not the case with s4. The clock has been reported to provide 1GHz instead. This is most likely due to how the bootloader is using the MMC clock on this platform. Regardless of why the MMC clock rate is 1GHz, if the MMC driver expects 24MHz, the clock should be properly assigned, so assign it. Reported-by: Nick Xie Closes: https://lore.kernel.org/linux-amlogic/20260113011931.40424-1-nick@k= hadas.com/ Fixes: 3ab9d54b5d84 ("arm64: dts: amlogic: enable some device nodes for S4") Tested-by: Nick Xie Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dt= s/amlogic/meson-s4.dtsi index 9d99ed2994df..62538fd9db6b 100644 --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi @@ -838,6 +838,10 @@ sd: mmc@fe08a000 { clock-names =3D "core", "clkin0", "clkin1"; resets =3D <&reset RESET_SD_EMMC_B>; status =3D "disabled"; + + assigned-clocks =3D <&clkc_periphs CLKID_SD_EMMC_B>; + assigned-clock-parents =3D <0>; + assigned-clock-rates =3D <24000000>; }; =20 emmc: mmc@fe08c000 { --=20 2.47.3