From nobody Mon Feb 9 19:37:53 2026 Received: from mail-05.mail-europe.com (mail-05.mail-europe.com [85.9.206.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A9135CBA6 for ; Tue, 13 Jan 2026 19:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.9.206.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331383; cv=none; b=SvR7q1mCq80E+lUeFHCw8WymoSKIWBB2Bzx9LBrq9jJ2cXkKPQ2TPJsaUeMXJuiQ5JpngY8YBP/yuWrForY7XjOKWctNxHuT10cGrHrNIOLPqZcHqApN4MjI5D/4SCIo3+IUngG5cu1dvJ/JfMk1DKvjnACNabsu6jl/PcFULsc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331383; c=relaxed/simple; bh=9q2VvP/fi/Cb5xwfiXOep8LY0yrsd3FC++ByhW8WtJI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UrW/I5kllEirE7ng3D3PZa0HCHowY7QUtyfIXymhB6UDh3VsYkfNMHTklY7QPKEgFtoGB70YN+w2llugdTqPJNjiPRYAf0Hn9dAto+mRuE0VENFPSz5qo42RJGpf2nYaELaHF5DW6tYmSYAe1+9ZXhuyuyw4vVHeM6NqVkVcZb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=pW9bgQMO; arc=none smtp.client-ip=85.9.206.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="pW9bgQMO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331368; x=1768590568; bh=9q2VvP/fi/Cb5xwfiXOep8LY0yrsd3FC++ByhW8WtJI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=pW9bgQMOq+wEcND4SQg7laipAGZv7YGZ76N8LSHXY85xIjzaloKk7bzIQX5aI7ot2 q7+koikJh3uoONbdj6DISwu1D7LEFIY9eGbudQ1fjoH208PJ0nMhhC0shrdvkl6XV3 q7vMY5ZLOArHLCy3thaYgJTDYTskCsjtIe8Ss8DEgOMVtODW4We4gECV+9TIUq8Enn KwbyXY21OMVvWd6lzwYkewaL9p90G0R1LcFKnH+yGRwNaOKxvgq8lC9Pf02dgXfs/o lcf/uHXNxK7pMEYY8CKurDvwPk/p84UHJL5u0oaWevmtIaDR1NystLt6NfsYlhxgyt Ivm1Dtf6jNq4Q== Date: Tue, 13 Jan 2026 19:09:25 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 8/9] gpib: pc2: Unify *allocate_private Message-ID: <20260113190759.54355-9-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: c9c737a78cc979fc19dec620986f9003f31e978f Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/pc2/pc2_gpib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/pc2/pc2_gpib.c b/drivers/gpib/pc2/pc2_gpib.c index 9f3943d1df66..93248b28982b 100644 --- a/drivers/gpib/pc2/pc2_gpib.c +++ b/drivers/gpib/pc2/pc2_gpib.c @@ -239,7 +239,7 @@ static int allocate_private(struct gpib_board *board) =20 board->private_data =3D kmalloc(sizeof(struct pc2_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; memset(priv, 0, sizeof(struct pc2_priv)); init_nec7210_private(&priv->nec7210_priv); @@ -257,10 +257,12 @@ static int pc2_generic_attach(struct gpib_board *boar= d, const struct gpib_board_ { struct pc2_priv *pc2_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval < 0) + return retval; pc2_priv =3D board->private_data; nec_priv =3D &pc2_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0