From nobody Mon Feb 9 20:59:21 2026 Received: from mail-43102.protonmail.ch (mail-43102.protonmail.ch [185.70.43.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4727F35B14A for ; Tue, 13 Jan 2026 19:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.102 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331372; cv=none; b=WSrnx2aLE+6XkakhSquur69ctfgRtNaELk7JGPhcgjp2gGxju90VYRqW58uueUR/6n3mei0S48gHm0b8HYfzN2KvXGQJsCOhZSScB564SrbN8B+oiS8uxtmQN/U37P7CxHABfT25L3KgnNVcJXZ023MKwMYAz2cHwJ+CDOBdqFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331372; c=relaxed/simple; bh=U7LY/wwVHSrG9c6LiUjedesdv41XgcRr/G6bfvi8D4M=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J+XQdn93fWCHMiTpnu9izVDKUi2OF0mvvNXkPXbufQXx0f0H5/+zsfIE8FLB2aSvbvaOhR9kTqe8BdGNxUY6EtRcky6nEAYBG7m0bKpRSxEqADhO6jbcUk4w5kvu7SYxGKg0uyfZOJJS69jyfrGRuF5GdmxrW8MfMT9fx0re83Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=BCHrmlDz; arc=none smtp.client-ip=185.70.43.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="BCHrmlDz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331357; x=1768590557; bh=U7LY/wwVHSrG9c6LiUjedesdv41XgcRr/G6bfvi8D4M=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=BCHrmlDzCwMZOo6v2jhbGpStekhSSDj8jeiR8rW/xA1omWRUuI+WN83U1GgBYLjUC PaqcTh8OvKieb0ZwSTy9WNbdMXk2IOClBhBkCFAHxldqWg57uN4lgHsbtTc8jYFnlB w5q6gSIrhRMr5G2rH2s339O63lMmef9buyqltuh+iC8rcuisUp3foZ/f7sy50hFQhX 5rxaeZyvuHMUYCGsQcMhVfOR74eI6ms88oLnj0TuwEKGPj1NaLj1MEMRrxg6yphlhp 9rDQEPVyW5Tjt6sZoG38wIonx4q1+Ybdkb5OjEeQGbUyvRjuHugjGyS9wfqpA7o17Q JQJNsVTfGhmrg== Date: Tue, 13 Jan 2026 19:09:15 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 6/9] gpib: hp_82341: Unify *allocate_private Message-ID: <20260113190759.54355-7-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: ac299aee5982876f67f994f927aa1eeb22ee618e Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/hp_82341/hp_82341.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/hp_82341/hp_82341.c b/drivers/gpib/hp_82341/hp_82= 341.c index 1a2ad0560e14..4a2440fe160f 100644 --- a/drivers/gpib/hp_82341/hp_82341.c +++ b/drivers/gpib/hp_82341/hp_82341.c @@ -693,8 +693,9 @@ static int hp_82341_attach(struct gpib_board *board, co= nst struct gpib_board_con int retval; =20 board->status =3D 0; - if (hp_82341_allocate_private(board)) - return -ENOMEM; + retval =3D hp_82341_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp_82341_read_byte; --=20 2.43.0