From nobody Tue Feb 10 01:15:01 2026 Received: from mail-244121.protonmail.ch (mail-244121.protonmail.ch [109.224.244.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6519635CB93 for ; Tue, 13 Jan 2026 19:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.121 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331360; cv=none; b=L8ExubQpj/dXYok9f9likUkLSz51eBSbZol59HNZ8tbLszjMBtDSt6coFePpR9qmU5Pv5H5X/MEQPlqcvhvmYATk79vbefjeLDBpauv68rhCDrf/38Gh1TDX9W3SQVnviH3XhPZMp2OiY+40g6fZZDJd6cFU2VHfcEKMGc0vK28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331360; c=relaxed/simple; bh=05l2QJZM2TvNO02P8ZGElQ4F0ay07b2IJl8yzXcKP3c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NXiXfKCvxm0lk6zZhgkTo6hcUKkVWywFcxuk11wqZjCEpnKKW7eSLrwvH7fmUiOPdwQptMoqTwtDMxDGlyNYOYsXWTb8B4S3PlBc62MKuNDfrHlrmx8KwFYLE/Zjm37c8c7lY26sr6ZpyJhgmMwThdmsiq095x1Ga2576fOulM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=PgCMAmtQ; arc=none smtp.client-ip=109.224.244.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="PgCMAmtQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331353; x=1768590553; bh=05l2QJZM2TvNO02P8ZGElQ4F0ay07b2IJl8yzXcKP3c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=PgCMAmtQv+Ugc7ca1TdVtyy2eW0zplsADAMdm52g9R8n7gQpoPt3mCPDlhBrCB5ZR Wjm0ttAF3IiAR2ViSB8HnFJkhmDWDaZ/mbh7rBE/JLRGLw3E49kpycpe2agmui8YVy x56sm0UI+9hM9ZgCYsKNr/E4aaTDhQ8xibUaUki/UFRxYoo7uvzFRGvkcXNd3ZDWwi dQHtwkFgbSA99kGzDjMjayqJvjr0Cb3O5xVPYn6i6EcS5joKpWkgbq8DsvQ6ED+b0p i/JK+Adp6KwGj3pl6e1L/kBhli62ljUrCKUIEHxb2RTpPtlRyouGGMsxDFqwl+2QX4 PCPdGVGtfa4fw== Date: Tue, 13 Jan 2026 19:09:09 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 5/9] gpib: hp_82335: Unify *allocate_private Message-ID: <20260113190759.54355-6-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: f69c337b9670b27d31479faaaee9ec7103e68206 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/hp_82335/hp82335.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/hp_82335/hp82335.c b/drivers/gpib/hp_82335/hp8233= 5.c index d0e47ef77c87..871079dd1088 100644 --- a/drivers/gpib/hp_82335/hp82335.c +++ b/drivers/gpib/hp_82335/hp82335.c @@ -212,7 +212,7 @@ static int hp82335_allocate_private(struct gpib_board *= board) { board->private_data =3D kzalloc(sizeof(struct hp82335_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; return 0; } =20 @@ -253,8 +253,9 @@ static int hp82335_attach(struct gpib_board *board, con= st struct gpib_board_conf =20 board->status =3D 0; =20 - if (hp82335_allocate_private(board)) - return -ENOMEM; + retval =3D hp82335_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp82335_read_byte; --=20 2.43.0