From nobody Mon Feb 9 20:10:59 2026 Received: from mail-106120.protonmail.ch (mail-106120.protonmail.ch [79.135.106.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5708335A94F for ; Tue, 13 Jan 2026 19:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.120 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331352; cv=none; b=oOlo9RD01Kviu7v/p9mukk0hfqAS5gT9BRZDpdXGyRTChUOQ30ElMrPe1dj5+d2KR52LOdCHDVsAhMFx8+jE+PK+KG5tyNn6zgwjlDTWtDIKTxprjZJ8rdfisQ27HL6JiUIvDmHPvne3Iaf5Ot8Wj6G+3wqX2TSffXxOTO93BvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331352; c=relaxed/simple; bh=Y4kjVIDM1AUJY5y6B8k7sfPyBVaMZGqpPaSDpyVyvIY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h84wyikLidVbOmE7+cD+4vzYr7gkPByqasy5O4LTmi4DpuQDdCCdvDsxuz9OZ+wNg4c9rQ7OoLB7vmBaJJ5CvngASgdXwLp12zl/YzweXJsYcOCD0vrEdXWo9ch2+eul/8E4UrpQCBvupkvfBud4PcstPY7qCukQtmI/VyFifY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=EphwNQ9k; arc=none smtp.client-ip=79.135.106.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="EphwNQ9k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331349; x=1768590549; bh=Y4kjVIDM1AUJY5y6B8k7sfPyBVaMZGqpPaSDpyVyvIY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=EphwNQ9kPXqbmUO8kRsa32thNS+VaBw4FWXxcat9vOHUFJrtfmDtcfmYj7qPlF9MF Ygi+GQVI2+u5e81TMP+nqIT6nyhxZtgDvlyZ2WrWsDGqsHr9w1tVL13//6a/QQh4mg xonuUMYq2XNSoX2dggUh2FvHvhp+aL++apkE/c93nh1Fxr3GenkTlEJUqMRHOgiDXh X6qhWbmAP7R0yNojTSj+IdkUJKEr+KtvkO325GvMd46rCWMQianipeQgSDm+El0fZR rP4r86IvO/0JjffmsYkRTbkXtHZ9sSi39RvsiXwNt6plT+3B7FXwe8m7My8/9Ya6om U/FiGPRX7S3tQ== Date: Tue, 13 Jan 2026 19:09:02 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 4/9] gpib: gpio: Unify *allocate_private Message-ID: <20260113190759.54355-5-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: b1627126ece4e476702ca386c858b215042867dd Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/gpio/gpib_bitbang.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpib/gpio/gpib_bitbang.c b/drivers/gpib/gpio/gpib_bitb= ang.c index 374cd61355e9..3b8bd34f2f3d 100644 --- a/drivers/gpib/gpio/gpib_bitbang.c +++ b/drivers/gpib/gpio/gpib_bitbang.c @@ -1068,7 +1068,7 @@ static int allocate_private(struct gpib_board *board) { board->private_data =3D kzalloc(sizeof(struct bb_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; return 0; } =20 @@ -1205,14 +1205,15 @@ static void bb_detach(struct gpib_board *board) static int bb_attach(struct gpib_board *board, const struct gpib_board_con= fig *config) { struct bb_priv *priv; - int retval =3D 0; + int retval; =20 dbg_printk(2, "%s\n", "Enter ..."); =20 board->status =3D 0; =20 - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval < 0) + return retval; priv =3D board->private_data; priv->direction =3D -1; priv->t1_delay =3D 2000; --=20 2.43.0