From nobody Mon Feb 9 20:59:21 2026 Received: from mail-106121.protonmail.ch (mail-106121.protonmail.ch [79.135.106.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E07E35A94F for ; Tue, 13 Jan 2026 19:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.121 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331340; cv=none; b=Har/X8Ht74W0RWb4fTmrLQkofVes/mE/9E46YbDVk0RoiHbIxamKLyixEPoIoY7wxE3wZ1NOeshlOgasXZXwGScIDzLCPnp7aZ5i/frm3KIT3xof4DHteNI4HjOEr7OMGFWGz23mBf4N3wkSQ6RfbIBNhv1EtElTQQnHffJ41WU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331340; c=relaxed/simple; bh=zAXD27PP25VlmyHchIbOu4kX4P4qHCuIpLWfnBMYVbk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XtBFI4lD7giBEA/S1e6A4SG4kUBTNgCgwp5WZwe2bLwpG1SHTLQ/B7HMekeL60CpeFMHA+Pu8BgAjB/rux+XQTOQp2bVhjIp9LdehXEA7m1ihI1SGxK3qCFfZRizkh3nv7Rp535o8dzIiEw0iMELoz3g84CSij7m731qDmYnWHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=mlDf8FlE; arc=none smtp.client-ip=79.135.106.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="mlDf8FlE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331336; x=1768590536; bh=zAXD27PP25VlmyHchIbOu4kX4P4qHCuIpLWfnBMYVbk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=mlDf8FlE92NVh26u6ySeM580hv/RiR6IW/MJR6F9rbdKKF90jjDHbktDC3kWa/UI1 9uCrSDG5/cfis5LaczSE2UKo1Xr3ou0RpwvA28i3j6Np4gXXpajB2SHyG/laFq9TKb skKR5qHCe9f4S9TIBQmkHRy93f1gbpAgWSHO9GYbrnVJ4de6VUDN3Dqf9XofS/ebOO gkKBNTHyGP6XSa9GPJMos+yxLVdNZ3L71VH07YYsYSuii1QOf803/JRU09msezc/7r Y73Dhggaewp8B6rvP1tRxCuRtNnWKO5/8DgSbBVcNtHOeaQt6TjyLvLjssCZmKrKnR UKvd24rNgZH/g== Date: Tue, 13 Jan 2026 19:08:49 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 2/9] gpib: cb7210: Unify *allocate_private Message-ID: <20260113190759.54355-3-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 2f806656c1004cbedea92bb0b04a27631c1c9c4e Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/cb7210/cb7210.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/cb7210/cb7210.c b/drivers/gpib/cb7210/cb7210.c index 24c61b151071..e0ce2ac494c4 100644 --- a/drivers/gpib/cb7210/cb7210.c +++ b/drivers/gpib/cb7210/cb7210.c @@ -876,11 +876,13 @@ static int cb7210_generic_attach(struct gpib_board *b= oard) { struct cb7210_priv *cb_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (cb7210_allocate_private(board)) - return -ENOMEM; + retval =3D cb7210_allocate_private(board); + if (retval < 0) + return retval; cb_priv =3D board->private_data; nec_priv =3D &cb_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_locking_ioport_read_byte; --=20 2.43.0