From nobody Tue Feb 10 02:49:24 2026 Received: from mail-10628.protonmail.ch (mail-10628.protonmail.ch [79.135.106.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6046835B150 for ; Tue, 13 Jan 2026 19:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.28 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331338; cv=none; b=ET37sA4GepInWCFNm+2ri6IuXfvom7kdCbXggJWZNF3HSWVm5e3IxGNoD5chiGddPTo6h3oWjdjjhyacBtK4etQHR9KCtxcXY/ykpZW+xvzerrvwIzU3E1wKPg9WaDsnb6gG4p8qZ2L6aOzcoGi1KANnPkRpE+qv34l8HtUWCfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331338; c=relaxed/simple; bh=oOcmj0Ambx6GkptRnQGwEesBI9z/hBW03V19FEzDF/c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kA+pErbnh0k3Wwa/Tq5zzSH0/grnLtd2Hv80ubLFMqUu7pGlcb4pEZHRD8yfKbBN5NW2HF5Oo9PUXAgjpS7UhipX4wOo9QL1HaZKsAB/lFrwHT/+qdvK1mrWV1qTSOuSrz4e7l4dM6d07X/7tNIAPCPZf78YSP1L315F1rJ0QjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=VEBsl2wi; arc=none smtp.client-ip=79.135.106.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="VEBsl2wi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331330; x=1768590530; bh=oOcmj0Ambx6GkptRnQGwEesBI9z/hBW03V19FEzDF/c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=VEBsl2wiQbhbR0BQ+WJl8p+N/W5vY2SQa8efC5qIhx9ZoBNenwseS9UPV5A85Dl1E oQC6FsTNVu1gh9api4wJvkot9fc55hv0objqEDWPTsknCYiwkKat/8E74CEm9O1OUj ZwJimyOxNTrbEeTYIhAuz9Dn8bfONUtzsWHa1f7K/U+9JCSNdA5+rwAznQqYGja76u busqCG7YHdfk0D4CHYyCOzc8A+rQEPZM72f5KTofBwT1NRxvETtI23Yh+4VbAetPtk CwuSgl38G/AMpnwBO24bXXVRCkPytUrDEcyTjZU54YKkGkfODpaputUe5fhVe+1NRz mbA3PfjvaZGhA== Date: Tue, 13 Jan 2026 19:08:43 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 1/9] gpib: agilent_82350b: Unify *allocate_private Message-ID: <20260113190759.54355-2-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 2e574dd4c582d3426599c302ab8f53a38805653a Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/agilent_82350b/agilent_82350b.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/agilent_82350b/agilent_82350b.c b/drivers/gpib/ag= ilent_82350b/agilent_82350b.c index 01a5bb43cd2d..f5f102863e47 100644 --- a/drivers/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/gpib/agilent_82350b/agilent_82350b.c @@ -599,8 +599,9 @@ static int agilent_82350b_generic_attach(struct gpib_bo= ard *board, =20 board->status =3D 0; =20 - if (agilent_82350b_allocate_private(board)) - return -ENOMEM; + retval =3D agilent_82350b_allocate_private(board); + if (retval < 0) + return retval; a_priv =3D board->private_data; a_priv->using_fifos =3D use_fifos; tms_priv =3D &a_priv->tms9914_priv; --=20 2.43.0