From nobody Sun Feb 8 22:57:39 2026 Received: from mail-10628.protonmail.ch (mail-10628.protonmail.ch [79.135.106.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6046835B150 for ; Tue, 13 Jan 2026 19:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.28 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331338; cv=none; b=ET37sA4GepInWCFNm+2ri6IuXfvom7kdCbXggJWZNF3HSWVm5e3IxGNoD5chiGddPTo6h3oWjdjjhyacBtK4etQHR9KCtxcXY/ykpZW+xvzerrvwIzU3E1wKPg9WaDsnb6gG4p8qZ2L6aOzcoGi1KANnPkRpE+qv34l8HtUWCfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331338; c=relaxed/simple; bh=oOcmj0Ambx6GkptRnQGwEesBI9z/hBW03V19FEzDF/c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kA+pErbnh0k3Wwa/Tq5zzSH0/grnLtd2Hv80ubLFMqUu7pGlcb4pEZHRD8yfKbBN5NW2HF5Oo9PUXAgjpS7UhipX4wOo9QL1HaZKsAB/lFrwHT/+qdvK1mrWV1qTSOuSrz4e7l4dM6d07X/7tNIAPCPZf78YSP1L315F1rJ0QjE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=VEBsl2wi; arc=none smtp.client-ip=79.135.106.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="VEBsl2wi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331330; x=1768590530; bh=oOcmj0Ambx6GkptRnQGwEesBI9z/hBW03V19FEzDF/c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=VEBsl2wiQbhbR0BQ+WJl8p+N/W5vY2SQa8efC5qIhx9ZoBNenwseS9UPV5A85Dl1E oQC6FsTNVu1gh9api4wJvkot9fc55hv0objqEDWPTsknCYiwkKat/8E74CEm9O1OUj ZwJimyOxNTrbEeTYIhAuz9Dn8bfONUtzsWHa1f7K/U+9JCSNdA5+rwAznQqYGja76u busqCG7YHdfk0D4CHYyCOzc8A+rQEPZM72f5KTofBwT1NRxvETtI23Yh+4VbAetPtk CwuSgl38G/AMpnwBO24bXXVRCkPytUrDEcyTjZU54YKkGkfODpaputUe5fhVe+1NRz mbA3PfjvaZGhA== Date: Tue, 13 Jan 2026 19:08:43 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 1/9] gpib: agilent_82350b: Unify *allocate_private Message-ID: <20260113190759.54355-2-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 2e574dd4c582d3426599c302ab8f53a38805653a Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/agilent_82350b/agilent_82350b.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/agilent_82350b/agilent_82350b.c b/drivers/gpib/ag= ilent_82350b/agilent_82350b.c index 01a5bb43cd2d..f5f102863e47 100644 --- a/drivers/gpib/agilent_82350b/agilent_82350b.c +++ b/drivers/gpib/agilent_82350b/agilent_82350b.c @@ -599,8 +599,9 @@ static int agilent_82350b_generic_attach(struct gpib_bo= ard *board, =20 board->status =3D 0; =20 - if (agilent_82350b_allocate_private(board)) - return -ENOMEM; + retval =3D agilent_82350b_allocate_private(board); + if (retval < 0) + return retval; a_priv =3D board->private_data; a_priv->using_fifos =3D use_fifos; tms_priv =3D &a_priv->tms9914_priv; --=20 2.43.0 From nobody Sun Feb 8 22:57:39 2026 Received: from mail-106121.protonmail.ch (mail-106121.protonmail.ch [79.135.106.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E07E35A94F for ; Tue, 13 Jan 2026 19:08:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.121 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331340; cv=none; b=Har/X8Ht74W0RWb4fTmrLQkofVes/mE/9E46YbDVk0RoiHbIxamKLyixEPoIoY7wxE3wZ1NOeshlOgasXZXwGScIDzLCPnp7aZ5i/frm3KIT3xof4DHteNI4HjOEr7OMGFWGz23mBf4N3wkSQ6RfbIBNhv1EtElTQQnHffJ41WU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331340; c=relaxed/simple; bh=zAXD27PP25VlmyHchIbOu4kX4P4qHCuIpLWfnBMYVbk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XtBFI4lD7giBEA/S1e6A4SG4kUBTNgCgwp5WZwe2bLwpG1SHTLQ/B7HMekeL60CpeFMHA+Pu8BgAjB/rux+XQTOQp2bVhjIp9LdehXEA7m1ihI1SGxK3qCFfZRizkh3nv7Rp535o8dzIiEw0iMELoz3g84CSij7m731qDmYnWHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=mlDf8FlE; arc=none smtp.client-ip=79.135.106.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="mlDf8FlE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331336; x=1768590536; bh=zAXD27PP25VlmyHchIbOu4kX4P4qHCuIpLWfnBMYVbk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=mlDf8FlE92NVh26u6ySeM580hv/RiR6IW/MJR6F9rbdKKF90jjDHbktDC3kWa/UI1 9uCrSDG5/cfis5LaczSE2UKo1Xr3ou0RpwvA28i3j6Np4gXXpajB2SHyG/laFq9TKb skKR5qHCe9f4S9TIBQmkHRy93f1gbpAgWSHO9GYbrnVJ4de6VUDN3Dqf9XofS/ebOO gkKBNTHyGP6XSa9GPJMos+yxLVdNZ3L71VH07YYsYSuii1QOf803/JRU09msezc/7r Y73Dhggaewp8B6rvP1tRxCuRtNnWKO5/8DgSbBVcNtHOeaQt6TjyLvLjssCZmKrKnR UKvd24rNgZH/g== Date: Tue, 13 Jan 2026 19:08:49 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 2/9] gpib: cb7210: Unify *allocate_private Message-ID: <20260113190759.54355-3-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 2f806656c1004cbedea92bb0b04a27631c1c9c4e Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/cb7210/cb7210.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/cb7210/cb7210.c b/drivers/gpib/cb7210/cb7210.c index 24c61b151071..e0ce2ac494c4 100644 --- a/drivers/gpib/cb7210/cb7210.c +++ b/drivers/gpib/cb7210/cb7210.c @@ -876,11 +876,13 @@ static int cb7210_generic_attach(struct gpib_board *b= oard) { struct cb7210_priv *cb_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (cb7210_allocate_private(board)) - return -ENOMEM; + retval =3D cb7210_allocate_private(board); + if (retval < 0) + return retval; cb_priv =3D board->private_data; nec_priv =3D &cb_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_locking_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 22:57:39 2026 Received: from mail-24417.protonmail.ch (mail-24417.protonmail.ch [109.224.244.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604D235A95B for ; Tue, 13 Jan 2026 19:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331352; cv=none; b=XT5cR7LG7aJaTeefw9ootmcknbt/aydwuy82B5vw9re+fRNBS1UVARv/erkeMFWP+wW77WrcMk6UxpfhSDKoFcw5xYUo8ZZw8wAXQfvaeO6/lZKvDJWhCuFLVscyTWV8biLpKkQtdwvPc1ANP83v0vjBOZAIK3KTfx2Md5/W7LM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331352; c=relaxed/simple; bh=qXpeRidoMeYne2lkGrvqWB2PxsxKPFEoxgDx5lbexaA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jeDDae1onoNdBlSm2+QEpiPajPopdvOX43sY7SGdTGPlWASxzAS9YfQvi+EedFeW3IYvbBwKZMIF7y13ixWw5pZ7AtOPQJ/0jzz4BJCPehzTQaTA1IoDYsojjsJvln1Yap5E8sWtUG1FOtyGpsN9J1B5O+FuBQeMq9z3WtcvV3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=sBWigoej; arc=none smtp.client-ip=109.224.244.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="sBWigoej" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331340; x=1768590540; bh=qXpeRidoMeYne2lkGrvqWB2PxsxKPFEoxgDx5lbexaA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=sBWigoejaYhco6fKpCUx2uw4gZq3yNmNG2i29HBi49lwZTQ+fua92I4yVH37HKClh Lkk8Eytt4HEAE4RI4kFjXfDNpFFiJ8WzPOopKu9lky2oKFLPy4olS839h3R0JSe12Z 3hVy2/QLHXek3QKIYDAnY5TW/iDJ0T1HlD7Dxe5+fQLB99F43cKsW+8v1MIWfO0n4J zg5AqFZZyhHToI0BDj1B/Jw3QcedDRa/BwL+BlyNaeLYRM4/8QDyaCwjhvmQykKrHm SfByywdgHAqNWR7DchJ8Fc+p2HQtB20nRFBiowxomuD5+QTDc7x4i57codFAnNnHN2 eu5JmDazt5owg== Date: Tue, 13 Jan 2026 19:08:56 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 3/9] gpib: cec: Unify *allocate_private Message-ID: <20260113190759.54355-4-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 95526c7b3b47ac06181d11500cd2b080ce68dfe8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/cec/cec_gpib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/cec/cec_gpib.c b/drivers/gpib/cec/cec_gpib.c index dbf9b95baabc..6d04becd1058 100644 --- a/drivers/gpib/cec/cec_gpib.c +++ b/drivers/gpib/cec/cec_gpib.c @@ -222,7 +222,7 @@ static int cec_allocate_private(struct gpib_board *boar= d) =20 board->private_data =3D kmalloc(sizeof(struct cec_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; memset(priv, 0, sizeof(struct cec_priv)); init_nec7210_private(&priv->nec7210_priv); @@ -239,11 +239,13 @@ static int cec_generic_attach(struct gpib_board *boar= d) { struct cec_priv *cec_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (cec_allocate_private(board)) - return -ENOMEM; + retval =3D cec_allocate_private(board); + if (retval < 0) + return retval; cec_priv =3D board->private_data; nec_priv =3D &cec_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 22:57:39 2026 Received: from mail-106120.protonmail.ch (mail-106120.protonmail.ch [79.135.106.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5708335A94F for ; Tue, 13 Jan 2026 19:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.120 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331352; cv=none; b=oOlo9RD01Kviu7v/p9mukk0hfqAS5gT9BRZDpdXGyRTChUOQ30ElMrPe1dj5+d2KR52LOdCHDVsAhMFx8+jE+PK+KG5tyNn6zgwjlDTWtDIKTxprjZJ8rdfisQ27HL6JiUIvDmHPvne3Iaf5Ot8Wj6G+3wqX2TSffXxOTO93BvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331352; c=relaxed/simple; bh=Y4kjVIDM1AUJY5y6B8k7sfPyBVaMZGqpPaSDpyVyvIY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h84wyikLidVbOmE7+cD+4vzYr7gkPByqasy5O4LTmi4DpuQDdCCdvDsxuz9OZ+wNg4c9rQ7OoLB7vmBaJJ5CvngASgdXwLp12zl/YzweXJsYcOCD0vrEdXWo9ch2+eul/8E4UrpQCBvupkvfBud4PcstPY7qCukQtmI/VyFifY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=EphwNQ9k; arc=none smtp.client-ip=79.135.106.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="EphwNQ9k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331349; x=1768590549; bh=Y4kjVIDM1AUJY5y6B8k7sfPyBVaMZGqpPaSDpyVyvIY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=EphwNQ9kPXqbmUO8kRsa32thNS+VaBw4FWXxcat9vOHUFJrtfmDtcfmYj7qPlF9MF Ygi+GQVI2+u5e81TMP+nqIT6nyhxZtgDvlyZ2WrWsDGqsHr9w1tVL13//6a/QQh4mg xonuUMYq2XNSoX2dggUh2FvHvhp+aL++apkE/c93nh1Fxr3GenkTlEJUqMRHOgiDXh X6qhWbmAP7R0yNojTSj+IdkUJKEr+KtvkO325GvMd46rCWMQianipeQgSDm+El0fZR rP4r86IvO/0JjffmsYkRTbkXtHZ9sSi39RvsiXwNt6plT+3B7FXwe8m7My8/9Ya6om U/FiGPRX7S3tQ== Date: Tue, 13 Jan 2026 19:09:02 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 4/9] gpib: gpio: Unify *allocate_private Message-ID: <20260113190759.54355-5-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: b1627126ece4e476702ca386c858b215042867dd Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/gpio/gpib_bitbang.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpib/gpio/gpib_bitbang.c b/drivers/gpib/gpio/gpib_bitb= ang.c index 374cd61355e9..3b8bd34f2f3d 100644 --- a/drivers/gpib/gpio/gpib_bitbang.c +++ b/drivers/gpib/gpio/gpib_bitbang.c @@ -1068,7 +1068,7 @@ static int allocate_private(struct gpib_board *board) { board->private_data =3D kzalloc(sizeof(struct bb_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; return 0; } =20 @@ -1205,14 +1205,15 @@ static void bb_detach(struct gpib_board *board) static int bb_attach(struct gpib_board *board, const struct gpib_board_con= fig *config) { struct bb_priv *priv; - int retval =3D 0; + int retval; =20 dbg_printk(2, "%s\n", "Enter ..."); =20 board->status =3D 0; =20 - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval < 0) + return retval; priv =3D board->private_data; priv->direction =3D -1; priv->t1_delay =3D 2000; --=20 2.43.0 From nobody Sun Feb 8 22:57:39 2026 Received: from mail-244121.protonmail.ch (mail-244121.protonmail.ch [109.224.244.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6519635CB93 for ; Tue, 13 Jan 2026 19:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=109.224.244.121 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331360; cv=none; b=L8ExubQpj/dXYok9f9likUkLSz51eBSbZol59HNZ8tbLszjMBtDSt6coFePpR9qmU5Pv5H5X/MEQPlqcvhvmYATk79vbefjeLDBpauv68rhCDrf/38Gh1TDX9W3SQVnviH3XhPZMp2OiY+40g6fZZDJd6cFU2VHfcEKMGc0vK28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331360; c=relaxed/simple; bh=05l2QJZM2TvNO02P8ZGElQ4F0ay07b2IJl8yzXcKP3c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NXiXfKCvxm0lk6zZhgkTo6hcUKkVWywFcxuk11wqZjCEpnKKW7eSLrwvH7fmUiOPdwQptMoqTwtDMxDGlyNYOYsXWTb8B4S3PlBc62MKuNDfrHlrmx8KwFYLE/Zjm37c8c7lY26sr6ZpyJhgmMwThdmsiq095x1Ga2576fOulM8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=PgCMAmtQ; arc=none smtp.client-ip=109.224.244.121 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="PgCMAmtQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331353; x=1768590553; bh=05l2QJZM2TvNO02P8ZGElQ4F0ay07b2IJl8yzXcKP3c=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=PgCMAmtQv+Ugc7ca1TdVtyy2eW0zplsADAMdm52g9R8n7gQpoPt3mCPDlhBrCB5ZR Wjm0ttAF3IiAR2ViSB8HnFJkhmDWDaZ/mbh7rBE/JLRGLw3E49kpycpe2agmui8YVy x56sm0UI+9hM9ZgCYsKNr/E4aaTDhQ8xibUaUki/UFRxYoo7uvzFRGvkcXNd3ZDWwi dQHtwkFgbSA99kGzDjMjayqJvjr0Cb3O5xVPYn6i6EcS5joKpWkgbq8DsvQ6ED+b0p i/JK+Adp6KwGj3pl6e1L/kBhli62ljUrCKUIEHxb2RTpPtlRyouGGMsxDFqwl+2QX4 PCPdGVGtfa4fw== Date: Tue, 13 Jan 2026 19:09:09 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 5/9] gpib: hp_82335: Unify *allocate_private Message-ID: <20260113190759.54355-6-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: f69c337b9670b27d31479faaaee9ec7103e68206 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/hp_82335/hp82335.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/hp_82335/hp82335.c b/drivers/gpib/hp_82335/hp8233= 5.c index d0e47ef77c87..871079dd1088 100644 --- a/drivers/gpib/hp_82335/hp82335.c +++ b/drivers/gpib/hp_82335/hp82335.c @@ -212,7 +212,7 @@ static int hp82335_allocate_private(struct gpib_board *= board) { board->private_data =3D kzalloc(sizeof(struct hp82335_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; return 0; } =20 @@ -253,8 +253,9 @@ static int hp82335_attach(struct gpib_board *board, con= st struct gpib_board_conf =20 board->status =3D 0; =20 - if (hp82335_allocate_private(board)) - return -ENOMEM; + retval =3D hp82335_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp82335_read_byte; --=20 2.43.0 From nobody Sun Feb 8 22:57:39 2026 Received: from mail-43102.protonmail.ch (mail-43102.protonmail.ch [185.70.43.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4727F35B14A for ; Tue, 13 Jan 2026 19:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.102 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331372; cv=none; b=WSrnx2aLE+6XkakhSquur69ctfgRtNaELk7JGPhcgjp2gGxju90VYRqW58uueUR/6n3mei0S48gHm0b8HYfzN2KvXGQJsCOhZSScB564SrbN8B+oiS8uxtmQN/U37P7CxHABfT25L3KgnNVcJXZ023MKwMYAz2cHwJ+CDOBdqFY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331372; c=relaxed/simple; bh=U7LY/wwVHSrG9c6LiUjedesdv41XgcRr/G6bfvi8D4M=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J+XQdn93fWCHMiTpnu9izVDKUi2OF0mvvNXkPXbufQXx0f0H5/+zsfIE8FLB2aSvbvaOhR9kTqe8BdGNxUY6EtRcky6nEAYBG7m0bKpRSxEqADhO6jbcUk4w5kvu7SYxGKg0uyfZOJJS69jyfrGRuF5GdmxrW8MfMT9fx0re83Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=BCHrmlDz; arc=none smtp.client-ip=185.70.43.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="BCHrmlDz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331357; x=1768590557; bh=U7LY/wwVHSrG9c6LiUjedesdv41XgcRr/G6bfvi8D4M=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=BCHrmlDzCwMZOo6v2jhbGpStekhSSDj8jeiR8rW/xA1omWRUuI+WN83U1GgBYLjUC PaqcTh8OvKieb0ZwSTy9WNbdMXk2IOClBhBkCFAHxldqWg57uN4lgHsbtTc8jYFnlB w5q6gSIrhRMr5G2rH2s339O63lMmef9buyqltuh+iC8rcuisUp3foZ/f7sy50hFQhX 5rxaeZyvuHMUYCGsQcMhVfOR74eI6ms88oLnj0TuwEKGPj1NaLj1MEMRrxg6yphlhp 9rDQEPVyW5Tjt6sZoG38wIonx4q1+Ybdkb5OjEeQGbUyvRjuHugjGyS9wfqpA7o17Q JQJNsVTfGhmrg== Date: Tue, 13 Jan 2026 19:09:15 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 6/9] gpib: hp_82341: Unify *allocate_private Message-ID: <20260113190759.54355-7-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: ac299aee5982876f67f994f927aa1eeb22ee618e Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/hp_82341/hp_82341.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpib/hp_82341/hp_82341.c b/drivers/gpib/hp_82341/hp_82= 341.c index 1a2ad0560e14..4a2440fe160f 100644 --- a/drivers/gpib/hp_82341/hp_82341.c +++ b/drivers/gpib/hp_82341/hp_82341.c @@ -693,8 +693,9 @@ static int hp_82341_attach(struct gpib_board *board, co= nst struct gpib_board_con int retval; =20 board->status =3D 0; - if (hp_82341_allocate_private(board)) - return -ENOMEM; + retval =3D hp_82341_allocate_private(board); + if (retval < 0) + return retval; hp_priv =3D board->private_data; tms_priv =3D &hp_priv->tms9914_priv; tms_priv->read_byte =3D hp_82341_read_byte; --=20 2.43.0 From nobody Sun Feb 8 22:57:40 2026 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B0D735B150 for ; Tue, 13 Jan 2026 19:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331379; cv=none; b=s0ecVJUD8TkqR4Rt+oQxfl9HDTnJO4brcksX2iffuyER4W8ZB4WgGY2paQjtCwxrxHkJDgAkCNisqjjRPbyWq8TrGaXPxPEPTZ5EMoWnVnYyFkX3I3k4WPwnZBrfYeYra1oOiIWiK8LgC/Hk1UP7QB2ceoRd904GHxTfw0qtknA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331379; c=relaxed/simple; bh=VVo1cPa8Qq8enlwClLOWNbEaZZM5rW/QX1GFz0NpdXs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WjSrLI1Qsbv9nWmCZw2aa4ElZHBlC17bnYNav4rpNwAX0TewCcg9N1mH8a1cFFycYGQZYFPEjAUxdwOWd8Abfu4LDgZcRxweXxPaOuHqcMT8F3e1C23PAzXy4iW+0UcJgSJNpWws25dQX9FLFNWy1v1zcz6Ot6G6HyDYu6Z+6AE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=Ayjc1M7w; arc=none smtp.client-ip=185.70.43.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="Ayjc1M7w" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331365; x=1768590565; bh=VVo1cPa8Qq8enlwClLOWNbEaZZM5rW/QX1GFz0NpdXs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Ayjc1M7wOdPvuIyuBT+g1nvd3PggtY9vTESk4Ox3mYTOUHH+ce6O00nDWYEbV0WwO box9aH5BZBplCTypezjkSx6cfc+Hv9sdr9K19ULErS87L4c6qfeEuJayobSxuGxuVi X6R1o5ZQehp/fH+PU5EKVB0CdcYtBcxXIk3No9OGiWPWZ9gPnNUfOuknlEXWxK/h7Y PIWWEvk8EaAFj1OnsFSw+rmRaumFtEmj6jSLt+O258ww3T0HFwQ51c99zrm3SIFf02 iKkE0SKhEsUDWWFUpubd3r8kdoWOjiRrQoMYf/AoVwxCxDNUO7JSoMMPn6QTYh3UNg 1JRWVKGYkm2eA== Date: Tue, 13 Jan 2026 19:09:19 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 7/9] gpib: ines: Unify *allocate_private Message-ID: <20260113190759.54355-8-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: d5bc5a4c84828e448c914f94a72fb8fbce094adb Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/ines/ines_gpib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/ines/ines_gpib.c b/drivers/gpib/ines/ines_gpib.c index a3cf846fd0f9..98f311f64d40 100644 --- a/drivers/gpib/ines/ines_gpib.c +++ b/drivers/gpib/ines/ines_gpib.c @@ -659,7 +659,7 @@ static int ines_allocate_private(struct gpib_board *boa= rd) =20 board->private_data =3D kmalloc(sizeof(struct ines_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; memset(priv, 0, sizeof(struct ines_priv)); init_nec7210_private(&priv->nec7210_priv); @@ -676,11 +676,13 @@ static int ines_generic_attach(struct gpib_board *boa= rd) { struct ines_priv *ines_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; =20 - if (ines_allocate_private(board)) - return -ENOMEM; + retval =3D ines_allocate_private(board); + if (retval < 0) + return retval; ines_priv =3D board->private_data; nec_priv =3D &ines_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 22:57:40 2026 Received: from mail-05.mail-europe.com (mail-05.mail-europe.com [85.9.206.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A9135CBA6 for ; Tue, 13 Jan 2026 19:09:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=85.9.206.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331383; cv=none; b=SvR7q1mCq80E+lUeFHCw8WymoSKIWBB2Bzx9LBrq9jJ2cXkKPQ2TPJsaUeMXJuiQ5JpngY8YBP/yuWrForY7XjOKWctNxHuT10cGrHrNIOLPqZcHqApN4MjI5D/4SCIo3+IUngG5cu1dvJ/JfMk1DKvjnACNabsu6jl/PcFULsc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331383; c=relaxed/simple; bh=9q2VvP/fi/Cb5xwfiXOep8LY0yrsd3FC++ByhW8WtJI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UrW/I5kllEirE7ng3D3PZa0HCHowY7QUtyfIXymhB6UDh3VsYkfNMHTklY7QPKEgFtoGB70YN+w2llugdTqPJNjiPRYAf0Hn9dAto+mRuE0VENFPSz5qo42RJGpf2nYaELaHF5DW6tYmSYAe1+9ZXhuyuyw4vVHeM6NqVkVcZb8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=pW9bgQMO; arc=none smtp.client-ip=85.9.206.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="pW9bgQMO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331368; x=1768590568; bh=9q2VvP/fi/Cb5xwfiXOep8LY0yrsd3FC++ByhW8WtJI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=pW9bgQMOq+wEcND4SQg7laipAGZv7YGZ76N8LSHXY85xIjzaloKk7bzIQX5aI7ot2 q7+koikJh3uoONbdj6DISwu1D7LEFIY9eGbudQ1fjoH208PJ0nMhhC0shrdvkl6XV3 q7vMY5ZLOArHLCy3thaYgJTDYTskCsjtIe8Ss8DEgOMVtODW4We4gECV+9TIUq8Enn KwbyXY21OMVvWd6lzwYkewaL9p90G0R1LcFKnH+yGRwNaOKxvgq8lC9Pf02dgXfs/o lcf/uHXNxK7pMEYY8CKurDvwPk/p84UHJL5u0oaWevmtIaDR1NystLt6NfsYlhxgyt Ivm1Dtf6jNq4Q== Date: Tue, 13 Jan 2026 19:09:25 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 8/9] gpib: pc2: Unify *allocate_private Message-ID: <20260113190759.54355-9-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: c9c737a78cc979fc19dec620986f9003f31e978f Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/pc2/pc2_gpib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpib/pc2/pc2_gpib.c b/drivers/gpib/pc2/pc2_gpib.c index 9f3943d1df66..93248b28982b 100644 --- a/drivers/gpib/pc2/pc2_gpib.c +++ b/drivers/gpib/pc2/pc2_gpib.c @@ -239,7 +239,7 @@ static int allocate_private(struct gpib_board *board) =20 board->private_data =3D kmalloc(sizeof(struct pc2_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; priv =3D board->private_data; memset(priv, 0, sizeof(struct pc2_priv)); init_nec7210_private(&priv->nec7210_priv); @@ -257,10 +257,12 @@ static int pc2_generic_attach(struct gpib_board *boar= d, const struct gpib_board_ { struct pc2_priv *pc2_priv; struct nec7210_priv *nec_priv; + int retval; =20 board->status =3D 0; - if (allocate_private(board)) - return -ENOMEM; + retval =3D allocate_private(board); + if (retval < 0) + return retval; pc2_priv =3D board->private_data; nec_priv =3D &pc2_priv->nec7210_priv; nec_priv->read_byte =3D nec7210_ioport_read_byte; --=20 2.43.0 From nobody Sun Feb 8 22:57:40 2026 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8045E35A94E for ; Tue, 13 Jan 2026 19:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.43.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331380; cv=none; b=UT1NkkcfDqKs+/NuaDfE2bKSqriajKOUjskuNOcX07Ngm8tjZpTiJGLOGCG9YoAzy/dbRvGifhHRsYJeSsBf6Fj/fas8hIXLBHSGbGtj+sFYo5mtCclAgC66FkDykPR2lmebzcCsnfUr02cGF5jK8Bb2rA7nOSia0hrjS8hdh3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768331380; c=relaxed/simple; bh=apGXgeWCBfuKeC6/ZUN5vENW8OXUmKiTv5g2GeKwJVs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qHfPiAaQ6Upp0axkpGZZ635W0RqYC5Qfk4vS7sPrSYGTYT8DulcwQXM2lWozBlqqeOWYOSbbDdlRm0TcUdU1w5E+SqK28qHY+PHJUlqDTJFj17n1IT8ZZ1fQjs4i0XVm7CVToxYegDLZJSR69MBc+9slolXpmfy2gJ74DRrlFgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=jc36tney; arc=none smtp.client-ip=185.70.43.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="jc36tney" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1768331370; x=1768590570; bh=apGXgeWCBfuKeC6/ZUN5vENW8OXUmKiTv5g2GeKwJVs=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=jc36tneyKUlMYhwPCgt5vfBoNiNKwiZNSS9aSZcm4FDUItncXwcPAWoxZ/xGibHJR un+2nYacJMGGrfIZlsa1jlWavJj0bdgKfS83eb/G50oizvK2r+ovhGrsAEYZt75Rz2 CZZ2siOtLd8lLSBtmK9qWWUk+WdhXI+lQoPWLndnQ8m6MOo4Nlxba+hju12RpcRQ56 /qkZEUqQepFF8qRmTz2I1QC0vTaSUL2ImCju+L+8uk1KonMqxacF8KVNFIQhRIFJdN CZHifsdvPW0RdJ4YzvSofxvNp8kPDVvZkm7VKQREMZWD0ti4mLUwoloizGdYgDlrLd bPJn+u5LAdVww== Date: Tue, 13 Jan 2026 19:09:29 +0000 To: Dave Penkler , Greg Kroah-Hartman , Michael Rubin , Dan Carpenter From: =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Cc: linux-kernel@vger.kernel.org, =?utf-8?Q?Dominik_Karol_Pi=C4=85tkowski?= Subject: [PATCH 9/9] gpib: tnt4882: Unify *allocate_private Message-ID: <20260113190759.54355-10-dominik.karol.piatkowski@protonmail.com> In-Reply-To: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> References: <20260113190759.54355-1-dominik.karol.piatkowski@protonmail.com> Feedback-ID: 117888567:user:proton X-Pm-Message-ID: 11f4bb1f2692da06d7ed79564928d363f427e2fb Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return values for *allocate_private functions as well as calling code in gpib driver are all over the place. Unify them by returning -errno if something fails, zero otherwise. Use the returned value as early return value in case of error. Signed-off-by: Dominik Karol Pi=C4=85tkowski --- drivers/gpib/tnt4882/tnt4882_gpib.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpib/tnt4882/tnt4882_gpib.c b/drivers/gpib/tnt4882/tnt= 4882_gpib.c index c03a976b7380..e12002c0e982 100644 --- a/drivers/gpib/tnt4882/tnt4882_gpib.c +++ b/drivers/gpib/tnt4882/tnt4882_gpib.c @@ -845,7 +845,7 @@ static int tnt4882_allocate_private(struct gpib_board *= board) =20 board->private_data =3D kmalloc(sizeof(struct tnt4882_priv), GFP_KERNEL); if (!board->private_data) - return -1; + return -ENOMEM; tnt_priv =3D board->private_data; memset(tnt_priv, 0, sizeof(struct tnt4882_priv)); init_nec7210_private(&tnt_priv->nec7210_priv); @@ -916,8 +916,9 @@ static int ni_pci_attach(struct gpib_board *board, cons= t struct gpib_board_confi =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval < 0) + return retval; tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; nec_priv->type =3D TNT4882; @@ -1039,8 +1040,9 @@ static int ni_isa_attach_common(struct gpib_board *bo= ard, const struct gpib_boar =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval < 0) + return retval; tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; nec_priv->type =3D chipset; @@ -1725,8 +1727,9 @@ static int ni_pcmcia_attach(struct gpib_board *board,= const struct gpib_board_co =20 board->status =3D 0; =20 - if (tnt4882_allocate_private(board)) - return -ENOMEM; + retval =3D tnt4882_allocate_private(board); + if (retval < 0) + return retval; =20 tnt_priv =3D board->private_data; nec_priv =3D &tnt_priv->nec7210_priv; --=20 2.43.0