From nobody Sun Feb 8 02:21:43 2026 Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B5734FF41 for ; Tue, 13 Jan 2026 17:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768325310; cv=none; b=TW1pSEhX8zpCA8V2ps/XM4L1PORt2ni9Hlye9EAhAjdJ/QcsVEuHFkHIzBYwW8piB8tMe2lBhhQ//rQl5UO6cCJAdNYNluIAf6ENIAN/GkPgiGCeEmmo1O48QSwH+8GllG20I6fsBuVrX9IrakJJJj3UGFOvnpF61m6Nj8YPOqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768325310; c=relaxed/simple; bh=Meer6c/+X91D0YLd3GkyH0qSgLCdVWodXhHDmNNWOz4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rX2CjOr6yrIeKav1rd/V8Vu9UAelYS+VfNpzOrLtxRQ+MueSbAyHzO3Xr9KulyZDySsju4DNnkxiJHF4q2FccPhi8pnuu++33TADLOwHGa0B2arIJoq7a3DysnVDQ5aLPQYTPJvP/dwnfGbg40n8swWvdXmWS0JVE1wmwKhzVh4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=tEyHO7vV; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="tEyHO7vV" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768325306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Rq1GG13WEjuhbrUN4QhlIVzArVbIZqAs8DmSHZ1p7AE=; b=tEyHO7vVhD3Kroo5udCD8vXTcxif0X2zs6I+L6NXrXYLrahB9e3qdWNfjHs5TRR2jANoAb /9LKSNgp4Ko+DkjiFueJh0XHwYOj/h7cMdAW4l3wCVYLbgpxodh4iAiO5bMj4dVPfX1vxD nuAGJVYFhpv4d+WS4vStBpI5/Xr87aw= From: Yosry Ahmed To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Subject: [PATCH] KVM: nSVM: Drop redundant/wrong comment in nested_vmcb02_prepare_save() Date: Tue, 13 Jan 2026 17:28:07 +0000 Message-ID: <20260113172807.2178526-1-yosry.ahmed@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" The comment above DR6 and DR7 initializations is redundant, because the entire function follows the same pattern of only initializing the fields in vmcb02 if the vmcb12 changed or the fields are dirty, which handles the first execution case. Also, the comment refers to new_vmcb12 as new_vmcs12. Just drop the comment. No functional change intended. Change-Id: Ib924765541fe3d8753b84b7ead8b47d8a24f0c8d Signed-off-by: Yosry Ahmed --- arch/x86/kvm/svm/nested.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c index f295a41ec659..cb00829896cc 100644 --- a/arch/x86/kvm/svm/nested.c +++ b/arch/x86/kvm/svm/nested.c @@ -699,7 +699,6 @@ static void nested_vmcb02_prepare_save(struct vcpu_svm = *svm, struct vmcb *vmcb12 vmcb02->save.rsp =3D vmcb12->save.rsp; vmcb02->save.rip =3D vmcb12->save.rip; =20 - /* These bits will be set properly on the first execution when new_vmc12 = is true */ if (unlikely(new_vmcb12 || vmcb_is_dirty(vmcb12, VMCB_DR))) { vmcb02->save.dr7 =3D svm->nested.save.dr7 | DR7_FIXED_1; svm->vcpu.arch.dr6 =3D svm->nested.save.dr6 | DR6_ACTIVE_LOW; base-commit: f62b64b970570c92fe22503b0cdc65be7ce7fc7c --=20 2.52.0.457.g6b5491de43-goog