From nobody Sun Feb 8 11:41:01 2026 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59D062C08B0 for ; Tue, 13 Jan 2026 14:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768315826; cv=none; b=lnq/ALB32S+fsH8jLVig6jlg/T6YObVmE0cp29O06vNtMmvpfCFISrGoNpATrX9b+K7btncLqInw4c5tDS8QrEiBGUlMeQHHoO0hBmtbbqExs7XL80JnGarJavnoii7JeYt6Oboy4h1m59Gp2hwkD1MHqSl4yOIYQE4kCAq9M0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768315826; c=relaxed/simple; bh=gwGyGXZoKGhUR7yVpkCfGp98uDGh70OIB4gsT59bFI0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=b0glEiPVACn1yNNOLYf9tpf5AypDAJFYxfJ9XD95h9TprIcrVBrqtClNigH82orWMn0MFOCfviiD1Zw+yWnY4jYG7rkJUC6npKo++kbcPlZ3lVAig6MlKdYOvyklm9qhHtzf5YnD/40BPMx1PDvP0iOK43KxKgpx9XBGjYJfG7k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=WtQVdUct; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="WtQVdUct" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-43284ed32a0so3918737f8f.3 for ; Tue, 13 Jan 2026 06:50:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1768315823; x=1768920623; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pT8HtWZ7bhGeduu7Js1yvS3Fnv/m2JoB3j3HxYtKEl4=; b=WtQVdUctzB3Ievq2ym0Ufw03f3b8oHM98agrO/EoQKhQ3KjzOOSc0d0/7Mpc3C9OoK UcaCgcYIOHmzZGO21HvQnIYzKexwtGS8B/m/YRDXgkiywloUCx4ZfUW6srrYNN6ipf3F PSU+iRGVbAlhm/YPFc45PuLLd+lLiZE8AejgXWRw4wrpY/B+hlSrC4Jh+x0vycpaQwLH wvCX/Rf1ONjLroM5ikKymn6ocWdGp0jV16tktu/CuSBYT+HR9z4zzFId703Cww5lKpEd 8pCJIUkcr4LlBpONU1//Udn1Xc4lNQXToR5XXold2w+fI5PK/z3Rj5JdkHHPLxyB5rEj qSZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768315823; x=1768920623; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pT8HtWZ7bhGeduu7Js1yvS3Fnv/m2JoB3j3HxYtKEl4=; b=IGawboC6NBNC2126ujS1X5XyXYt6lerzPYCXuFVbfL1ABYBEZApyOYqO2OkBOO43QQ MPoQm33llycVI3SOBhhYTKPTMUPhkdvbjLY6Xl2MrLd9oGTRxnRB56vXUWmrZvCeddvM 7JCL/2AUirjOczeeM7TwC8UFOaPURPjDv9ZpH5pViVST+JDVFMMBtAGZB7ogYC2BDNMy m6wqndZPqZIfZO2/qA0rIUQyQZo/uBK687UlSgE5gKR2eGKhG67XggIYv/4oECixX1a6 OrQK1/EvUaDlsUBlXQjzU2uHRXf1L6KhMAmDs9L5W50qxkKRWP3AEXgtDuI3AkJymIfG zVrw== X-Forwarded-Encrypted: i=1; AJvYcCU5j+nxTjQ0NZrewPA2Ji++DuRsarXiXQz8fllHGapBP8ldBDLE/XSrY3DLWeFeO3ArRrznB3rLlvDoOHY=@vger.kernel.org X-Gm-Message-State: AOJu0YwiVottnDAclB8IGyxMcA1leD/11hXALbF5L1iuL7bIZgyhDVdn R9xLVPuM8+E10uWPSHRECeYAqP73jX1cdxlXRo9SyuEiepEZQsZWnHLIVTvcKPjNIFM= X-Gm-Gg: AY/fxX57BKEq3oe/H5C91/5+bTOU6X4cve9ppkPi18Iil6fw5LnY7vA3UOlkrAQeZmB UPBhVcfwnvfds9xUa11o0eX+0+aU0FaGwB3xy0uHqA+jFPK1xVcJSjukYmvj/WotshHw1XQutTk wo8b8aZU1VvUDOjmCa5Y29cb3/x62Dn5JH4NdNqAT33SJJIKiAJrk/at2Xvktp2urn8et4QaV+Z S2OnKXweKL4iV/b6AwzUJClncMue36ChSdHX+qeHxRezV7BvgVHgovvtu8a/VsnLOAo+VQq4UV5 XGa4EvyuCzYELZQUQClMx4jlqV7xf2YbgGEHbZiqfpbE32PqKca4fAYYAMhobGV3bVM3yueU+Nq KRk5XFhd7oXlDPbvYR+yt/PcmGFZyjlKpmQKCPCfKkqSEk56cJl9qOSHlr88Qp6/n8rl808OHQA 5Yd06Olp/hQSHiGLODxsvlLX3Cn8K1Xj1T4ilIPWaxYhCtds4DZgPfTirBHeGjw7gvS7EXmbH9b 3A= X-Google-Smtp-Source: AGHT+IECFzghAT8Q3ptMlbUy7ZuR27SMLHy0JrGto7kIH4jxQBz2y2Gie3XK2KIud6pvAnQLS/aaew== X-Received: by 2002:a5d:5f54:0:b0:42f:bb9b:9a82 with SMTP id ffacd0b85a97d-432c37746d9mr26127012f8f.60.1768315822565; Tue, 13 Jan 2026 06:50:22 -0800 (PST) Received: from localhost (p200300f65f20eb04fab5de2138b6a8fa.dip0.t-ipconnect.de. [2003:f6:5f20:eb04:fab5:de21:38b6:a8fa]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-432bd0daa78sm45419522f8f.6.2026.01.13.06.50.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 06:50:22 -0800 (PST) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Greg Kroah-Hartman Cc: Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] greybus: Use bus methods for .probe() and .remove() Date: Tue, 13 Jan 2026 15:50:09 +0100 Message-ID: <20260113145012.2379944-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2465; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=gwGyGXZoKGhUR7yVpkCfGp98uDGh70OIB4gsT59bFI0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBpZlukObv+1XpB9pMerotsBPU9oifT5io0rqk4E GHGQo/hLcSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCaWZbpAAKCRCPgPtYfRL+ TgCSB/9mNe1EA83h6Cqwyr7JxazoacmIHbZJ9EssrEVmRRbrcG9WZqzmKX84NdvkrnG4gPUYhzy Qstz1t5COwNr+QCApJ4/5uje/c8es92xMDOYpKNn2p0ruIWRVAqZdfl8bNXypCgWnUnpyWqxcej ZSrOnsWXZeZgVUm6AUsFmabiTpKrSijpRiUErjossOCABd5uPBAYIMKSFsXMgx9L7C+8RoKvVGU cH8Riv/hOS05+/SwSsJaqeDaraqJjxaixQMCyrK3IcOMsNd+4dQHW0I5wj3FuynebSfAFczG1CS 9AWgjbpdGyFCNPpvEryiva32rZg1/cHxxJCaI11G9cCGHohx X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable These are nearly identical to the respective driver callbacks. The only difference is that .remove() returns void instead of int. The objective is to get rid of users of struct device_driver callbacks .probe() and .remove() to eventually remove these. Acked-by: Johan Hovold Signed-off-by: Uwe Kleine-K=C3=B6nig --- Changes since (implicit) v1, https://lore.kernel.org/greybus-dev/20251210175943.590059-2-u.kleine-koenig= @baylibre.com: - keep tabs in the struct initializer - Add Ack by Johan drivers/greybus/core.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/greybus/core.c b/drivers/greybus/core.c index 313eb65cf703..45c5437c460f 100644 --- a/drivers/greybus/core.c +++ b/drivers/greybus/core.c @@ -185,13 +185,6 @@ static void greybus_shutdown(struct device *dev) } } =20 -const struct bus_type greybus_bus_type =3D { - .name =3D "greybus", - .match =3D greybus_match_device, - .uevent =3D greybus_uevent, - .shutdown =3D greybus_shutdown, -}; - static int greybus_probe(struct device *dev) { struct greybus_driver *driver =3D to_greybus_driver(dev->driver); @@ -252,7 +245,7 @@ static int greybus_probe(struct device *dev) return 0; } =20 -static int greybus_remove(struct device *dev) +static void greybus_remove(struct device *dev) { struct greybus_driver *driver =3D to_greybus_driver(dev->driver); struct gb_bundle *bundle =3D to_gb_bundle(dev); @@ -291,10 +284,17 @@ static int greybus_remove(struct device *dev) pm_runtime_set_suspended(dev); pm_runtime_dont_use_autosuspend(dev); pm_runtime_put_noidle(dev); - - return 0; } =20 +const struct bus_type greybus_bus_type =3D { + .name =3D "greybus", + .match =3D greybus_match_device, + .uevent =3D greybus_uevent, + .probe =3D greybus_probe, + .remove =3D greybus_remove, + .shutdown =3D greybus_shutdown, +}; + int greybus_register_driver(struct greybus_driver *driver, struct module *= owner, const char *mod_name) { @@ -305,8 +305,6 @@ int greybus_register_driver(struct greybus_driver *driv= er, struct module *owner, =20 driver->driver.bus =3D &greybus_bus_type; driver->driver.name =3D driver->name; - driver->driver.probe =3D greybus_probe; - driver->driver.remove =3D greybus_remove; driver->driver.owner =3D owner; driver->driver.mod_name =3D mod_name; =20 base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 --=20 2.47.3