From nobody Mon Feb 9 17:23:01 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54DB53904C2 for ; Tue, 13 Jan 2026 13:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768309569; cv=none; b=WJ+BMhcbZJl6i+2AG2Y+KFDPKDJkKhxrnFTT3MamTSseARzzOTnoGR8g5EiBqLvSu6qLAWvVjCCWEqiPu0V2Hpv/Aa/d5DFSXlrQE6ta/Oq5fh8AablidSrPtXCdFZE5alBFuduWL2e4kenPsnGV83hAMcyYkZDHF+wdTcuW0G4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768309569; c=relaxed/simple; bh=xDKAaqJEsHbZnL+cmpHT9aD/t1xQZpYd2AXwHmw7ASc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOz+MwVUhaBJXLvQzozBaobBj3kGauNZF4I1a2bt7Tm4+gJuF/DOYVm/WbgN+qqirH4ZIgVDa4XKaRyKjbKtJi2ohVL6RR+YfanO49HIkLBjPgeR8pCaivNoYwacfzdXmlaV3NJtWgZEMEC+oCf7WVDgCH9tOJk0PS9SnByAdnI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DAPXqVLP; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DAPXqVLP" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b86ef1e864cso367264666b.1 for ; Tue, 13 Jan 2026 05:06:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1768309560; x=1768914360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ozHGUyiY6A9TybEdpmpfYkpaTQz6PtmOWnadeDhNFJQ=; b=DAPXqVLPu8jR3x+rx06HshbcAW+Ev1JU3FrRRNCMib6vvz94JCDzkFfS6MRRm3HV8I XL3m+aEybIOsi8XATyQS9BlhRuBQ2gm4nOGgdJ3z6d+koD1MPta0n136Nt9Z26TOL0+Z Zl/cRW7z7ljRcxdXV4/DY75PM7UoXaS0PwFFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768309560; x=1768914360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ozHGUyiY6A9TybEdpmpfYkpaTQz6PtmOWnadeDhNFJQ=; b=Wbuop5tiiYzFvsIUWvvJ7Hx6n160TfEWViSA1sD2aVmk9CFroTOAjJmEtD9F3Wcpyn AteGb8obG2PUogkYWf4ulXkJW7VMKHeNKlc/fJURN2iNOSlQjAuEm45PGtXbjhmNrc/W xBqZaRShj+6UWL+KOfjeVyMd5wLv10SabzKJWkZJDDStcpodBPrlr/6FFvp82nsrzWNV Vfqd5uMb/IbOmCKiHt/+2Ik5DdRISv71qXWS770PXhDyjCXeuzk+q8PF7CnQGzeak10m gq8cRnMxFhvipjYFgQLf/AwiE3mT7spYO8y/xtKaQIZgzw9EsQmiywb0k1DL/ANae8rR AG6Q== X-Forwarded-Encrypted: i=1; AJvYcCXd0EQVFd0TjLHoSmd3uC/a7lxmIQjte3j8eatuqS74OPbdiW7OjRjy28FLcfwwNYpgvQNd22IC1sV9arY=@vger.kernel.org X-Gm-Message-State: AOJu0YyC/iq+PPzB/dkfZEhowcFL/PMHndQ7qBSuqB8T97krJK1Nkj39 5QDrLsFft/ESUjhtS/uj5rCE6Z2wj0u3ROSu4EeN814stAQngi35XR/wRHKBd8Q8UA== X-Gm-Gg: AY/fxX6+mKyV8Amj3oos76EIOS+we6/gn8G2/5ZUHyj58atVoNykuM3SoP8BoS4x+SR yG13lF01PDXNY5DJj/vpY/W/v/fNuJDihrs03lOPud6ePoV5C69R0CEQIELBUq8V2qopcJuaNhH bGjO8kNsbocdFHwYUvA+qnR2LUTufYgQLqQqboxdrFoGC43OFjmf/vGz5XGHlQf6eBJ0p2Y50ol GGwhqkHnr3Vmip09gkG3U0GHL0EZ3P5QflTEiWrUgKy5KZDR/vp2D2b9ATjHPsFwYlpQfLJ3kGU AX9FKEGDH0iAbHDZMetWtdlegjos3fLz0D0Ked6vH13+LCAQr0VtpeCUCqTXS/VG18pf7a/EbND CFXAgQgEJ1y156L5hGAVV1gQDhwoHnVT1kbXTrRCk9lke06neGqRXlhY3vOVGaYGbVbvUI14n9J DqMV8liJg0Fhy3Z/hidzqEF8qwNUATLsXNkIcPcok4qeflDbD7VWB6sd7/e/IMn+YKrED+VukIb ZyCwVBY X-Google-Smtp-Source: AGHT+IERLF4PHZwh7YhwuDFtdlx0ez3BDip2EOvxGlTqLDh5wkJQ8ZMkQJAb5HRrvhsdbkq8VQofMw== X-Received: by 2002:a17:907:780b:b0:b87:1fe8:9534 with SMTP id a640c23a62f3a-b871fe8af72mr384125466b.48.1768309560490; Tue, 13 Jan 2026 05:06:00 -0800 (PST) Received: from akuchynski.c.googlers.com.com (150.230.32.34.bc.googleusercontent.com. [34.32.230.150]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b871b5e60dasm586217266b.63.2026.01.13.05.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 05:05:59 -0800 (PST) From: Andrei Kuchynski To: Heikki Krogerus , Abhishek Pandit-Subedi , Benson Leung , Jameson Thies , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Tzung-Bi Shih , Guenter Roeck , Greg Kroah-Hartman , Dmitry Baryshkov , =?UTF-8?q?=C5=81ukasz=20Bartosik?= , Abel Vesa , Pooja Katiyar , Johan Hovold , Hsin-Te Yuan , Madhu M , Venkat Jayaraman , Andrei Kuchynski Subject: [PATCH v4 8/8] usb: typec: ucsi: Enforce mode selection for cros_ec_ucsi Date: Tue, 13 Jan 2026 13:05:36 +0000 Message-ID: <20260113130536.3068311-9-akuchynski@chromium.org> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog In-Reply-To: <20260113130536.3068311-1-akuchynski@chromium.org> References: <20260113130536.3068311-1-akuchynski@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The mode selection sequence is initiated by the driver after all partner alternate modes have been successfully registered. When a partner is disconnected, the driver also stops the mode selection process and releases resources via `typec_mode_selection_delete`. Signed-off-by: Andrei Kuchynski --- drivers/usb/typec/ucsi/cros_ec_ucsi.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/usb/typec/ucsi/cros_ec_ucsi.c b/drivers/usb/typec/ucsi= /cros_ec_ucsi.c index eed2a7d0ebc63..437a2982a9d51 100644 --- a/drivers/usb/typec/ucsi/cros_ec_ucsi.c +++ b/drivers/usb/typec/ucsi/cros_ec_ucsi.c @@ -16,6 +16,7 @@ #include #include #include +#include =20 #include "ucsi.h" =20 @@ -33,6 +34,11 @@ /* Number of times to attempt recovery from a write timeout before giving = up. */ #define WRITE_TMO_CTR_MAX 5 =20 +/* Delay between mode entry/exit attempts, ms */ +static const unsigned int mode_selection_delay =3D 1000; +/* Timeout for a mode entry attempt, ms */ +static const unsigned int mode_selection_timeout =3D 4000; + struct cros_ucsi_data { struct device *dev; struct ucsi *ucsi; @@ -134,6 +140,19 @@ static int cros_ucsi_sync_control(struct ucsi *ucsi, u= 64 cmd, u32 *cci, return ret; } =20 +static void cros_ucsi_add_partner_altmodes(struct ucsi_connector *con) +{ + if (con->ucsi->cap.features & UCSI_CAP_ALT_MODE_OVERRIDE) + typec_mode_selection_start(con->partner, + mode_selection_delay, mode_selection_timeout); +} + +static void cros_ucsi_remove_partner_altmodes(struct ucsi_connector *con) +{ + if (con->ucsi->cap.features & UCSI_CAP_ALT_MODE_OVERRIDE) + typec_mode_selection_delete(con->partner); +} + static const struct ucsi_operations cros_ucsi_ops =3D { .read_version =3D cros_ucsi_read_version, .read_cci =3D cros_ucsi_read_cci, @@ -141,6 +160,8 @@ static const struct ucsi_operations cros_ucsi_ops =3D { .read_message_in =3D cros_ucsi_read_message_in, .async_control =3D cros_ucsi_async_control, .sync_control =3D cros_ucsi_sync_control, + .add_partner_altmodes =3D cros_ucsi_add_partner_altmodes, + .remove_partner_altmodes =3D cros_ucsi_remove_partner_altmodes, }; =20 static void cros_ucsi_work(struct work_struct *work) --=20 2.52.0.457.g6b5491de43-goog