From nobody Sun Feb 8 18:15:52 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 091B5394489 for ; Tue, 13 Jan 2026 12:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768307884; cv=none; b=kCA+y+j7VzVIzNrIAyA5Cpn+PC6wHXCBlWpDqvYa38WbRZ6zuQQLJ1WfP+BasiKNv268KnHV1+9+oawQKYftuz2VUYlHKsEhuniSVXCxOtt9AqKO8ji89cLKvXNg81+nZKxMNmmMvxSyW3l6bxpUxWJMKQenWOExUz7+BLYj+WE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768307884; c=relaxed/simple; bh=CCULviIUt1z9O4zm0Y/tKUyP/DMbEeojREOXeyucv0w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fD/82Zuh2Rb5OPgN8hcgHwdQjTeT3dootT66AL2bN85qX+xifecBFcnwV1qk8hLeV61c9b66E7egludzdwk0uZEbSSy82AUaQBjnORbiaXwrzl/xv2yCk7iVLX8kokYRJKDZK8u5n8/QxoAiLv7mob0evYiaFpZl98bhxZwP99I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TjAF6B46; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TjAF6B46" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81f47610542so1198813b3a.0 for ; Tue, 13 Jan 2026 04:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768307880; x=1768912680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2KgPNZ1+hiG4bP2a4hNVRlEnc7lnvw26sruTYHkKl3A=; b=TjAF6B46C1880MRmAKko5tS55L1chEmPHhJ2d5ObRAw6+1tmQZM5Z8aMnBXN9GaU32 wqP7DWJ0NYNfPyaMqvhKYQtLzklElcrshJHU6Cal4Lki5dOyBKGAdCPi2IUjIdy71bUj TLne4nfC4SnF3rg9UC1Nn+fxPzGDT+Ru12+7TgcoQHK1GkIxz8LU1rS47dfIh4Gongw4 NZe3KmEhFA5oSccgvX3sGeL/N3Sh8jcx6bHtErJCVnVtwzO2ftvVt+VZ1y446XAyryEx 3PAP5rlUnQ+8AI8ga8ry3WlS7Wlp0+ahgxQ1LkPkqBmZT24uYqrR+T2G/KpfrqNdXF+b 6NZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768307880; x=1768912680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2KgPNZ1+hiG4bP2a4hNVRlEnc7lnvw26sruTYHkKl3A=; b=WEmDPzRURra7MjIVVO3LRNCcaBGQ0NEb8urSSLlvnSPm/rvO9YYzDfU0Epd9V1ACEI YzYh2CoxbXdQujYf0vJm5wzOoV65E/5VWmCji13AoaY2BV3DdpwfuQjCcHGuMNTtnViE eFCOArGSNv5TvlyZ/C5i7VfV8e/cj7zHob5HCj9vTOxsbJ2hLXAufZo1M4qy27nbvrQA r6RdPrmyczqoS1dT0gJDKKTlpdgAdR9mN8yZ7SNUcOpTiAw0DScn7vuyTBP+uc7RWwVg GmBK2IeSbFYaT0gOt1rhelbbF3ta7WibHMatRTJX5c+gA/YpxI4L7vj+TAw0sap11TzU 2OMQ== X-Forwarded-Encrypted: i=1; AJvYcCUXRpyjjc7zkhL5G4y6ybYNDVRjOlM0JYcplhNLVjA+jAA8mSwLYo2NpRvbC8efA927QouzarMzqy9rbxo=@vger.kernel.org X-Gm-Message-State: AOJu0YySE1sxGTofZ1VZqDRBJzM8fFB3PuFdy8fbJryvzMnZZU/VbfxD gnAPIJI8lJHjjVDqsgYRvIXBR9n59fzcqkIlH6WT2zkezSGfh5JyMvK7 X-Gm-Gg: AY/fxX7ZLB7+bKljsEfFZaFVAKaYAerkAsHp6nDs5mteqfp0lmqQpRXP3wODyK3Suha 2b+8xVqWyeobKd3/fD8Y9SJFcuQamLQo/5KNN+vf2ANOfFfbMgpljhbVkOlTwHZh2YD5Q8qDZ8S KqRF/F3aqIvqpylK8wVx3euDfRrsJ/P/71zVnjGrOGlH7K7rnnc0fgUCRiAywtbfkTqfsQart3N Uwfs0Vic1yTPTz0GLCnLiDZ13A1ssVXot38Xc/EBsP/Mtq5G5BUknoNLSxocxXfBoj3FNFvFguO Stqno8cH2AUQQ97iJ/zIYkVqEZjAqPjGNzGoojHGCHzGv/qB8t6vW6T6Po+TXQ56CAG44AmhFlm xDpR5lDiP2fCEmZo2B63DLt9RmdWelmCQoZ4cfB90Ussx03l7E3N+IUwRy2w3KAiawmdHltX5Zh RKBbEh/MxiUKS8u5ET5HM= X-Google-Smtp-Source: AGHT+IE4FDzI2fl3iF/FeHvk73xQO0/uUff9GpZajmdaH4++8DOBr9WgUzShXoJrvM7PV7zAGGon7Q== X-Received: by 2002:a05:6a00:8c10:b0:7b7:5066:7f9 with SMTP id d2e1a72fcca58-81b7e928742mr18063499b3a.7.1768307880309; Tue, 13 Jan 2026 04:38:00 -0800 (PST) Received: from archlinux ([2405:201:1b:225c:eb9d:1fc0:f95c:bd90]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81e9dd8fd8dsm11409000b3a.10.2026.01.13.04.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 04:38:00 -0800 (PST) From: Krishna Chomal To: ilpo.jarvinen@linux.intel.com, hansg@kernel.org, linux@roeck-us.net Cc: platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Chomal Subject: [PATCH v3 3/3] platform/x86: hp-wmi: implement fan keep-alive Date: Tue, 13 Jan 2026 18:07:38 +0530 Message-ID: <20260113123738.222244-4-krishna.chomal108@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113123738.222244-1-krishna.chomal108@gmail.com> References: <20251230145053.516196-1-krishna.chomal108@gmail.com> <20260113123738.222244-1-krishna.chomal108@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The firmware on some HP laptops automatically reverts the fan speed control to "Auto" mode after a 120 second timeout window. To ensure that the user-selected fan profile (Max/Manual) persists, implement a keep-alive mechanism that periodically refreshes the fan mode trigger before the timeout occurs. - Introduce a delayed workqueue to trigger the fan mode refresh every 90 seconds, ensuring the system maintains the correct fan mode setting. - Integrate the refresh mechanism into hp_wmi_hwmon_enforce_ctx() to start, update or cancel the keep-alive process based on the current fan mode. This ensures that the driver stays in sync with the hardware. Tested on: HP Omen 16-wf1xxx (board ID 8C78) Signed-off-by: Krishna Chomal --- Changes in v3: - Rename "ctx" to "priv" for drvdata Changes in v2: - Explicitly specify time unit in KEEP_ALIVE_DELAY macro - Handle work rescheduling directly in switch/case --- drivers/platform/x86/hp/hp-wmi.c | 46 +++++++++++++++++++++++++++++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-= wmi.c index d04e53ae1803..45ab644ff10e 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -34,6 +34,7 @@ #include #include #include +#include =20 MODULE_AUTHOR("Matthew Garrett "); MODULE_DESCRIPTION("HP laptop WMI driver"); @@ -368,6 +369,7 @@ struct hp_wmi_hwmon_priv { u8 gpu_delta; u8 mode; u8 pwm; + struct delayed_work keep_alive_dwork; }; =20 struct victus_s_fan_table_header { @@ -386,6 +388,12 @@ struct victus_s_fan_table { struct victus_s_fan_table_entry entries[]; } __packed; =20 +/* + * 90s delay to prevent the firmware from resetting fan mode after fixed + * 120s timeout + */ +#define KEEP_ALIVE_DELAY_SECS 90 + static inline u8 rpm_to_pwm(u8 rpm, struct hp_wmi_hwmon_priv *priv) { return fixp_linear_interpolate(0, 0, priv->max_rpm, U8_MAX, @@ -2093,6 +2101,7 @@ static int __init hp_wmi_bios_setup(struct platform_d= evice *device) static void __exit hp_wmi_bios_remove(struct platform_device *device) { int i; + struct hp_wmi_hwmon_priv *priv; =20 for (i =3D 0; i < rfkill2_count; i++) { rfkill_unregister(rfkill2[i].rfkill); @@ -2111,6 +2120,10 @@ static void __exit hp_wmi_bios_remove(struct platfor= m_device *device) rfkill_unregister(wwan_rfkill); rfkill_destroy(wwan_rfkill); } + + priv =3D platform_get_drvdata(device); + if (priv) + cancel_delayed_work_sync(&priv->keep_alive_dwork); } =20 static int hp_wmi_resume_handler(struct device *device) @@ -2179,12 +2192,20 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_= hwmon_priv *priv) if (is_victus_s_thermal_profile()) hp_wmi_get_fan_count_userdefine_trigger(); ret =3D hp_wmi_fan_speed_max_set(1); - return ret; + if (ret < 0) + return ret; + schedule_delayed_work(&priv->keep_alive_dwork, + secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); + return 0; case PWM_MODE_MANUAL: if (!is_victus_s_thermal_profile()) return -EOPNOTSUPP; ret =3D hp_wmi_fan_speed_set(priv, pwm_to_rpm(priv->pwm, priv)); - return ret; + if (ret < 0) + return ret; + schedule_delayed_work(&priv->keep_alive_dwork, + secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); + return 0; case PWM_MODE_AUTO: if (is_victus_s_thermal_profile()) { hp_wmi_get_fan_count_userdefine_trigger(); @@ -2192,7 +2213,10 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_h= wmon_priv *priv) } else { ret =3D hp_wmi_fan_speed_max_set(0); } - return ret; + if (ret < 0) + return ret; + cancel_delayed_work_sync(&priv->keep_alive_dwork); + return 0; default: /* shouldn't happen */ return -EINVAL; @@ -2336,6 +2360,20 @@ static const struct hwmon_chip_info chip_info =3D { .info =3D info, }; =20 +static void hp_wmi_hwmon_keep_alive_handler(struct work_struct *work) +{ + struct delayed_work *dwork; + struct hp_wmi_hwmon_priv *priv; + + dwork =3D to_delayed_work(work); + priv =3D container_of(dwork, struct hp_wmi_hwmon_priv, keep_alive_dwork); + /* + * Re-apply the current hwmon context settings. + * NOTE: hp_wmi_apply_fan_settings will handle the re-scheduling. + */ + hp_wmi_apply_fan_settings(priv); +} + static int hp_wmi_setup_fan_settings(struct hp_wmi_hwmon_priv *priv) { u8 fan_data[128] =3D { 0 }; @@ -2393,6 +2431,8 @@ static int hp_wmi_hwmon_init(void) return PTR_ERR(hwmon); } =20 + INIT_DELAYED_WORK(&priv->keep_alive_dwork, hp_wmi_hwmon_keep_alive_handle= r); + platform_set_drvdata(hp_wmi_platform_dev, priv); hp_wmi_apply_fan_settings(priv); =20 return 0; --=20 2.52.0