From nobody Sun Feb 8 04:34:40 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489A92D5432 for ; Tue, 13 Jan 2026 10:37:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768300666; cv=none; b=uFOpVvPTWbgkxXunxJriZwLUx/xS8V14NhHMVs/idhW65iZrFRTecpnHTJpKsPBVF/jYc+BRI142hUYsZcorcfCK3g/MHp0TFNpSn8AOG89Sku3wBHsfQcDmzI9bAdcs5WE4fnrFBXCCXcw1W0zY9Xw1fgSuhD6WqD8t+kg69SM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768300666; c=relaxed/simple; bh=0kytHVNeJhJC0XXVaCMs5aSv7phmolsyKnR1GsjYMNc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dsnSNmBjIM0sbGP4S0XiKJqpTUBlrSvt6Jl+Rl5mItFD1Ad+RjcL2oH8/NDaIcB8qs2fFVBqRH/7A2djlkR1TP9z4BWnDmE0NtYklL2x9hDhSlFpI2qTBDsgx84mclUPbz7K3MJyuxBY4QDa2HlDPZByhp6lMx73N3TtW5iKW9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V46Tw7wE; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V46Tw7wE" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a0bae9aca3so47337045ad.3 for ; Tue, 13 Jan 2026 02:37:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768300664; x=1768905464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Oazj4yczN23Rbwqju/OxFHmi/BXkpTACewJYAxvqYXs=; b=V46Tw7wEW2RuJDZWT6RkImoNpw5mwqJ+pGozt9lfKRKQpvyCOj2o0Ke2ZkTnldyLs6 Ix+SjY5k+9GApEC4YAOGTDPF6o5MGPmHuVKbhxE2hLGutmBAPX8uLCr7fRMT4lXDZC8c t279c6wzceLlxtLFhBnZYF1kMVKbkC57DOtVdambtEOJX/VDrbyQhQcNlyN2zHaOvdTF 6/pH63W3AwD9PCB40jrA2xXWKxzuge+glpOgozu1d6N/bUa/8uCg1zHGuYyV/92l5cT2 ousP1pmUlvLMiO9B+v4o1qPb3aIR6aC5zSyFBp4AC82pkTolXxMGw1UIqUY+gXDBFOzc xfdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768300664; x=1768905464; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Oazj4yczN23Rbwqju/OxFHmi/BXkpTACewJYAxvqYXs=; b=hzoRdAxkP93Vt4smkSU4JoSLwplehIJNWm8u6eDum5wH5h8GPjXW7jl+wZavmQnv5+ QQ7p6ESHzLd1+UgRxAubVUHnSh1bF12bETIK4SYhvZOytI8DftjV0DSL3ssEh39iKMjn mNJO1ECrbBBoLO3QEhGS3i0fcNCxRr0tuIypaS/QftkXCsZxn8yEMLFN60yJ9S72q9KB JThRMHfSb22wlWdTiaj6yLkErTxvp0JDFxXntxGWmI7/3JrEF27s02085XIDZxA7bT9t 5AuSad8AKYu3iFdhyWBfQD13d9t6IRA42V4LHsnDP8oZ4II5ZBLxzz96ffaGZSl4MgxY /dCA== X-Forwarded-Encrypted: i=1; AJvYcCXQBM6hvFlqDeLZpRTwg2jlyfPwyge5kQ+wj9U3ay7l3PrC7mQrYFHLOGDsO4k7MrtpMA/IT59iYCSoRls=@vger.kernel.org X-Gm-Message-State: AOJu0Yzw1nsvxMFleHJWsNXujZAkhHjv9vn5ImSLl00YYn8uFWhF0mVn w1cqENkDsIQ9PPYFHFZCR8jOmabt7OIVNGexm22nhcX2pdmK7Gb4n7hiD86w4A== X-Gm-Gg: AY/fxX6hJpy+LIDsPtfW4F+NkcFoeMlvePZEopgjAc8CCLFvL/jrMVsM7rCIaAEahNk OawYPpBKWaZ7hvO8o3XsbxtcN/+J5iE20NvfxFO+jnN1ay/twZLojmFPzJeMB48yFIdcNwA1+Lb zZagcvMuRxUsS5cmeWlUoD5wwY4dfAg6OGWW8K+0CM4txi4ySB6SrXCDz2ndZE0EE8V3S8M2Vfx QP544TJZ+T/LVXB/4vXD4v/w+DU46tgpQt11VZ4Z1iH8It/jrBK0GurGXWUZ53krX+Wx7/EyDQS tx6yHO5WFoAAmj8TuF29YWlXSHLUH66tdkS3NI/Eq3LNnvOzLydIsawgzUHTkEq5dBWBy6RyLrJ kmr7MUKYutQ/zyAdtU4iNoaZaPy1pLhPsF1CPHv5H1LyZlVuj7JD5SWnhAxheOEmjD2Lgf+H5XS d6I2iQclR2 X-Google-Smtp-Source: AGHT+IFbNiOPutKZbCPk2Ib2s2FH0lOFtSTWKU0X5Jb8z683ODPBb559/5ZycXNLmLbC0VM9Gi7LRg== X-Received: by 2002:a17:902:ce0a:b0:298:4ee2:19f3 with SMTP id d9443c01a7336-2a3ee4edf11mr218273755ad.49.1768300664221; Tue, 13 Jan 2026 02:37:44 -0800 (PST) Received: from cong ([112.197.171.165]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c48d77sm195748505ad.41.2026.01.13.02.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 02:37:43 -0800 (PST) From: Vo Thanh Cong To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, anac.amplar@gmail.com, Vo Thanh Cong Subject: [PATCH v2] staging: rtl8723bs: remove unnecessary else after break Date: Tue, 13 Jan 2026 17:37:38 +0700 Message-ID: <20260113103738.207570-1-thanhcongvo079@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes the checkpatch.pl warning: "WARNING: else is not generally useful after a break or return" In sdio_ops_linux.c, the else blocks after break statements are redundant. Removing them reduces indentation level and improves code readability. Signed-off-by: Vo Thanh Cong --- v2 - Add a blank line after the break statement to improve readability as suggested by Greg Kroah-Hartman. .../staging/rtl8723bs/os_dep/sdio_ops_linux.c | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c b/drivers/st= aging/rtl8723bs/os_dep/sdio_ops_linux.c index 5dc00e9117ae..3ea9fdfa14f8 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c @@ -219,14 +219,14 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s3= 2 *err) if (*err =3D=3D 0) { rtw_reset_continual_io_error(psdiodev); break; - } else { - if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; - - if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { - padapter->bSurpriseRemoved =3D true; - break; - } + } + + if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) + padapter->bSurpriseRemoved =3D true; + + if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { + padapter->bSurpriseRemoved =3D true; + break; } } } @@ -295,14 +295,14 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, = u32 v, s32 *err) if (*err =3D=3D 0) { rtw_reset_continual_io_error(psdiodev); break; - } else { - if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) - padapter->bSurpriseRemoved =3D true; - - if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { - padapter->bSurpriseRemoved =3D true; - break; - } + } + + if ((-ESHUTDOWN =3D=3D *err) || (-ENODEV =3D=3D *err)) + padapter->bSurpriseRemoved =3D true; + + if (rtw_inc_and_chk_continual_io_error(psdiodev) =3D=3D true) { + padapter->bSurpriseRemoved =3D true; + break; } } } --=20 2.52.0