From nobody Mon Feb 9 13:58:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC8D272E63 for ; Tue, 13 Jan 2026 10:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768300454; cv=none; b=qW80fF/TbXZmVfl2q3q/KuZ7C3laLDUYfUC+wNW74YA6dCbfc6OZfqgV4zWrtR/eVc+jZDtjpZi8d4YWhyMNOYegjMSS21mdJ7TIWqNaCO7WSPMHlPXlwzAZPxMajamupyA/NgR9fjYNNytX0zvOl6aOQSIP+tbd3JwU/f0JPbg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768300454; c=relaxed/simple; bh=phMaZEdW+xwnGZ/4yeh8Mowv3dTqrpN1TGsy4KysEu8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=U1J2dNJXve/O/8D6yKXFUQVa2YyHBqRcW3z4s3tMeGT0yG30pEJr4wO2VfhrWCBHb1SGVq4SpWw8lyDK/TF0xurerRlNp6wp8My/y16oAjS/Jg4dsQmRKEUPEjZQptqc8hwpFkJ9P0MzuttiN3cvVvKdhzj3Qtw5ljoRxrKXH0I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bzqzJBrC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z4GOXftq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bzqzJBrC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z4GOXftq" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D538PZ2865817 for ; Tue, 13 Jan 2026 10:34:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cdPa96MAj6K cEAgrDqHeO2LCi+XsOMkFPiPYTvWqu9g=; b=bzqzJBrCoTv+38gfH7SYTdzEXNa dpu421uHFNyhL57BAto9x7HqbdPeClyfA4vCjiGxI5IISW+gotYqZJxMwKQvSFW/ OH27yPdAotnsmHg4Gyqvyvwwm3cSeYeYZAWxjcSFm1kObkEDwcuJQ3769CwYl6cu N/Mfut4+PAxBVOL14QY+NCiJWnD4DPYlUfp1sUN4D6tTcdYHySozLoNnE7CvHTDO aM5/C7Y6303WLL9rAYi8yhxVxG2pLzQrt0R3+S9HUrOrvVp6649LQOq6HdSJo0RB 7+ilnWggDgL13JQOhhaqYygmmS8juhONzvRfZeQyicWiRCDByyX7bm8nu9g== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnfjh91me-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 10:34:12 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c3dfa080662so3371230a12.1 for ; Tue, 13 Jan 2026 02:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768300451; x=1768905251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cdPa96MAj6KcEAgrDqHeO2LCi+XsOMkFPiPYTvWqu9g=; b=Z4GOXftqzPaI86RaMyj1DudAENv9cWElq40NNZ5az9SqezTkJX2lUazFT24qeTGUkf jMpG/f3HuuTyG8/gkdW4Inu3gPBgB8THCio4X2mwjYAoJLL/RUpjuzyjlDzRq0fUaB2W GDQXR/NM6EG+2NDJoaInxoCWu7LDuR+ngEn1XDMLMU6AYKYpT1dQb0dogOxHpngXhmF1 NZ8JlICNqOVTORRI1s++khYzXLfbBcG4U+dXWACiQtcrXhyoYSaYyyLgtNkXLGl/T+ag sk7etX0JDGTDnX5LfvGUW07tyY1xnKzOUF/fYzQmO16hGkXpYwYhXju+9Xlrx2lW/WjW 7egQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768300451; x=1768905251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cdPa96MAj6KcEAgrDqHeO2LCi+XsOMkFPiPYTvWqu9g=; b=Vjl4Ihcl5RBlTCzbJ52vWF+I+zn2eswzdnUvWUMIbcwPsq/AsE43nCqfdReA8KCfyj zLSsFBFc1Spv3YeI2wIA3Wg0tpBOV49xwmV6H6zC1kySCk8jOVx0WErJ1R1G9qevBPeT 2VWUZ2z2jE+D6L+tS6oZM1EPltoDN/k+2GJ1jMdJmj/r7MMbHREFPkSfpXjO9mglDAhH mu3ISwjiNnOwkAx+cHr6qmTbYszIITdR4Zv4aRlg2cKhtDDYbFrC0t/9CIClYpRlm4/Z WDolVhK5RSK73aay4uZjOvpphyrkBFnVdS6cD9S/MEEH0xZUVm7Nu97Ft/pXwOetGy1+ wXfQ== X-Forwarded-Encrypted: i=1; AJvYcCV7o/ojw5IQPm0sBQrc9L1FWw7y4LtXpZS3x/kSBrgD118fCzwTisK3c2lQsvr47mhq/fd2nq/If7PIdTQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzVwogxFUWmoP5ayk2kAlqSpUi0e6QsM0qvDO/Q6smsaTJilJaa rcCWHnDPMdvTqwsWkyucPCsJ6bZXwLpPnUaJnP1rEDOEzfLFS9D0G3j0XbLWZlqAgMvLW/GFaQf LeVwmqpyS/Z1qwu0KnHqmtzX8G7VS9g9ooAs60nyXjtqRrzxUgN8j+4NslgOl/4HQcn4= X-Gm-Gg: AY/fxX4s+AOzo9/JBI6ki8HbnRE0EaHO5h39Kmy4E+p1EM91/c+NlTAN3xgan7os65e pXwGuFi6w75H/RGNKR71Ac8FJUyJEY7/QD9nIY958AioJ/R79RXA3qcAjtsUCWNsLLgenu7BVsn 7vrTrmmlzjY3AKNo6wuzwaLI6C+uCasSfTNLCqPDsvuQ7ZgG040KR4JLCQk2UrqrPwqVJ0jZJYT 1+NUx/P9awM89vtNZZ3xmxijKNf+AgXfetCMQtvxjENLUYU2Gk45rJnrXVUqKy0cKjFMz20HNIU VOhsSIBYogQliK8nX6tHncD+Uo9AHjRJPmxdKFF3AWnlF60mg+ZCJDghV+pAFqz1yrQfKtVP5TJ pdeo2kj9WHFHVS9HPF6N85jRwSGFznRmJrIAtyQ== X-Received: by 2002:a05:6a20:c909:b0:366:22a1:2a4e with SMTP id adf61e73a8af0-38bd9982ba8mr2533441637.9.1768300451516; Tue, 13 Jan 2026 02:34:11 -0800 (PST) X-Received: by 2002:a05:6a20:c909:b0:366:22a1:2a4e with SMTP id adf61e73a8af0-38bd9982ba8mr2533417637.9.1768300450987; Tue, 13 Jan 2026 02:34:10 -0800 (PST) Received: from hu-prashk-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c4cca06b2edsm19769911a12.32.2026.01.13.02.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 02:34:10 -0800 (PST) From: Prashanth K To: Thinh Nguyen , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Prashanth K Subject: [PATCH v3 1/3] usb: dwc3: Remove of dep->regs Date: Tue, 13 Jan 2026 16:03:58 +0530 Message-Id: <20260113103400.2347763-2-prashanth.k@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260113103400.2347763-1-prashanth.k@oss.qualcomm.com> References: <20260113103400.2347763-1-prashanth.k@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA4OSBTYWx0ZWRfX/Br7Zbs6urLm +W3CqJVJyouEDDRb8qL5p5kRrecX1t2Enn3ZMgJyD4pOC/+kP03S0Jwj1rQTt0bEfN8C604LnGV rIZ52gDT6DVEHceOXByPt74tCiaugzNFyo6RYQXLs2AjYnz1H9CU7fNeE2m96VF/eWShnpB6TOs OMrSBTIAnll8iHs6jWYP4EWtUnZaGecKxmY8UeCb5xdVexh6ucelBlX2o+6ExQ+I2naIkOjPQhj hCuH2x1hWxktUwnOD+7O2xW7UI0doVGiSLspEtJ0XKfDY+FM5AmrqYHVVfLxoLIppozRvZgjR+g gXiu/MTjWSiULtNYhUnP/kKoHLlhdMZ1FAZaa0yak1Z9FxHh17nTsb6sAWwOwCQsoLO4GdcxcjN ROEKe6e8PXElIfH84S0Qg86uPn/84U6IEPZsLjVJNonoJz6CBvPIexN9eesE5kxalRVwbWLlnLf 3LladqVfE3YgYE1h6Mw== X-Proofpoint-GUID: N5bm97luVSCKS4CHUM0aIUxNTBAtDCYf X-Proofpoint-ORIG-GUID: N5bm97luVSCKS4CHUM0aIUxNTBAtDCYf X-Authority-Analysis: v=2.4 cv=XJQ9iAhE c=1 sm=1 tr=0 ts=69661fa4 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=jIQo8A4GAAAA:8 a=M8qNcNEInNZZPuFPK7cA:9 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 phishscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130089 Content-Type: text/plain; charset="utf-8" Remove dep->regs from struct dwc3_ep and reuse dwc->regs instead. Thus eliminating redundant iomem addresses and making register access more consistent across the driver. Signed-off-by: Prashanth K Acked-by: Thinh Nguyen --- drivers/usb/dwc3/core.h | 10 ++++------ drivers/usb/dwc3/debugfs.c | 12 ++++-------- drivers/usb/dwc3/gadget.c | 12 ++++++------ drivers/usb/dwc3/gadget.h | 2 +- 4 files changed, 15 insertions(+), 21 deletions(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index a5fc92c4ffa3..23188b910528 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -165,10 +165,10 @@ #define DWC3_DCFG1 0xc740 /* DWC_usb32 only */ =20 #define DWC3_DEP_BASE(n) (0xc800 + ((n) * 0x10)) -#define DWC3_DEPCMDPAR2 0x00 -#define DWC3_DEPCMDPAR1 0x04 -#define DWC3_DEPCMDPAR0 0x08 -#define DWC3_DEPCMD 0x0c +#define DWC3_DEPCMDPAR2(n) (DWC3_DEP_BASE(n) + 0x00) +#define DWC3_DEPCMDPAR1(n) (DWC3_DEP_BASE(n) + 0x04) +#define DWC3_DEPCMDPAR0(n) (DWC3_DEP_BASE(n) + 0x08) +#define DWC3_DEPCMD(n) (DWC3_DEP_BASE(n) + 0x0c) =20 #define DWC3_DEV_IMOD(n) (0xca00 + ((n) * 0x4)) =20 @@ -749,8 +749,6 @@ struct dwc3_ep { struct list_head pending_list; struct list_head started_list; =20 - void __iomem *regs; - struct dwc3_trb *trb_pool; dma_addr_t trb_pool_dma; struct dwc3 *dwc; diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c index d18bf5e32cc8..0b45ff16f575 100644 --- a/drivers/usb/dwc3/debugfs.c +++ b/drivers/usb/dwc3/debugfs.c @@ -36,23 +36,19 @@ #define dump_ep_register_set(n) \ { \ .name =3D "DEPCMDPAR2("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMDPAR2, \ + .offset =3D DWC3_DEPCMDPAR2(n), \ }, \ { \ .name =3D "DEPCMDPAR1("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMDPAR1, \ + .offset =3D DWC3_DEPCMDPAR1(n), \ }, \ { \ .name =3D "DEPCMDPAR0("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMDPAR0, \ + .offset =3D DWC3_DEPCMDPAR0(n), \ }, \ { \ .name =3D "DEPCMD("__stringify(n)")", \ - .offset =3D DWC3_DEP_BASE(n) + \ - DWC3_DEPCMD, \ + .offset =3D DWC3_DEPCMD(n), \ } =20 =20 diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 8a35a6901db7..ce087cbc4a53 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -320,6 +320,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, =20 int cmd_status =3D 0; int ret =3D -EINVAL; + u8 epnum =3D dep->number; =20 /* * When operating in USB 2.0 speeds (HS/FS), if GUSB2PHYCFG.ENBLSLPM or @@ -355,9 +356,9 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, * improve performance. */ if (DWC3_DEPCMD_CMD(cmd) !=3D DWC3_DEPCMD_UPDATETRANSFER) { - dwc3_writel(dep->regs, DWC3_DEPCMDPAR0, params->param0); - dwc3_writel(dep->regs, DWC3_DEPCMDPAR1, params->param1); - dwc3_writel(dep->regs, DWC3_DEPCMDPAR2, params->param2); + dwc3_writel(dwc->regs, DWC3_DEPCMDPAR0(epnum), params->param0); + dwc3_writel(dwc->regs, DWC3_DEPCMDPAR1(epnum), params->param1); + dwc3_writel(dwc->regs, DWC3_DEPCMDPAR2(epnum), params->param2); } =20 /* @@ -381,7 +382,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, else cmd |=3D DWC3_DEPCMD_CMDACT; =20 - dwc3_writel(dep->regs, DWC3_DEPCMD, cmd); + dwc3_writel(dwc->regs, DWC3_DEPCMD(epnum), cmd); =20 if (!(cmd & DWC3_DEPCMD_CMDACT) || (DWC3_DEPCMD_CMD(cmd) =3D=3D DWC3_DEPCMD_ENDTRANSFER && @@ -391,7 +392,7 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsign= ed int cmd, } =20 do { - reg =3D dwc3_readl(dep->regs, DWC3_DEPCMD); + reg =3D dwc3_readl(dwc->regs, DWC3_DEPCMD(epnum)); if (!(reg & DWC3_DEPCMD_CMDACT)) { cmd_status =3D DWC3_DEPCMD_STATUS(reg); =20 @@ -3381,7 +3382,6 @@ static int dwc3_gadget_init_endpoint(struct dwc3 *dwc= , u8 epnum) dep->dwc =3D dwc; dep->number =3D epnum; dep->direction =3D direction; - dep->regs =3D dwc->regs + DWC3_DEP_BASE(epnum); dwc->eps[epnum] =3D dep; dep->combo_num =3D 0; dep->start_cmd_status =3D 0; diff --git a/drivers/usb/dwc3/gadget.h b/drivers/usb/dwc3/gadget.h index d73e735e4081..c3aa9638b7a5 100644 --- a/drivers/usb/dwc3/gadget.h +++ b/drivers/usb/dwc3/gadget.h @@ -132,7 +132,7 @@ static inline void dwc3_gadget_ep_get_transfer_index(st= ruct dwc3_ep *dep) { u32 res_id; =20 - res_id =3D dwc3_readl(dep->regs, DWC3_DEPCMD); + res_id =3D dwc3_readl(dep->dwc->regs, DWC3_DEPCMD(dep->number)); dep->resource_index =3D DWC3_DEPCMD_GET_RSC_IDX(res_id); } =20 --=20 2.34.1