From nobody Sat Feb 7 13:41:09 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAED923EA9B; Tue, 13 Jan 2026 08:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768292692; cv=none; b=lDsgQWdrBj+IRisr0HK+B9Eb5VjCJVvaSeoouyiCF4ZOHjWi81wADI1TKffSZayJey6nNcOuIAgv4C7Bn2FTlA52v3v8nIAVb+TqDXMoT1aO30TjvvQ1pcBskEzmIcSI8iupqSJGSisfkvFPM7GTX7cFpCR7U+npF9gN8zegjV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768292692; c=relaxed/simple; bh=K+qe+XhI83vj/6bO+RWRIFt0Wm4qiA8w38om6/KQybM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ozo+6+c7J/7LVmw9mxhPXPv3/NWnTwBVyIgQfFUK44CpDvnViFwqLOHWzCg6NGkWfxuIcFtJnD2lVS8S891ZmAoaT4h0BmQk6q0bhoTc8nJ3nAsoHtvGsj1kaGlWtFDqWXrRNhrMU7aG39uegJWUTGpzAGR3AcTu1PhVX9ZEdpQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=bc2hpOLg; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="bc2hpOLg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768292691; x=1799828691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=K+qe+XhI83vj/6bO+RWRIFt0Wm4qiA8w38om6/KQybM=; b=bc2hpOLgidaChTapvxK7P3u1PeXzBSuVwe2gADSrutY0PU8qUUTWDpMy WWtjNA16UBrPrCsc1Ymu9Mhy4qxf0iMw4vcZuVzr5NCpjs2ETYrNyt0O1 ddUKIQ1KxKOtiePRsEOtJ1xcWLEAVXnGsqUJYLkfl/Sls9xmr3SCNJRd8 A8sXoN/EhWZMAwbmIJbz+9OGQd0Ris6LaF0TV+/dFD+OU9GCnBHMfXGH2 tfOc7PAqaQV2EJ86zFmGlfU3bSpDBrC8lqyBcEYKc0U9VFAJQwMIRYezq EPYh6lJcof+DOu1YSKPK84WlWfgtZKr9FjU0WxRo0Fcu0ZQLp2a6wtKTh w==; X-CSE-ConnectionGUID: 4XvQV6wcTdWpMHyPUx2xdQ== X-CSE-MsgGUID: veDrompoQm2oXa7ybXYttw== X-IronPort-AV: E=McAfee;i="6800,10657,11669"; a="80939214" X-IronPort-AV: E=Sophos;i="6.21,222,1763452800"; d="scan'208";a="80939214" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2026 00:24:50 -0800 X-CSE-ConnectionGUID: 9vl+rjbGRoWg3VHjMXcLzg== X-CSE-MsgGUID: 0x1NJZtUQIC7m13lUd0ocQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,222,1763452800"; d="scan'208";a="203960023" Received: from black.igk.intel.com ([10.91.253.5]) by fmviesa007.fm.intel.com with ESMTP; 13 Jan 2026 00:24:49 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 6D7EF98; Tue, 13 Jan 2026 09:24:48 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dmitry Torokhov Subject: [PATCH v2 1/2] Input: wdt87xx_i2c - tidy up ACPI ID table Date: Tue, 13 Jan 2026 09:22:57 +0100 Message-ID: <20260113082445.44186-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260113082445.44186-1-andriy.shevchenko@linux.intel.com> References: <20260113082445.44186-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Tidy up ACPI ID table: - drop ACPI_PTR() and hence replace acpi.h with mod_devicetable.h et al. - remove explicit driver_data initializer Signed-off-by: Andy Shevchenko --- drivers/input/touchscreen/wdt87xx_i2c.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchs= creen/wdt87xx_i2c.c index 88d376090e6e..99636d6eb0f3 100644 --- a/drivers/input/touchscreen/wdt87xx_i2c.c +++ b/drivers/input/touchscreen/wdt87xx_i2c.c @@ -9,17 +9,24 @@ * may be copied, distributed, and modified under those terms. */ =20 +#include +#include +#include +#include #include #include +#include #include -#include #include #include +#include +#include #include +#include +#include #include -#include -#include -#include +#include +#include #include =20 #define WDT87XX_NAME "wdt87xx_i2c" @@ -1153,13 +1160,11 @@ static const struct i2c_device_id wdt87xx_dev_id[] = =3D { }; MODULE_DEVICE_TABLE(i2c, wdt87xx_dev_id); =20 -#ifdef CONFIG_ACPI static const struct acpi_device_id wdt87xx_acpi_id[] =3D { - { "WDHT0001", 0 }, + { "WDHT0001" }, { } }; MODULE_DEVICE_TABLE(acpi, wdt87xx_acpi_id); -#endif =20 static struct i2c_driver wdt87xx_driver =3D { .probe =3D wdt87xx_ts_probe, @@ -1168,7 +1173,7 @@ static struct i2c_driver wdt87xx_driver =3D { .name =3D WDT87XX_NAME, .dev_groups =3D wdt87xx_groups, .pm =3D pm_sleep_ptr(&wdt87xx_pm_ops), - .acpi_match_table =3D ACPI_PTR(wdt87xx_acpi_id), + .acpi_match_table =3D wdt87xx_acpi_id, }, }; module_i2c_driver(wdt87xx_driver); --=20 2.50.1 From nobody Sat Feb 7 13:41:09 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF9DC3644C6; Tue, 13 Jan 2026 08:24:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768292693; cv=none; b=P28ZTSUCuF1yJBc6BpDgWvjt/xAHzo74PHli5QVA8pybDAYZkmOcjRPEIKqz5UUW98wsEIIJYJuBt59yFU3dXj02NpA3e1OnvV44f1uxMNnvj/0OupT2wU4hw8lCOryFnCZr+m9UYSw9w72wNiHwhslHUTYQDtwP/z1kHXfEntA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768292693; c=relaxed/simple; bh=7VYHBNdfJRI/4r3wGlZlrY7u9q+KbI+duuDtsnpaLz4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H3l5hQ7K+V407jFaqXM0/F24rZ1V8wlH2ZUINGUSRhcxm7S+Q18rdIz7WWRcVhMrBB6vI74S3DUMkI7LTCElDPsUCTUHeEPL61YzT24SYXG7TurAtNlTSkQmNlJqnYGvPosBgoiyhEhqOE622vNgb9m1HIvDRGm7/qrHKYs+tws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RuwPhcU3; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RuwPhcU3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1768292691; x=1799828691; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7VYHBNdfJRI/4r3wGlZlrY7u9q+KbI+duuDtsnpaLz4=; b=RuwPhcU3NTRVJwqDy1UVx/tCXjyX2x+00iqQqV5SNS/D+aktl6+vr7td RXgYurRh/2pFX3NAzt6hgAE330DeMkb8lVypBK4KTULgzQ6+/7PWGYCM8 oOYiDUu1YBBUUTD/+GW0vXz+7a0ecnjJIzxLxZQfp+d34ZuSrOn5ZFM+S pqFVLAGycO5S1ppMMF2fzrpXPe3VZ1l/RsZDplcrNzjJlOlYgu1i5oJ57 +PfhqTfxAnmaTYfc04Vfmz/0FaF56c6/KdBMjw1tNzwLtYexdPPPBFadL 8MbHnGdSzMao7rTzT44UwfBfLTwaaje2GoE+eMxznPyeJZ+OAYI5+rgw9 g==; X-CSE-ConnectionGUID: n420hJJVRU6eUmKSsUTIcg== X-CSE-MsgGUID: k/9lJEL5SYWXJsv4L4QE6g== X-IronPort-AV: E=McAfee;i="6800,10657,11669"; a="86988109" X-IronPort-AV: E=Sophos;i="6.21,222,1763452800"; d="scan'208";a="86988109" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2026 00:24:51 -0800 X-CSE-ConnectionGUID: fybJbI9zTTahWXeZQni/9w== X-CSE-MsgGUID: YCZBGhswRlq+4vC1QMWNIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,222,1763452800"; d="scan'208";a="203479204" Received: from black.igk.intel.com ([10.91.253.5]) by orviesa006.jf.intel.com with ESMTP; 13 Jan 2026 00:24:49 -0800 Received: by black.igk.intel.com (Postfix, from userid 1003) id 71F1199; Tue, 13 Jan 2026 09:24:48 +0100 (CET) From: Andy Shevchenko To: Andy Shevchenko , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dmitry Torokhov Subject: [PATCH v2 2/2] Input: wdt87xx_i2c - switch to use dev_err_probe() Date: Tue, 13 Jan 2026 09:22:58 +0100 Message-ID: <20260113082445.44186-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260113082445.44186-1-andriy.shevchenko@linux.intel.com> References: <20260113082445.44186-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch to use dev_err_probe() to simplify the error path and unify a message template. With that being done, drop the now no-op message for -ENOMEM as allocator will print a big warning anyway and remove duplicate message for devm_request_threaded_irq(). Signed-off-by: Andy Shevchenko --- drivers/input/touchscreen/wdt87xx_i2c.c | 24 +++++++----------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/drivers/input/touchscreen/wdt87xx_i2c.c b/drivers/input/touchs= creen/wdt87xx_i2c.c index 99636d6eb0f3..3bf899fe615c 100644 --- a/drivers/input/touchscreen/wdt87xx_i2c.c +++ b/drivers/input/touchscreen/wdt87xx_i2c.c @@ -1033,10 +1033,8 @@ static int wdt87xx_ts_create_input_device(struct wdt= 87xx_data *wdt) int error; =20 input =3D devm_input_allocate_device(dev); - if (!input) { - dev_err(dev, "failed to allocate input device\n"); + if (!input) return -ENOMEM; - } wdt->input =3D input; =20 input->name =3D "WDT87xx Touchscreen"; @@ -1060,16 +1058,15 @@ static int wdt87xx_ts_create_input_device(struct wd= t87xx_data *wdt) INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); =20 error =3D input_register_device(input); - if (error) { - dev_err(dev, "failed to register input device: %d\n", error); - return error; - } + if (error) + return dev_err_probe(dev, error, "failed to register input device\n"); =20 return 0; } =20 static int wdt87xx_ts_probe(struct i2c_client *client) { + struct device *dev =3D &client->dev; struct wdt87xx_data *wdt; int error; =20 @@ -1099,16 +1096,9 @@ static int wdt87xx_ts_probe(struct i2c_client *clien= t) if (error) return error; =20 - error =3D devm_request_threaded_irq(&client->dev, client->irq, - NULL, wdt87xx_ts_interrupt, - IRQF_ONESHOT, - client->name, wdt); - if (error) { - dev_err(&client->dev, "request irq failed: %d\n", error); - return error; - } - - return 0; + return devm_request_threaded_irq(dev, client->irq, + NULL, wdt87xx_ts_interrupt, + IRQF_ONESHOT, client->name, wdt); } =20 static int wdt87xx_suspend(struct device *dev) --=20 2.50.1