From nobody Sun Feb 8 12:20:30 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DCD8163; Tue, 13 Jan 2026 01:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768268857; cv=none; b=Vr6eVnIU98ErtVtY6GzUWkbiOlTjhPnk3e+U1rrC0J5BW9nGVzVwOJifo/xCX2tExtHCb0vcDv8aoGSzC1N/Rjf7xGBzvPQTNP0algrBcVWg4mq8SImugZoiA2PPoCnuiSrDQPYp+/oCYZBSbTEYPs4bHlb9wpLnyKqnjpVwov4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768268857; c=relaxed/simple; bh=6eyCo2mFt6iN1iC84h2K7GeOcI28F3Mm7aZY9xlt+HA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Uini3CeTQfYrN40qrtFL6hpLQk/aPNWKhp6W5z3Tn1t894MLN9hSuFfC0yaUNFc0XLiHa96MiiAtUpfPG2SDN4s4JbtO08C1oUxQlgXGiqYmc37PzUPJWtWoQNUHlYmKQlY32XowRPyQ/EaVugkUCZAT05+0maevTEXUjoobuRU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from dfae2b116770.home.arpa (unknown [124.16.138.129]) by APP-01 (Coremail) with SMTP id qwCowAAXvmkmpGVpOViMBA--.15566S2; Tue, 13 Jan 2026 09:47:18 +0800 (CST) From: Wentao Liang To: nm@ti.com, ssantosh@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Wentao Liang , stable@vger.kernel.org Subject: [PATCH v3] soc: ti: pruss: fix double free in pruss_clk_mux_setup() Date: Tue, 13 Jan 2026 01:47:16 +0000 Message-Id: <20260113014716.2464741-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowAAXvmkmpGVpOViMBA--.15566S2 X-Coremail-Antispam: 1UD129KBjvJXoWrZw4DtryrJF48CrWfGFW5Awb_yoW8JF1kp3 y8CrWSv348JF4xAF45Ar4kGFyYva9Iyay7uayq9w13ZF13tryjq3W2vFyavFsxtFyrGwsI yF4DKF9rC3W5AF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvq14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Wrv_ZF1lYx0Ex4A2jsIE14v26rxl6rkdMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1lc2xSY4AK67AK6w4l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0x ZFpf9x0pRNyCXUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwkGA2lllVk4lwAAsk Content-Type: text/plain; charset="utf-8" In the pruss_clk_mux_setup(), the devm_add_action_or_reset() indirectly calls pruss_of_free_clk_provider(), which calls of_node_put(clk_mux_np) on the error path. However, after the devm_add_action_or_reset() returns, the of_node_put(clk_mux_np) is called again, causing a double free. Fix by returning directly, to avoid the duplicate of_node_put(). Fixes: ba59c9b43c86 ("soc: ti: pruss: support CORECLK_MUX and IEPCLK_MUX") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- Changes in v2: - Drop error jumping label. Changes in v3: - Omit curly brackets. --- drivers/soc/ti/pruss.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c index d7634bf5413a..0bc5122ee22b 100644 --- a/drivers/soc/ti/pruss.c +++ b/drivers/soc/ti/pruss.c @@ -366,12 +366,10 @@ static int pruss_clk_mux_setup(struct pruss *pruss, s= truct clk *clk_mux, =20 ret =3D devm_add_action_or_reset(dev, pruss_of_free_clk_provider, clk_mux_np); - if (ret) { + if (ret) dev_err(dev, "failed to add clkmux free action %d", ret); - goto put_clk_mux_np; - } =20 - return 0; + return ret; =20 put_clk_mux_np: of_node_put(clk_mux_np); --=20 2.34.1