From nobody Tue Feb 10 03:36:57 2026 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35EEA392837 for ; Tue, 13 Jan 2026 14:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313005; cv=none; b=ZyedkWroZw0XSM+DIId4FmJAAEMl3kGp3oKNxGnMKxJNre0UkSRkjA1h2ilhmSGlz2XTGvusR2av1qWpfuFKHWtgzXhPyPTLjneAeS3k3y9bZig9aVoRFopuhKMUdxqg3uJckLGFJHVNn2RZ7HlNkz0Cwan//HR84clkRuprEDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313005; c=relaxed/simple; bh=AjcBVqaSwngnU7vWvCLDzdROI1QNyjFRZt30RDyeG1w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tF1E30BjYZ9hROuE8Ki79xyYb643p7r8M59Mojt9siySSk8f0KlNc6gpaujoYexfYEv04pGx/IK8jATLJyrem4CV/PXf+/v0YVZ9CBg7me1HMNLJh24+6ODLim3FXZhaN7l4KZzloHfDaP9A138LgFnL7cc/obUBXGyXEeztpV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zVExJH6/; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zVExJH6/" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6536e4d25e1so749450a12.1 for ; Tue, 13 Jan 2026 06:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768312995; x=1768917795; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=u5Qwb5fmkXxIaTr5x+YXiqZotS/TDI0WvSzgONSjKHg=; b=zVExJH6/NTmHWb4z80CXbbLMphVYtGX9ea5Ey0mBxeMxMsChAdJtS9GmO1NyvFNbJR j2sJsQ6ujlHeGVVlHjcto4EOZAgYxMtAfCbE2HDQ7JSAksPn4MNNjy489j3c4257/6vG /yG8G3CZtSxgXOgESwMAUE+t4c3ZbUHBp+OQgOMs7G8Z98JVwzrrDD9R49kWBaaC+iYc f3e9RB65WL4Rl0GhYKzjQbiTgYhbvJhnLRZU1QW43gM8k8NWxOP/NWu55bwWpZpTChKy 2oT96Cm9oDaZqH3ZaOZTcCJZCMJyPgSDrAhavQYZFhX/AIoB56KWS99w0E83NzRL07K9 FH1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768312995; x=1768917795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=u5Qwb5fmkXxIaTr5x+YXiqZotS/TDI0WvSzgONSjKHg=; b=TUrZZVItG44OzDaGyaLIm6UJT3ok8oZktIZbKJpCrOO7FufixlTzsAsAENyEpT3MPz VlNxIoDSOuocTyGL5Ol6QW78XupwrymBziDL7dHAG7nQ6bdk1uQmronDPZOySyFx1g/c W7ErwnvfDZYzI00jfJpVv8H8hQ2pT6FvSHunj/vdE1kMkUB4O1yVHsdTTxRIRhanLo+a bTRfMZXhbldTkiJAFmye3qvQ9QFEhJTBPXHE3Lv60Yw34kYqeKgY3SGmBzh0Rvbe9jd2 QhvngMCHPR6Ti3FO/R6DudSlbaUvejn5NhTa/rHMK3Mrign/leLlA31uA+zAV9usG8Tx tnZQ== X-Forwarded-Encrypted: i=1; AJvYcCXcv0Kfm0eOFZmJ4zx/FHXHatBVjdGQMFl/V1X2iZZ8rSl+OmGZxAhW0AiJbthLEfiWp3xrZ60sHAJCqHc=@vger.kernel.org X-Gm-Message-State: AOJu0YwYaIoJTUypoX6POX+DGKPIuq6zAS6IXbIK9jt/qepMDqEVH6T4 FNadCnsu+wE9O6xlBzMeOJQla2nT1+zDd+LBhd1/1mAXOcIU80NaxVaca1HUMrVhZ1o= X-Gm-Gg: AY/fxX6XVor3D0PUcNtmZM2jD/SAjZYjDBcO4vpi4pdhrgBdjlKoaid+kzZfTt+XYdN 608HpNi/9BlSHifhB6PgxQtax6/bFVU4MHRzkjxiqPhMd40TLEHAXAWbI5JzCMrO6RkK0kR3ahI tCnvnLV4v2QSzKpao9Vp+J1KiDETjep209YiIZKrmTD7kvQz2UmLteW52LkAtHFvEb5rVhG8jSR VddzO4XXxsq99Xn2r4HfOQsjrSRNTR5kzjbmSdhVp4vrStjjdV8RWAqbxNB2XXHI6/LpQmVv3/W F7BdrSxVBEQZqJvyk78cbj8WBDhetAH1r6dldyQEdOEP+rY6tFynAYLDwgD28t8cErI02oK30+k KbJFTxDpQMo6L0nPts0Th+JtcaP6q+zlv5bNEqLw6lTM3YbJQ70dIEQpFyFei7b6Yc1lUTAid8h MqcQbWu0egWjvi2p4OgsUISUR8cTlXKCS/DH70e2Fmo0NMMVQCJF2/btT4D2NBxa4IYA/TgrerP W+8Mg== X-Google-Smtp-Source: AGHT+IGD5Nz5s9REDbdCYuNAnZ1go2Ngvk7Gzz33zgEgVPupf8AA6b4vmxIJTcTUNUBnRLOq0woxNw== X-Received: by 2002:a17:907:97cc:b0:b87:3809:6982 with SMTP id a640c23a62f3a-b8738096f23mr258296666b.57.1768312994526; Tue, 13 Jan 2026 06:03:14 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf65c07sm20139157a12.23.2026.01.13.06.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 06:03:14 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 13 Jan 2026 14:03:12 +0000 Subject: [PATCH v3 2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260113-s5m-alarm-v3-2-855a19db1277@linaro.org> References: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> In-Reply-To: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The core driver now exposes the alarm IRQ as a resource, so we can drop the lookup from here to simplify the code and make adding support for additional variants easier in this driver. Acked-by: Alexandre Belloni Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s5m.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index a7220b4d0e8dd35786b060e2a4106e2a39fe743f..c6ed5a4ca8a0e4554b1c88c879b= 01fc384735007 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include =20 @@ -683,22 +682,18 @@ static int s5m_rtc_probe(struct platform_device *pdev) case S2MPS15X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS14X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps14_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS13X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps13_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S5M8767X: regmap_cfg =3D &s5m_rtc_regmap_config; info->regs =3D &s5m_rtc_regs; - alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: return dev_err_probe(&pdev->dev, -ENODEV, @@ -719,7 +714,6 @@ static int s5m_rtc_probe(struct platform_device *pdev) "Failed to allocate regmap\n"); } else if (device_type =3D=3D S2MPG10) { info->regs =3D &s2mpg10_rtc_regs; - alarm_irq =3D S2MPG10_IRQ_RTCA0; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -730,13 +724,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->s5m87xx =3D s5m87xx; info->device_type =3D device_type; =20 - if (s5m87xx->irq_data) { - info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) - return dev_err_probe(&pdev->dev, -EINVAL, - "Failed to get virtual IRQ %d\n", - alarm_irq); - } + alarm_irq =3D platform_get_irq_byname_optional(pdev, "alarm"); + if (alarm_irq > 0) + info->irq =3D alarm_irq; + else if (alarm_irq =3D=3D -ENXIO) + info->irq =3D 0; + else + return dev_err_probe(&pdev->dev, alarm_irq ? : -EINVAL, + "IRQ 'alarm' not found\n"); =20 platform_set_drvdata(pdev, info); =20 --=20 2.52.0.457.g6b5491de43-goog