From nobody Mon Feb 9 07:39:07 2026 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92FFE392826 for ; Tue, 13 Jan 2026 14:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768312999; cv=none; b=I+2uKMDm3QoqvYDam8gwxKhg/66jZGo8+HY1EJFDPc3tH7934wB97zf3MCq7CQ+ucterprjanDbb3N9G2o+/wdeDoNtxK/9ATuYAb0lGFCmYJ3s78insFiCreFFE6IcJurUoqHzhHa5EeyHfnmv9X7Z6ct5P+GKDJ7gOi3vDm+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768312999; c=relaxed/simple; bh=YursKKXNmAq3gLEo1Ra7eyeVALmovWWslD5JKj7z2PM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WslWNm+N9PLVLYeEUVzkob+frqUu3jAxrUJCI23v5NGIzAKDcEdpS3ptROYMashtRv6kgeaHYwSDVx0UOYQ9gFSMljqxbX765/Y8FvFeuWjBXo14z15snW3hNKhrPS92LCCPytiqC92V/Hxagb147rgdIrVNvWb5pGvyPPTqawU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=tRUP6nrC; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tRUP6nrC" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-64d02c01865so385292a12.1 for ; Tue, 13 Jan 2026 06:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768312994; x=1768917794; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2QNRfSu+X0n9+C9HJ8TARuT1Nhgd2E5zqZHGvVona/I=; b=tRUP6nrCrfrgqXZvZtIAIvdOyt8TtvzY1msQiZPmrxrpHIAxhi2lntUAVkaMOy+otY tuE5Fl7nbTpSLFO7H3NYy59cgxEy/GH1IIKk6ocjCagpBdlesqmshakjTJWZnMAyCZDL N7W5wPJ5LfmZvXhxG55ZBGlFuPZeSVLu9IE6Iu/E2Cl2sEU68HMhBF1Q3roqNFWknvgp n4yWDQMGM1swX9ovQzXPoCAs++01XbO02MF5r6Pl++c49dPxGBAV1+sDGr9Jk/Cila1z e39HNA8aOEn3bgSGEAc/2Z7pbXRg328lg7M8F2aOQ9GEZMyW/xt54J8PZqWTSRNrPkHW +/6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768312994; x=1768917794; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=2QNRfSu+X0n9+C9HJ8TARuT1Nhgd2E5zqZHGvVona/I=; b=f2hN8RqPIEZR7FBE8Hbgr+/Ql/NQvP3eHkYulYxZaXk9fiACqvd8boSQwdR0KP5OVz 6jLbpnhoXSO0frP4CzliGFKwaKSFyA4Jr5REl6xxiYIR4wzXH0yyqnWnnTixdaDkFn/G 2P/CB3Wdo6f/lArMCLvVOBwvoeuesnfAA44p9Tu9oCVo9EEmMOApOLUvATrXnFDct77w NDIZatnxqbvjaZFaI/bPz4SD/GWvauqCA91kSPRvh3WIjBFAmIHHf63N7qGLLixQ/R7e heExzuc477ggWZMKUVcaexOwCvWq+jMu55VN1bq9aqAEWO3s7G9amNx2dlGz2B99Rs7K hkRg== X-Forwarded-Encrypted: i=1; AJvYcCVE5Kanqdz3Vrqa/xz9IjVG9l8e060H7vwMfVhzn4Nw5iIhEWbrtWGNYF7uy4q01CT1k2SUwe6rCS6oSvI=@vger.kernel.org X-Gm-Message-State: AOJu0YynrVriW5EicZwr/9mNziNbXwB9YjccknlXi44qzuUgkypusit3 o7ye7TDdOx5/2yApzcemeSJh8YtaKVWMFr7GCymH1y1kwSJ9VHARJMGAH6OZv6hSgiY= X-Gm-Gg: AY/fxX6N06dr0rdIL/RmmDa7PViPW1zQ2V5NPVBFuCdTkdAYg9AxU5nfDt1XovGJ7GW Hzovaj7uQE+FD0v/VhKHmKqfk6it9D39M0AVGXw0drEZ9fm8UHgarbOg28xd0jtqr2G1d+GLvb4 4CFCeXXNPCJ+Al8tNo2/yXBZm6BiF8+g6wcURgMSd2luRx5Xsrq+HjECNoJWcHzOeArXpdU3ezV 0vufy+68yFjEZb1sRqGklYdJs8FxEcU6ZqKGJLjuwCUWJOewEc0w5ocfWN3ndw20ExgNwCXgQA9 IzJbriAhzQrqYHGiber3+9Rk0i/VQNM/ya08iLheP9ouuGWH+ku5FmVu1KRCGCsE/m+huL0pYCw OwQcBozX+0KDx8XeATR8i9RvN9rMXDrehVYp4DCjYA8wrxw0uW3h4jX04rGsGVoVcysu/d+GB3a LrwBjrFy8g9FslquW1gRpSodxotiO/5A5dkSLgfqjSbTXBraXAymlZ4cz+lFZfpPxXFyt3X4CZk Wci8Q== X-Google-Smtp-Source: AGHT+IGTTr6SX1QOQDiv8wO0iFLkAfJCO8fhPBk9ftZPt1uQsStN5fTC5tHBZBCLBy3V7N0AGsHvyg== X-Received: by 2002:aa7:cd13:0:b0:64b:7e89:811 with SMTP id 4fb4d7f45d1cf-65097e071f5mr16815559a12.13.1768312994017; Tue, 13 Jan 2026 06:03:14 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf65c07sm20139157a12.23.2026.01.13.06.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 06:03:13 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 13 Jan 2026 14:03:11 +0000 Subject: [PATCH v3 1/3] mfd: sec: add rtc alarm IRQ as platform device resource Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260113-s5m-alarm-v3-1-855a19db1277@linaro.org> References: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> In-Reply-To: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 By adding the RTC alarm IRQ to the MFD cell as a resource, the child driver (rtc) can simply query that IRQ, instead of having a lookup table itself. This change therefore allows the child driver to be simplified with regards to determining the alarm IRQ. Signed-off-by: Andr=C3=A9 Draszik --- drivers/mfd/sec-common.c | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 42d55e70e34c8d7cd68cddaecc88017e259365b4..77370db52a7ba81234136b29f85= 892f4b197f429 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -23,9 +23,13 @@ #include #include "sec-core.h" =20 +static const struct resource s5m8767_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S5M8767_IRQ_RTCA1, "alarm"), +}; + static const struct mfd_cell s5m8767_devs[] =3D { MFD_CELL_NAME("s5m8767-pmic"), - MFD_CELL_NAME("s5m-rtc"), + MFD_CELL_RES("s5m-rtc", s5m8767_rtc_resources), MFD_CELL_OF("s5m8767-clk", NULL, NULL, 0, 0, "samsung,s5m8767-clk"), }; =20 @@ -33,50 +37,66 @@ static const struct mfd_cell s2dos05_devs[] =3D { MFD_CELL_NAME("s2dos05-regulator"), }; =20 +static const struct resource s2mpg10_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPG10_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mpg10_devs[] =3D { MFD_CELL_NAME("s2mpg10-meter"), MFD_CELL_NAME("s2mpg10-regulator"), - MFD_CELL_NAME("s2mpg10-rtc"), + MFD_CELL_RES("s2mpg10-rtc", s2mpg10_rtc_resources), MFD_CELL_OF("s2mpg10-clk", NULL, NULL, 0, 0, "samsung,s2mpg10-clk"), MFD_CELL_OF("s2mpg10-gpio", NULL, NULL, 0, 0, "samsung,s2mpg10-gpio"), }; =20 +static const struct resource s2mps11_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPS11_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mps11_devs[] =3D { MFD_CELL_NAME("s2mps11-regulator"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps11_rtc_resources), MFD_CELL_OF("s2mps11-clk", NULL, NULL, 0, 0, "samsung,s2mps11-clk"), }; =20 +static const struct resource s2mps14_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPS14_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mps13_devs[] =3D { MFD_CELL_NAME("s2mps13-regulator"), - MFD_CELL_NAME("s2mps13-rtc"), + MFD_CELL_RES("s2mps13-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps13-clk", NULL, NULL, 0, 0, "samsung,s2mps13-clk"), }; =20 static const struct mfd_cell s2mps14_devs[] =3D { MFD_CELL_NAME("s2mps14-regulator"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps14-clk", NULL, NULL, 0, 0, "samsung,s2mps14-clk"), }; =20 static const struct mfd_cell s2mps15_devs[] =3D { MFD_CELL_NAME("s2mps15-regulator"), - MFD_CELL_NAME("s2mps15-rtc"), + MFD_CELL_RES("s2mps15-rtc", s2mps14_rtc_resources), MFD_CELL_OF("s2mps13-clk", NULL, NULL, 0, 0, "samsung,s2mps13-clk"), }; =20 static const struct mfd_cell s2mpa01_devs[] =3D { MFD_CELL_NAME("s2mpa01-pmic"), - MFD_CELL_NAME("s2mps14-rtc"), + MFD_CELL_RES("s2mps14-rtc", s2mps14_rtc_resources), }; =20 static const struct mfd_cell s2mpu02_devs[] =3D { MFD_CELL_NAME("s2mpu02-regulator"), }; =20 +static const struct resource s2mpu05_rtc_resources[] =3D { + DEFINE_RES_IRQ_NAMED(S2MPU05_IRQ_RTCA0, "alarm"), +}; + static const struct mfd_cell s2mpu05_devs[] =3D { MFD_CELL_NAME("s2mpu05-regulator"), - MFD_CELL_NAME("s2mps15-rtc"), + MFD_CELL_RES("s2mps15-rtc", s2mpu05_rtc_resources), }; =20 static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) @@ -220,7 +240,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, sec_pmic->device_type); } ret =3D devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, NULL); + NULL, 0, regmap_irq_get_domain(sec_pmic->irq_data)); if (ret) return ret; =20 --=20 2.52.0.457.g6b5491de43-goog From nobody Mon Feb 9 07:39:07 2026 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35EEA392837 for ; Tue, 13 Jan 2026 14:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313005; cv=none; b=ZyedkWroZw0XSM+DIId4FmJAAEMl3kGp3oKNxGnMKxJNre0UkSRkjA1h2ilhmSGlz2XTGvusR2av1qWpfuFKHWtgzXhPyPTLjneAeS3k3y9bZig9aVoRFopuhKMUdxqg3uJckLGFJHVNn2RZ7HlNkz0Cwan//HR84clkRuprEDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768313005; c=relaxed/simple; bh=AjcBVqaSwngnU7vWvCLDzdROI1QNyjFRZt30RDyeG1w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tF1E30BjYZ9hROuE8Ki79xyYb643p7r8M59Mojt9siySSk8f0KlNc6gpaujoYexfYEv04pGx/IK8jATLJyrem4CV/PXf+/v0YVZ9CBg7me1HMNLJh24+6ODLim3FXZhaN7l4KZzloHfDaP9A138LgFnL7cc/obUBXGyXEeztpV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zVExJH6/; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zVExJH6/" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6536e4d25e1so749450a12.1 for ; Tue, 13 Jan 2026 06:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768312995; x=1768917795; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=u5Qwb5fmkXxIaTr5x+YXiqZotS/TDI0WvSzgONSjKHg=; b=zVExJH6/NTmHWb4z80CXbbLMphVYtGX9ea5Ey0mBxeMxMsChAdJtS9GmO1NyvFNbJR j2sJsQ6ujlHeGVVlHjcto4EOZAgYxMtAfCbE2HDQ7JSAksPn4MNNjy489j3c4257/6vG /yG8G3CZtSxgXOgESwMAUE+t4c3ZbUHBp+OQgOMs7G8Z98JVwzrrDD9R49kWBaaC+iYc f3e9RB65WL4Rl0GhYKzjQbiTgYhbvJhnLRZU1QW43gM8k8NWxOP/NWu55bwWpZpTChKy 2oT96Cm9oDaZqH3ZaOZTcCJZCMJyPgSDrAhavQYZFhX/AIoB56KWS99w0E83NzRL07K9 FH1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768312995; x=1768917795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=u5Qwb5fmkXxIaTr5x+YXiqZotS/TDI0WvSzgONSjKHg=; b=TUrZZVItG44OzDaGyaLIm6UJT3ok8oZktIZbKJpCrOO7FufixlTzsAsAENyEpT3MPz VlNxIoDSOuocTyGL5Ol6QW78XupwrymBziDL7dHAG7nQ6bdk1uQmronDPZOySyFx1g/c W7ErwnvfDZYzI00jfJpVv8H8hQ2pT6FvSHunj/vdE1kMkUB4O1yVHsdTTxRIRhanLo+a bTRfMZXhbldTkiJAFmye3qvQ9QFEhJTBPXHE3Lv60Yw34kYqeKgY3SGmBzh0Rvbe9jd2 QhvngMCHPR6Ti3FO/R6DudSlbaUvejn5NhTa/rHMK3Mrign/leLlA31uA+zAV9usG8Tx tnZQ== X-Forwarded-Encrypted: i=1; AJvYcCXcv0Kfm0eOFZmJ4zx/FHXHatBVjdGQMFl/V1X2iZZ8rSl+OmGZxAhW0AiJbthLEfiWp3xrZ60sHAJCqHc=@vger.kernel.org X-Gm-Message-State: AOJu0YwYaIoJTUypoX6POX+DGKPIuq6zAS6IXbIK9jt/qepMDqEVH6T4 FNadCnsu+wE9O6xlBzMeOJQla2nT1+zDd+LBhd1/1mAXOcIU80NaxVaca1HUMrVhZ1o= X-Gm-Gg: AY/fxX6XVor3D0PUcNtmZM2jD/SAjZYjDBcO4vpi4pdhrgBdjlKoaid+kzZfTt+XYdN 608HpNi/9BlSHifhB6PgxQtax6/bFVU4MHRzkjxiqPhMd40TLEHAXAWbI5JzCMrO6RkK0kR3ahI tCnvnLV4v2QSzKpao9Vp+J1KiDETjep209YiIZKrmTD7kvQz2UmLteW52LkAtHFvEb5rVhG8jSR VddzO4XXxsq99Xn2r4HfOQsjrSRNTR5kzjbmSdhVp4vrStjjdV8RWAqbxNB2XXHI6/LpQmVv3/W F7BdrSxVBEQZqJvyk78cbj8WBDhetAH1r6dldyQEdOEP+rY6tFynAYLDwgD28t8cErI02oK30+k KbJFTxDpQMo6L0nPts0Th+JtcaP6q+zlv5bNEqLw6lTM3YbJQ70dIEQpFyFei7b6Yc1lUTAid8h MqcQbWu0egWjvi2p4OgsUISUR8cTlXKCS/DH70e2Fmo0NMMVQCJF2/btT4D2NBxa4IYA/TgrerP W+8Mg== X-Google-Smtp-Source: AGHT+IGD5Nz5s9REDbdCYuNAnZ1go2Ngvk7Gzz33zgEgVPupf8AA6b4vmxIJTcTUNUBnRLOq0woxNw== X-Received: by 2002:a17:907:97cc:b0:b87:3809:6982 with SMTP id a640c23a62f3a-b8738096f23mr258296666b.57.1768312994526; Tue, 13 Jan 2026 06:03:14 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf65c07sm20139157a12.23.2026.01.13.06.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 06:03:14 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 13 Jan 2026 14:03:12 +0000 Subject: [PATCH v3 2/3] rtc: s5m: query platform device IRQ resource for alarm IRQ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260113-s5m-alarm-v3-2-855a19db1277@linaro.org> References: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> In-Reply-To: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 The core driver now exposes the alarm IRQ as a resource, so we can drop the lookup from here to simplify the code and make adding support for additional variants easier in this driver. Acked-by: Alexandre Belloni Signed-off-by: Andr=C3=A9 Draszik --- drivers/rtc/rtc-s5m.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index a7220b4d0e8dd35786b060e2a4106e2a39fe743f..c6ed5a4ca8a0e4554b1c88c879b= 01fc384735007 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include =20 @@ -683,22 +682,18 @@ static int s5m_rtc_probe(struct platform_device *pdev) case S2MPS15X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps15_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS14X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps14_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S2MPS13X: regmap_cfg =3D &s2mps14_rtc_regmap_config; info->regs =3D &s2mps13_rtc_regs; - alarm_irq =3D S2MPS14_IRQ_RTCA0; break; case S5M8767X: regmap_cfg =3D &s5m_rtc_regmap_config; info->regs =3D &s5m_rtc_regs; - alarm_irq =3D S5M8767_IRQ_RTCA1; break; default: return dev_err_probe(&pdev->dev, -ENODEV, @@ -719,7 +714,6 @@ static int s5m_rtc_probe(struct platform_device *pdev) "Failed to allocate regmap\n"); } else if (device_type =3D=3D S2MPG10) { info->regs =3D &s2mpg10_rtc_regs; - alarm_irq =3D S2MPG10_IRQ_RTCA0; } else { return dev_err_probe(&pdev->dev, -ENODEV, "Unsupported device type %d\n", @@ -730,13 +724,14 @@ static int s5m_rtc_probe(struct platform_device *pdev) info->s5m87xx =3D s5m87xx; info->device_type =3D device_type; =20 - if (s5m87xx->irq_data) { - info->irq =3D regmap_irq_get_virq(s5m87xx->irq_data, alarm_irq); - if (info->irq <=3D 0) - return dev_err_probe(&pdev->dev, -EINVAL, - "Failed to get virtual IRQ %d\n", - alarm_irq); - } + alarm_irq =3D platform_get_irq_byname_optional(pdev, "alarm"); + if (alarm_irq > 0) + info->irq =3D alarm_irq; + else if (alarm_irq =3D=3D -ENXIO) + info->irq =3D 0; + else + return dev_err_probe(&pdev->dev, alarm_irq ? : -EINVAL, + "IRQ 'alarm' not found\n"); =20 platform_set_drvdata(pdev, info); =20 --=20 2.52.0.457.g6b5491de43-goog From nobody Mon Feb 9 07:39:07 2026 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 025D4392B71 for ; Tue, 13 Jan 2026 14:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768312999; cv=none; b=ngmJ/Whccvl1G1K8QM+h1vQkBnWeLponaCqr7Joy0hzsXw6scJHClwsXFHUXXkig5xfY2XKHYa3wIwEZ8Ei61fPC46KbNpjVJY6xE5bAW20vHSnf4y0q/3M2LAqp48eS5SYR3rnk/geHOF1bR8RBEOAWQWhCrCRGPwlE0Wox/KE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768312999; c=relaxed/simple; bh=7EcWUnN0+N32pOYCO+1MoaYBsSNzfSeivRzWX9y8YCc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tKC8VnSBSbqZfqJDdYfZcAsY0D680TArD0LuJeJjYHWLvRmhIRpMcIlL+EytkRYov+C4r6vF6LMRSdOL9UCs2yW3IiipcPN7IfQpqXJMDgb1ITpri48XzTQLqGRHFjca0qmOkznb/NhlfxhY4NSnvTetnDZ4SqpGJI6mU3pf1Q0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vlz5V8MP; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vlz5V8MP" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-650854c473fso3373786a12.1 for ; Tue, 13 Jan 2026 06:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768312995; x=1768917795; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=u2zaFPeW0OjuaYCVWPM7pM9hcNh6cwyjFk/ezWJ8SDE=; b=vlz5V8MPioRADm3VAhU54U6kofewBmqE5vYkAx1Vtdd6tF2teRc5xR+pBcPPYuyokT 2EFTokEdE6J4Cj9cHrAyPAre3ZG18qExkmZv6HJ6hWiZe6LFBUAKvA0lfenMaR333vBZ q38NXeNh/mwZIdKVziRqSf7TYYI2Coa26M4dsUCDYLFeVIysqNy53YMRF+8czcRlscO9 8gkwoG1M4QTrPjkBCVwCy94+8RhY49S5hUpQKpiawlC+BaRnYXO8NuIE1VaPDer8aqBr S2X0H//5Fgevx52Jf2uigYLYpFaxsLB4cEwMtSGRo9fbDAoFP7DjuGMEj/nlVxitvm2j 3Paw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768312995; x=1768917795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=u2zaFPeW0OjuaYCVWPM7pM9hcNh6cwyjFk/ezWJ8SDE=; b=LZymDycCdh4ghVpxP3kZZcJJARaFz+++uTM9YbRFtp2REidaqnRoguNnjfUqVczRU+ Yoy9eEq/wuHsCdZExGY9I9Jk4IhpE5v4G6ERGU40i2wMFIWmi9oxRq6eSjQOZL5eX6ob 9PWRjJHeZ3vL6RqzqgDBAuOuFBudoAoUBJ43xjeBg8y+CP4wRpyy5MtCRQq/PWBMNki7 x2ljifaEdi48X0nXotbB8b6GRV4ovtUEf71FIzZbsPMpIF9fKY+anSxRbxosLD+eLg3+ OaD71lp5G4xVG3b7G5UP0zOT2RPmOIMR+WtZ+IavZzqnuyMs/VS4ahKeZVXTL7nlEOAp XA6g== X-Forwarded-Encrypted: i=1; AJvYcCXqe3IXRJxg14Dul4bJtzhUO/GNqZ/lO6cOGbcLOoD8/Qx/XHZwp0m5gB8v0yYOS5J9FPCUrz2AsW3GGWM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm1JNqkXrJfWNQ6pjzZ5JQAahBVzfvyzT7VcdKL/UwFv7LKJ5d /K9JiBBTUiF0dgiLZ/S3ndJNyi2NUzThVRdVZaU/JSG4cgBY3p07S981apL7iYfNCU0= X-Gm-Gg: AY/fxX7QMSEqskVJaDNHOjgPYo9TNnpcLl7DutpKbTZ4xo6bf7jORmVa5Rqz8GPcU5G kdVdX4FYIgn0tKTPjSchka5YqHZLoQY1MuvM+srxDw63deZn+e6f4qusyBO5nvCPHmbrMKd77R4 +GNxaMsZWgA6AG86YX85cxuhqAlSfAShMy9x0QpVhN2SEkDvO5V/4EJj3qW1jTEuUTG8Gmlxhb2 jJ/dJf+AenIqYp18qMozz11kpN6kwmMysWyyzFRoBMayca9zY39A6wZMON2icEMJDP0tZLPU2lr k/FYnKJdClWsKB61nWUdry/k6ODlM6y3oTv8oTnjbIazeCfJbliZGDMahMFT2VvY9e7JTrBnjrR JHY2IdAlWnHRzh8nTqxebAa7/8B8jCAfXMNIqCz/mUFTBbX22EJ0sBXLdmxQhspqa9zSiPjPQ1L hgL7xLZKwySwDz58JsdEfKO9JblcNHzOpJAzmEE1KTFdFkaryvLXI2G5aLKfJEETJ6OiI40hRRt gviqw== X-Google-Smtp-Source: AGHT+IGy72R/EUzURB6M21xGkc6VsgnlOxnsyKpL+CiAACdFJ/LepvXg6sQq1k/76EpK7ARgXbCncA== X-Received: by 2002:a05:6402:510d:b0:649:c6fb:1f5c with SMTP id 4fb4d7f45d1cf-652e48f7ce4mr2713178a12.5.1768312995170; Tue, 13 Jan 2026 06:03:15 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf65c07sm20139157a12.23.2026.01.13.06.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 06:03:14 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 13 Jan 2026 14:03:13 +0000 Subject: [PATCH v3 3/3] mfd: sec: drop now unused struct sec_pmic_dev::irq_data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260113-s5m-alarm-v3-3-855a19db1277@linaro.org> References: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> In-Reply-To: <20260113-s5m-alarm-v3-0-855a19db1277@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , Juan Yescas , Douglas Anderson , kernel-team@android.com, Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 This was used only to allow the s5m RTC driver to deal with the alarm IRQ. That driver now uses a different approach to acquire that IRQ, and ::irq_data doesn't need to be kept around anymore. Signed-off-by: Andr=C3=A9 Draszik --- v3: - make s2mpg1x_add_chained_irq_chip() specific to PMIC irq chip (Lee), and rename to s2mpg1x_add_chained_pmic() (Andre) v2: - return struct regmap_irq_chip_data * in sec_irq_init() (Lee) --- drivers/mfd/sec-common.c | 9 +++--- drivers/mfd/sec-core.h | 2 +- drivers/mfd/sec-irq.c | 64 ++++++++++++++++++------------------= ---- include/linux/mfd/samsung/core.h | 1 - 4 files changed, 35 insertions(+), 41 deletions(-) diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 77370db52a7ba81234136b29f85892f4b197f429..0021f9ae8484fd0afc2e47c813a= 953c91fa38546 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -163,6 +163,7 @@ sec_pmic_parse_dt_pdata(struct device *dev) int sec_pmic_probe(struct device *dev, int device_type, unsigned int irq, struct regmap *regmap, struct i2c_client *client) { + struct regmap_irq_chip_data *irq_data; struct sec_platform_data *pdata; const struct mfd_cell *sec_devs; struct sec_pmic_dev *sec_pmic; @@ -187,9 +188,9 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, =20 sec_pmic->pdata =3D pdata; =20 - ret =3D sec_irq_init(sec_pmic); - if (ret) - return ret; + irq_data =3D sec_irq_init(sec_pmic); + if (IS_ERR(irq_data)) + return PTR_ERR(irq_data); =20 pm_runtime_set_active(sec_pmic->dev); =20 @@ -240,7 +241,7 @@ int sec_pmic_probe(struct device *dev, int device_type,= unsigned int irq, sec_pmic->device_type); } ret =3D devm_mfd_add_devices(sec_pmic->dev, -1, sec_devs, num_sec_devs, - NULL, 0, regmap_irq_get_domain(sec_pmic->irq_data)); + NULL, 0, regmap_irq_get_domain(irq_data)); if (ret) return ret; =20 diff --git a/drivers/mfd/sec-core.h b/drivers/mfd/sec-core.h index 92c7558ab8b0de44a52e028eeb7998e38358cb4c..8d85c70c232612d1f7e5fb61b2a= cd25bf03a62e0 100644 --- a/drivers/mfd/sec-core.h +++ b/drivers/mfd/sec-core.h @@ -18,6 +18,6 @@ int sec_pmic_probe(struct device *dev, int device_type, u= nsigned int irq, struct regmap *regmap, struct i2c_client *client); void sec_pmic_shutdown(struct device *dev); =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic); +struct regmap_irq_chip_data *sec_irq_init(struct sec_pmic_dev *sec_pmic); =20 #endif /* __SEC_CORE_INT_H */ diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index 74ac70002d1fc54c7eeb78cfc21b6117a3e14b03..e0dd122e8fe5ad86ae1e97dc1a4= b1605d1813a64 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -268,26 +268,28 @@ static const struct regmap_irq_chip s5m8767_irq_chip = =3D { .ack_base =3D S5M8767_REG_INT1, }; =20 -static int s2mpg1x_add_chained_irq_chip(struct device *dev, struct regmap = *regmap, int pirq, - struct regmap_irq_chip_data *parent, - const struct regmap_irq_chip *chip, - struct regmap_irq_chip_data **data) +static struct regmap_irq_chip_data * +s2mpg1x_add_chained_pmic(struct sec_pmic_dev *sec_pmic, int pirq, + struct regmap_irq_chip_data *parent, const struct regmap_irq_chip *chi= p) { + struct device *dev =3D sec_pmic->dev; + struct regmap_irq_chip_data *data; int irq, ret; =20 irq =3D regmap_irq_get_virq(parent, pirq); if (irq < 0) - return dev_err_probe(dev, irq, "Failed to get parent vIRQ(%d) for chip %= s\n", pirq, - chip->name); + return dev_err_ptr_probe(dev, irq, "Failed to get parent vIRQ(%d) for ch= ip %s\n", + pirq, chip->name); =20 - ret =3D devm_regmap_add_irq_chip(dev, regmap, irq, IRQF_ONESHOT | IRQF_SH= ARED, 0, chip, data); + ret =3D devm_regmap_add_irq_chip(dev, sec_pmic->regmap_pmic, irq, + IRQF_ONESHOT | IRQF_SHARED, 0, chip, &data); if (ret) - return dev_err_probe(dev, ret, "Failed to add %s IRQ chip\n", chip->name= ); + return dev_err_ptr_probe(dev, ret, "Failed to add %s IRQ chip\n", chip->= name); =20 - return 0; + return data; } =20 -static int sec_irq_init_s2mpg1x(struct sec_pmic_dev *sec_pmic) +static struct regmap_irq_chip_data *sec_irq_init_s2mpg1x(struct sec_pmic_d= ev *sec_pmic) { const struct regmap_irq_chip *irq_chip, *chained_irq_chip; struct regmap_irq_chip_data *irq_data; @@ -302,27 +304,27 @@ static int sec_irq_init_s2mpg1x(struct sec_pmic_dev *= sec_pmic) chained_pirq =3D S2MPG10_COMMON_IRQ_PMIC; break; default: - return dev_err_probe(sec_pmic->dev, -EINVAL, "Unsupported device type %d= \n", - sec_pmic->device_type); + return dev_err_ptr_probe(sec_pmic->dev, -EINVAL, "Unsupported device typ= e %d\n", + sec_pmic->device_type); } =20 regmap_common =3D dev_get_regmap(sec_pmic->dev, "common"); if (!regmap_common) - return dev_err_probe(sec_pmic->dev, -EINVAL, "No 'common' regmap %d\n", - sec_pmic->device_type); + return dev_err_ptr_probe(sec_pmic->dev, -EINVAL, "No 'common' regmap %d\= n", + sec_pmic->device_type); =20 ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, regmap_common, sec_pmic->= irq, IRQF_ONESHOT, 0, irq_chip, &irq_data); if (ret) - return dev_err_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\n", - irq_chip->name); + return dev_err_ptr_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\= n", + irq_chip->name); =20 - return s2mpg1x_add_chained_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic,= chained_pirq, - irq_data, chained_irq_chip, &sec_pmic->irq_data); + return s2mpg1x_add_chained_pmic(sec_pmic, chained_pirq, irq_data, chained= _irq_chip); } =20 -int sec_irq_init(struct sec_pmic_dev *sec_pmic) +struct regmap_irq_chip_data *sec_irq_init(struct sec_pmic_dev *sec_pmic) { + struct regmap_irq_chip_data *sec_irq_chip_data; const struct regmap_irq_chip *sec_irq_chip; int ret; =20 @@ -331,7 +333,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) sec_irq_chip =3D &s5m8767_irq_chip; break; case S2DOS05: - return 0; + return NULL; case S2MPA01: sec_irq_chip =3D &s2mps14_irq_chip; break; @@ -356,30 +358,22 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) sec_irq_chip =3D &s2mpu05_irq_chip; break; default: - return dev_err_probe(sec_pmic->dev, -EINVAL, - "Unsupported device type %d\n", - sec_pmic->device_type); + return dev_err_ptr_probe(sec_pmic->dev, -EINVAL, "Unsupported device typ= e %d\n", + sec_pmic->device_type); } =20 if (!sec_pmic->irq) { dev_warn(sec_pmic->dev, "No interrupt specified, no interrupts\n"); - return 0; + return NULL; } =20 ret =3D devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic, sec_pmic->irq, IRQF_ONESHOT, - 0, sec_irq_chip, &sec_pmic->irq_data); + 0, sec_irq_chip, &sec_irq_chip_data); if (ret) - return dev_err_probe(sec_pmic->dev, ret, - "Failed to add %s IRQ chip\n", - sec_irq_chip->name); + return dev_err_ptr_probe(sec_pmic->dev, ret, "Failed to add %s IRQ chip\= n", + sec_irq_chip->name); =20 - /* - * The rtc-s5m driver requests S2MPS14_IRQ_RTCA0 also for S2MPS11 - * so the interrupt number must be consistent. - */ - BUILD_BUG_ON(((enum s2mps14_irq)S2MPS11_IRQ_RTCA0) !=3D S2MPS14_IRQ_RTCA0= ); - - return 0; + return sec_irq_chip_data; } diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/c= ore.h index d785e101fe795a5d8f9cccf4ccc4232437e89416..c7c3c8cd8d5f99ef0cc3188e1c3= b49031f4750f2 100644 --- a/include/linux/mfd/samsung/core.h +++ b/include/linux/mfd/samsung/core.h @@ -69,7 +69,6 @@ struct sec_pmic_dev { =20 int device_type; int irq; - struct regmap_irq_chip_data *irq_data; }; =20 struct sec_platform_data { --=20 2.52.0.457.g6b5491de43-goog