From nobody Mon Feb 9 04:08:58 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4525D2FD689 for ; Tue, 13 Jan 2026 19:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768333675; cv=none; b=DYzZelTms3ucveIn8AjoB/cPNKQIgMjk92IMKHpaaPRhpID/aWjWlWOFJWswDmvhaMPZCOyA2ioaVUuYHBIH2QjcsxDBlRDOQ1txHqxMCktW7vImjbOnT9KlqfyQ7bYNGwkTp7NIfOR3byLveH/dKfdhAVC2eyt2qxXRuKxL/o4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768333675; c=relaxed/simple; bh=m7H4fYTAN2wd1dmuh2ZoMuMP5dHupazPoMOEB3geRO8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=lToiVeQulgVQKzOaCyTp6bwRvE12GAMljR9S3+IkUfFFL3QUNl52Vi3iVeYbKgIhFZFiteK5SuxkG+I4/5l1t7QK8AXFbCWGyjOUlIWcSk38/1F05Gqn9UVU4Mi+kkOD4T3SFwsuHP8Q8gwyBjcF+j2K4cu3uRAMIrcdZa1nl58= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HGPw4+aw; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=s+bffX4d; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HGPw4+aw"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="s+bffX4d" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1768333673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h/J0VdyKSP8djFklxCotVlWBB1IldyLH81OZ7k+LqYY=; b=HGPw4+awczPyku1zFqCBCoXZKkCHYphAGI9owrabzWNXagtzNOoXO2WyZbGsfSg487pSkS zVJvqwTJVuqckngpaOoEJDrwGjW6GhtQGua5MS7i/plmi5JDcUZVvRAPxgEB88jVcXzetS 8NkoWCN0rnQssxHuYdPRYk0GKVBgoY8= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-z8Ms0B4ZPVi2ldfPJvsF6Q-1; Tue, 13 Jan 2026 14:47:52 -0500 X-MC-Unique: z8Ms0B4ZPVi2ldfPJvsF6Q-1 X-Mimecast-MFC-AGG-ID: z8Ms0B4ZPVi2ldfPJvsF6Q_1768333672 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8b2e2342803so2076635585a.3 for ; Tue, 13 Jan 2026 11:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1768333672; x=1768938472; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=h/J0VdyKSP8djFklxCotVlWBB1IldyLH81OZ7k+LqYY=; b=s+bffX4d35uwaiUfTHOEuVGDW1ePFM6ug0WeADGd6V6xsdZuKPR4miGIK4WSpFIBra k9qo0ncN89C9KATVWKmIpeyHH5iOdgzAfCQWklnZyYKt2whdeo9YFpSlWc6pPlWagiZM rENq/WDDig+LlujawGNzZdRo3IzBlE3zNm+28/m/H5J6/tFTZk4Gq44KkH2VLP0M0G6K NeiOaeQaQqmKMGW8zQrMiG9fXC7NlkaBiAmrcoCn4kfdgZJvUKwrOZtpYpLgBJHWt8Bt LNR1d4InPRli0AzhjGZQuRMeH9FjjFwMWFbP7K/bd9Nxha8NsupYT0zj3QsIxy489eYJ 12xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768333672; x=1768938472; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h/J0VdyKSP8djFklxCotVlWBB1IldyLH81OZ7k+LqYY=; b=pCrbeyvrLQvuhkmADpg4tr20bSjOuoXPiZ0MWlWKTe6Lfwc2shVmp5LRIlQa1jeYCF tkg4R0m/ANoXUDW6YscxY2b3wDIazdEb8zBiJqVVVr/qHQnztln5Y03u7ZEV6G3kwS6Y I3JNplUipTrRUEcwk/UO1LJeUtZW/q7tFsb/BuKqJsq1VeohFU+Y6yQt6pX92VZ0MDff nRcHMJ9FEt9GuqMpyr5/02sdJLS8cKseY96reYVuOmgTAYKlyquBBJL/t6CP/BD0OHSF h7Vk+Jp9pILQSKbBpQnfWgWG3wGZk0oY1Lrm0A2JIhRQSk1CLX5uHXH9Wkrb1nx4Hlls D7Eg== X-Forwarded-Encrypted: i=1; AJvYcCXsjAPeZ6t/k7bbH3nghuoPqrCb4G74Ec0Y7GE1W7tiLwcA1YyCKNJZw8KMqfPBvUE9xcIiQaAWCRk+OPw=@vger.kernel.org X-Gm-Message-State: AOJu0YybJAC2J4JceBND+LCpu/sU5e/nGfdEnhP7aEdB9ZgPvEN6ez2d hdJPhGH0WLv9ZLdzvFVwh23gzabPQDKcFLk1yO9NgqGU8mAau8NUVSdfRaCt9kHqD3bsjYMWccs 2p603jDawrJlvRVuxtk+HlDRUhXA83RCyOynzilTa544uQUNuytq5F6QeZf2uu1p7Lw== X-Gm-Gg: AY/fxX65lDDh4n3RwniKGPO8/Q3hoFBe18YYOoYCyanw/N5SHr8N33hKYcVwS2FzokN pSzXTaRL4w79bv69Vl1Tf7YCqc7SVOT0rJHcy88xFl5gR7kA0NK/eZSK1gglhrB80UeFXJfPefi vrWyLWqvhPB1hz9trealAv5PUT3tckkwG9H8rFlritQ2CBWg0z9rzQO3WM4EEyu6U3v089UXoOp KNt66KnxwEN6UonkWku6shQqFdpOKAL3AF13aHvq0UvA0itm0K6SDIbwM3CifzJ9bkvX92nxhl2 gfDDAFZvH7ObXOGTpvDytJ81QasyOHGkS0Hi899uc5+PpPKmW6RBmA2nLC1wY8r4VgTaGSkviB2 S1dNWZwYvwHP6MYhNPe4n1HRO97HY/2EvNDW8EvKyJg== X-Received: by 2002:a05:620a:7088:b0:8c3:7016:1d8c with SMTP id af79cd13be357-8c52fbdde52mr54924585a.88.1768333671664; Tue, 13 Jan 2026 11:47:51 -0800 (PST) X-Received: by 2002:a05:620a:7088:b0:8c3:7016:1d8c with SMTP id af79cd13be357-8c52fbdde52mr54921585a.88.1768333671231; Tue, 13 Jan 2026 11:47:51 -0800 (PST) Received: from jkangas-thinkpadp1gen3.rmtuswa.csb ([2601:1c2:4400:eb20:99f3:ffd5:11da:6745]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770e4262sm159356436d6.20.2026.01.13.11.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 11:47:50 -0800 (PST) From: Jared Kangas Date: Tue, 13 Jan 2026 11:46:50 -0800 Subject: [PATCH] dmaengine: fsl-edma: don't explicitly disable clocks in .remove() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260113-fsl-edma-clock-removal-v1-1-2025b49e7bcc@redhat.com> X-B4-Tracking: v=1; b=H4sIACmhZmkC/x3MQQqEMBAF0atIr20wQUW8irgI7Y82RiMJyIB49 wku36LqoYykyDRWDyXcmjWeBaauSDZ3rmBdisk2tm+MsexzYCyHYwlRdk444u0Ct+iGwUK8E1C JrwSvv288ze/7B1XCBg1oAAAA X-Change-ID: 20260112-fsl-edma-clock-removal-4e5882ecface To: Frank Li , Vinod Koul , Alison Wang , Arnd Bergmann , Jingchang Lu Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Jared Kangas X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768333669; l=2024; i=jkangas@redhat.com; s=20251111; h=from:subject:message-id; bh=m7H4fYTAN2wd1dmuh2ZoMuMP5dHupazPoMOEB3geRO8=; b=RTdr4dUq+xENYTPbNTXSYKGcwPQ5UmP3ZVIZbo6p8PArbQkhSnZe+H6uVpra2B+HKhbYHt2dy I+vvV99uQZJDUMBR0Gcy9NobxdDF8Dy+ng6btr6YNj4TQMSGLLvIHhc X-Developer-Key: i=jkangas@redhat.com; a=ed25519; pk=eFM2Mqcfarb4qox390655bUATO0fG9gwgaw7kGmOEZQ= The clocks in fsl_edma_engine::muxclk are allocated and enabled with devm_clk_get_enabled(), which automatically cleans these resources up, but these clocks are also manually disabled in fsl_edma_remove(). This causes warnings on driver removal for each clock: edma_module already disabled WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1200 clk_core_disable= +0x198/0x1c8 [...] Call trace: clk_core_disable+0x198/0x1c8 (P) clk_disable+0x34/0x58 fsl_edma_remove+0x74/0xe8 [fsl_edma] [...] ---[ end trace 0000000000000000 ]--- edma_module already unprepared WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1059 clk_core_unprepa= re+0x1f8/0x220 [...] Call trace: clk_core_unprepare+0x1f8/0x220 (P) clk_unprepare+0x34/0x58 fsl_edma_remove+0x7c/0xe8 [fsl_edma] [...] ---[ end trace 0000000000000000 ]--- Fix these warnings by removing the unnecessary fsl_disable_clocks() call in fsl_edma_remove(). Fixes: a9903de3aa16 ("dmaengine: fsl-edma: refactor using devm_clk_get_enab= led") Signed-off-by: Jared Kangas Reviewed-by: Frank Li --- drivers/dma/fsl-edma-main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c index 97583c7d51a2e8e7a50c7eb4f5ff0582ac95798d..093185768ad8ef09270ae02c99d= 0ee2accc183bd 100644 --- a/drivers/dma/fsl-edma-main.c +++ b/drivers/dma/fsl-edma-main.c @@ -915,7 +915,6 @@ static void fsl_edma_remove(struct platform_device *pde= v) of_dma_controller_free(np); dma_async_device_unregister(&fsl_edma->dma_dev); fsl_edma_cleanup_vchan(&fsl_edma->dma_dev); - fsl_disable_clocks(fsl_edma, fsl_edma->drvdata->dmamuxs); } =20 static int fsl_edma_suspend_late(struct device *dev) --- base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449 change-id: 20260112-fsl-edma-clock-removal-4e5882ecface Best regards, --=20 Jared Kangas