From nobody Mon Feb 9 12:25:31 2026 Received: from mx07-00376f01.pphosted.com (mx07-00376f01.pphosted.com [185.132.180.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7515B38A70F for ; Tue, 13 Jan 2026 10:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.180.163 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768299444; cv=none; b=qcRUgmDLhyafnkU7mgE0vzJN3iWHdQM9ybOKJrmURXaUpkTJ6AzJMOdY+6jXxSUqZMfWD9tejVngGxSGzuDitc2Gk/cXCmeB/qu1l99pfI8xyS507tS4TkX/rFpIYH7mhNhEIP8rhee0EjvD+kOPP/a52eTOsz/B0Lm33N/F57w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768299444; c=relaxed/simple; bh=5EcW8XdUmOfp836puLffKDqVJ8rRli7zcv/+RK2YIfQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=fhUsfSkW8V0+9FkNjtq+6cdr4Gy0LWo8HRPl8zAcmLvkIIuIDCWvhiNJ7LulRCQI1GmRWegJrkzRJsU7lB+YTHyewncKdW0LEYE3bZL/HgaJCK2feYOeYx45xyd4xxEWUB+DmXZUiU7DsxH/VndJ0lNPYik68t8YrikgjZpMjXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=Me1qJjmR; arc=none smtp.client-ip=185.132.180.163 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="Me1qJjmR" Received: from pps.filterd (m0168889.ppops.net [127.0.0.1]) by mx07-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D6XiIT3196794; Tue, 13 Jan 2026 10:16:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=dk201812; bh=O 9U7zjzOjCEzi5GIRDwZrE0mEmBXOKSi9S9+0WqO3fg=; b=Me1qJjmREiRmuaBsk oiPLCbdhYNxcH99mwKy8VdRRAybrMQa7QXfLNQ00Z6QYqYUkhkqnF73eL7tJO2X4 vMzBex+shSK8xU+4QJWzdrTW1DVvdrrCqzSL1Q+AA39avpCZ7sJxsfxAERK2FFF2 ljpGDln8Z/iorf1/IDLQa6LoF6TKIXB+6kStdcYJ2k9lUWwJ1VEmJuyKvuIgzd1j UAGKbbLDYA2kcEawIaPsziq5Hb5gwBbrm4JO014k2Txwnn3lJucm2QHa6SSiXKM/ 2jtpEVPNX0QNu5rY1pWA7XXY6aoBmbVTFbcqkzHftbCAREu71y1gNYvDXtLtjE80 Sys+g== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx07-00376f01.pphosted.com (PPS) with ESMTPS id 4bkfqua1rs-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jan 2026 10:16:58 +0000 (GMT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa (172.25.4.58) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Tue, 13 Jan 2026 10:16:57 +0000 From: Matt Coster Date: Tue, 13 Jan 2026 10:16:41 +0000 Subject: [PATCH 3/6] drm/imagination: Load FW trace config at init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260113-device-support-info-v1-3-91e5db7f7294@imgtec.com> References: <20260113-device-support-info-v1-0-91e5db7f7294@imgtec.com> In-Reply-To: <20260113-device-support-info-v1-0-91e5db7f7294@imgtec.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Frank Binns , Brajesh Gupta , Alessio Belle , Alexandru Dadu , Matt Coster , , X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1237; i=matt.coster@imgtec.com; h=from:subject:message-id; bh=5EcW8XdUmOfp836puLffKDqVJ8rRli7zcv/+RK2YIfQ=; b=owGbwMvMwCFWuUfy8817WRsYT6slMWSmSU9bVNzdoXC2eM2slzd/7N29acv2RU2CqlJuKkl+L 1avUd+1o6OUhUGMg0FWTJFlxwrLFWp/1LQkbvwqhpnDygQyhIGLUwAmEmHNyDD1VdfmbYxTLIST lzxS7LRIUzx7LjuYJ/O0p2fodE2fhecYfrPEW2izTy3Kcl3d9O/M7f3sfGI9b9+VvOZObFdRbXZ 7ywMA X-Developer-Key: i=matt.coster@imgtec.com; a=openpgp; fpr=05A40CFCE7269D61D97100A1747F0A9036F90DFA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA4NiBTYWx0ZWRfX6XSF99NPkCYa 7raHqa7iI8dku3qu3r9fOkXMmsz9hSzUPq5aa1QouJ0m/x8nGxM7FPc6OReH0HSiWblKvuneDZU IycJ4f5WUphgkUfnZBP+mWIUsS67ti7W2Bas7b/T17JWOTibsQQ+LAjw777B9vXKSaXZCgFoHNr YIEtaZs8taRmrxvjkR7BtxS6Ax9VE+FPYhNdv7H3IMPu0YmGmGhJ8R9pPScOfHWnU7kNJ/Ud6O1 Yga+1ExgxHsLktqDDhqIQWtrKrlskyeM2ZrALtJANrH9jT0QzSoDErtNs6dKqnLI83yFbUA86Tw 7QkgzQL9ZNdqAAEiekpaxHfuW2uaJiTv1V3tCYdIAl9sMgFPT/X37m/ogCdqExzNuS1hUvE8nW6 CfSl0thKkWx0cxv2IfhbD6MMATzs4gCMaf8TDNSHv4dqLUK9PelRCMMeZasbxDpSujxUN9Y5vpm XZ7NO7V4tkmscOZfLIQ== X-Proofpoint-GUID: aGia30f4RZjsG6SKkTo1fpAfYo4MaRiJ X-Proofpoint-ORIG-GUID: aGia30f4RZjsG6SKkTo1fpAfYo4MaRiJ X-Authority-Analysis: v=2.4 cv=aexsXBot c=1 sm=1 tr=0 ts=69661b9a cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=jNdnsKvOq7QA:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=VkNPw1HP01LnGYTKEx00:22 a=r_1tXGB3AAAA:8 a=F4SZs_XWik5TpCwB3EkA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 We have a module parameter to set the initial group mask before debugfs is available for any specific device, but don't currently use that value when initialising devices. Use the module parameter value as the initial value for group_mask. Signed-off-by: Matt Coster --- drivers/gpu/drm/imagination/pvr_fw_trace.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/i= magination/pvr_fw_trace.c index a2aa588cbe5fa..93119f0f23a92 100644 --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c @@ -130,8 +130,13 @@ int pvr_fw_trace_init(struct pvr_device *pvr_dev) } } =20 - /* TODO: Provide control of group mask. */ - fw_trace->group_mask =3D 0; + /* + * Load the initial group_mask from the init_fw_trace_mask module + * parameter. This allows early tracing before the user can write to + * debugfs. Unlike update_logtype(), we don't set log_type here as that + * is initialised by tracebuf_ctrl_init(). + */ + fw_trace->group_mask =3D pvr_fw_trace_init_mask; =20 fw_trace->tracebuf_ctrl =3D pvr_fw_object_create_and_map(pvr_dev, --=20 2.52.0