From nobody Sat Feb 7 09:29:25 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B983803FD for ; Tue, 13 Jan 2026 09:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768295026; cv=none; b=kyRIqvqqBfgMh4lSe/VJJfjxHDvNpIaIA1CJDxGVAjbWIFXbe2fOCJ6wOk7q8IRH7P+7LqAqODaXZ/NgqrlD46Q595MNByvWDkxkDCOUeoKKGi5Gt9Mon88FMzavfLyv/QKQpoqQQaVp1ngwRjFWPzofvP/WOSHkQkOwDVgCeic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768295026; c=relaxed/simple; bh=R9nZwPy9XRc15CVOKozFsAIrfAJ5dbYQZLjeVD3rWjQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Hq5m4joQijSFyyKtg52Y2yXYs7wEGKQCOjuFBPB7/ABf1G6Q57Lv5K+oJxbCyz0gD1jWq7xaQS1VTkZjQKdMu+1AD7YD+o0ujFIEcxpK/b5xbJ3MW9UaUnL3dtxWyfmpkzDYwwnUtCJL93rgdnMBzCTBTXEOG0agIieHtyvhCC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ep6si/QB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FBuDru8C; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ep6si/QB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FBuDru8C" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D597h62835090 for ; Tue, 13 Jan 2026 09:03:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qkmijmGyhFvPEoMmJS0OwOoxZZwnFPG+GA3Si6C/b8I=; b=Ep6si/QBUkrDd2iP bIRaUnyvAhRwOmDHHg8G6Hk2zANcVZophW1xn5Q8n+BQCPGZS45awPqiCcQOTUB3 NXdx5wiE06oyf3xxtHM9bui02AnCEvdN++rVFBxpubn5JAhEU4vgWPyWMV8Re0Ak NZ/a3DnXDfph72++JaXpeLqqjiYihsxw89is1RzA9bl6IZmfvgH1pqKstZaYWJQB cSCnuRexvZSuS0ETddF3oTytJAy8NawurkxLuyKYKRoWWt97HNfnd8NwP2cjC5SE 1kIOt6h2NnWHOU8CkgZ9jEqa4ErWuodGtDg5w+lxj5XSu+pxjE0tN5PLyfQQYbqg IxFRxQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnfn9rn4v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 09:03:42 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4f4a92bf359so209286571cf.2 for ; Tue, 13 Jan 2026 01:03:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768295022; x=1768899822; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qkmijmGyhFvPEoMmJS0OwOoxZZwnFPG+GA3Si6C/b8I=; b=FBuDru8CXodzVO7lEDyxUO9EBXR7xvP6/0/fiGedgOucnhHYyZbeh6/0XSu+T0mgoJ o8KZOIKWP4fzGJ8DUcZQQK25UgbmHrPT6eX6Y2kQSpDQcQ+hGlYmDdUQ4h7zEWlwjV/p AIifVMn5nwoa+tN1hWTXEIZfZBnHDWDT64lYrPTvGVY2ep4E7p5ga8N4mTXJQxoKxV0h 8V04aizlMtYlCDrW/CfzB6rUfkfm6DAJ3yDPxt+f56Bm4D04592fKitZG9yWKWSMXAAI 2Md/pVQDWlg8Z0IGuZ+klwWlD2RYV8qc+dRoriZf1G/fAiaCvV24DdWAPWXY5sXzMgXZ O9BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768295022; x=1768899822; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qkmijmGyhFvPEoMmJS0OwOoxZZwnFPG+GA3Si6C/b8I=; b=ga6gVxnj2rmHOuw38oQs0NlmJm4KJ5Y/gj4T+4iNiW/Yz+PIrpQeO26MbWIAQmbHw0 rDzCv8yK9wKZ3D1U4lFwZFIMOzRMoI3C/kVeUBMaWeefHgNeP9glavBdlJe+gRNnxWPB f5euWoHrSVwRkI5zJce6f2ajjAygNy+O1ZJ+KiV49iItHg1zR6Y8QXdbfDNSr/tgotnL fVERC8IGT+gYs7f/V8qcdBIGKQUPSsV9L2KwJKjA/yGfg10LaPFzmeKfixHvEVkDjv8J bzGwiSZY7IEwYEWXl4/OlBOQO3+CF0R620ffsJGsJn85qSrF840Fxvnxv4RPXg/4j8RS DENQ== X-Gm-Message-State: AOJu0Yy5akOVs7H36nDpG7qg1rJB6l9GS+X9qB//MhbqNCeTN4qDDhpj eBjM0x123PAMZpIV5VZlOisTggAGwuRwDev+rc39i+l2wDn2H9K7+dKsSH59JrrRzbBkk1zWpHU eu+Xg6gTHceUHNvcxx6Ojjrx14t0cq0spuYpCNVU0F3tJmLdhkYPx9FPV2ME3+FpfMYE= X-Gm-Gg: AY/fxX4mrOgCPcKEqxLAkHHzd9o3jRfQDgp4ozGKv+vWNSqiM57B8K33OJb9bFkN6Le +x1b7OHF+xoeTOWERTN57QSnVeJVU8m2wflY4HJn8NfF/fKesTPQ6XnZmtuibd1C/6OLPudbSdf ZOIIzeGNM2JSOHL2jSWROB975rFP9aVQtStu2lmNMgp/HUro/WmFM6Fo7/QUXmn8hdAbotrdTm1 QnlY4fyT+8ka0FRzm5qG8rcA0aOgs9Tw7j4ri9NoSoSvE12U+kM17FUSjQ52xlpbLnY82XkEO2g GPcGkxH29JFU6OY2HBdUPGweU20fhGIJ82+ZGdme6B5M/yqWkm8LeYdGatpI6ts9DX2Gv7zrlI3 pKRvM56HlJ1tNXGYJvod10xC1NIcXeDcHt3cIE4VsakJi8VcYe772n2TrouRR3kSHsW7HILAjho Uo X-Received: by 2002:a05:622a:148f:b0:4ff:b29a:9af6 with SMTP id d75a77b69052e-4ffb4a52aedmr306492691cf.71.1768295022206; Tue, 13 Jan 2026 01:03:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHNhJ++r8bFoVxVbXFvNb0bkYxr+Ze8eUj/Rww/YBbg/V6XAay6CZuJoV4fWf4AO2yKnIi4Tg== X-Received: by 2002:a05:622a:148f:b0:4ff:b29a:9af6 with SMTP id d75a77b69052e-4ffb4a52aedmr306492331cf.71.1768295021766; Tue, 13 Jan 2026 01:03:41 -0800 (PST) Received: from WENMLIU-LAB01.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770ce298sm154352586d6.8.2026.01.13.01.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jan 2026 01:03:41 -0800 (PST) From: Wenmeng Liu Date: Tue, 13 Jan 2026 17:03:27 +0800 Subject: [PATCH v8 2/3] media: qcom: camss: Add link support for TPG Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260113-camss_tpg-v8-2-fa2cb186a018@oss.qualcomm.com> References: <20260113-camss_tpg-v8-0-fa2cb186a018@oss.qualcomm.com> In-Reply-To: <20260113-camss_tpg-v8-0-fa2cb186a018@oss.qualcomm.com> To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, Wenmeng Liu X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1768295009; l=8231; i=wenmeng.liu@oss.qualcomm.com; s=20250925; h=from:subject:message-id; bh=R9nZwPy9XRc15CVOKozFsAIrfAJ5dbYQZLjeVD3rWjQ=; b=pJKEiLa3YmQOsOOSOVTKL8xUWDAdtm8vvbxkb+8VTUosbWoC0FOY4B/ylJ+S2uhjLAIYH3fcQ nZqZ+ZAWOSUAaFt5ymCuvv6BZa45GcM9ddeO4F6S+d9uTW/j0JanKHa X-Developer-Key: i=wenmeng.liu@oss.qualcomm.com; a=ed25519; pk=fQJjf9C3jGDjE1zj2kO3NQLTbQEaZObVcXAzx5WLPX0= X-Proofpoint-GUID: 1UfU8mkXLhf9w18eIwt7bPaHrHoQqfj4 X-Proofpoint-ORIG-GUID: 1UfU8mkXLhf9w18eIwt7bPaHrHoQqfj4 X-Authority-Analysis: v=2.4 cv=HN/O14tv c=1 sm=1 tr=0 ts=69660a6e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=D-OMaI2VJto731AKaP4A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA3NCBTYWx0ZWRfXyPqDNmfifpQf +kifSfTVjCFTj1dyFrDRA1R3RdYsjfCN8otoXhtWtj2NlX65o68iNfP8gl+x1rFBoBHtPnTylLp nk06IXFdwwjS8JyCAAIReRPfowywbMG+9ZPFxurj2KOGPwR4RYFePwEaxp53RM2SxZ5wYg1oqNZ mcYZzeXOKoY+BQq9M5gbVQ0AyGo9I312q+Ps2TO3ILztJZjRyW2jIYbuJ7v1K5flo48vyMAZ4Xu 45p61OXfgBgiN6yHr9nbIICMgGlylRUrgoIie3t+2P8EMDIy3elzZ3mnx2/IAT35w6TePwt81Ow 8mqwdRSlOvmfMNSbqXknbWQjzmXweugxRfknE5z3slpKP+u30VPWlTHgSqqv8kbj1umoNZSTtS0 d4TN98TXT8XbDlAj4IuBk8TUW9XBlo09KX24QRuQWvWerB47ugiWvmQwRsHjBkMzHN8kXFYxBmV kzM03BWNsirdGyASDow== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130074 TPG is connected to the csid as an entity, the link needs to be adapted. Signed-off-by: Wenmeng Liu --- drivers/media/platform/qcom/camss/camss-csid.c | 45 +++++++++++++------ drivers/media/platform/qcom/camss/camss-csid.h | 1 + drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-csiphy.h | 2 + drivers/media/platform/qcom/camss/camss.c | 55 ++++++++++++++++++++= ++++ 5 files changed, 90 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media= /platform/qcom/camss/camss-csid.c index 5284b5857368c37c202cd89dad6ae8042b637537..42fb299a655354face660308c3d= 535b09caa8ed2 100644 --- a/drivers/media/platform/qcom/camss/camss-csid.c +++ b/drivers/media/platform/qcom/camss/camss-csid.c @@ -35,6 +35,8 @@ #define HW_VERSION_REVISION 16 #define HW_VERSION_GENERATION 28 =20 +#define LANE_CFG_BITWIDTH 4 + #define MSM_CSID_NAME "msm_csid" =20 const char * const csid_testgen_modes[] =3D { @@ -1227,18 +1229,22 @@ void msm_csid_get_csid_id(struct media_entity *enti= ty, u8 *id) } =20 /* - * csid_get_lane_assign - Calculate CSI2 lane assign configuration paramet= er - * @lane_cfg - CSI2 lane configuration + * csid_get_lane_assign - Calculate lane assign by csiphy/tpg lane num + * @num: lane num + * @pos_array: Array of lane positions * * Return lane assign */ -static u32 csid_get_lane_assign(struct csiphy_lanes_cfg *lane_cfg) +static u32 csid_get_lane_assign(struct csiphy_lanes_cfg *lane_cfg, int num= _lanes) { u32 lane_assign =3D 0; + int pos; int i; =20 - for (i =3D 0; i < lane_cfg->num_data; i++) - lane_assign |=3D lane_cfg->data[i].pos << (i * 4); + for (i =3D 0; i < num_lanes; i++) { + pos =3D lane_cfg ? lane_cfg->data[i].pos : i; + lane_assign |=3D pos << (i * LANE_CFG_BITWIDTH); + } =20 return lane_assign; } @@ -1263,6 +1269,7 @@ static int csid_link_setup(struct media_entity *entit= y, if ((local->flags & MEDIA_PAD_FL_SINK) && (flags & MEDIA_LNK_FL_ENABLED)) { struct v4l2_subdev *sd; + struct tpg_device *tpg; struct csid_device *csid; struct csiphy_device *csiphy; struct csiphy_lanes_cfg *lane_cfg; @@ -1277,18 +1284,28 @@ static int csid_link_setup(struct media_entity *ent= ity, return -EBUSY; =20 sd =3D media_entity_to_v4l2_subdev(remote->entity); - csiphy =3D v4l2_get_subdevdata(sd); + if (sd->grp_id =3D=3D TPG_GUP_ID) { + tpg =3D v4l2_get_subdevdata(sd); =20 - /* If a sensor is not linked to CSIPHY */ - /* do no allow a link from CSIPHY to CSID */ - if (!csiphy->cfg.csi2) - return -EPERM; + csid->phy.lane_cnt =3D tpg->res->lane_cnt; + csid->phy.csiphy_id =3D tpg->id; + csid->phy.lane_assign =3D csid_get_lane_assign(NULL, csid->phy.lane_cnt= ); + csid->tpg_linked =3D true; + } else { + csiphy =3D v4l2_get_subdevdata(sd); =20 - csid->phy.csiphy_id =3D csiphy->id; + /* If a sensor is not linked to CSIPHY */ + /* do no allow a link from CSIPHY to CSID */ + if (!csiphy->cfg.csi2) + return -EPERM; =20 - lane_cfg =3D &csiphy->cfg.csi2->lane_cfg; - csid->phy.lane_cnt =3D lane_cfg->num_data; - csid->phy.lane_assign =3D csid_get_lane_assign(lane_cfg); + csid->phy.csiphy_id =3D csiphy->id; + + lane_cfg =3D &csiphy->cfg.csi2->lane_cfg; + csid->phy.lane_cnt =3D lane_cfg->num_data; + csid->phy.lane_assign =3D csid_get_lane_assign(lane_cfg, lane_cfg->num_= data); + csid->tpg_linked =3D false; + } } /* Decide which virtual channels to enable based on which source pads are= enabled */ if (local->flags & MEDIA_PAD_FL_SOURCE) { diff --git a/drivers/media/platform/qcom/camss/camss-csid.h b/drivers/media= /platform/qcom/camss/camss-csid.h index aedc96ed84b2fcc3f352160dcfd31554a671d0fc..5296b10f6bac839a3faa1039bdb= f0fbbbe9456ac 100644 --- a/drivers/media/platform/qcom/camss/camss-csid.h +++ b/drivers/media/platform/qcom/camss/camss-csid.h @@ -161,6 +161,7 @@ struct csid_device { int num_supplies; struct completion reset_complete; struct csid_testgen_config testgen; + bool tpg_linked; struct csid_phy_config phy; struct v4l2_mbus_framefmt fmt[MSM_CSID_PADS_NUM]; struct v4l2_ctrl_handler ctrls; diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/med= ia/platform/qcom/camss/camss-csiphy.c index a734fb7dde0a492cf6e33f53e379557665d54f64..c15990d9d09cc8f9960729bdc11= 2d81751b4938c 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c @@ -800,6 +800,7 @@ int msm_csiphy_register_entity(struct csiphy_device *cs= iphy, sd->flags |=3D V4L2_SUBDEV_FL_HAS_DEVNODE; snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d", MSM_CSIPHY_NAME, csiphy->id); + sd->grp_id =3D CSIPHY_GUP_ID; v4l2_set_subdevdata(sd, csiphy); =20 ret =3D csiphy_init_formats(sd, NULL); diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.h b/drivers/med= ia/platform/qcom/camss/camss-csiphy.h index 895f80003c441dcacf98435f91567f90afa29279..b7bcf2bdd2124f77b5354b15b33= aa1e0983143e8 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.h +++ b/drivers/media/platform/qcom/camss/camss-csiphy.h @@ -21,6 +21,8 @@ #define MSM_CSIPHY_PAD_SRC 1 #define MSM_CSIPHY_PADS_NUM 2 =20 +#define CSIPHY_GUP_ID 1 + struct csiphy_lane { u8 pos; u8 pol; diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/plat= form/qcom/camss/camss.c index fcc2b2c3cba076e598bc8aacd34efce5d71713ca..43fdcb9af101ef34b118035ca9c= 68757b66118df 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -4145,6 +4145,19 @@ static int camss_init_subdevices(struct camss *camss) } } =20 + if (camss->tpg) { + for (i =3D 0; i < camss->res->tpg_num; i++) { + ret =3D msm_tpg_subdev_init(camss, &camss->tpg[i], + &res->tpg_res[i], i); + if (ret < 0) { + dev_err(camss->dev, + "Failed to init tpg%d sub-device: %d\n", + i, ret); + return ret; + } + } + } + /* note: SM8250 requires VFE to be initialized before CSID */ for (i =3D 0; i < camss->res->vfe_num; i++) { ret =3D msm_vfe_subdev_init(camss, &camss->vfe[i], @@ -4233,6 +4246,23 @@ static int camss_link_entities(struct camss *camss) } } =20 + for (i =3D 0; i < camss->res->tpg_num; i++) { + for (j =3D 0; j < camss->res->csid_num; j++) { + ret =3D media_create_pad_link(&camss->tpg[i].subdev.entity, + MSM_TPG_PAD_SRC, + &camss->csid[j].subdev.entity, + MSM_CSID_PAD_SINK, + 0); + if (ret < 0) { + camss_link_err(camss, + camss->tpg[i].subdev.entity.name, + camss->csid[j].subdev.entity.name, + ret); + return ret; + } + } + } + if (camss->ispif) { for (i =3D 0; i < camss->res->csid_num; i++) { for (j =3D 0; j < camss->ispif->line_num; j++) { @@ -4337,6 +4367,19 @@ static int camss_register_entities(struct camss *cam= ss) } } =20 + if (camss->tpg) { + for (i =3D 0; i < camss->res->tpg_num; i++) { + ret =3D msm_tpg_register_entity(&camss->tpg[i], + &camss->v4l2_dev); + if (ret < 0) { + dev_err(camss->dev, + "Failed to register tpg%d entity: %d\n", + i, ret); + goto err_reg_tpg; + } + } + } + for (i =3D 0; i < camss->res->csid_num; i++) { ret =3D msm_csid_register_entity(&camss->csid[i], &camss->v4l2_dev); @@ -4380,6 +4423,13 @@ static int camss_register_entities(struct camss *cam= ss) for (i--; i >=3D 0; i--) msm_csid_unregister_entity(&camss->csid[i]); =20 + i =3D camss->res->tpg_num; +err_reg_tpg: + if (camss->tpg) { + for (i--; i >=3D 0; i--) + msm_tpg_unregister_entity(&camss->tpg[i]); + } + i =3D camss->res->csiphy_num; err_reg_csiphy: for (i--; i >=3D 0; i--) @@ -4401,6 +4451,11 @@ static void camss_unregister_entities(struct camss *= camss) for (i =3D 0; i < camss->res->csiphy_num; i++) msm_csiphy_unregister_entity(&camss->csiphy[i]); =20 + if (camss->tpg) { + for (i =3D 0; i < camss->res->tpg_num; i++) + msm_tpg_unregister_entity(&camss->tpg[i]); + } + for (i =3D 0; i < camss->res->csid_num; i++) msm_csid_unregister_entity(&camss->csid[i]); =20 --=20 2.34.1