From nobody Sat Feb 7 23:47:54 2026 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C9373126A7 for ; Mon, 12 Jan 2026 23:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768259411; cv=none; b=O59HNci04/CCRQuNtMiIzY7pdujY7W3DihLjashD7nDGU5QWi2QkwPdxiX+FHi8sxPID5rUkJpbOYkRSB/N5W4PeurP2O8w8jyo7jmPXvJeR1JALArTLF0eqM0wJCiwz2G0ctDV52Cpl90AA2pEgF89KEsSdFBanqFHDaetMiiw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768259411; c=relaxed/simple; bh=hSt66rCqqC73KbbbiO9lZskui0WT+x9BIB/TbYXiN04=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=e/cWU/O4MrmcnEkzwYte9ruuHH1xGkN77ryO4uzT5lmn0tdx1B4N5eoI3I9+ekLZ7RuPU0VsbaArNAPf3k4vlj+Fzf8u6YsTSfTemsvTRfUwcaW3gWRjY+sqrU0+2O7/dcq5eOJFJoIAPYtw/wpsW6Yx8O0hWRa0aSD2/husxYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=zukxraCT; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="zukxraCT" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2b21d136010so1863284eec.1 for ; Mon, 12 Jan 2026 15:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768259409; x=1768864209; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ys9dvyGwIYrmKuQ4BRnJwsHizh4UyGAtZEMdFdAVXfI=; b=zukxraCTWDZAQPmozTvcQ7hQV9IxtM2+345IR+gm+GfCLPNApdfneh/AeO1j3n7nYx Tnz2g/jxbeEHoXvkCCmq61x6AbCmKYFh6fNsw96F4tn4pE2TMa2Qg1LMMih2pv4xvoYo MeaeUvBpt1qJooYYbVQLgGbhigIEV+Gvs58zvw2vJoTJgwglCSAUI1hCkqkdTcE6HnJ9 3J2N/y4IwpMlqq4LQDyUCbALI0tbdQhrXV8S+zkY49Lus59FT7p/dIyAgi9jiRSqjc9c e3/0lU9CKWyOVEy2p7uym/q8H4fC4n5ZcZTQiwZhjftIDSk15lqw4A1Gxkhu4bjO7Jnm mg4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768259409; x=1768864209; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ys9dvyGwIYrmKuQ4BRnJwsHizh4UyGAtZEMdFdAVXfI=; b=JKsiVVsckzGriKQGueujxiS3GrJm+LKGPn84N97Ef4Zj04eMTlPsUss/KaqfWSpEmU y/etNz8vtlWhzHb0MIltuZioL4M6SlCwduZfvgs06i5cszRA9v1y7XpjEerh0esaNScE HlrHM/3ejGPHUBEJAQ/c0rQUmf68vuSXEkWmCDZNEfVsBFuQnVwqE2FKYyU8hhQsaUGi zyc9qzZGrCU+1qo3jwGGP7Rn9j3idR8jOvj46OWFRSyD87QLVzUUB2CZN5/BcBZy33g5 uZXRmNcUSmtCDuSrp1AHk2+FM5KIMh32MSlXe3bMQnk7nB4cFhOSSsF4Ao1Z6FAcDkfB VPFw== X-Forwarded-Encrypted: i=1; AJvYcCUqn0Tgz0uoEyhpti416+7YmdFluZeR2cKWBcZG1tzCPrWVwQ5fGqRUhIX3NDKibPDaCkL0bww8a06vqgs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfjsa4jIHehpc919bh9nV4aNP6a9osK3ZFMOWosXSBqkrI7647 6iKTYorKK5vCQNJtR2wSefY2ZOOh+lCxW8Klhwolg/VbE0zw4IjL0nQJLn73vqn5mzjZyaLjoUd 4oAIXGA== X-Google-Smtp-Source: AGHT+IG2eLtwALIqRuLzTvWBZTR3JwnqCHU/cLQ/o7m/M8FDpJLzndU6O/Y0t/1rJsF81ci2jWQlHUXyLwY= X-Received: from dlbtp2.prod.google.com ([2002:a05:7022:3b82:b0:123:2dd9:db4]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:6286:b0:119:e56b:9899 with SMTP id a92af1059eb24-121f8a5b4demr19013846c88.0.1768259409124; Mon, 12 Jan 2026 15:10:09 -0800 (PST) Date: Mon, 12 Jan 2026 23:09:43 +0000 In-Reply-To: <20260112230944.3085309-1-boolli@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260112230944.3085309-1-boolli@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260112230944.3085309-2-boolli@google.com> Subject: [PATCH 1/2] idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. From: Li Li To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In idpf_rxq_group_alloc(), if rx_qgrp->splitq.bufq_sets failed to get allocated: rx_qgrp->splitq.bufq_sets =3D kcalloc(vport->num_bufqs_per_qgrp, sizeof(struct idpf_bufq_set), GFP_KERNEL); if (!rx_qgrp->splitq.bufq_sets) { err =3D -ENOMEM; goto err_alloc; } idpf_rxq_group_rel() would attempt to deallocate it in idpf_rxq_sw_queue_rel(), causing a kernel panic: ``` [ 7.967242] early-network-sshd-n-rexd[3148]: knetbase: Info: [ 8.1278= 04] BUG: kernel NULL pointer dereference, address: 00000000000000c0 ... [ 8.129779] RIP: 0010:idpf_rxq_group_rel+0x101/0x170 ... [ 8.133854] Call Trace: [ 8.133980] [ 8.134092] idpf_vport_queues_alloc+0x286/0x500 [ 8.134313] idpf_vport_open+0x4d/0x3f0 [ 8.134498] idpf_open+0x71/0xb0 [ 8.134668] __dev_open+0x142/0x260 [ 8.134840] netif_open+0x2f/0xe0 [ 8.135004] dev_open+0x3d/0x70 [ 8.135166] bond_enslave+0x5ed/0xf50 [ 8.135345] ? nla_put_ifalias+0x3d/0x90 [ 8.135533] ? kvfree_call_rcu+0xb5/0x3b0 [ 8.135725] ? kvfree_call_rcu+0xb5/0x3b0 [ 8.135916] do_set_master+0x114/0x160 [ 8.136098] do_setlink+0x412/0xfb0 [ 8.136269] ? security_sock_rcv_skb+0x2a/0x50 [ 8.136509] ? sk_filter_trim_cap+0x7c/0x320 [ 8.136714] ? skb_queue_tail+0x20/0x50 [ 8.136899] ? __nla_validate_parse+0x92/0xe50 [ 8.137112] ? security_capable+0x35/0x60 [ 8.137304] rtnl_newlink+0x95c/0xa00 [ 8.137483] ? __rtnl_unlock+0x37/0x70 [ 8.137664] ? netdev_run_todo+0x63/0x530 [ 8.137855] ? allocate_slab+0x280/0x870 [ 8.138044] ? security_capable+0x35/0x60 [ 8.138235] rtnetlink_rcv_msg+0x2e6/0x340 [ 8.138431] ? __pfx_rtnetlink_rcv_msg+0x10/0x10 [ 8.138650] netlink_rcv_skb+0x16a/0x1a0 [ 8.138840] netlink_unicast+0x20a/0x320 [ 8.139028] netlink_sendmsg+0x304/0x3b0 [ 8.139217] __sock_sendmsg+0x89/0xb0 [ 8.139399] ____sys_sendmsg+0x167/0x1c0 [ 8.139588] ? ____sys_recvmsg+0xed/0x150 [ 8.139780] ___sys_sendmsg+0xdd/0x120 [ 8.139960] ? ___sys_recvmsg+0x124/0x1e0 [ 8.140152] ? rcutree_enqueue+0x1f/0xb0 [ 8.140341] ? rcutree_enqueue+0x1f/0xb0 [ 8.140528] ? call_rcu+0xde/0x2a0 [ 8.140695] ? evict+0x286/0x2d0 [ 8.140856] ? rcutree_enqueue+0x1f/0xb0 [ 8.141043] ? kmem_cache_free+0x2c/0x350 [ 8.141236] __x64_sys_sendmsg+0x72/0xc0 [ 8.141424] do_syscall_64+0x6f/0x890 [ 8.141603] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 8.141841] RIP: 0033:0x7f2799d21bd0 ... [ 8.149905] Kernel panic - not syncing: Fatal exception [ 8.175940] Kernel Offset: 0xf800000 from 0xffffffff81000000 (relocation= range: 0xffffffff80000000-0xffffffffbfffffff) [ 8.176425] Rebooting in 10 seconds.. ``` Tested: With this patch, the kernel panic no longer appears. Fixes: 95af467d9a4e ("idpf: configure resources for RX queues") Signed-off-by: Li Li Reviewed-by: Aleksandr Loktionov Reviewed-by: Paul Menzel Tested-by: Samuel Salin --- drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethe= rnet/intel/idpf/idpf_txrx.c index e7b131dba200c..b4dab4a8ee11b 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c @@ -1337,6 +1337,8 @@ static void idpf_txq_group_rel(struct idpf_vport *vpo= rt) static void idpf_rxq_sw_queue_rel(struct idpf_rxq_group *rx_qgrp) { int i, j; + if (!rx_qgrp->splitq.bufq_sets) + return; =20 for (i =3D 0; i < rx_qgrp->vport->num_bufqs_per_qgrp; i++) { struct idpf_bufq_set *bufq_set =3D &rx_qgrp->splitq.bufq_sets[i]; --=20 2.52.0.457.g6b5491de43-goog From nobody Sat Feb 7 23:47:54 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D974031B805 for ; Mon, 12 Jan 2026 23:10:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768259414; cv=none; b=mBsullg1tYV7bN9oIc19X/NH6DU6XsKsQQPSI+A+apHNVxmrqryyRU+4MF/fETcCBk+k7kmBpArfYEN4PxxTjf/SNo+Hoaib7pde2ZYo+h5eMDy0jCT76CHEVJd7sx3LsroJznIN1doM9fUkH3b/rzckYuazWBRujzw3ugI4Kfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768259414; c=relaxed/simple; bh=OVeV2T7Schb9tKEgL7V9yVfcDlLFjn7Kd/3QGB2jaS0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=iuOSVM9ox+jAxhVQPVZPp1ijt8XiwlMQ5EHK2ZDWoQ4aqdTWd0dnZ7u5dlv5J0AbytoVIJFus+qb1GH7kH0FEjp5WPORqHK061ESqWRBCGWFJj0vBSecCI/xPEbKYAFtBIGSWeYDjvK+kaYZdb6tTUbY/IWvdnaXemj1BNKXWXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ynLTSRMj; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ynLTSRMj" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2b1766192e6so5597442eec.1 for ; Mon, 12 Jan 2026 15:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1768259412; x=1768864212; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1GtgZegM7FjbeyuOL5Y6kyqpA7dLG8bpU56qxoB17r0=; b=ynLTSRMj+oVwvUq+S4c/t9F6Khf+qqUpOqTQdsVGQvhVQCpCPUIGQrKkllgUHAb86W zF6w6P7T2kPMPPXIG6bGFJQMcBjPEuifRNGZzUZjc9HQSoriLxiPSLd10jFHNoySoh8M oOH1F4Gwh6S0t4RCe3MR0EAMHytZ7lVKgOhTXfyo4GG4RyrfaB5Ca0Z6yTccLRmFxzOx KsjJvGDKBIDE3NaBwd71dfflQPnu47WeuEpiSn9h1a+61wieRJQOkpJSWA5hiyNFYC4G 9dCV99ps66o0Mb45QX5NrkV15F1q8cq+nML7HXp53f8xvW2PeEXootcss+hkQZYT3TjQ saMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768259412; x=1768864212; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1GtgZegM7FjbeyuOL5Y6kyqpA7dLG8bpU56qxoB17r0=; b=E8Dn8cqOP5PP7ojvafMtnUSNYIbhzM61aHG+X6G/mp726ZBgb67BPZUawmusjy9W/d e5N5gQdCKIEV6+hWHMuV3drMMBTzXZ59NH2jnmjz9dyffnQulvt8dGgA61YqjecGMdZ/ Q2AL3DdEu0JdlP6V0p8T6VBQetYOn7YW2yrTTeYNFrFiyHbH6WgVZ+yw+M/v1GDTg+GO V+neI1eJOnfAqF+I0aSMvQNxc0aG30J5wByGyG5JNaVljtXcFDGeYC2N41A5aqlVOkQT AST6MnKedCL1x3efQAdidd5FTOdQMV91q7EuccB7ehdwbYn6CZiGzZNDAbF5u4XhKMfZ 0SFA== X-Forwarded-Encrypted: i=1; AJvYcCURhEDqyJzg2PHcY5YGKumm4ruhn40KDRBx/6cAwG4X5AlS7FWHisU/U3if6fkxMF1uSnLDGYocg42gnR0=@vger.kernel.org X-Gm-Message-State: AOJu0YzWisxeQ5Jof5ue3FX2kfBVKEs0LeXx6Ng0cyC0qnyi1ZF6ozcC 4J1UvIdabDimC9gBGlw7E92WQ1xY+hiP/n1q+kQ+g/jjBpiFPkGyfejJZLFJPdpxV9YTJX/sppZ N/Hdjqw== X-Google-Smtp-Source: AGHT+IFUZfbTXF1Fw1Cvh/r4GdD8A92eVq9LwJaEBG9JrsMm9bSGeUApjkJeHgxbw+xleiw77AYeSVOJYO4= X-Received: from dlbti6.prod.google.com ([2002:a05:7022:1b06:b0:11f:3484:4f15]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:f90:b0:11d:c04a:dc5b with SMTP id a92af1059eb24-121f8b7a790mr16487972c88.30.1768259411873; Mon, 12 Jan 2026 15:10:11 -0800 (PST) Date: Mon, 12 Jan 2026 23:09:44 +0000 In-Reply-To: <20260112230944.3085309-1-boolli@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260112230944.3085309-1-boolli@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260112230944.3085309-3-boolli@google.com> Subject: [PATCH 2/2] idpf: skip deallocating txq group's txqs if it is NULL. From: Li Li To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In idpf_txq_group_alloc(), if any txq group's txqs failed to allocate memory: for (j =3D 0; j < tx_qgrp->num_txq; j++) { tx_qgrp->txqs[j] =3D kzalloc(sizeof(*tx_qgrp->txqs[j]), GFP_KERNEL); if (!tx_qgrp->txqs[j]) goto err_alloc; } It would cause a NULL ptr kernel panic in idpf_txq_group_rel(): for (j =3D 0; j < txq_grp->num_txq; j++) { if (flow_sch_en) { kfree(txq_grp->txqs[j]->refillq); txq_grp->txqs[j]->refillq =3D NULL; } kfree(txq_grp->txqs[j]); txq_grp->txqs[j] =3D NULL; } [ 6.532461] BUG: kernel NULL pointer dereference, address: 0000000000000= 058 ... [ 6.534433] RIP: 0010:idpf_txq_group_rel+0xc9/0x110 ... [ 6.538513] Call Trace: [ 6.538639] [ 6.538760] idpf_vport_queues_alloc+0x75/0x550 [ 6.538978] idpf_vport_open+0x4d/0x3f0 [ 6.539164] idpf_open+0x71/0xb0 [ 6.539324] __dev_open+0x142/0x260 [ 6.539506] netif_open+0x2f/0xe0 [ 6.539670] dev_open+0x3d/0x70 [ 6.539827] bond_enslave+0x5ed/0xf50 [ 6.540005] ? rcutree_enqueue+0x1f/0xb0 [ 6.540193] ? call_rcu+0xde/0x2a0 [ 6.540375] ? barn_get_empty_sheaf+0x5c/0x80 [ 6.540594] ? __kfree_rcu_sheaf+0xb6/0x1a0 [ 6.540793] ? nla_put_ifalias+0x3d/0x90 [ 6.540981] ? kvfree_call_rcu+0xb5/0x3b0 [ 6.541173] ? kvfree_call_rcu+0xb5/0x3b0 [ 6.541365] do_set_master+0x114/0x160 [ 6.541547] do_setlink+0x412/0xfb0 [ 6.541717] ? security_sock_rcv_skb+0x2a/0x50 [ 6.541931] ? sk_filter_trim_cap+0x7c/0x320 [ 6.542136] ? skb_queue_tail+0x20/0x50 [ 6.542322] ? __nla_validate_parse+0x92/0xe50 ro[o t t o6 .d5e4f2a5u4l0t]- ? security_capable+0x35/0x60 [ 6.542792] rtnl_newlink+0x95c/0xa00 [ 6.542972] ? __rtnl_unlock+0x37/0x70 [ 6.543152] ? netdev_run_todo+0x63/0x530 [ 6.543343] ? allocate_slab+0x280/0x870 [ 6.543531] ? security_capable+0x35/0x60 [ 6.543722] rtnetlink_rcv_msg+0x2e6/0x340 [ 6.543918] ? __pfx_rtnetlink_rcv_msg+0x10/0x10 [ 6.544138] netlink_rcv_skb+0x16a/0x1a0 [ 6.544328] netlink_unicast+0x20a/0x320 [ 6.544516] netlink_sendmsg+0x304/0x3b0 [ 6.544748] __sock_sendmsg+0x89/0xb0 [ 6.544928] ____sys_sendmsg+0x167/0x1c0 [ 6.545116] ? ____sys_recvmsg+0xed/0x150 [ 6.545308] ___sys_sendmsg+0xdd/0x120 [ 6.545489] ? ___sys_recvmsg+0x124/0x1e0 [ 6.545680] ? rcutree_enqueue+0x1f/0xb0 [ 6.545867] ? rcutree_enqueue+0x1f/0xb0 [ 6.546055] ? call_rcu+0xde/0x2a0 [ 6.546222] ? evict+0x286/0x2d0 [ 6.546389] ? rcutree_enqueue+0x1f/0xb0 [ 6.546577] ? kmem_cache_free+0x2c/0x350 [ 6.546784] __x64_sys_sendmsg+0x72/0xc0 [ 6.546972] do_syscall_64+0x6f/0x890 [ 6.547150] entry_SYSCALL_64_after_hwframe+0x76/0x7e [ 6.547393] RIP: 0033:0x7fc1a3347bd0 ... [ 6.551375] RIP: 0010:idpf_txq_group_rel+0xc9/0x110 ... [ 6.578856] Rebooting in 10 seconds.. We should skip deallocating txqs[j] if it is NULL in the first place. Tested: with this patch, the kernel panic no longer appears. Fixes: 1c325aac10a8 ("idpf: configure resources for TX queues") Signed-off-by: Li Li Reviewed-by: Aleksandr Loktionov Reviewed-by: Paul Menzel Tested-by: Samuel Salin --- drivers/net/ethernet/intel/idpf/idpf_txrx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethe= rnet/intel/idpf/idpf_txrx.c index b4dab4a8ee11b..25207da6c995d 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c @@ -1311,6 +1311,9 @@ static void idpf_txq_group_rel(struct idpf_vport *vpo= rt) struct idpf_txq_group *txq_grp =3D &vport->txq_grps[i]; =20 for (j =3D 0; j < txq_grp->num_txq; j++) { + if (!txq_grp->txqs[j]) + continue; + if (flow_sch_en) { kfree(txq_grp->txqs[j]->refillq); txq_grp->txqs[j]->refillq =3D NULL; --=20 2.52.0.457.g6b5491de43-goog