From nobody Sun Feb 8 19:55:48 2026 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F28D632693D for ; Mon, 12 Jan 2026 20:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768249352; cv=none; b=Lej2OwB1PKzl3BxyrThju+TT/OmG6EZq4Vrf5TWEZqGpBTZ7UO18Dl5jnpxXqiY7b1HxcMpliNcHdtks2WWSR4zBt+CQCpUWhp0x04L25/4jM2P3FAlNpdUL2g70wl6Do2ZQ6+KLTWVJOjUvEr2myK8P/6o0mscO5Esvo58J6FU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768249352; c=relaxed/simple; bh=iTyXVmOKTtuuaBrXEffb8U93bQ3tGfex+q/fzHPqD8M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cOAWFdMOi2Z9mlIrHJbepaECAwdSZVTmqGMH0VadUxWAi/k1DYhhSHt3pVlr5Gjw//q5JiSKrUP66xl6NJ9XErDJ3I0MBD6ZmQa2L9YwDKdpQ7+0nLRFIEw0pZcEj8rUtRVY2nwWwJB+Qup8S+jJcIkFsCYPlUjPdJ5nHDifr44= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZsI49F7K; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZsI49F7K" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7cac8243bcdso4720701a34.3 for ; Mon, 12 Jan 2026 12:22:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768249350; x=1768854150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KQhHys9dUc4M12K/6mikStA3Vn/WKvogmWYn0AQLqxc=; b=ZsI49F7KRQmr5ZgWYRBPXxD2dack01vCpTd4Lh3X4mLnMBB7pg1mDrvVLCZA1kA2fN uj0RO/RR4oLUbRamX4y7iixnCMfun/SHl0GjtQE1lj9iC46iIEH9P2Ti24nq1xG430Py cK10ppdP2ATBXboaxPS2FMjWtA9Yv51JwJv4VbGkLQgrabaC9whyD0OK0DwU57op34HV RHodG4J9wJ4Cy9c+1LeclC2u8+iNraDaWkBOeoYKJa9/SCFy42x924xegaZHdS4xi7jf f7K7AGgKNu+z2Kg1SRWJNU9ea007jS08KY+xeKWCNNsuPm99qU8eT+d8vchlRTTL+hsE 0zSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768249350; x=1768854150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KQhHys9dUc4M12K/6mikStA3Vn/WKvogmWYn0AQLqxc=; b=UaN9m+0T6c1eHT4GAV4Fc/wioGF3Pu9P1T4/dGOpYQ1Ux0oGos5Gi1+Qohp2gSDPL0 A0y0jPoqeNTeH7MAi8nqux9StoMu29krHnnx8mGfWHmgx5kzK4UjETF+BYWDYgcCTH88 zmi7lFEV33r/Ox4Q1ul4ST81HLArVXBJiYOTufE2o0UHDcpqkMYM0Y783WywIdJsjcUx T4W4EN2/lokQ/oWw8gRP+DFGgfMle2jr8dQyY9RwnhvYqhC4VvWwwef9a5dNJ87hVrar 1HCfymQezRpM1n3GfV0TNWcJ3/G5dp3YpbBVVzvNpkmRjyTK3HxwzrX4ua4oz1HJoHDL OP7w== X-Forwarded-Encrypted: i=1; AJvYcCVIiQKhkis0g5RTy3f9HFgfmKHZr+7A+5P85FSwUqDcVfM1ntjNmHIQD3C4ANyMIFh2HSxOAzdmao9cDkY=@vger.kernel.org X-Gm-Message-State: AOJu0YzkwLwqV+3cqUVXPIeyElV44QA8dZBCp6O9UxFT6MJhyccCGcqu 3FkZSTcd1S0gPMk+2CphtAFBCr7SsDs3rAxRM2lzqQzLUVPcYoD/Lhht3wy9Fw== X-Gm-Gg: AY/fxX49UqsaU3A/SEaDJtZAVlnJk3EGqlbbah1Zpeyz5+RArjvJn+z6ar7Ljg35Zqi pb9WryjoDIamJcgYYKiVuEUfSMCZ5lCuhlTt2LbzlFvW3CN15JM88vrQFZClHhzBKB0KoXBYRGq sr8YyD1dXnJizVrGtAZxz/J5D08LltOzh8aNSBtECQKa8b/5+qT9VAcDR4qXpLLy/iGI6JtM8Pe ZekP93O3NSKWNZxDQDFgpSyLNlAR3vJ8YZVgIlQ6aPRlvfX4iv5zDWJA9j7kHLWMw8lsGpgm71i zYnw3fbJ5DehQL9jxWSsNzXz9mTSk4NqUKiDWc/3Qucsibjsum+urVnmoWK5U6DUk9Xcoqsol+f L7mzv2C28For3Joahs0MTT6ca1khzmmyU8Y8CYGLN+OYr93WQXzulhRIpepjYpGDAB4UJOrtgv+ +8xPubKV27DFrHYJehhuHH3rlbuNgTL5yc X-Google-Smtp-Source: AGHT+IEm2dv7tfrD2jmFgs5OapJQ/RY2SS/945e1BkQco4M2LTyMhD/j6zxrTMMNwp8sgXmupU5y+Q== X-Received: by 2002:a05:6830:6ab9:b0:7c7:6752:2d8 with SMTP id 46e09a7af769-7ce50bb5c2emr11052191a34.32.1768249349917; Mon, 12 Jan 2026 12:22:29 -0800 (PST) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ce4762eefbsm15289256a34.0.2026.01.12.12.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 12:22:29 -0800 (PST) From: Jiasheng Jiang To: boris@bur.io Cc: clm@fb.com, dsterba@suse.com, jiashengjiangcool@gmail.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] btrfs: zoned: remove redundant space_info lock and variable in do_allocation_zoned Date: Mon, 12 Jan 2026 20:22:27 +0000 Message-Id: <20260112202227.37626-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260112185637.GB450687@zen.localdomain> References: <20260112185637.GB450687@zen.localdomain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In do_allocation_zoned(), the code acquires space_info->lock before block_group->lock. However, the critical section does not access or modify any members of the space_info structure. Thus, the lock is redundant as it provides no necessary synchronization here. This change simplifies the locking logic and aligns the function with other zoned paths, such as __btrfs_add_free_space_zoned(), which only rely on block_group->lock. Since the 'space_info' local variable is no longer used after removing the lock calls, it is also removed. Removing this unnecessary lock reduces contention on the global space_info lock, improving concurrency in the zoned allocation path. Signed-off-by: Jiasheng Jiang Reviewed-by: Boris Burkov Reviewed-by: Johannes Thumshirn Reviewed-by: Naohiro Aota --- Changelog: v1 -> v2: 1. Removed the description about avoiding deadlocks. --- fs/btrfs/extent-tree.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index e4cae34620d1..43d78056c274 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -3839,7 +3839,6 @@ static int do_allocation_zoned(struct btrfs_block_gro= up *block_group, struct btrfs_block_group **bg_ret) { struct btrfs_fs_info *fs_info =3D block_group->fs_info; - struct btrfs_space_info *space_info =3D block_group->space_info; struct btrfs_free_space_ctl *ctl =3D block_group->free_space_ctl; u64 start =3D block_group->start; u64 num_bytes =3D ffe_ctl->num_bytes; @@ -3900,7 +3899,6 @@ static int do_allocation_zoned(struct btrfs_block_gro= up *block_group, */ } =20 - spin_lock(&space_info->lock); spin_lock(&block_group->lock); spin_lock(&fs_info->treelog_bg_lock); spin_lock(&fs_info->relocation_bg_lock); @@ -4002,7 +4000,6 @@ static int do_allocation_zoned(struct btrfs_block_gro= up *block_group, spin_unlock(&fs_info->relocation_bg_lock); spin_unlock(&fs_info->treelog_bg_lock); spin_unlock(&block_group->lock); - spin_unlock(&space_info->lock); return ret; } =20 --=20 2.25.1