From nobody Tue Feb 10 05:44:25 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2549D3128A9 for ; Mon, 12 Jan 2026 19:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768244523; cv=none; b=t0iE8lzQc7dqQV/Zl8AsJgm/pu6U4kTerhowGB9zdAbWFj6sglIhcebegNspK9h57cR9HVePQ+KMl1KMC6jnmytq0uFQkiNwcXeP3w8fC1aGBSN50HhCI7U9lWwhw9ER4m+o8HkAI1jX6i6GHK0R5OmV7gAzloldJfmllA2FBxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768244523; c=relaxed/simple; bh=pfeLOwuV5tNEGHquY+BElAmY8n4IFgbScPUapFuaNyg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Xvy6SE6yZ3N4fky9bvnW7CAExBdpavqA/JU3FIOghgkKKQDhx0JHXaQBFGrGXO/DXvDjy6v/nNhMXE9HHDgjrsQg+AKI4i1qm1LktaXODgXOHkRQ4EB3de2b1fi3YTWcOXnXhvsfzc7a6+Kt/5tiz7Zu2QQ67iHYV+zrlEdCBYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j8xAR0Kn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gghVYMfC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j8xAR0Kn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gghVYMfC" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60CHfGec3684989 for ; Mon, 12 Jan 2026 19:01:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=uPDjxnyIvH6 EuQa8qYzLtg8+o6G0UI+SqbdnqVH1a/A=; b=j8xAR0KnlQbuR+kAFXJJdgxvQLO 3xF97ZVby5/Ki1VwyrZHjp/WnNNShU43ykYNqQJ233v9LzzoF8spllzL3PAJYHfX Wn9W84LmWOJYM8LyDW84AlsUUyTg3RKmicxzmI0k6nLGHkN0F8vE0OG2a5z97twT DsQpUmxMpnfu08WD2SyNln/jr9Y6hnu1YatpWzb7Qp6tftGTIpFtR63Kbz6Jow+k a04UA+cvGXKyJLl8GDODLS5kjn8KbW3JlldRpUGVOHSd4XMCLKta4nMZt+JbYc5u i5MP4W2MaZ3vIvz80690mlxsOodqpXQ/Y7ik4HNs0LlOhQRpEBkZzCJxyLA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bn52f0bkr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Jan 2026 19:01:56 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0fe4ade9eso63108755ad.0 for ; Mon, 12 Jan 2026 11:01:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768244516; x=1768849316; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uPDjxnyIvH6EuQa8qYzLtg8+o6G0UI+SqbdnqVH1a/A=; b=gghVYMfCDqQPRz69+S7Gx24q9WkkfyFowlpccMKo8Ctn/uC2OLfiP9dC6jklj62rsL oBB7hdNlkpWg/8RoMhrP8n3UifK6LludSJQac9KjprMvuWRn0oLEuguADAyn75qneKwz S/J7M8jrCna8MULs2dzixHZkGFIibqQwU6dx1dN+O73AQrvZCMZmVESUUDyVvMvO0WE1 YSON6WCK/LBqmPst9yqS1Xc4FVTP6TkgOqENRHw74YMguSsF3R6CW2neuyyD7R5LbXjS lCN2rpBaVdSRaXM2u+DZJCk0t0b5zyqwJaM49qEmprtb8SHKCkUUBucMLAe9t+qTpcq1 CGCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768244516; x=1768849316; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uPDjxnyIvH6EuQa8qYzLtg8+o6G0UI+SqbdnqVH1a/A=; b=vjmYI/SBIu2PcqjD2+B05dOawMuLxLmz3IlxbatlpirsS4czItiBH6kH8Mu17/7SLl iHgu2wszL09uO13Uk4SVDz7iPKPCUGRk45g6YsA/bBsjE+AktY7VhAFSMUV0oUUFglQS Eh4oJ2pvnU0T3b+DKlqE1M2POmOxeiNItxTQ2g4hfwxNcIawfU6WyPpLNqu77ZSGEqHX eSXzNghOUvLKucFNuygioI5kwy7Y/pjshhDstGEeA/9+FAuDhsRGZHU0it4vXnrgQH17 fIO6Fn42HAfJCUAwgUS+WyV2AjTccM+tH6BsCqwu5BhLblika0Bd+zBmWAWncgcKt8D9 swPA== X-Forwarded-Encrypted: i=1; AJvYcCX2T1jk0sz7dBYbyKjcfsTVWD1KnQE178v8RicEk/1pYoT/+V7UzS1wfvWKlEmnH34qdp4Lt/m3au6husQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6PgrYIWV9HZA+f5tIEJZeyKiOGeaxGoZ2NymThcIqxk89R3BK ZWe1G9CMpKasvsE2VNjGJnm4xeamFzzO85RJSgM3lpD5OGN1zEl6Mya01X9/v+v/kZb1M+5jT1u 70QN7OzTmpFBd/ZFyqvVaKMQmcJRfIHrdCE7vnyS33Jjouse1CUbAGPV2gC6kx69PkPQ= X-Gm-Gg: AY/fxX4BLlX4nqWSggoKQUepltdbbw+s9rsgv61OqtzqMTmYTazI6soyhK9+Xukj4bF eQLknXR3SkoT4JY4MBkintgtRnMG8+vvIDcMTuWGnQJnz8d+vMVmIkhCsLBkmalO0ZC2ixfZfmC 1n/Cv+G89hvTqlhBBiZX1Pve5WL8RdKBBeqdpbq3PBY+NgCohKWfzFMbrqzHnl3u03Qm2bdxEIP wcdOskfPyvqGhiEra4Wsdjuk0c84RKC8vAMhqBcf3r2xecz3f6akGnCuoBgGdkupWollzOkbeaS wDzyBxGiPX791+Mh24kLZ/kPCyq+c+JBHzaf1pDlEKweH+KguockpEJD4wI0fMJHxyGc71zWC+L oz0+9yWCqgUkkftKwN0ZUUYYuUQTEDHWg99CxDxtpB4o= X-Received: by 2002:a17:903:37c3:b0:29f:2734:6ffb with SMTP id d9443c01a7336-2a3ee434de2mr165519515ad.22.1768244515347; Mon, 12 Jan 2026 11:01:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGwEXg2WbEK0kcjSo9QlXVzcQp789a1loIB7VqV7j6g3wpJFM++BTLFba+1EthzjPpfOZoS3Q== X-Received: by 2002:a17:903:37c3:b0:29f:2734:6ffb with SMTP id d9443c01a7336-2a3ee434de2mr165519135ad.22.1768244514744; Mon, 12 Jan 2026 11:01:54 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3cc8888sm180120595ad.76.2026.01.12.11.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 11:01:54 -0800 (PST) From: Praveen Talari To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, bjorn.andersson@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, Praveen Talari Subject: [PATCH v1 2/4] spi: qcom-geni: Use geni_se_resources_init() for resource initialization Date: Tue, 13 Jan 2026 00:31:32 +0530 Message-Id: <20260112190134.1526646-3-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260112190134.1526646-1-praveen.talari@oss.qualcomm.com> References: <20260112190134.1526646-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEyMDE1NyBTYWx0ZWRfX18ukjPlLyaxy eKz7pdbJEKOP0B2p7+kgyeuSfGHVJkYaG55rr0yBxf4b1PIYc2cUikq0Hi0E/GM7EYHl6Ndjqe2 StZmasa3uTO0GbjECUb/I6GdDbHSAjLqY6/qFqh+sOzQOOSnzzkWVlNE77DTZAYgtpVhmqcTGb2 rKctARt6xeQm5MWqfbk8TgT3bRN9Ua9z3zlc5TNkbZVIQvWVK0jAnRPExLKw5YodlXTDf9PSq+f WBqrAS+UVYt8M0BfI47I0pt06OXxwCPlxhrj9PgPp8lMOemkB/yAo3HkPzgITzfmkxp+W5tJS17 Xp9Pv1oC2d5ujvnWESPOSLx2mJMyJV/0p2wNN0YARZ5nhjTjyGlWycLHBCroE1/PlIKBC6hpHpV SaQBkBXW9SjgW8XNi34pW2frhfZGFsDxMuYOiIdnWQ9OJQEDaAfPUt1B5gj6hm8/KFAvHJO2h38 GwsMo5+/WidmISq2vNA== X-Authority-Analysis: v=2.4 cv=TcCbdBQh c=1 sm=1 tr=0 ts=69654524 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=COk6AnOGAAAA:8 a=TXo2QnZ9t29hVJcr6pMA:9 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: q12V2I2K3LOtVUXhXNXOVMmoqA8IhfZu X-Proofpoint-ORIG-GUID: q12V2I2K3LOtVUXhXNXOVMmoqA8IhfZu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-12_05,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601120157 Content-Type: text/plain; charset="utf-8" From: Praveen Talari Replace resources initialization such as clocks, ICC path and OPP with the common geni_se_resources_init() function to avoid code duplication across all drivers. The geni_se_resources_init() function handles all these resources internally, reducing code duplication and ensuring consistent resource management across GENI SE drivers. Signed-off-by: Praveen Talari --- drivers/spi/spi-geni-qcom.c | 26 +------------------------- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index 5cca356cb673..7d047ae9c874 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -1014,7 +1014,6 @@ static int spi_geni_probe(struct platform_device *pde= v) struct spi_controller *spi; struct spi_geni_master *mas; void __iomem *base; - struct clk *clk; struct device *dev =3D &pdev->dev; =20 irq =3D platform_get_irq(pdev, 0); @@ -1029,10 +1028,6 @@ static int spi_geni_probe(struct platform_device *pd= ev) if (IS_ERR(base)) return PTR_ERR(base); =20 - clk =3D devm_clk_get(dev, "se"); - if (IS_ERR(clk)) - return PTR_ERR(clk); - spi =3D devm_spi_alloc_host(dev, sizeof(*mas)); if (!spi) return -ENOMEM; @@ -1044,17 +1039,10 @@ static int spi_geni_probe(struct platform_device *p= dev) mas->se.dev =3D dev; mas->se.wrapper =3D dev_get_drvdata(dev->parent); mas->se.base =3D base; - mas->se.clk =3D clk; =20 - ret =3D devm_pm_opp_set_clkname(&pdev->dev, "se"); + ret =3D geni_se_resources_init(&mas->se); if (ret) return ret; - /* OPP table is optional */ - ret =3D devm_pm_opp_of_add_table(&pdev->dev); - if (ret && ret !=3D -ENODEV) { - dev_err(&pdev->dev, "invalid OPP table in device tree\n"); - return ret; - } =20 spi->bus_num =3D -1; spi->dev.of_node =3D dev->of_node; @@ -1078,10 +1066,6 @@ static int spi_geni_probe(struct platform_device *pd= ev) init_completion(&mas->rx_reset_done); spin_lock_init(&mas->lock); =20 - ret =3D geni_icc_get(&mas->se, NULL); - if (ret) - return ret; - pm_runtime_use_autosuspend(&pdev->dev); pm_runtime_set_autosuspend_delay(&pdev->dev, 250); ret =3D devm_pm_runtime_enable(dev); @@ -1091,14 +1075,6 @@ static int spi_geni_probe(struct platform_device *pd= ev) if (device_property_read_bool(&pdev->dev, "spi-slave")) spi->target =3D true; =20 - /* Set the bus quota to a reasonable value for register access */ - mas->se.icc_paths[GENI_TO_CORE].avg_bw =3D Bps_to_icc(CORE_2X_50_MHZ); - mas->se.icc_paths[CPU_TO_GENI].avg_bw =3D GENI_DEFAULT_BW; - - ret =3D geni_icc_set_bw(&mas->se); - if (ret) - return ret; - ret =3D spi_geni_init(mas); if (ret) return ret; --=20 2.34.1