From nobody Sat Feb 7 18:51:49 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0A8137F741 for ; Mon, 12 Jan 2026 17:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768239778; cv=none; b=jWKNl81O4jPW6Yax9BI8FFeyFKkZVACSUPmjl6IUUOB0b+KJficizGbQ/m43hnGwBbV8LwU2WVkT+9P31K+YOjwGMvnTSqsA45IKALWWL9SbkGCMWrLraxX+TPiJaKrMk228txCp5alJuR+pCImvwuPSvV//s1vr3JcYXQ96oaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768239778; c=relaxed/simple; bh=CQnOPZYgxeNxaXVrR23UF6dE33CIyoJknaCvKC5jtfc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hyvF3GFVNkvdhOIvbaK2qT/178basjZhkYCRlkz0s9P7uSUcSiUYyTHcOL05zwa239MmzfLVv8604K45KpClWsNYcBJn8qMRvL5hA46QJF1tyaVFcXxiHRfmRihP8baVqrOe3i0xfbvtmCSLpqLbMQbvT/r4Dd+YJJFqDC9TO0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S8zfkbd/; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S8zfkbd/" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-430fbb6012bso5404114f8f.1 for ; Mon, 12 Jan 2026 09:42:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768239773; x=1768844573; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P4U7ahMZkTVYOTJmtKsNu+JXI6NaqQN0SF98Zi2bPS8=; b=S8zfkbd/FfZ0wpSb8sRbNqIS/mlipKrYaIHvXPXKl6LiIONUIQsbyYR6AyvMY1jl/f eYGlAAI6A4xYK5wptadKIyxnZGXCZ1Ho/pj4FsUmLvI1u8U9qK9vgnXSGcZR+jiqppwh M2R1SPYHGWmRvQ79QRJbPPLcEw1YnbBRdaVepwfIaMcoSpLjCmRskllQLZM3Icjflj5P dUNq+GFlAXN0cVrJDeDB9YsoTHt9Mv9fRZVwPp3Grj/MVuuyubZtTuaiHbhsqUDokQXu XBAWw4mjqiYcUsjvx6mcacO9YgFqIr+UDmdW6xfEtqn2IhQUya2j+nt2DhTUXo68XCs/ e2SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768239773; x=1768844573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=P4U7ahMZkTVYOTJmtKsNu+JXI6NaqQN0SF98Zi2bPS8=; b=GTUoATdSvGJwISN8OzEPpryFnZCEuwB9nRvKmLXA7KrDOd7o1VY2OhhhQHgaN2e6Kb oCIsYv+dQhhMZ9w1Ye10pdmyF66j5iX6qzk8itOraBx5uyc23Z2njH6boye0T/swm12l Hd3mu44IhquG8gBKJx4Fh5B/lokmVrbCZQyTcja53YupudnUTWusc2nHYTLvzsu+AnZv BvtTjRwd5ch152AnrCTFRY/dOvP7THdBIRsKoxEy9/OnuPaRWUupOyBzE0xNgKD5BraW m/9icmFgaSUFKSHEx4cT3yYBw7ZjVR6Uiqhwz6MOgpFeuOET6vADTsQdrzgTkz8hH9XD NThg== X-Forwarded-Encrypted: i=1; AJvYcCWmj4VbVILPlAj/9BgJ4NI3yZ1P9F574Hv7JT3XsdMvohfH2hPmUGk2Q4cgtcmipAGwaxAtUpsZlTLzyN8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc10Co03d8VrJN5wSlJj8HZeZxXygws1Qp87YQBjEzUrHatrKn jhwotCYPrhTRf339f2TfR6rz3l7bouEt9QC/fIWgsSyjrjLi9CpvVRGmHf6dFvd1 X-Gm-Gg: AY/fxX50MVg4w9EAxBGCqG6zPoCJOLfrt/QhSJ35OLONk0DscB3Qk/NDdOKL48sJIFd ixIYXZxoYC7MR6/NisEozNFxmueNQOXq2y8zm3hm5/AR7cngi1iQxrVg2pDQe+iu9pIJPF2vfnP 5wcRBV3JMWoa+ePuI8yXSJP90zPMljqKceum0pJaHqRONmRaQrFPJJeMhN43lMHnwCA++YoY8gp gls4b37ukH2jmp8+d4pbHtAdl25hIYZeSRwrbcU5kMiAiBKPMNAQKPz+Rr4dLDMlg7iyfQRzcG0 zjzP3tLkBPSEFGDO5H1WZBrya4o0dndVkZstVKN3Ryzv3MYY2ujhKXWQC3XDnFYBXV9wMoWa9Jm OpchTxAuDBBMo2JK0VRVTA0WRH/Wu+r/d36xojCLDV+OzUfiFxiTzapJE0srIusqXs8F82NByDc xoXMGP/72vxiryIXD3Rod9qTnkxVfWoupjkvkcgoA= X-Google-Smtp-Source: AGHT+IFWIvqiIBM4zMFzmf4FfMnuelp81OKLXDRTcRxGMFTfyz9z28XdlOLe4Aoxdy8Aw+TUJDgrZQ== X-Received: by 2002:adf:fe8f:0:b0:430:f97a:6f43 with SMTP id ffacd0b85a97d-432c379f3c9mr19910375f8f.53.1768239773012; Mon, 12 Jan 2026 09:42:53 -0800 (PST) Received: from localhost.localdomain ([2400:adc1:447:6d00:1c1a:7818:23f6:aae1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dacd1sm39090716f8f.4.2026.01.12.09.42.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 09:42:52 -0800 (PST) From: Mahad Ibrahim To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, mahad.ibrahim.dev@gmail.com Subject: [PATCH 08/10] staging: rtl8723bs: Fix style and alignment issues in HalHWImg8723B_RF.c Date: Mon, 12 Jan 2026 22:42:25 +0500 Message-ID: <20260112174227.14922-9-mahad.ibrahim.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260112174227.14922-1-mahad.ibrahim.dev@gmail.com> References: <20260112174227.14922-1-mahad.ibrahim.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix multiple coding style issues to silence checkpatch.pl warnings. - Move the first part of the conditional logic in 'if' statements to the same line as the opening parenthesis. This fixes the checkpatch warning: "Lines should not end with a '('". - Fix the alignment of function arguments and long variable assignments. Use spaces to align subsequent lines with the opening parenthesis, adhering to the kernel coding style guidelines. - Remove hanging parentheses to improve readability. Signed-off-by: Mahad Ibrahim --- .../staging/rtl8723bs/hal/HalHWImg8723B_RF.c | 97 +++++++------------ 1 file changed, 36 insertions(+), 61 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c b/drivers/sta= ging/rtl8723bs/hal/HalHWImg8723B_RF.c index 0c7d0307b822..22be62ad8e0e 100644 --- a/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c +++ b/drivers/staging/rtl8723bs/hal/HalHWImg8723B_RF.c @@ -8,9 +8,7 @@ #include #include "odm_precomp.h" =20 -static bool CheckPositive( - struct dm_odm_t *pDM_Odm, const u32 Condition1, const u32 Condition2 -) +static bool CheckPositive(struct dm_odm_t *pDM_Odm, const u32 Condition1, = const u32 Condition2) { u8 _BoardType =3D ((pDM_Odm->BoardType & BIT4) >> 4) << 0 | /* _GLNA */ @@ -36,16 +34,12 @@ static bool CheckPositive( /* Value Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ /* QFN Type [15:12] and Cut Version [27:24] need to do value check */ =20 - if ( - ((cond1 & 0x0000F000) !=3D 0) && - ((cond1 & 0x0000F000) !=3D (driver1 & 0x0000F000)) - ) + if (((cond1 & 0x0000F000) !=3D 0) && + ((cond1 & 0x0000F000) !=3D (driver1 & 0x0000F000))) return false; =20 - if ( - ((cond1 & 0x0F000000) !=3D 0) && - ((cond1 & 0x0F000000) !=3D (driver1 & 0x0F000000)) - ) + if (((cond1 & 0x0F000000) !=3D 0) && + ((cond1 & 0x0F000000) !=3D (driver1 & 0x0F000000))) return false; =20 /* Bit Defined Check =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ @@ -311,47 +305,30 @@ void ODM_ReadAndConfig_MP_8723B_TxPowerTrack_SDIO(str= uct dm_odm_t *pDM_Odm) struct odm_rf_cal_t *pRFCalibrateInfo =3D &pDM_Odm->RFCalibrateInfo; =20 =20 - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GA_P, - gDeltaSwingTableIdx_MP_2GA_P_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GA_N, - gDeltaSwingTableIdx_MP_2GA_N_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GB_P, - gDeltaSwingTableIdx_MP_2GB_P_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GB_N, - gDeltaSwingTableIdx_MP_2GB_N_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); - - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_P, - gDeltaSwingTableIdx_MP_2GCCKA_P_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_N, - gDeltaSwingTableIdx_MP_2GCCKA_N_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKB_P, - gDeltaSwingTableIdx_MP_2GCCKB_P_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); - memcpy( - pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKB_N, - gDeltaSwingTableIdx_MP_2GCCKB_N_TxPowerTrack_SDIO_8723B, - DELTA_SWINGIDX_SIZE - ); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GA_P, + gDeltaSwingTableIdx_MP_2GA_P_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GA_N, + gDeltaSwingTableIdx_MP_2GA_N_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GB_P, + gDeltaSwingTableIdx_MP_2GB_P_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GB_N, + gDeltaSwingTableIdx_MP_2GB_N_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_P, + gDeltaSwingTableIdx_MP_2GCCKA_P_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKA_N, + gDeltaSwingTableIdx_MP_2GCCKA_N_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKB_P, + gDeltaSwingTableIdx_MP_2GCCKB_P_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); + memcpy(pRFCalibrateInfo->DeltaSwingTableIdx_2GCCKB_N, + gDeltaSwingTableIdx_MP_2GCCKB_N_TxPowerTrack_SDIO_8723B, + DELTA_SWINGIDX_SIZE); } =20 /*************************************************************************= ***** @@ -542,14 +519,12 @@ void ODM_ReadAndConfig_MP_8723B_TXPWR_LMT(struct dm_o= dm_t *pDM_Odm) u8 *chnl =3D Array[i+4]; u8 *val =3D Array[i+5]; =20 - odm_ConfigBB_TXPWR_LMT_8723B( - pDM_Odm, - regulation, - bandwidth, - rate, - rfPath, - chnl, - val - ); + odm_ConfigBB_TXPWR_LMT_8723B(pDM_Odm, + regulation, + bandwidth, + rate, + rfPath, + chnl, + val); } } --=20 2.47.3