From nobody Sat Feb 7 13:41:43 2026 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8EF4378D8D for ; Mon, 12 Jan 2026 17:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768237495; cv=none; b=smNqwq+bpu0Pi9w916fUwbD4zIxWfshb7uo8+/3mDUBKz8IxpyNM1oY+oxlg8oTQFfvX6DNqno63wpy5FqwfOE/K/R+3cJRBRUjjoLMAjMera0cOWhLRlhxH1p/WCyRvHFPJ1K4NsvpwroGoT4vtvjg6P0084OO3cvASwgU70j0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768237495; c=relaxed/simple; bh=PSODpUAswlIac0Cz2UXm4iCjS0hhRMof1atbvQalbhk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Rzi5c7DJbUH489jADwFJQxJ1NxsJVVnyGPw7NrhsHHyLPPb+CkoEsDXWkFFkVR5Ejs8yD0PcL/KLlxlP6NxPcI4axqwNEcLaUHe/Lty1N9+0QTJO/Ft6v4Gs1oqw9pNKauO7PfxmXHsoCtUI8QjRL+KkHBeMhrRzE5qP2eEZUsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Q2wS8JYF; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Q2wS8JYF" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768237491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=g1TniHRbfd2bwPXGfXb5xEPMCBPMS+sg9L8CypJ8iH8=; b=Q2wS8JYFCBAFkM39RowL4YyslHWXkOpu9IDwzfFYnY6zyKPyMaM1pNqiselmmAQCY6/c5C SGKN44GJyi3fqZyCLKP3sp9rYJ3gSpzjVKRpjQd4gV9pxkVE26o5tnhH6Nq6m1/YJBYvkv rx7a7Y4Q5WYI1QGIsuTo81uyLQFpofE= From: Thorsten Blum To: Philipp Reisner , Lars Ellenberg , =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , Jens Axboe Cc: Thorsten Blum , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drbd: Replace deprecated strcpy with strscpy Date: Mon, 12 Jan 2026 18:04:12 +0100 Message-ID: <20260112170412.741013-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" strcpy() has been deprecated [1] because it performs no bounds checking on the destination buffer, which can lead to buffer overflows. Replace it with the safer strscpy(). No functional changes. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy= [1] Signed-off-by: Thorsten Blum --- drivers/block/drbd/drbd_main.c | 14 +++++++++----- drivers/block/drbd/drbd_receiver.c | 4 ++-- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c index c73376886e7a..8cb5d5ba9a3d 100644 --- a/drivers/block/drbd/drbd_main.c +++ b/drivers/block/drbd/drbd_main.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -732,9 +733,9 @@ int drbd_send_sync_param(struct drbd_peer_device *peer_= device) } =20 if (apv >=3D 88) - strcpy(p->verify_alg, nc->verify_alg); + strscpy(p->verify_alg, nc->verify_alg); if (apv >=3D 89) - strcpy(p->csums_alg, nc->csums_alg); + strscpy(p->csums_alg, nc->csums_alg); rcu_read_unlock(); =20 return drbd_send_command(peer_device, sock, cmd, size, NULL, 0); @@ -745,6 +746,7 @@ int __drbd_send_protocol(struct drbd_connection *connec= tion, enum drbd_packet cm struct drbd_socket *sock; struct p_protocol *p; struct net_conf *nc; + size_t integrity_alg_len; int size, cf; =20 sock =3D &connection->data; @@ -762,8 +764,10 @@ int __drbd_send_protocol(struct drbd_connection *conne= ction, enum drbd_packet cm } =20 size =3D sizeof(*p); - if (connection->agreed_pro_version >=3D 87) - size +=3D strlen(nc->integrity_alg) + 1; + if (connection->agreed_pro_version >=3D 87) { + integrity_alg_len =3D strlen(nc->integrity_alg) + 1; + size +=3D integrity_alg_len; + } =20 p->protocol =3D cpu_to_be32(nc->wire_protocol); p->after_sb_0p =3D cpu_to_be32(nc->after_sb_0p); @@ -778,7 +782,7 @@ int __drbd_send_protocol(struct drbd_connection *connec= tion, enum drbd_packet cm p->conn_flags =3D cpu_to_be32(cf); =20 if (connection->agreed_pro_version >=3D 87) - strcpy(p->integrity_alg, nc->integrity_alg); + strscpy(p->integrity_alg, nc->integrity_alg, integrity_alg_len); rcu_read_unlock(); =20 return __conn_send_command(connection, sock, cmd, size, NULL, 0); diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_r= eceiver.c index 3de919b6f0e1..3d0a061b6c40 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -3801,14 +3801,14 @@ static int receive_SyncParam(struct drbd_connection= *connection, struct packet_i *new_net_conf =3D *old_net_conf; =20 if (verify_tfm) { - strcpy(new_net_conf->verify_alg, p->verify_alg); + strscpy(new_net_conf->verify_alg, p->verify_alg); new_net_conf->verify_alg_len =3D strlen(p->verify_alg) + 1; crypto_free_shash(peer_device->connection->verify_tfm); peer_device->connection->verify_tfm =3D verify_tfm; drbd_info(device, "using verify-alg: \"%s\"\n", p->verify_alg); } if (csums_tfm) { - strcpy(new_net_conf->csums_alg, p->csums_alg); + strscpy(new_net_conf->csums_alg, p->csums_alg); new_net_conf->csums_alg_len =3D strlen(p->csums_alg) + 1; crypto_free_shash(peer_device->connection->csums_tfm); peer_device->connection->csums_tfm =3D csums_tfm; --=20 Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4