From nobody Sun Feb 8 21:46:32 2026 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914C22E03E3 for ; Mon, 12 Jan 2026 14:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768229981; cv=none; b=VCZ6etbEKVtlzLd6gebULfiqUtAX+oQOrxnrEp2SY45VqAFW7nVhOhfce0yAmAiz9K9I/lH0itNb5RTSWuEGd1u+VvWtxWtrX3gjxVtwZYH4qhPNUMvJdjF4fsH69QsCdnzvdjcG8oiflwRUAMIHcu+KjgxASgcCvVGrBaVPId0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768229981; c=relaxed/simple; bh=fw3T6G9VgD08D+eTmDQTDZhpWeH/Grb134iPYg3VsZk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VpnXzUIR/xuEDM3UxTUYO2Y0FKCs5AO3x6d7wzO8sm0xhcOMEkZkJe7VVoWnJdVQJiU4vn1BtCRkrhBS4p6qEAyTijTLKAyxYUYdeHB1Ne9RLWirPTLrXxVFHUVf2LotPu2K8/kKTqMS/dzQ6qwCAj5r0gv62QizTb0OdR8rKtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iBxjoDSA; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iBxjoDSA" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1768229977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WmcUogJQ7fcHKXe6kkOKsVPYN+oinZgv3uN1gDoQI10=; b=iBxjoDSAW+btQN4SHES8oKHE5Z18P/+D/U2gR7cJ+McdPMB7qH6DUH1CFGMAb+wSm5+HPk 75bcI9Y22UdbFwBQ+oWAGvofo6vRuwDUeVEDp50+reLs9bELcUWGSnVpvWvHit2o0Uzufz GqOQc+9VBB94kGhCm5OA2Pql/dJ5dxg= From: Leon Hwang To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Christian Brauner , Seth Forshee , Yuichiro Tsuji , Andrey Albershteyn , Leon Hwang , Willem de Bruijn , Jason Xing , Tao Chen , Mykyta Yatsenko , Kumar Kartikeya Dwivedi , Anton Protopopov , Amery Hung , Rong Tao , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-patches-bot@fb.com Subject: [PATCH bpf-next v5 8/9] libbpf: Add common attr support for map_create Date: Mon, 12 Jan 2026 22:56:15 +0800 Message-ID: <20260112145616.44195-9-leon.hwang@linux.dev> In-Reply-To: <20260112145616.44195-1-leon.hwang@linux.dev> References: <20260112145616.44195-1-leon.hwang@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" With the previous commit adding common attribute support for BPF_MAP_CREATE, users can now retrieve detailed error messages when map creation fails via the log_buf field. Introduce struct bpf_syscall_common_attr_opts with the following fields: log_buf, log_size, log_level, and log_true_size. Extend bpf_map_create_opts with a new field common_attr_opts, allowing users to capture and inspect log messages on map creation failures. Signed-off-by: Leon Hwang --- tools/lib/bpf/bpf.c | 15 ++++++++++++++- tools/lib/bpf/bpf.h | 17 ++++++++++++++++- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c index d44e667aaf02..d65df1b7b2be 100644 --- a/tools/lib/bpf/bpf.c +++ b/tools/lib/bpf/bpf.c @@ -207,6 +207,9 @@ int bpf_map_create(enum bpf_map_type map_type, const struct bpf_map_create_opts *opts) { const size_t attr_sz =3D offsetofend(union bpf_attr, excl_prog_hash_size); + const size_t common_attr_sz =3D sizeof(struct bpf_common_attr); + struct bpf_syscall_common_attr_opts *common_attr_opts; + struct bpf_common_attr common_attr; union bpf_attr attr; int fd; =20 @@ -240,7 +243,17 @@ int bpf_map_create(enum bpf_map_type map_type, attr.excl_prog_hash =3D ptr_to_u64(OPTS_GET(opts, excl_prog_hash, NULL)); attr.excl_prog_hash_size =3D OPTS_GET(opts, excl_prog_hash_size, 0); =20 - fd =3D sys_bpf_fd(BPF_MAP_CREATE, &attr, attr_sz); + common_attr_opts =3D OPTS_GET(opts, common_attr_opts, NULL); + if (common_attr_opts && feat_supported(NULL, FEAT_EXTENDED_SYSCALL)) { + memset(&common_attr, 0, common_attr_sz); + common_attr.log_buf =3D ptr_to_u64(OPTS_GET(common_attr_opts, log_buf, N= ULL)); + common_attr.log_size =3D OPTS_GET(common_attr_opts, log_size, 0); + common_attr.log_level =3D OPTS_GET(common_attr_opts, log_level, 0); + fd =3D sys_bpf_ext_fd(BPF_MAP_CREATE, &attr, attr_sz, &common_attr, comm= on_attr_sz); + OPTS_SET(common_attr_opts, log_true_size, common_attr.log_true_size); + } else { + fd =3D sys_bpf_fd(BPF_MAP_CREATE, &attr, attr_sz); + } return libbpf_err_errno(fd); } =20 diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h index 2c8e88ddb674..c4a26e6b71ea 100644 --- a/tools/lib/bpf/bpf.h +++ b/tools/lib/bpf/bpf.h @@ -37,6 +37,18 @@ extern "C" { =20 LIBBPF_API int libbpf_set_memlock_rlim(size_t memlock_bytes); =20 +struct bpf_syscall_common_attr_opts { + size_t sz; /* size of this struct for forward/backward compatibility */ + + char *log_buf; + __u32 log_size; + __u32 log_level; + __u32 log_true_size; + + size_t :0; +}; +#define bpf_syscall_common_attr_opts__last_field log_true_size + struct bpf_map_create_opts { size_t sz; /* size of this struct for forward/backward compatibility */ =20 @@ -57,9 +69,12 @@ struct bpf_map_create_opts { =20 const void *excl_prog_hash; __u32 excl_prog_hash_size; + + struct bpf_syscall_common_attr_opts *common_attr_opts; + size_t :0; }; -#define bpf_map_create_opts__last_field excl_prog_hash_size +#define bpf_map_create_opts__last_field common_attr_opts =20 LIBBPF_API int bpf_map_create(enum bpf_map_type map_type, const char *map_name, --=20 2.52.0