From nobody Tue Feb 10 05:44:36 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73903347BB4 for ; Mon, 12 Jan 2026 10:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768214883; cv=none; b=DpZ3Nilkl9/UWKaReZauGKGf8w3IV3IjpxrhwLMiwsX3ofA3sP6AWKaj2mIlAaab7FNoYrH0uo3NEY7GWmIAq0k9iey2CYnm9rDgUvheppgH37pGd3YgR3sO/rd+6kNs2ElLH+dItqMPf+gUptB33dbJoIZ60MBqVseBKq2FAYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768214883; c=relaxed/simple; bh=68XYG3tdqPOqD6BAG89rFRpLL4RPlGdjOEPrTt97jYI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eBId0Zix2GVeiobh0/R/4YCCnNuYxTUvKibdTR0c8xPcwEO88Y9qnfH/3CrfbEMQ5/oFXB+sDnJrUhGiZrzmkffBb3JqvmI17a7C4MOp5hs7EHoX7R01fFio0V8xrsDkO8kLfYkVBpCBsUJuY9Eow9Is0Kw1fxJzeyaM92sKYlg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D+DhQx4T; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D8U+nqqT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D+DhQx4T"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D8U+nqqT" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60CA70Ej1381714 for ; Mon, 12 Jan 2026 10:48:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tiqRW3gaC++ bZCm4/OwS1b+DcRa9wG6BSji9LqUF26A=; b=D+DhQx4Tpdqc5iDtaKwciPT20P9 3+waspf+fYZTa8ZnRH167/s1bN0eopVcCmbA4FriIC0NwOvWfsO0XnSApYHfFZBb aan0Nc0HVPX6ibUbqDSpYcLlZRCVstFr7CJqJRztIExG5YGBDs5mikBz6YieCKF1 2InMgBaeeayql32QqeA9X3+u/LUOSyO2PPGopP5id+RZsnAVvu/i0eoWLo62zW+E FagV1pi3Z9KARB9a4uNYHz5Aqn2VLNwzQ/fPNAnIpD/0RcrSrZLzXXeGx32G+0Dc xvAhaui+QDK9L5HI0emjdMjrk3CWQdXd7yrjJT1ysNCk/jcouS5YOKm98Xw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bmxwv038d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Jan 2026 10:48:00 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81f46844106so956220b3a.0 for ; Mon, 12 Jan 2026 02:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768214879; x=1768819679; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tiqRW3gaC++bZCm4/OwS1b+DcRa9wG6BSji9LqUF26A=; b=D8U+nqqT7w38d9BQ3pL8fTdeBhJUvild3Y2H4Tzei/VzIlpTuT6JaVChEGuYkZn6O5 2hmB9hFlm0UT+bfMySPYR2NcWa4zYo2c/wcpcSA8mhBPZxcVKb9UYCIJ5jOozH8OGVm6 gOkzzrkJc+bEB1TaWdHMAWuCRpL1ZZ5az+PfzJlOY4sQTkyrlis7B8SW50dKdbyG20Xz WTBG17195FoQFB09oKu6piI9GwBmt/f86Co/ZzJeU6d6PK6rconGuWsjKnISdmQxr5a3 JyR9zx7ANOJwQXn43GjyhGgz4JShCOLwEFAKNg6SsyvHBwqxADZUe1nqy+zrGlODh5+p 7Ptg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768214879; x=1768819679; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tiqRW3gaC++bZCm4/OwS1b+DcRa9wG6BSji9LqUF26A=; b=cAm1fiXil2z1BdtGIS6Kqp1iVrJm0N5NoKiRLRNiVukg1MkwHTI3s3U+L7NGX8NlR9 LnAOi3t0SrsBLQvAmIaitEMmvmpTjc/PsyVuWJtPEPO5myQVXF4ecRfZCdzjUxmuvhMb IodFWfQFYTgt0vLdo+E8xTWHpWwWyJBNQzZpqqf4QtgAYCU3MW5BQiN5tNYWZcKom5y2 QGDpkZ/Lvh9ht32IzidrrBsQLNF8Dybx7lrrjYHvjpa34Eh5lj4NbXubjH/HFawlf51o QqCjwgBmEtea7++q2B5tL6sud6rxRfKEWzU1/oMGx9lUQPH7W4nMVGIgBXzXdMoFyXnU WiZw== X-Forwarded-Encrypted: i=1; AJvYcCXwJJWSHRSzyMCYvNJHpC8G157LNiHJCj+Aoix1xtIvoTOuGG6w8jxQ4Q8LEhqVohdnqF0cKjiiSdz2CkU=@vger.kernel.org X-Gm-Message-State: AOJu0YwbVK7f0aGLJhlWoMl8pZnGLZT6qrNKW7m9HLJygGIvIA2slMwx ag+LmsgLVcGFiZSg5Z7cZI/WwzYYo9UTeGzutbKH6zUuWb4+/QdbIBLMUc/jyDZWabM3J+I0oBs NxxUFvlGFZWPCHwfrhjBqx0eWiUU7dM3Nk3MZO4yQcAOup3AUwxrVb2TF5OhF4dtACMU= X-Gm-Gg: AY/fxX6iec+OrLO4GsoA1Tod/nS1TiVqsyHXKNRAXiykSEgowCOPzaxgQI+6DXuhr28 TEAAW0VyNlF5ReV/75WC6FrAyrzlicnm59hqTvEhmXf2DaMF7/doiH6+0FQwJU5vqyAKVaUewzD y48YEUBlVkGj82D7gvW4ylUdIVOzpUoxVNfFjtEXnffMdGozjOgu0+UKE4VzGA3r7MwpwlreE3D 2klZq9neXxaSNA9253oBBQDYL8Mqm0cAiLVRprI9zAfRB63AH+bnTAigROO4OYbzKifkLx5E3c2 7OlRzJnC7C2kQfGJTpUc1UVfj3CP/iyGKV02m/UK2L7O/esBAUan4Q+WamXFl5ls7H2cegrdlsN 2tUa3Crv5BVYa9ml7/3OfffOI+nGHAY0HKuCKUcqExaA= X-Received: by 2002:a05:6a00:a247:b0:81f:4e1c:1d3b with SMTP id d2e1a72fcca58-81f4e1c2365mr3003751b3a.23.1768214879265; Mon, 12 Jan 2026 02:47:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZWAF21brn4EKDzeFUSrcgyjyM55X9jg6ATGNFL66fTuuXf8Zunil1Grf+5WcgDdXS4uVwGw== X-Received: by 2002:a05:6a00:a247:b0:81f:4e1c:1d3b with SMTP id d2e1a72fcca58-81f4e1c2365mr3003728b3a.23.1768214878674; Mon, 12 Jan 2026 02:47:58 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819bafe9b8dsm17288681b3a.22.2026.01.12.02.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 02:47:58 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com Subject: [PATCH v3 04/12] soc: qcom: geni-se: Add resources activation/deactivation helpers Date: Mon, 12 Jan 2026 16:17:14 +0530 Message-Id: <20260112104722.591521-5-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> References: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 7qk3p39m8YNqsCyTaNLFSwG5O91lw0CV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEyMDA4NSBTYWx0ZWRfX+hfBrChagKcv vy/C3dcuEuBzgVZCYIBpdqzvrqMCvW89HE1c61kXVsPv2h0kGRKEVhWADLnrj8KBKN/Np4L1z1o sw+iuO+jGmN7HuiLnm3A85aeCel6nj48xTLVW870+lEb8R8Kto7S6AaO3ozGBTXLGgwi/XVc8Sg LNxpJ2sONvZuZwkQiIsE23h1N/jEq+gTJDYyPDaZ1fHrHrfdHZZXO8iUbq48N0sqi6DBPUmYWhx QN3MJIIA+mNPcQ8ZzNo0feEECU/TJshGoqqneFh3x7CxtS8vc6QlscAQgsRZ2WrLd1QVqZlTvQG Coqdx8VHD8HOA1zepuJ3b6zij8tJr3XlOPE1H5IkmDQoLmrwqCXs2rVkiDmSXK5N+eId/vMbOFt KRwZfdvigTREnnKxKwBjYWkHAUdOrxnipMeFG3//5YyndwA6odaoOe5y+KnmmCmcR7yGNdhkULT ebPNaN6TPBxobMDWfrw== X-Proofpoint-ORIG-GUID: 7qk3p39m8YNqsCyTaNLFSwG5O91lw0CV X-Authority-Analysis: v=2.4 cv=C/XkCAP+ c=1 sm=1 tr=0 ts=6964d160 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=KBRiQYpxJDLEvAb9SdYA:9 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-12_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601120085 Content-Type: text/plain; charset="utf-8" The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource activation/deactivation sequences independently, leading to code duplication. Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to power on/off resources.The activate function enables ICC, clocks, and TLMM whereas the deactivate function disables resources in reverse order including OPP rate reset, clocks, ICC and TLMM. Signed-off-by: Praveen Talari --- v2 -> v3 - Added export symbol for new APIs. v1 -> v2 Bjorn - Updated commit message based code changes. - Removed geni_se_resource_state() API. - Utilized code snippet from geni_se_resources_off() --- drivers/soc/qcom/qcom-geni-se.c | 79 ++++++++++++++++++++++++++++++++ include/linux/soc/qcom/geni-se.h | 4 ++ 2 files changed, 83 insertions(+) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index 75e722cd1a94..3341bc98df09 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -1013,6 +1013,85 @@ int geni_icc_disable(struct geni_se *se) } EXPORT_SYMBOL_GPL(geni_icc_disable); =20 +/** + * geni_se_resources_deactivate() - Deactivate GENI SE device resources + * @se: Pointer to the geni_se structure + * + * Deactivates device resources for power saving: OPP rate to 0, pin contr= ol + * to sleep state, turns off clocks, and disables interconnect. Skips ACPI= devices. + * + * Return: 0 on success, negative error code on failure + */ +int geni_se_resources_deactivate(struct geni_se *se) +{ + int ret; + + if (has_acpi_companion(se->dev)) + return 0; + + if (se->has_opp) + dev_pm_opp_set_rate(se->dev, 0); + + ret =3D pinctrl_pm_select_sleep_state(se->dev); + if (ret) + return ret; + + geni_se_clks_off(se); + + if (se->core_clk) + clk_disable_unprepare(se->core_clk); + + return geni_icc_disable(se); +} +EXPORT_SYMBOL_GPL(geni_se_resources_deactivate); + +/** + * geni_se_resources_activate() - Activate GENI SE device resources + * @se: Pointer to the geni_se structure + * + * Activates device resources for operation: enables interconnect, prepare= s clocks, + * and sets pin control to default state. Includes error cleanup. Skips AC= PI devices. + * + * Return: 0 on success, negative error code on failure + */ +int geni_se_resources_activate(struct geni_se *se) +{ + int ret; + + if (has_acpi_companion(se->dev)) + return 0; + + ret =3D geni_icc_enable(se); + if (ret) + return ret; + + if (se->core_clk) { + ret =3D clk_prepare_enable(se->core_clk); + if (ret) + goto out_icc_disable; + } + + ret =3D geni_se_clks_on(se); + if (ret) + goto out_clk_disable; + + ret =3D pinctrl_pm_select_default_state(se->dev); + if (ret) { + geni_se_clks_off(se); + goto out_clk_disable; + } + + return ret; + +out_clk_disable: + if (se->core_clk) + clk_disable_unprepare(se->core_clk); +out_icc_disable: + geni_icc_disable(se); + return ret; +} +EXPORT_SYMBOL_GPL(geni_se_resources_activate); + /** * geni_se_resources_init() - Initialize resources for a GENI SE device. * @se: Pointer to the geni_se structure representing the GENI SE device. diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni= -se.h index c182dd0f0bde..36a68149345c 100644 --- a/include/linux/soc/qcom/geni-se.h +++ b/include/linux/soc/qcom/geni-se.h @@ -541,6 +541,10 @@ int geni_icc_disable(struct geni_se *se); =20 int geni_se_resources_init(struct geni_se *se); =20 +int geni_se_resources_activate(struct geni_se *se); + +int geni_se_resources_deactivate(struct geni_se *se); + int geni_load_se_firmware(struct geni_se *se, enum geni_se_protocol_type p= rotocol); #endif #endif --=20 2.34.1