From nobody Tue Feb 10 08:27:30 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28DE828000C for ; Mon, 12 Jan 2026 10:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768214875; cv=none; b=S5+6owp8h7j2RWhuroomdWE6iJfpDGYtPL1vjX+lLDOjvDx2DPdkOMr3oH/RlYIEN9fn1U7wfvn+Tf3T6QIiBk19gENT8nqxSHyT6xgsIJLvll/svtBU05oqHEeUR+sTSzQHfMTAcjzaZ5uMWp9NDAMr38pfP0vuQkdiX6Y3Ggs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768214875; c=relaxed/simple; bh=aNFoPhCzK98jZhwkTUn8Ng4tLog3h9ErdlG5j8XEi8I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Fw9qtzqT/x/p7L1K1J4uLixZkPdviicyjgK+GuEVXuRhHFQlouzS3DZYkjQOVxHedlnsN1i7AAhgaNf8pCmhqoAD/ltrRq6S4GN4r44iQke94gjnBGpNQ61rMaFCYUuh+KrlnTz0NkDpSv7gU2rlVytbl0IZ4toif6RunBbcj38= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NQGJQWTQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZNqXn5Oc; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NQGJQWTQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZNqXn5Oc" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60CAEWZ61315820 for ; Mon, 12 Jan 2026 10:47:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=coMCstee7sz aR5m5p6HnyI6xCasetiM+wXF6qx7XZKc=; b=NQGJQWTQBE4KQu8sYmqBwFDbOTW lQNUQO6yqBr/YstNhJDU04xkhzgXqgtCnxsJc7TqMsbQiMkwO7PQCTuEPJQ8Vx72 /4hrCtsg5NNDn3rJRPXA/5TBKHj58rOVEcicSEZDO4X3rb3O3lFadVver2ezwwBO 0H/PCowSkinrEsVOSAAlAytlqsLk4jDpG7SIMQNMhHBwl6ppoiDBGyQ0jVyKT7lb 6z7NkhTcg0WPV5CPppKfR4Elgw3k1g99DiITaKqPoJtvt9o6SvdqYHdl2ZqoEN5L qJNuONWpdLiztQJgNQFQU0fVaEWnfI0RX+kzBpFC40+bDH4fmmSUf5Bkf4Q== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bmy1hg2sq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Jan 2026 10:47:53 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-81dd077ca65so2183172b3a.2 for ; Mon, 12 Jan 2026 02:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768214873; x=1768819673; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=coMCstee7szaR5m5p6HnyI6xCasetiM+wXF6qx7XZKc=; b=ZNqXn5Ocapz+i4C8g7Zqt3Aa+9lGnMw4E712hQ+WHZw7u6sH/3b4oW5ZQ8chj4OPHB 4erZZ631aCOF2689PlzoFi0131+pRQidJ/KPsC3dg8dLW4U+yY3IsmFKzq5dTour2Zya TozW/v09NLgmtDh/mKwhkKezejUcYej+dJvi0hnM7tF1iyrY2dAWDlrGrEZ7MrppHHdn KmX+dVOr+9Npj9e/1gQQe5BPcJjXjsPW9JYDfZh6FBiJ/ALel4t3Pf6g6DEQ7gM1fgRZ XX3HbbuiCvpiaNFKoElQmw+haEEuJHt3jxYmAgcq1J+9wN+BkcrifP0OWcqlunHRx/ZO ErfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768214873; x=1768819673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=coMCstee7szaR5m5p6HnyI6xCasetiM+wXF6qx7XZKc=; b=O7jTTtN0f2h0OXdjIgqyDWG9Py4mmRbC4Hms82TbgND/k5JyLXLhROA24OF0rxFkhV 6MfAcAC5s3bviCM/YywiMR3VV3KLtYcy4eBmbxu9jBvQ9bVxNfbqAyByheA7qUcZeA4v P8WSq3Z+iAv6roRQ9VOXg7Wf6b9VKEsvQ5nlRKQCv7WxdahcXQkcyr5wQNY2BOHiD/sa 0IkjpTkq7ON0Hj41OY3TjlIVxRWQbTww8vjBOoTFiLFQG4s+vK3b+oSQTCWm9z6ylLO1 sroeepsxgdBlPHn/PR3NYiEt00QI2ZQMHDZqf80WxHyO4wMKCAuAquuCbpcxw54E7B/d 9qdQ== X-Forwarded-Encrypted: i=1; AJvYcCW1l+4WFYTihiOklpvGX9wf7dSaGj47dlaS2X0WAE1nXcqqOi1a+ub2G2YiiSiDuY0jsUSQAeDp528kJtk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz43hcCsFS9pgYLhowlHTVywlnHQ8rRZf52JXrFO8Kj3zateb95 IU5YzMRnzLvAidXbimq1465peIeNjcrkea1gVLZhm/fh+Uh7dg3l+Nw7hR83FeRR71aebw1oU36 P+b+jgjlfLgA7aGTZ6rrlxZXaUqyLsa7h7FVCx7oEAfh6wI9GkmxxVZSBhZpgiCBOvf0= X-Gm-Gg: AY/fxX6chDDl9HpPY5uHq8JvoONgrgLl6qQTTrZNYG3lFCyq4P4JKxoa2MtognRD/we 3/1HJ6R2vrCgzhzLtZ/alTi1XhYVMWBy1YKhP53FHmHlLcJ5TGA0wtg99pZZZvABGQ/pXz9qQaN 262VOQ5EftiwrtNBJk0vaLtaiDDJRki97AzQpPoqkeNq2+XshqeKRBl/GpE9JehKlBKO1hBaMY+ tJlJcQzGjg0D61/IsMbRdMOVN+jazAS46G8RkGF6VjpP8ov7cF0jL28qmy6rW0B8dwdgzZK74yp HuLx7aM0PxmxS0Ww/NHshhXjk84juNEc8IVAWYQKvEtZqRkhQYrWZh6ctN2+DNFwe1jV+IdZFip Tel49l7bVo8gOUJrThWFGVjbIurZyj8dR1KvjgseQlqE= X-Received: by 2002:a05:6a00:3497:b0:81f:521c:b645 with SMTP id d2e1a72fcca58-81f521d04f4mr3579684b3a.51.1768214872776; Mon, 12 Jan 2026 02:47:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiZKUIz5YIpwAv4P7EKAra9UVtYRBVWXXWo6WhNlH8oQGUeKhjGYITgMfF7CTfdabqu4Xo4Q== X-Received: by 2002:a05:6a00:3497:b0:81f:521c:b645 with SMTP id d2e1a72fcca58-81f521d04f4mr3579657b3a.51.1768214872227; Mon, 12 Jan 2026 02:47:52 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819bafe9b8dsm17288681b3a.22.2026.01.12.02.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 02:47:51 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com Subject: [PATCH v3 03/12] soc: qcom: geni-se: Introduce helper API for resource initialization Date: Mon, 12 Jan 2026 16:17:13 +0530 Message-Id: <20260112104722.591521-4-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> References: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: bj9u5t_u-HGHc6bh7zf2GlVPdqUYApGk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEyMDA4NSBTYWx0ZWRfX0rDzNqPKpqTH 1KgOnEH9VZmy7M9Nq1KmTxMnIbM8PVKLgHayXxia8FCnL0hK1dVXen0ntvBOpxodqfevogTgvK2 Nss218noTwHtnf1wDXxy9Qr7tLM1Lg03zDgwJAuzeOuHY8vwaEaqedsk4G1YH8Kxll4k/rW/LH7 dwjpTIRMOWy47MAZNXKECdIwwa3NlgLtfgIfYI7rJR9oTNKlg1htbDBubdeJJWLrHRqFWaDF91e TvL1fhGuV97nzBE9K5bJUTi2xeCR7uLmPBPUoJMtdIFufX38NKBRhvoVU6rCLTWHCRITcO87bf/ iSU0nVYtyknDcFt2kPMxj7rJAji1scDTp52da6R0/4K9lnE6y83ozOcqyFjG3M61xSnD7tvDSyM eq30c0uOjxFDgDDgRQ/ye7p4wGXlTP+bv7HPDPGS1srnI+rHduQsmQ5XzjB1IUhKAKUde2Tc8yT 0y6wR2QfggZoRMQJJVA== X-Proofpoint-ORIG-GUID: bj9u5t_u-HGHc6bh7zf2GlVPdqUYApGk X-Authority-Analysis: v=2.4 cv=EovfbCcA c=1 sm=1 tr=0 ts=6964d159 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=OYYzyx7XpuDNtx8IVW4A:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-12_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601120085 Content-Type: text/plain; charset="utf-8" The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently duplicate code for initializing shared resources such as clocks and interconnect paths. Introduce a new helper API, geni_se_resources_init(), to centralize this initialization logic, improving modularity and simplifying the probe function. Signed-off-by: Praveen Talari --- v1 -> v2: From kernel test robot - Updated proper return value for devm_pm_opp_set_clkname() --- drivers/soc/qcom/qcom-geni-se.c | 47 ++++++++++++++++++++++++++++++++ include/linux/soc/qcom/geni-se.h | 6 ++++ 2 files changed, 53 insertions(+) diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-s= e.c index b0542f836453..75e722cd1a94 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -19,6 +19,7 @@ #include #include #include +#include #include =20 /** @@ -1012,6 +1013,52 @@ int geni_icc_disable(struct geni_se *se) } EXPORT_SYMBOL_GPL(geni_icc_disable); =20 +/** + * geni_se_resources_init() - Initialize resources for a GENI SE device. + * @se: Pointer to the geni_se structure representing the GENI SE device. + * + * This function initializes various resources required by the GENI Serial= Engine + * (SE) device, including clock resources (core and SE clocks), interconne= ct + * paths for communication. + * It retrieves optional and mandatory clock resources, adds an OF-based + * operating performance point (OPP) table, and sets up interconnect paths + * with default bandwidths. The function also sets a flag (`has_opp`) to + * indicate whether OPP support is available for the device. + * + * Return: 0 on success, or a negative errno on failure. + */ +int geni_se_resources_init(struct geni_se *se) +{ + int ret; + + se->core_clk =3D devm_clk_get_optional(se->dev, "core"); + if (IS_ERR(se->core_clk)) + return dev_err_probe(se->dev, PTR_ERR(se->core_clk), + "Failed to get optional core clk\n"); + + se->clk =3D devm_clk_get(se->dev, "se"); + if (IS_ERR(se->clk) && !has_acpi_companion(se->dev)) + return dev_err_probe(se->dev, PTR_ERR(se->clk), + "Failed to get SE clk\n"); + + ret =3D devm_pm_opp_set_clkname(se->dev, "se"); + if (ret) + return ret; + + ret =3D devm_pm_opp_of_add_table(se->dev); + if (ret && ret !=3D -ENODEV) + return dev_err_probe(se->dev, ret, "Failed to add OPP table\n"); + + se->has_opp =3D (ret =3D=3D 0); + + ret =3D geni_icc_get(se, "qup-memory"); + if (ret) + return ret; + + return geni_icc_set_bw_ab(se, GENI_DEFAULT_BW, GENI_DEFAULT_BW, GENI_DEFA= ULT_BW); +} +EXPORT_SYMBOL_GPL(geni_se_resources_init); + /** * geni_find_protocol_fw() - Locate and validate SE firmware for a protoco= l. * @dev: Pointer to the device structure. diff --git a/include/linux/soc/qcom/geni-se.h b/include/linux/soc/qcom/geni= -se.h index 980aabea2157..c182dd0f0bde 100644 --- a/include/linux/soc/qcom/geni-se.h +++ b/include/linux/soc/qcom/geni-se.h @@ -60,18 +60,22 @@ struct geni_icc_path { * @dev: Pointer to the Serial Engine device * @wrapper: Pointer to the parent QUP Wrapper core * @clk: Handle to the core serial engine clock + * @core_clk: Auxiliary clock, which may be required by a protocol * @num_clk_levels: Number of valid clock levels in clk_perf_tbl * @clk_perf_tbl: Table of clock frequency input to serial engine clock * @icc_paths: Array of ICC paths for SE + * @has_opp: Indicates if OPP is supported */ struct geni_se { void __iomem *base; struct device *dev; struct geni_wrapper *wrapper; struct clk *clk; + struct clk *core_clk; unsigned int num_clk_levels; unsigned long *clk_perf_tbl; struct geni_icc_path icc_paths[3]; + bool has_opp; }; =20 /* Common SE registers */ @@ -535,6 +539,8 @@ int geni_icc_enable(struct geni_se *se); =20 int geni_icc_disable(struct geni_se *se); =20 +int geni_se_resources_init(struct geni_se *se); + int geni_load_se_firmware(struct geni_se *se, enum geni_se_protocol_type p= rotocol); #endif #endif --=20 2.34.1