From nobody Tue Feb 10 06:27:56 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C83CF34D92E for ; Mon, 12 Jan 2026 10:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768214927; cv=none; b=kwVd+KvNMyrMeclE+zyla2MFvd24Y8uPCyJyQfmrsxhW2ZIKK6HGjaVUtTUHd3hsDs674+I8azQy7ZXeArTys/TS/qmx1f6+Tyr6S32RjH52o0xHFnk3Ju2jB6KJwbxp59roz4CfSfKxORaQ/nQP2j2ZIt+a5SSUAlavZgAP6kc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768214927; c=relaxed/simple; bh=xDkyBPuRfFQUeONjgjh4SZDmWk1ekP9KQszR2YZ49MA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FTW9CruJioDzxmOyWUebs1kN/xjwmgQDp3L3xreb/eQg4cy3EE9kp03AOV6QsxOnRpj+DUBCqMKMCxP3UDcYbRpNzcgc1EmxPXoY1GFaa2CdZ1Dmy6QlWh5CXmwua0hjQuuXBSKVISdavZYDpJjXtbuxuH6Bs/7Yp/Uw/HPyaiA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JKAfdB4d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gQBRWp/E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JKAfdB4d"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gQBRWp/E" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60C8qvhJ113539 for ; Mon, 12 Jan 2026 10:48:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=DgcATLdadUu BZeeDX28NTXhmDobAIOP7dtiFb52lyrc=; b=JKAfdB4dHfaB9u1ww6gVBJ1Avxt entuwA825HhlBUx+3pWqp70dBCqTUk7jWAQWpHD0WB5T3H1B0FgV1UtDfymIqW2a MWzQzyatvO6aiB0juOs5/UhEJUo9HjoiScskWSQSioKjPHSJry3aQUldRzfNhT4K f6Ru0MDE9Fi2vwJzac0+HBNd4MF2L5HtsBwfqbPNXAj2/dNe1q9ANEh6fI9+r0gy mpd8rK17ylFJ8Q6GjfaJ9s8uPHe47ePbOaigKrQ+IkYgzVTJumnXMm61e2O6iTnr 8vIYvKeI7trN7RJrpZk1xuWZj4e52wBVxWDwEZYJd3j6ugRseuAZbrwQjKQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bmr4uhe8j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 12 Jan 2026 10:48:45 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-81f5381d17dso723919b3a.1 for ; Mon, 12 Jan 2026 02:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768214924; x=1768819724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DgcATLdadUuBZeeDX28NTXhmDobAIOP7dtiFb52lyrc=; b=gQBRWp/E1Rx8LBnWpP/TaY/Cq0UKrpdQ7o9tI8pzPWsqK5vG/fyEIbfow3bTFQ40MJ xaSjBrTlsDP0IkovSGge37duzlS8UMEEMdei+/VkRcCP2/dYQsMg2Hg8vIRgUiB2cPH1 1QlpftashsF/0DyFBPiOgKceRlQ+vY5JQpdeP59IC001Yq14ayKUZRs3KuDD6mTzb5aN kHrHkMi0Nx6yeh7+Hzyyf+/kBgsR+U11IHVyTrrj49sAiy/OiuTRPcbbHgg7gSlSmM8r QB+h9NB8iPUBcln4a0pgoHEnZPQ3yLpvTMQx0Wegl0RtHYHPoEcxvwT6t6ZWZF71fJdo 3uxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768214924; x=1768819724; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DgcATLdadUuBZeeDX28NTXhmDobAIOP7dtiFb52lyrc=; b=Kbql7qLcihEIG0B6TSrsm1W62trUgW5seJNKxkGY6+u3DvUk0WJNPK64S9hF7j2y8l egGh0q5Ga05LOFxvecBjN4WjR6dsvVh1h7psKA0x+x5J9St2QEPj1qXRg04RqEPbYvZ0 RKlknnSAcdnqdZvWBxd4tTcanJFd1IAjQsWESTurA2RCcDfbEM2sknhc2UxM5rTOogMw azPSbvSuh72qIA7UTxjEBxW0Z7RkFsrE4ncQHsDvngjT9n+kGLeJg/WE3aTZs/XkJgKf 8puCPe1/9LJ1nNaPn8A0qGx5ZsLFYQHnUd7fkVwFNB8vTU6BoADAXnQU5jYpNRqUOMAe KeHw== X-Forwarded-Encrypted: i=1; AJvYcCWpkjfqVEgpd8BWEIKFOttGVdgoIkMmfu4Pv905i0wLOl3MZYQbAreGuj4CpWvJid2laqhlJ28kbXpu8KY=@vger.kernel.org X-Gm-Message-State: AOJu0YwALDY+JtWPfOcDE7X1BPbBOFvh5U8zrTDZvSPmO48IXhW43ZCg pniSLdnwh6pSCyFABDgcQngOZ0AN3hAhhiT6rflVD9dD1hS6DqayYC/FPD4EXbj1kHElod2jyAC umSCDlElTVevsPSS3EYbgEBBo0FWUouaWIyQIG1sPEexXI6A4+EakXnQzo4d+DUViR+0= X-Gm-Gg: AY/fxX4mRUCcvDjTQCIkIosgQorBK9cxmchCi0xcB0CWbJAYR0Ccmy7F90AgUW4XF1i 9bd0EmfGrk1L/1UfVP8i1RJzmexFnpXj5nXneubHzbmSbsT5OFZuXtCY2PfN5hnOfAuzZKatBXu fbol4Zyd+w5M2M4zeoaZZXgEOAwmFBPVXirsdDlSVnTX+iBbKNLelH2cCrFQtCQBxhS4ZTv4VM+ +oedp0wm4ODLXg2b0/6ilJqc1wZow3LMxse5BiO/ugzlTqdIH8fv73AoWdm7r/VPCCKY5rdXvpg UkQ6oqD1yZ0VDTPh6zK3oWOILCqS7NjQUgE/AHnhABrl2Nkx+xo5DRK4zCbiYpjxr6Bvse4Aocd d1y/5/WdkQ6gZsO68gCynPviyRjryhAWMHKdaNIZi7FI= X-Received: by 2002:a05:6a00:2c85:b0:7e8:4471:8d9 with SMTP id d2e1a72fcca58-81b7f6e0b44mr15813976b3a.58.1768214924288; Mon, 12 Jan 2026 02:48:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiy1O1m10aedAjMGwqF5rmnMlSOnYznyA7LCV0CRzi5hXIOLAynz0ndP1rRsqUmnbm0WcHlw== X-Received: by 2002:a05:6a00:2c85:b0:7e8:4471:8d9 with SMTP id d2e1a72fcca58-81b7f6e0b44mr15813955b3a.58.1768214923736; Mon, 12 Jan 2026 02:48:43 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-819bafe9b8dsm17288681b3a.22.2026.01.12.02.48.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 02:48:43 -0800 (PST) From: Praveen Talari To: Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , Praveen Talari , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org, dmitry.baryshkov@oss.qualcomm.com, bjorn.andersson@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com Subject: [PATCH v3 11/12] i2c: qcom-geni: Store of_device_id data in driver private struct Date: Mon, 12 Jan 2026 16:17:21 +0530 Message-Id: <20260112104722.591521-12-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> References: <20260112104722.591521-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEyMDA4NSBTYWx0ZWRfX/lQ/RXubiTX0 Q04GPL84hn8K2m6wZkDGH8UZ55r7Qh5rnN9hhQau/uiGyzXM+Iu0s5ZXch+RClbH+27GxpuH5FO xkgx+mcnaQ2k8UD5IUKGaXplzEoPZM3Iyz1foe1bta+cKcCzTvPWbHIZzzOVEqvxh1QhpZk2KO2 oJPYfgTsbY5/M+rUsHZJcCcrYeNaOUlyrlTFxP8kz85+7FAWpVxE/l0ThZnapBvuJrinRVGPRHP fmxLJJfkA+PG5+xtzILiS140bxojlL9MubFLvXm+ziposq1YRpeF84AZTTfKCOFtM2TnS2ETeDr 5zY0U+bBculB4QIKNr0Y/tDAnDsxKZv9X4mtqqjHU2nrSozoAwzZxTrGJ9m3YbZmMv+6OAFf/m0 e7ThX2iRwLvxnaP7gKqJUibfRFI05UJRn/VHvmT5bJC1PkSUtcWSZ7uy+jpKFVHRgMmtUatkxsO R109azLnJ46QaHYlwyQ== X-Proofpoint-ORIG-GUID: 9SFFA3zOzRO6m_Rke31QCucXax5Q3i_g X-Authority-Analysis: v=2.4 cv=YocChoYX c=1 sm=1 tr=0 ts=6964d18d cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=mUiiJuWc4wU39pmrI74A:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-GUID: 9SFFA3zOzRO6m_Rke31QCucXax5Q3i_g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-12_03,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601120085 Content-Type: text/plain; charset="utf-8" To avoid repeatedly fetching and checking platform data across various functions, store the struct of_device_id data directly in the i2c private structure. This change enhances code maintainability and reduces redundancy. Signed-off-by: Praveen Talari Acked-by: Viken Dadhaniya --- drivers/i2c/busses/i2c-qcom-geni.c | 32 ++++++++++++++++-------------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qc= om-geni.c index b0a18e3d57d9..1c9356e13b97 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -77,6 +77,13 @@ enum geni_i2c_err_code { #define XFER_TIMEOUT HZ #define RST_TIMEOUT HZ =20 +struct geni_i2c_desc { + bool has_core_clk; + char *icc_ddr; + bool no_dma_support; + unsigned int tx_fifo_depth; +}; + #define QCOM_I2C_MIN_NUM_OF_MSGS_MULTI_DESC 2 =20 /** @@ -121,13 +128,7 @@ struct geni_i2c_dev { bool is_tx_multi_desc_xfer; u32 num_msgs; struct geni_i2c_gpi_multi_desc_xfer i2c_multi_desc_config; -}; - -struct geni_i2c_desc { - bool has_core_clk; - char *icc_ddr; - bool no_dma_support; - unsigned int tx_fifo_depth; + const struct geni_i2c_desc *dev_data; }; =20 struct geni_i2c_err_log { @@ -978,7 +979,6 @@ static int setup_gpi_dma(struct geni_i2c_dev *gi2c) =20 static int geni_i2c_init(struct geni_i2c_dev *gi2c) { - const struct geni_i2c_desc *desc =3D NULL; u32 proto, tx_depth; bool fifo_disable; int ret; @@ -1001,8 +1001,7 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) goto err; } =20 - desc =3D device_get_match_data(gi2c->se.dev); - if (desc && desc->no_dma_support) + if (gi2c->dev_data->no_dma_support) fifo_disable =3D false; else fifo_disable =3D readl_relaxed(gi2c->se.base + GENI_IF_DISABLE_RO) & FIF= O_IF_DISABLE; @@ -1020,8 +1019,8 @@ static int geni_i2c_init(struct geni_i2c_dev *gi2c) tx_depth =3D geni_se_get_tx_fifo_depth(&gi2c->se); =20 /* I2C Master Hub Serial Elements doesn't have the HW_PARAM_0 register */ - if (!tx_depth && desc) - tx_depth =3D desc->tx_fifo_depth; + if (!tx_depth && gi2c->dev_data->has_core_clk) + tx_depth =3D gi2c->dev_data->tx_fifo_depth; =20 if (!tx_depth) { ret =3D dev_err_probe(gi2c->se.dev, -EINVAL, @@ -1064,7 +1063,6 @@ static int geni_i2c_probe(struct platform_device *pde= v) struct geni_i2c_dev *gi2c; int ret; struct device *dev =3D &pdev->dev; - const struct geni_i2c_desc *desc =3D NULL; =20 gi2c =3D devm_kzalloc(dev, sizeof(*gi2c), GFP_KERNEL); if (!gi2c) @@ -1076,7 +1074,7 @@ static int geni_i2c_probe(struct platform_device *pde= v) if (IS_ERR(gi2c->se.base)) return PTR_ERR(gi2c->se.base); =20 - desc =3D device_get_match_data(&pdev->dev); + gi2c->dev_data =3D device_get_match_data(&pdev->dev); =20 ret =3D device_property_read_u32(dev, "clock-frequency", &gi2c->clk_freq_out); @@ -1215,6 +1213,10 @@ static const struct dev_pm_ops geni_i2c_pm_ops =3D { NULL) }; =20 +static const struct geni_i2c_desc geni_i2c =3D { + .icc_ddr =3D "qup-memory", +}; + static const struct geni_i2c_desc i2c_master_hub =3D { .has_core_clk =3D true, .icc_ddr =3D NULL, @@ -1223,7 +1225,7 @@ static const struct geni_i2c_desc i2c_master_hub =3D { }; =20 static const struct of_device_id geni_i2c_dt_match[] =3D { - { .compatible =3D "qcom,geni-i2c" }, + { .compatible =3D "qcom,geni-i2c", .data =3D &geni_i2c }, { .compatible =3D "qcom,geni-i2c-master-hub", .data =3D &i2c_master_hub }, {} }; --=20 2.34.1