From nobody Wed Feb 11 02:09:09 2026 Received: from mail-pg1-f225.google.com (mail-pg1-f225.google.com [209.85.215.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D624531691C for ; Mon, 12 Jan 2026 06:49:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768200548; cv=none; b=V0EQC8Whx4UXvctifw0a6QUWzUjjuhzbUCgJ3SZL/klLNTD0PIdPB1UZBaKQEa4hGZffC1C2uxIL8ycEvmUXsOSmDUpHiD11uxJABeslWOeoSpGq2BIOQWht+XWc3Rra8dSEHd9RHi6dTF+KjZa+hPU0vGnv4ZcJ1IJ9XqfkTkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768200548; c=relaxed/simple; bh=/NupvgywEukBz4QryS1IcnmPfJQHRj4TZPz9BZQSMgM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=day0fsLmbh2iSlNao9QarpGMESMz3VhS/Ul2W6WqIRXR6HLkDBkJVNWwsYUVCvLa+edaBcVDB0mByFgUB2nV7Kq8c9NIdR84/L/eMiKGUmgjYU2P0XKRYkPkLxOkLUWHaK0VhHwWpoEXVuj8HtBaV8jhWE2iQru4fnVjS2FydDA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=HULDzgV0; arc=none smtp.client-ip=209.85.215.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="HULDzgV0" Received: by mail-pg1-f225.google.com with SMTP id 41be03b00d2f7-c1b5b65f832so119050a12.3 for ; Sun, 11 Jan 2026 22:49:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768200544; x=1768805344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jPMqt7OubTukSzfJGmFa7NplH3SyhzWtPIziyN+vzQc=; b=hcPY8HKCJcZtja4D/gssumyc5ZESvitrEJltUmlVheJb17uD0gOdUPz/ZkUBN8+6g3 JtC0n64UAh9nRgG/dSknjpxPOauhuZfjJHv8KPZV7aos8dzjZaWnqpSRMIQGU4FbJjVq MH1w6AWDL5sKSVGiC/RBpYAX7vcgYQWP5Tbns8jXl1KK1/luaOd/lqViuLXLUtBaRf/4 /7cTqxCdZXzqCxmZZskJ07Q1dz5+ux94dMHS4qZUI0EJmzojVyJtSp6bbiiSWNSoknDW 7i5RmTLUQ7un7rHXigUgyAxhElMrg4SajgRfxnKX5NHl89+dRHwTcaOVi5Y9NwyjkeTX 7yxQ== X-Forwarded-Encrypted: i=1; AJvYcCUlz6DKOrJd8iNWCRvdLiEnEFu4JjD8Yyyk1PWfpT14xzBCDnNxYImyBbk+TCVaBtElY9TznKVbR4FpNQY=@vger.kernel.org X-Gm-Message-State: AOJu0YykAAHZqKjlV4EaeuFSMa2NaK318D4QRhdb0V7BfJ99gd0kH8RE 322H+UNjjMkVjN0yWMIeqP4VgCFGRcmbZdCso8ME4pK7/AvlzsUN6eCnTHAjOv7zGCvtm4VQw6t jAjvn2HufkG8+490Vwf+z/SH/lq3P3p1uNQ/qFq7jxmp0nso1grjuA/PEkGghcdkO7m2G5QnpN7 z0PHWNquV2xyI9HajfjKLkCzgQk/V73qylxmsxZAs/UcigM3QwBt8/FUkWw3EmskkcviB0oK9Nf OQ4qz5Iqpdz3QFatKA3662xa7SWXSx/ph7XpVI= X-Gm-Gg: AY/fxX4DOrwaHIUpDMbxlypdsYVR9MgXIyugKVwHWz1FzGr7/8WY6pPRXAf5ixdJCQU BQh9B+MOxgqgw6jRAteAGJ/lGWHImDeabTI/mQ8XP2XO8eRD9iQUag5euFTv5khzrR5l7RzsDAg gPdEIWwA18qcM2SImRIXspSGsMtuZK00Jsk5QEzkBajTbnwRkvqkR+Lw+9IrI8lQdVGtA3qbvMm CC812jOpWCQmmgS8WIeooADOcfa2VmqAShcmn3fWDP6lNt895aQcdTt4nSNl+HPomN8h6EtTfAt OCnDnHBa2KnB2BkDX5Ae1QaFfiWIq6sxDPXCxvw2LJVC89tGslYvkGAroqofFmBGAYYJsbCgwyK kmlJFaLIS1AbsNOdzyL3Z45ZkXqac/HpGgJC0j3IWFgC1tEX11mSw7VVHm3t38UK/JtkA3I3+S6 4nLE940+hiHobQuLrbfIyFBhTdDAH3vHcEy/AG+wLQLpOfAzmZWsHJO0a54j8= X-Google-Smtp-Source: AGHT+IHyp3XZsMgXVPtkh/JwofZU9aEnXPAGhKKRWZ8yzwTianx/aaAAYxY6RtFXb5eTNRVQQQtKkw7rmwQc X-Received: by 2002:a05:6a00:2294:b0:81e:baa3:1fd6 with SMTP id d2e1a72fcca58-81ebaa3233dmr4911661b3a.4.1768200544058; Sun, 11 Jan 2026 22:49:04 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-2.dlp.protect.broadcom.com. [144.49.247.2]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-81f3cac3bdesm787118b3a.6.2026.01.11.22.49.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Jan 2026 22:49:04 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-88fd7ddba3fso24055696d6.1 for ; Sun, 11 Jan 2026 22:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768200543; x=1768805343; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jPMqt7OubTukSzfJGmFa7NplH3SyhzWtPIziyN+vzQc=; b=HULDzgV0xNjjSDM0vQDvUI6wFElpZDOEMzhjLyc0Zk2D0LMSxBEPRLi4ELVQC2Zckj +t0+mYjt0a+14Ys/HHcXrEkZecSP7mRKLNoLAbvQ34qFg1tmnQlWVTfUaw17GkjwMuvP tY4Ic7ug4kHP2ApvIjskPOrgGh9/eHxqAw+/M= X-Forwarded-Encrypted: i=1; AJvYcCWQT2l/aZBrGZQvpUvE2sfdcrBXEmUVJK2pn7gq31VpiD3Glk7B/aJhyoIBLJjgGMz0yk6UB3LsfJHir9c=@vger.kernel.org X-Received: by 2002:a05:6214:2481:b0:70d:e7e1:840f with SMTP id 6a1803df08f44-890842cb736mr185047226d6.3.1768200542666; Sun, 11 Jan 2026 22:49:02 -0800 (PST) X-Received: by 2002:a05:6214:2481:b0:70d:e7e1:840f with SMTP id 6a1803df08f44-890842cb736mr185047146d6.3.1768200542333; Sun, 11 Jan 2026 22:49:02 -0800 (PST) Received: from keerthanak-ph5-dev.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770e472csm131125426d6.23.2026.01.11.22.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 22:49:01 -0800 (PST) From: Keerthana K To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org, borisp@nvidia.com, john.fastabend@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Kuniyuki Iwashima , Sabrina Dubroca , Sasha Levin , Keerthana K Subject: [PATCH v6.6.y 2/2] tls: Use __sk_dst_get() and dst_dev_rcu() in get_netdev_for_sock(). Date: Mon, 12 Jan 2026 06:45:54 +0000 Message-ID: <20260112064554.2969656-3-keerthana.kalyanasundaram@broadcom.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260112064554.2969656-1-keerthana.kalyanasundaram@broadcom.com> References: <20260112064554.2969656-1-keerthana.kalyanasundaram@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Kuniyuki Iwashima [ Upstream commit c65f27b9c3be2269918e1cbad6d8884741f835c5 ] get_netdev_for_sock() is called during setsockopt(), so not under RCU. Using sk_dst_get(sk)->dev could trigger UAF. Let's use __sk_dst_get() and dst_dev_rcu(). Note that the only ->ndo_sk_get_lower_dev() user is bond_sk_get_lower_dev(), which uses RCU. Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure") Signed-off-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Reviewed-by: Sabrina Dubroca Link: https://patch.msgid.link/20250916214758.650211-6-kuniyu@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin [ Keerthana: Backport to v6.6.y ] Signed-off-by: Keerthana K --- net/tls/tls_device.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index 4f72fd26a..55b46df65 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -125,17 +125,19 @@ static void tls_device_queue_ctx_destruction(struct t= ls_context *ctx) /* We assume that the socket is already connected */ static struct net_device *get_netdev_for_sock(struct sock *sk) { - struct dst_entry *dst =3D sk_dst_get(sk); - struct net_device *netdev =3D NULL; + struct net_device *dev, *lowest_dev =3D NULL; + struct dst_entry *dst; =20 - if (likely(dst)) { - netdev =3D netdev_sk_get_lowest_dev(dst->dev, sk); - dev_hold(netdev); + rcu_read_lock(); + dst =3D __sk_dst_get(sk); + dev =3D dst ? dst_dev_rcu(dst) : NULL; + if (likely(dev)) { + lowest_dev =3D netdev_sk_get_lowest_dev(dev, sk); + dev_hold(lowest_dev); } + rcu_read_unlock(); =20 - dst_release(dst); - - return netdev; + return lowest_dev; } =20 static void destroy_record(struct tls_record_info *record) --=20 2.43.7