From nobody Tue Feb 10 05:46:11 2026 Received: from mail-yw1-f226.google.com (mail-yw1-f226.google.com [209.85.128.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BFA4311C01 for ; Mon, 12 Jan 2026 06:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768199941; cv=none; b=CmcXQELYeL98uo3o+yqcigvPq047gqjN7dBt630q56PCeGAWuOsLSVbaq0NEtdIscRYfoBayNtNogaAQWoraQr/PhxVeyL31LVJLg+J+W+sPXuAVc7ggx1EDN/4k4n5nMRph3WBxOuiIIpLkZnJoY0/w/xUHMX8QgJCSa8dW9mE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768199941; c=relaxed/simple; bh=XjmEkDhy70C9BPaUIKs8e1nglyFuMhkb7Yn1iqBTdVE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EJHKH+n6hleASNPLERdiAd1K/nsNsG/1lc3FgnfwZO9/hWyydqvQskEoK2Jd4b/z+GMVmgS4t8oXuz1btg8A+Sm99QITbKIPmudw9mJ67kjwiAAvzFdlsSENVQVPkdD5tG8vxZq6ogvygLGlqNT5lCoUxuc3CZzpT9aZnRNePAE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=T6ThGJ9F; arc=none smtp.client-ip=209.85.128.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="T6ThGJ9F" Received: by mail-yw1-f226.google.com with SMTP id 00721157ae682-790633e6491so3698317b3.2 for ; Sun, 11 Jan 2026 22:39:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768199939; x=1768804739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o/toLEsajSo6fO5hRJUdPGrIZ19DquBDTOLbcgJFlJU=; b=qa/rDRDckAflv1pQN8b3X4pj9dEFvKa1ZpZTKX2o2XsMh//HbnbQ0F+wtb5T6OAor1 3hG9YAt764HOiK1sYEV+w08/dnan62drW8FRxNpvNuRAWf2r06kSNv7+PbF3kBWKxFor CYoSs52T5BPbXWGsHLFkZlGzs0fYK6TE2meFN1fUYD9De2dLWyIjrFwIi/urxlTzhifx QEtwO1sQh3RObncACI4+j2mmce2oJOsCL+CDXfrga17dsEcYaXmB0MiKbOairTlAShrW fOA3nGydBV/7Nl3drS1AG9Qh+LzTtEcjMBQk0feXIqlybIc4WcEOvBTwnTI/0uvGIZFs BNqQ== X-Forwarded-Encrypted: i=1; AJvYcCUzhmEcBGRE180zd/hS8GoYy3SQPXa4HFBY79j4qmv3e3Skz5qAbo4AbEEv9MNcFmudYWcmQ0Qd6Mkmmrc=@vger.kernel.org X-Gm-Message-State: AOJu0YxBRdSF3839UOKSrOa+aclkpJvCHxd58IetrrqR4vq4wYqFyq9B kfWo0gDnqU+ySXI9cLitWNoDiZvbmSleljWPbZlFCjgjM6L38zR7/HGlyFZmA3U+DV+Ui+Uw8P1 FRZbN3Re9NJhbDTKYh4pptzlHavyFPFhDng26i48IMoxYLmzdxFcOvrh9ZQuRTfe1nhR35JBZKU BU8foNYoIJf72oAcEjWZHHEPSYk/xjzkUsuh5/vKzW9W6zcPuN801Id6r7UWaLaoVgoUDc4Z+Kp G7Rv6P7F4NvvPiDNqCs62viHMJjwShYQPPrdNA= X-Gm-Gg: AY/fxX5goeTeKLeXzVUYBI4k7o5NtWLFi6FS8giJcIxpH0PAjUbGVgMuyRZe+dTGpoO nOZSJpcBwrYMtJNsnP31mjuItXuvEAywHqsnFfDjLyHY6b6v9mMakd1rTGb/E3WYNlJFZ5z+3Gj nOHUJhlqnWBFZ097fYQ7pLQSbZw/yqqczA9lSsAXcpGKEEfFzZI5mmKnA/sE41NwtxrK13skm7l ANkYQYaNNGzsZQW36HLwSO6qmTbziGjWljr0muyNGAQ8GI1PDQAKjtpQtDPRpIwndK+yEEUiyT1 ikxnSDJoHjLeK+XTvBAs3xeDGBSlYSFG+RoP5H9v/XNjZ4wObKWppkwrKmpkvVUswm2AlIzBmXX 7RIW3AquwDtEq6gw++BDWbWZJXtjHmxxWpsU4O+hq/4dRUfh5BFj+RpJIBmFTB/dahJShlo9zQ0 d9XWoRTmbIfzTYgIvIFQSrzzlpl4ZyEztOkSLcL3uEtlEWiYOxvuKCOGWUcHHl+6Gh X-Google-Smtp-Source: AGHT+IF3C21x257t146ZILOOy3OIYZb0lHnKJB9KX7tbn6f8IikEhQWQ4tMJmMxntuqJuxxrCfronQaa8Ekl X-Received: by 2002:a05:690c:a4cc:10b0:78d:6aae:9cf0 with SMTP id 00721157ae682-790b570180bmr102970977b3.9.1768199939196; Sun, 11 Jan 2026 22:38:59 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-118.dlp.protect.broadcom.com. [144.49.247.118]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-790aa6b2b23sm12821737b3.16.2026.01.11.22.38.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Jan 2026 22:38:59 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ed83a05863so21199851cf.2 for ; Sun, 11 Jan 2026 22:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768199938; x=1768804738; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o/toLEsajSo6fO5hRJUdPGrIZ19DquBDTOLbcgJFlJU=; b=T6ThGJ9FNIC6rMU07ILVmsrUuHVwUkSiQ2lPUMoR+OPEv1PV94ggUYzce+ft5+IO+o Krwe3l543dqa6cfVGaLTs/DI4NsFjmrGdverjfdZa94qmiQA1gfXIj4fCpHZhMD8kMJM H9CzfCEuj9pY6D3IRtrdJwYK/Ged64JSoL1yY= X-Forwarded-Encrypted: i=1; AJvYcCXkHLpfbxdJ65Q2PinOoYgc+nQOEF/lp1hiRXTK3ckiH/VmZ2kVjg2ue8m9ibXdmdfwD77owvri2gidQ6I=@vger.kernel.org X-Received: by 2002:a05:622a:408:b0:4f1:d267:dd2b with SMTP id d75a77b69052e-4ffb47d22b1mr178117461cf.1.1768199938525; Sun, 11 Jan 2026 22:38:58 -0800 (PST) X-Received: by 2002:a05:622a:408:b0:4f1:d267:dd2b with SMTP id d75a77b69052e-4ffb47d22b1mr178117401cf.1.1768199938113; Sun, 11 Jan 2026 22:38:58 -0800 (PST) Received: from keerthanak-ph5-dev.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-890770e2833sm126594216d6.18.2026.01.11.22.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 22:38:57 -0800 (PST) From: Keerthana K To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org, borisp@nvidia.com, john.fastabend@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Kuniyuki Iwashima , Sabrina Dubroca , Sasha Levin , Keerthana K Subject: [PATCH v5.15-v6.1 2/2] tls: Use __sk_dst_get() and dst_dev_rcu() in get_netdev_for_sock(). Date: Mon, 12 Jan 2026 06:35:46 +0000 Message-ID: <20260112063546.2969089-3-keerthana.kalyanasundaram@broadcom.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260112063546.2969089-1-keerthana.kalyanasundaram@broadcom.com> References: <20260112063546.2969089-1-keerthana.kalyanasundaram@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Kuniyuki Iwashima [ Upstream commit c65f27b9c3be2269918e1cbad6d8884741f835c5 ] get_netdev_for_sock() is called during setsockopt(), so not under RCU. Using sk_dst_get(sk)->dev could trigger UAF. Let's use __sk_dst_get() and dst_dev_rcu(). Note that the only ->ndo_sk_get_lower_dev() user is bond_sk_get_lower_dev(), which uses RCU. Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure") Signed-off-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Reviewed-by: Sabrina Dubroca Link: https://patch.msgid.link/20250916214758.650211-6-kuniyu@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin [ Keerthana: Backport to v5.15-v6.1 ] Signed-off-by: Keerthana K --- net/tls/tls_device.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index c51377a15..e79bce6db 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -125,17 +125,19 @@ static void tls_device_queue_ctx_destruction(struct t= ls_context *ctx) /* We assume that the socket is already connected */ static struct net_device *get_netdev_for_sock(struct sock *sk) { - struct dst_entry *dst =3D sk_dst_get(sk); - struct net_device *netdev =3D NULL; + struct net_device *dev, *lowest_dev =3D NULL; + struct dst_entry *dst; =20 - if (likely(dst)) { - netdev =3D netdev_sk_get_lowest_dev(dst->dev, sk); - dev_hold(netdev); + rcu_read_lock(); + dst =3D __sk_dst_get(sk); + dev =3D dst ? dst_dev_rcu(dst) : NULL; + if (likely(dev)) { + lowest_dev =3D netdev_sk_get_lowest_dev(dev, sk); + dev_hold(lowest_dev); } + rcu_read_unlock(); =20 - dst_release(dst); - - return netdev; + return lowest_dev; } =20 static void destroy_record(struct tls_record_info *record) --=20 2.43.7