From nobody Tue Feb 10 16:21:33 2026 Received: from mail-pj1-f99.google.com (mail-pj1-f99.google.com [209.85.216.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DF9630E0D4 for ; Mon, 12 Jan 2026 06:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768199648; cv=none; b=BNqeBB3vd654ngny5/Ztmb0z8AnhqlxaQC0oL9XrP/HPYs97nJuY5rDtX1DD4/Tw16qxd6ErJ/HW6qG2o9pbLra/ZO2+S9icQPPuX0zsn5L/QOqxlexMfLSa3oIG5vyhpeGDBxDr/O09AO4lL2mmkS+X17QQzwg6sjR8ZFM2b0o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768199648; c=relaxed/simple; bh=QgXU/7yNwhrctzlcitKYbDUmDIC7I+TCoOtStmFwLvY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lNCaBGsoz/Kbhz4I7klIXBsoY4wXPBOL0rpTWwLwRlW0bQND1Dsm09nddATFCD/uEBa1O9jBb2+EeyMMqMPm0p3ESy0uEOFG14fkFEE1vnoEEXcw3/E8vr/4U8Gr0SabudB2YVeVBawg7V0P1V1qH5RNyHj4i2oVnLsq3iWyRmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ThAgV2pu; arc=none smtp.client-ip=209.85.216.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ThAgV2pu" Received: by mail-pj1-f99.google.com with SMTP id 98e67ed59e1d1-34ab8682357so603998a91.2 for ; Sun, 11 Jan 2026 22:34:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768199641; x=1768804441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fj8sUP59dWob41aCsZ9BHl56sg70okF+kqjbtKr6YBw=; b=le5plKeeoQM3xzLMDfws0curfNONkggqj0cWN/uZslWVIr1H5lfmvNsSs7z41VIhoC 5AbCJXil+GjbfbVDgui0DAG3WnygJ67DM5NwiHQHG4gke44fiYY46Em6+ZbkxbNAoZJN H6FfhzKDA6rcYCC315kQIRk206R1D7X4QdqH1GRUyew/e9HI9JffOzyKxyTRq/Tpv0tE o6zidlheg58Pq+zFvP6Ms64vPLmJ30VOeJdsc8D0+Dn4EJGnVg7af97WqGlrKmkJFi7k 4q0hCtB5xrhK2A65VdyOEaek7+PF9eUNFRFkWVNu/mGBfqFw+grcBXL7r7DpSJ3On9HB InXQ== X-Forwarded-Encrypted: i=1; AJvYcCVGqYDMsmga7NhtSQJaTiosnltG+XA4MR4c/zZn3zJ53MKtJ7RmIMXA9GtGyQ8OkA/pR+18XV9b7Dy6W5Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwkXS6nrXyzMbAYs5b46t8ZDuCuC+zkb3GI4Q2oMYQdtmqTnOj9 XDka0yFwUAfqxapvIHokFYL8LAqLsHC/5PfSkNVNBeNKGYAR4vfPbkH/Ta6fwt3V9/SjvyVE+ox gvYgp19VHmFVzMIGqyzMkBoFQWqfAkPa6KiJu+hOt8sA0FZArc0Vn/wiNoGk3uKV9hjjoXjKi7r rDj7PFI1KphwnKzG7FjgyiYW6POhMThuhm4vWWX/lCD5XG/XOlorsolPjC36UD0WL3y6D0Z0FFy GrL9nfCRmnpfp0rmwpCUhcAUBYmz8Z1qbQfEoI= X-Gm-Gg: AY/fxX7znjFWjVugPsBSBqpO6YZ5Q3+e305yNbAbJWKKv6yGTen/IikfTnQfo33TxKf xhNMQ2a9L69F6+0LrpqcWQUhECVzs7PxyVKA7swU6tfeGyP5Lf1YNKU+k5YMPOnBAw1eLfwIClD z5V03M9rZvlwrM9OA2Ml9szA3xZA5bpeqO2LfySVsIzUd3rrczjzecTzmClSMZ4oD/f/blabaxU FWW3MXAO5IrObhohtyN8LhmNg/fXn9w1KKzDzXqfz+Tgow019b11FhbajqARoPekjE/591ZM1dE xC07JA6zTFZqnWjkRF7axSu/3yZKQiwuj6R7wl8nT0APzh26blna25x4ZvLN0GJ279yRh0FVymk z1l6cjUaJJ8fI1RiBOGgSSGJvUt64IXCQYSKeIY3m6Gef8M1MXA2Pb5O7kuSAbdtNaKuST6jeix RpA/YiKKQC8bUcaFDPA65nNrDEw+5JrpAYnW+U7kyMNW5XzKFag+nIyNDbP1k= X-Google-Smtp-Source: AGHT+IHy9IySVWDzx9n3dDnc5x/e0DCfuzlnVzYY7sG3SSO97+dS1cpuptB+3rAFDrfv2Do8rBHl93wqNLVJ X-Received: by 2002:a17:90b:57c4:b0:340:bca2:cf82 with SMTP id 98e67ed59e1d1-34f68ca85f3mr10332680a91.4.1768199640995; Sun, 11 Jan 2026 22:34:00 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-2.dlp.protect.broadcom.com. [144.49.247.2]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-34f5fad00b8sm2344350a91.2.2026.01.11.22.34.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 Jan 2026 22:34:00 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b10c2ea0b5so208460185a.0 for ; Sun, 11 Jan 2026 22:34:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768199640; x=1768804440; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fj8sUP59dWob41aCsZ9BHl56sg70okF+kqjbtKr6YBw=; b=ThAgV2pubm4Q7pp3q9FJDD2nM3KMDZhJFl7CqmIgihg7TH+444o1HybUOpKBLqZD3+ nL4uRVC4EoCVe1XcLuoRra1iGqciBAevz393+GAUWs9RYsK9Ssik64JOSGZmwHv1o8nU VeV83qVSIoBKyUDZfMlbbWO+AF0+L9W9fKRuE= X-Forwarded-Encrypted: i=1; AJvYcCXiF4d14j/mj4WxMeHgxjXsc6oZ8RrXu3jOY1bLTwr56x4QbzjRCfa16dgOnlQkZ4Z5onYG9HLdQb/8UsU=@vger.kernel.org X-Received: by 2002:ad4:5c48:0:b0:880:52f6:775e with SMTP id 6a1803df08f44-89084275c91mr188503696d6.6.1768199639725; Sun, 11 Jan 2026 22:33:59 -0800 (PST) X-Received: by 2002:ad4:5c48:0:b0:880:52f6:775e with SMTP id 6a1803df08f44-89084275c91mr188503536d6.6.1768199639235; Sun, 11 Jan 2026 22:33:59 -0800 (PST) Received: from keerthanak-ph5-dev.. ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f4a794bsm1472324885a.9.2026.01.11.22.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 22:33:58 -0800 (PST) From: Keerthana K To: stable@vger.kernel.org, gregkh@linuxfoundation.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, yoshfuji@linux-ipv6.org, dsahern@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, borisp@nvidia.com, john.fastabend@gmail.com, sashal@kernel.org, leitao@debian.org, kuniyu@amazon.com, willemb@google.com, jramaseu@redhat.com, aviadye@mellanox.com, ilyal@mellanox.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com, Kuniyuki Iwashima , Sabrina Dubroca , Keerthana K Subject: [PATCH v5.10.y 3/3] tls: Use __sk_dst_get() and dst_dev_rcu() in get_netdev_for_sock(). Date: Mon, 12 Jan 2026 06:30:39 +0000 Message-ID: <20260112063039.2968980-4-keerthana.kalyanasundaram@broadcom.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260112063039.2968980-1-keerthana.kalyanasundaram@broadcom.com> References: <20260112063039.2968980-1-keerthana.kalyanasundaram@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" From: Kuniyuki Iwashima [ Upstream commit c65f27b9c3be2269918e1cbad6d8884741f835c5 ] get_netdev_for_sock() is called during setsockopt(), so not under RCU. Using sk_dst_get(sk)->dev could trigger UAF. Let's use __sk_dst_get() and dst_dev_rcu(). Note that the only ->ndo_sk_get_lower_dev() user is bond_sk_get_lower_dev(), which uses RCU. Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure") Signed-off-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Reviewed-by: Sabrina Dubroca Link: https://patch.msgid.link/20250916214758.650211-6-kuniyu@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin [ Keerthana: Backported the patch to v5.10.y ] Signed-off-by: Keerthana K --- net/tls/tls_device.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index 8e89ff403073..8cf4e1651b0c 100644 --- a/net/tls/tls_device.c +++ b/net/tls/tls_device.c @@ -113,17 +113,19 @@ static void tls_device_queue_ctx_destruction(struct t= ls_context *ctx) /* We assume that the socket is already connected */ static struct net_device *get_netdev_for_sock(struct sock *sk) { - struct dst_entry *dst =3D sk_dst_get(sk); - struct net_device *netdev =3D NULL; + struct net_device *dev, *lowest_dev =3D NULL; + struct dst_entry *dst; =20 - if (likely(dst)) { - netdev =3D dst->dev; - dev_hold(netdev); + rcu_read_lock(); + dst =3D __sk_dst_get(sk); + dev =3D dst ? dst_dev_rcu(dst) : NULL; + if (likely(dev)) { + lowest_dev =3D netdev_sk_get_lowest_dev(dev, sk); + dev_hold(lowest_dev); } + rcu_read_unlock(); =20 - dst_release(dst); - - return netdev; + return lowest_dev; } =20 static void destroy_record(struct tls_record_info *record) --=20 2.43.7