From nobody Sun Feb 8 02:21:17 2026 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 558BC305968 for ; Mon, 12 Jan 2026 03:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768187994; cv=none; b=qK8pIy6fw8i6ASSHWqLwIJOat8jK4OBXnXiiJZ4+T4R7AdA6EDF7ZjPw3ofJ27HBog4MinJFl8ECpWLR9zqqbMkxbrWDo88t6pc9hfKAakwQ5eMu1zXymz66pB6NiXEwlr1liyzwsJFsV2QHD52vaYdjBTBJdB8v0Bmit53lJIE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768187994; c=relaxed/simple; bh=RN91yWkWmNRohZ8HHFiKPYzxXK4v+/pvq+4rsJ60dPs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lue1l9/lf347CO2+Mvi45cDn8rcC3GIbmL8QV+Si2cggGQh+8O/S6KF8J4VlT68dttxz12Aw/lbtZAgMIi2HL+YlPNTMJnuCJ3maoM5k7JErOMVoADRY/gH52q6ECnhYY6JUppDuA1fT449nTaNowkobTyw9Ed41B48EoNJhDlQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gJw2fGKa; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gJw2fGKa" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-81e8a9d521dso1091834b3a.2 for ; Sun, 11 Jan 2026 19:19:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768187993; x=1768792793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ugu6idDb+e7+lXIGjO+xVcau9gmwlAzHbI8PVEfCb3Y=; b=gJw2fGKaW4UcLUnf2bIg+Qh3r/bO+q+eYzMsHD0WsSMUr/TpEbmWmv+0FEeiTS2q3w 8ZjlMvUe7vQE5Oi5bCkQF+v/sC+BJMiaOUnxIIyfMfbc/A6RsPbMJGMDA0pa/9fywbrY o5S2mQvx3Pl5n5OPQ0rppA1/vBq6b+N2HvSdE5w+BN7QKeisfAnQmA5nTF8FuAJlt4Xm d1iOV5MSpM9kQOscCn1pn3Tgp5TUwBi80T6Wy5OWGfhmMfJRdN+bULzY2tl2uS2wrGRA /0BP3rOzfBvfK+9+LSt9J13kUs9fFgUrAXNUuxA8wHo/ML9VhUJUZSmBtAIXZBrVc9VO 1Xxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768187993; x=1768792793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ugu6idDb+e7+lXIGjO+xVcau9gmwlAzHbI8PVEfCb3Y=; b=Omwp6fOJAu3UR+t+qOEM3kLmhoD0M+x33eeWARIIbiseNc18FzHnZuUNqWAEFmBqUI WddwT0Oeb98gaMB1ELCZLvxkO3V9cJVylbhVE2QL20P04EQUD16oIZETYHmnInTz7JUd mUa2GfB5McbKeq7VDC9fmUB/056c6b5XDHryJl/X6wYQLDNNLqKeAWXxcMdPE0ox2LdM T/MD+rLf4m+CgqoKCK4czRddlNfi+oqR7tHGKGhvQkZQYLtfy07mGNhQRbA4wXZ5TzRQ HxIv84jRLPjW3j/LZAsPqWuwbCW3HcE3/BPkcI+sdYHGMDTmLn18NUbFEF+8zlUeJbZc mcTw== X-Forwarded-Encrypted: i=1; AJvYcCXzIx8CsKi9o0uGJ76MhBDHRKuloNNIluploZEcH7Ex0VWQdJE3phZYzTQ7nLjW9a+wFcNl8HaEZs3ucx0=@vger.kernel.org X-Gm-Message-State: AOJu0YxID16kuyRoVM0zV1en6ia+GP9upTIO303JOvnGmgjcSDNuMhjt uBuQUo8c4XI1ECrfgYE90jcw+3UtnA65MA4lsh0kpf4HOXNDH82yyb/n X-Gm-Gg: AY/fxX6nKTZtom5AXVfIu08oz5GWqoq7lLhahw2i6C2aFahpOZ1AKaLwrXijSLopMYx ZV8efPQCLRLGOn0Cma7wTwqUFtAZsNm142Guerg2OpwejkiRtc0VMDs+gT+u1ufeQEc6yTRFYqy b3lRFNCiKAyq9KMY9jh02QYmFga+jZqx2cNJ2lnqvBjx6a+/bas/ib4cM23CnrsjXgG+/CuB9P3 lHbskgV6Ft2NVXTMUJsOZwuMsGTmGzGS5it/2YW1tdd96tIDcwRt+qTeLHw5gIO3pZ5Z87ltcJ7 U566yWCvik1/z5zHk7vSn6P3xkLkcNF7kpawmDRTLcu96HRbglrsq3cvPzTtgTZ71vTwhwiNiGe Yr804mj4JLZIoXlQwgK10BDahDyTuWhMtf5g21NDF4t9gZcGhnQKIojXJ0MbUOog9nCyr X-Google-Smtp-Source: AGHT+IGcZK6mPWA6oDBHPkfLpnwCSTkzQjn9CeOs3lAH6csFM6RCBJa44RzzIl8oz1SRi6hHSNZ66A== X-Received: by 2002:a05:6a00:2c89:b0:81e:2b7a:bbd8 with SMTP id d2e1a72fcca58-81e2b7abd37mr7896442b3a.6.1768187992741; Sun, 11 Jan 2026 19:19:52 -0800 (PST) Received: from ryzen ([2601:644:8000:8e26::ea0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81dd5a992f1sm8099649b3a.11.2026.01.11.19.19.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 19:19:52 -0800 (PST) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , linux-kernel@vger.kernel.org (open list) Subject: [PATCH ath-next 1/2] wifi: ath5k: ahb: use devm for ioremap Date: Sun, 11 Jan 2026 19:19:33 -0800 Message-ID: <20260112031934.44839-2-rosenp@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112031934.44839-1-rosenp@gmail.com> References: <20260112031934.44839-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplifies the code by quite a bit in probe. Also allows removing a goto and returning directly. Signed-off-by: Rosen Penev --- drivers/net/wireless/ath/ath5k/ahb.c | 33 ++++++---------------------- 1 file changed, 7 insertions(+), 26 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/at= h/ath5k/ahb.c index cb3e891ee1bd..f34313568d9c 100644 --- a/drivers/net/wireless/ath/ath5k/ahb.c +++ b/drivers/net/wireless/ath/ath5k/ahb.c @@ -87,7 +87,6 @@ static int ath_ahb_probe(struct platform_device *pdev) struct ar231x_board_config *bcfg =3D dev_get_platdata(&pdev->dev); struct ath5k_hw *ah; struct ieee80211_hw *hw; - struct resource *res; void __iomem *mem; int irq; int ret =3D 0; @@ -95,35 +94,21 @@ static int ath_ahb_probe(struct platform_device *pdev) if (!dev_get_platdata(&pdev->dev)) { dev_err(&pdev->dev, "no platform data specified\n"); - ret =3D -EINVAL; - goto err_out; + return -EINVAL; } - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (res =3D=3D NULL) { - dev_err(&pdev->dev, "no memory resource found\n"); - ret =3D -ENXIO; - goto err_out; - } - - mem =3D ioremap(res->start, resource_size(res)); - if (mem =3D=3D NULL) { - dev_err(&pdev->dev, "ioremap failed\n"); - ret =3D -ENOMEM; - goto err_out; - } + mem =3D devm_platform_ioremap_resources(pdev, 0); + if (IS_ERR(mem)) + return dev_err_probe(&pdev->dev, PTR_ERR(mem), "ioremap failed\n"); irq =3D platform_get_irq(pdev, 0); - if (irq < 0) { - ret =3D irq; - goto err_iounmap; - } + if (irq < 0) + return irq; hw =3D ieee80211_alloc_hw(sizeof(struct ath5k_hw), &ath5k_hw_ops); if (hw =3D=3D NULL) { dev_err(&pdev->dev, "no memory for ieee80211_hw\n"); - ret =3D -ENOMEM; - goto err_iounmap; + return -ENOMEM; } ah =3D hw->priv; @@ -179,9 +164,6 @@ static int ath_ahb_probe(struct platform_device *pdev) err_free_hw: ieee80211_free_hw(hw); - err_iounmap: - iounmap(mem); - err_out: return ret; } @@ -213,7 +195,6 @@ static void ath_ahb_remove(struct platform_device *pdev) } ath5k_deinit_ah(ah); - iounmap(ah->iobase); ieee80211_free_hw(hw); } -- 2.52.0 From nobody Sun Feb 8 02:21:17 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02C5430BF52 for ; Mon, 12 Jan 2026 03:19:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768187996; cv=none; b=HLT4j6WjVe5G8fGjMxn0oPQA0K0Ghh+VgMSw0DZBQUUUfP8FiQvks1JhtrOlKb+LR5eeAFCoiQJNOTmLYgruOzP0ZXrWts8E81OXxw7GfIwpukKdujBni7ebqsj17Zmw0lUuRHGKUhWdB52HsNqUmOPr5TsabgOStpQbekAJZeI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768187996; c=relaxed/simple; bh=Yy86ZOwHP8tKFUQ4iASWQV1lG9OuTK8A73uqCISCa+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PUBmfvXZaeb8xjTNyAVh0j/QlNoGX/LHAkPxaIrA6gRLHePZjTgMU/XneotuLDvFLnrGyDs7tUB5RyAGfAlPp2c9KdJDg9YCqsYy4iPWvG/bWs2Y+u3ulZ6LFMxMOdoNTJZMkq4GiDzegDGfL6FWrlQajtL3VY1gl3mSQ9ZvcHk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=R1D/6was; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="R1D/6was" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-81dbc0a99d2so1214232b3a.1 for ; Sun, 11 Jan 2026 19:19:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768187994; x=1768792794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NkwZVaoD5+0zze2LhAa6KpS0108D55pwKILZunGiXdQ=; b=R1D/6wasIye/OrcGo0+n1QdJCZMXoxVsPmhkAeTUawOv9L9LHJylFf/7Ohta3V19ah I9oeaV+CPl9q2QI7HGJAf/EBy5uNhiKQ8Od+KNG9pmdV0aO0WvbcZYa2b9vIO9XcHQCn W10UiFgwApk+Gy1hgSYj+WosglFlaA+xZrlWYXxtlo4YawUn7ITfoR2wHEBUUeUEwB5B KSdgNyTNzDyynCfcKzRqigGjT+FxCoXlTcj5nEa92ZSKl4g/td0/pSbJnhk2etBKUceQ OVhAuONu9EmaoE1qYRzDTaqAUjXZpy2idWtFfHZAqY2kykB78bi6q2JoqxhiBqqA0tID 2XPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768187994; x=1768792794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NkwZVaoD5+0zze2LhAa6KpS0108D55pwKILZunGiXdQ=; b=bDgWE5Dgr5fkbobGoiiQBgiCasQxOEYEBtjqV17pMVr24v4v/55ejGEOLVmwUSHv6V z3TfP2qhuMd9qWnlXxdxWRjtxbLkDrgXop3Is/qk5ZuqpbWqGxW+dl7R4Ge2oAop/O5R Tl7KF6NupB7/QTzNf0uLZiYpavJJ5pk1hvP5OkZdXIMlE/PwKLOwRdr7QB0NP0Fs6nWL zSOY1H+lirDrEeyulOKDBBpdpIuE47j090Ofm4DVLpShEEvOTOfd8SfAGACUdi6FFjmA 6beOC740+CuQZSqfTrEzrFLtz8oYGY2cIYgMu1XeBFAYZPj8NZjrClEMRrYjHSm596cV iRDA== X-Forwarded-Encrypted: i=1; AJvYcCUZZtTEOFGgaXKI9TG8SRI4+q1TqQa5Xbt9rBEyMmqh8NuBjyFXufc/cE0PxsU8ofNnhz9hQd/3e4NmSmI=@vger.kernel.org X-Gm-Message-State: AOJu0YxLp91Ft8SJTH8hL9Kv1VYf9JjdDIi8tHWbbr/MYNaCXm2QIw/5 2irY7xonjsE3DotAOpO9y5ujwBpweGmctVPFwmRNfXx7s5ihimDO0IGt X-Gm-Gg: AY/fxX64OTitDHeJPU1iQEphi3R045ClyPLcUSFbsBw1o5n9/7zQLsjP/Hmf7hM4YVB /FY5LYRdOAP0pIuKkHF16WkFcPP8MqyuIgB3b4Lb+d+9I/oNJtpFMBpa2PBEE88CZglDGo5SnI+ tsk8AeAn9OQSpOnikiMkcNkuy8tgnZSqavOR55wf2xTCS3Ax4CItk0H5Ps0NGlfTMAasMhiGae7 6jEm8hpPUiydagSCVnhvsRXnRRB6RLnh05ivA8cluAfQRiS5xNY4WFVXYVU3p1UwwVlROfh5tq5 T4TnF77DSDj9UPdAr2zs1D/xBXm8R04gbPWIhTsSQxaaYnT2zhUuyqfRwWmHLz/KaAk9rxtTIjT DSSwWpu6RoawWlLczwCGcVLlJ4ATvYGvJQbZAsPbTHD7eTwNxw9ZQOOj8Rw== X-Google-Smtp-Source: AGHT+IGhVYyJ4nE5HkZMAntl5wN21Pv6rFicCjaf03fPixlDv6t7n3azt/PY6PmZxxMLUGnLhuDSnQ== X-Received: by 2002:a05:6a00:4acb:b0:7ff:97b3:59bb with SMTP id d2e1a72fcca58-81b7de5cf80mr14812302b3a.16.1768187994316; Sun, 11 Jan 2026 19:19:54 -0800 (PST) Received: from ryzen ([2601:644:8000:8e26::ea0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81dd5a992f1sm8099649b3a.11.2026.01.11.19.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 19:19:53 -0800 (PST) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Jiri Slaby , Nick Kossifidis , Luis Chamberlain , linux-kernel@vger.kernel.org (open list) Subject: [PATCH ath-next 2/2] wifi: ath5k: set MAC address through OF Date: Sun, 11 Jan 2026 19:19:34 -0800 Message-ID: <20260112031934.44839-3-rosenp@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112031934.44839-1-rosenp@gmail.com> References: <20260112031934.44839-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If defined in OF, set the MAC address. Allows avoiding having to do that in userspace. Signed-off-by: Rosen Penev --- drivers/net/wireless/ath/ath5k/base.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/a= th/ath5k/base.c index 4d88b02ffa79..22ca7e624b32 100644 --- a/drivers/net/wireless/ath/ath5k/base.c +++ b/drivers/net/wireless/ath/ath5k/base.c @@ -59,6 +59,7 @@ #include #include +#include #include #include @@ -2570,6 +2571,19 @@ static const struct ieee80211_iface_combination if_c= omb =3D { .num_different_channels =3D 1, }; +static int ath5k_of_init(struct ath5k_hw *ah) +{ + struct ath_common *common =3D ath5k_hw_common(ah); + struct device_node *np =3D ah->dev->of_node; + int ret; + + ret =3D of_get_mac_address(np, common->macaddr); + if (ret =3D=3D -EPROBE_DEFER) + return ret; + + return 0; +} + int ath5k_init_ah(struct ath5k_hw *ah, const struct ath_bus_ops *bus_ops) { @@ -2638,6 +2652,10 @@ ath5k_init_ah(struct ath5k_hw *ah, const struct ath_= bus_ops *bus_ops) common->priv =3D ah; common->clockrate =3D 40; + ret =3D ath5k_of_init(ah); + if (ret) + return ret; + /* * Cache line size is used to size and align various * structures used to communicate with the hardware. -- 2.52.0