From nobody Sun Feb 8 00:49:48 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B42F1AF0BB for ; Mon, 12 Jan 2026 02:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768184170; cv=none; b=jWZ43uu3MZHP5ik/y4CJ5llfCis1/M2aRnKoCdboyEFa0opWPRJdOsMbGAwBHvsPsZDm8yrGnEBIuWOvyIw5ogf2p2VDkKiI9rHQOcYqMv1IpYUG/NCmaTfa1IHM02A3AHBz+3MiadxNA3U1lwWQ3zfmwp19NLjgUgyIT6n6S/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768184170; c=relaxed/simple; bh=B5FfKozUW0NcIj5zt5YFL5fVXpavwUO2OUM+5DwC5mQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=u9eOdTxCqj1/dUS5WYfvONByuBOKygWojG1fouGAVpIU+D+hWfgCcrju1XEnNSXEJp3wsERBcLAxvl/jbfzDHJndrrQrRcykaF7Ge1hvB36iDCvMsXXBfCtqRuW79hnvp/eR1na7BZqqyRYeY9vLyOtqKt6xlqDtDXBMDMvaMhI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kPkTkZJ3; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kPkTkZJ3" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a09757004cso55074775ad.3 for ; Sun, 11 Jan 2026 18:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768184167; x=1768788967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=t0uAkNpDPiVFicZcGdNzE7rrmCZO2YKCotnRT3KoGY8=; b=kPkTkZJ3XvdSg4b8EBu2dZIu1SimS/8UqEBhdu33rIGtZX2uDUeCR6LbWHVmFf2L4N rNHGOwLYBam5+ZeGagaR0Ox8suJWyRHIOQwvH3KwbrA4LS7JNdEI326AGqHHhNnqkvwQ SKe3ZCXVUVvxGwfP7cjpg44XrJoLfnbKg4453Ryd9wlhPOZdC9CytF2VGiGAWCsIKeRw tjfCr/MBIJOwZRSfWLnf+WBWXtU2JJlp5oOUG0gBNcaw1QAzwSvdoqZnoRWv4Fs3ZXuA QuTaGDIhnXq4wNfsOBFdD7eCmujVQc1j7U24L1ZhEgHnhLImA+tG902XBVA1b9mNuZFT qaLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768184167; x=1768788967; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t0uAkNpDPiVFicZcGdNzE7rrmCZO2YKCotnRT3KoGY8=; b=akAoUfCxyl+0OugY10/5/zQ00jbgpj6V8GG7PudZXDW/FRM4uu3lphAl4/Ps3KlnPg jIrQj+LGxP2xbNgIJyEI8hr2QV0IUobnVT3MPa/5iB47sGzveBKW8HWaX1a6gTLpvxg1 wiPtChXLN5OiM3I59O8A6CaTMVCu/s778VoY6U8IlUIsemVR8qhtSOsfff3dnceqwgjo ZOYgWlecqYBtRfwdRBKhf4rzgq3tT6aQeaQmKyRIpKiF1fJe4rnj9HCBYatAW6OmTi3v Dg3AwNsj5b+dxd8t+NM77T2nxYsfLNqDxdMQIPR8HFu8HdCvbdx01jJmmLyn64fWZyZB 9Lzw== X-Forwarded-Encrypted: i=1; AJvYcCWTXpfVsX1hTrQv+F6IWhvrUmb2MJw1yVVD4w8BuhKCmuHKAokEp1Oi5SJxklWmROxDuVHqw5R/3vW5nOU=@vger.kernel.org X-Gm-Message-State: AOJu0YwLvA7OovpHfMvkEPN0dW0VC7pxg7xv8WuUa4pMeeUkdynXk2sv rw6d2cY952RrPsTU5+gmYQ+VqED02KSRCCZf7S4kpLvznW4QuATMHKAKBiEFdsX/ZNc= X-Gm-Gg: AY/fxX6CYkcarQvVQyyjypr3DP5nUqR1LQbO6FbgiNzmpp+T8fAg1l6PyTTsiatOLTw VI7BrllgAgwQz3PxDa5JLfD/iD7AlumDodvrRTJ5/ymR9Ez3Cq7zVgUhmzFqP+wgX19ofxk9jYq dg/T+DoDOe41ndLvHxwjMjWW4cVN9+wo9VzGAj+5Mj+DDZ+kzm2DTLSQfC26RCGMjv8ajEiON89 DtjdtwwJITGEvBlwU/TXjQT2wdZrxD4aB/WDmVl9ZFad/D9+T/OTRQ9LP+HkMwSpy5X2TsqEke0 qR9WSw2M+67wFsIPLgWINvlvWIN3pVLAJOrxx/NCG6yB+UeMCdt0dqs7yZf2u1dcX+f04yF2ybN PpipsdMujiK9GZVeKfaKFGnloPU+w+gTV9jXDDICEEQFqpf8M2shox42Nt7ACNQf1Y0MAd5cBt0 Jj+u85g0OOPyU449g5Jt8+bzEr4m4= X-Google-Smtp-Source: AGHT+IEwEYcAJq1cetdUP3i6jeooEmEtD3UhltjnVGz/MnuEVRILp5YdBihUyYh2+SQByOom0O2QxQ== X-Received: by 2002:a17:903:2f4e:b0:2a1:deb:c460 with SMTP id d9443c01a7336-2a3ee48ab74mr179903165ad.33.1768184167282; Sun, 11 Jan 2026 18:16:07 -0800 (PST) Received: from pengdl-pc.mioffice.cn ([43.224.245.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c5ce06sm156208185ad.44.2026.01.11.18.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 18:16:06 -0800 (PST) From: Donglin Peng To: rostedt@goodmis.org Cc: mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Donglin Peng Subject: [PATCH v2] function_graph: Fix args pointer mismatch in print_graph_retval() Date: Mon, 12 Jan 2026 10:16:01 +0800 Message-Id: <20260112021601.1300479-1-dolinux.peng@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Donglin Peng When funcgraph-args and funcgraph-retaddr are both enabled, many kernel functions display invalid parameters in trace logs[1]. The issue occurs because print_graph_retval() passes a mismatched args pointer to print_function_args(). Fix this by retrieving the correct args pointer using the FGRAPH_ENTRY_ARGS() macro. [1] https://gitee.com/pengdonglin137/funcgraph_visualization/raw/master/sam= ples/error_args.png Fixes: f83ac7544fbf ("function_graph: Enable funcgraph-args and funcgraph-r= etaddr to work simultaneously") Signed-off-by: Donglin Peng --- kernel/trace/trace_functions_graph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_func= tions_graph.c index b1e9c9913309..1de6f1573621 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -901,7 +901,7 @@ static void print_graph_retval(struct trace_seq *s, str= uct ftrace_graph_ent_entr trace_seq_printf(s, "%ps", func); =20 if (args_size >=3D FTRACE_REGS_MAX_ARGS * sizeof(long)) { - print_function_args(s, entry->args, (unsigned long)func); + print_function_args(s, FGRAPH_ENTRY_ARGS(entry), (unsigned long)func); trace_seq_putc(s, ';'); } else trace_seq_puts(s, "();"); --=20 2.34.1