From nobody Sun Feb 8 10:03:30 2026 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9090E1A724C for ; Mon, 12 Jan 2026 01:54:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768182857; cv=none; b=KlTGCCHaG84kKW6FkUtV8SpaPpTzjn3/eAPeVMo5v7cSvNM5hRMncHES6IzUcKxjK3pFfeIiwv/gw7E5SaVNf6WKvOo90OuXfHT5WHXDBFQYfb1mPlrT8S0IDY2hhvZTVoXLfrqyOpsiXD73ZazFnp/B8D0Tyb4sm82dW+nipCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768182857; c=relaxed/simple; bh=kCD6HRJcmZrPRPRnBZZYRifzn18q6tmbp9qI98+NNEw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=f+d4jpxG+K1WswKwLtuRgFpbtfuEkxH+LsWyqOA9oN2czl1YmH6mfS2CkEAsxphGfOSdOoPLmqp1LdcleQK3Lwkjn+Mk+4c5TLve6qpLYpt1dPtZnEMcycjvUotfVmKK0Tx+SojNFt2VVVbewmWv+/IbhXW0aJrxJGC8eWK/UzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MnP1JrpL; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MnP1JrpL" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-45a7db48c57so2090003b6e.2 for ; Sun, 11 Jan 2026 17:54:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768182855; x=1768787655; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Auu+FpQXOrTqGrm+zeuNScIciQTdgODF3k4zFrtqeoI=; b=MnP1JrpLGCtKqHo/4lAyAgHzxnzDcFRX2OTTzpivbxyH7ORmase9vtG0AX1c2oxPKk oevyCvzoXtNr/LwuUIG81PNpF4BdZxFQs8AfpoLpuYaWv+dLc440Hb+jbbE6fTW/B2ix Jrn9S8CKR4TCjF3KJ7kdWmK+/gfw2oRbQRwxzdpS2U4qwZogWaQvKNef2khAlLheGET4 tvqhXt0SP0vJYNWeo0HI0V+W0qj/5hXPzQEGIyPode11jT4QkEAhytAyLflciRM+TIdn FKGvyJjzbhgsapN7b32urX0VKiLp6dLkXF1aSagLztNRFscY7tnY2HIBXtYZkL8/ON2g lo9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768182855; x=1768787655; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Auu+FpQXOrTqGrm+zeuNScIciQTdgODF3k4zFrtqeoI=; b=Z0+JypyK1WYqSFXsvjKu1y8v92Mj9hXkhEqr+vdd58l4KNQ3x5xADypP9NNYsI20Z8 6JK6M7ntw48KaKw0n4aYIANdl09n0m6sj1o42EJD98X4fuu8cJFSbSJJjKux3wi/1gMM B3qCrssJnyDiWrRMI7Of9xRntxXYqngSwrcWCeW6AVqonbMqxqmDr+Tj+tXhbUHpJl9V M1WhDhajugq+xJzrkEULv67uo6K7N9IbmT4RRGtUlsubKPE7y4qYOOQ3s0fcZ31nNJb1 s1idmSg/20WqMh26iSLX2Lv9c0+ur1BCun2kFp4ETL1xgQTO8o9ZV3VZ0dH00YdLobZL sWKA== X-Forwarded-Encrypted: i=1; AJvYcCX0BsnxgnIfjaNbJDoIR5DpVYAhmlVjFEmECB2ewzIOMxl0DbqBwFESYQ99Ne8CWurCW/9CnSA4FwLcx/o=@vger.kernel.org X-Gm-Message-State: AOJu0YyjfnRBe+11ArmbMtkKvkUdY9u0WayU5YS5jqodwlUzL4wvpvf+ KDvSxz0BaiHIq3ovhj0iSyBr0nfa0Fnca1vrazJNZJBn9XPCqKbIpXaKj1cr4w== X-Gm-Gg: AY/fxX5THDWPp1JPq57gz4FTWdu3FfxNuEfg4eFpL4g7dqyN3erpKablRaL/Mq9/QIa MYpcpGzotbyt26ma3PKCCNjS0No70qfLnc6oL6Ns2JmnxGcHI7oPXvghCL1djiZOplLyaJqmMP8 t/Oa36HD6apsyQq8PauYsA1J0KwOfbc03c1fuv+++SqmzciTTlDGDwjiDc5pp/6FLFq77T0M6m6 szAg/BZOWd4S+wTBkpSs3OP7o7EbQV2i0J9DwLqBjcpvoETCNuPHiEkmxIcZZQiqjZZi1wXWrW1 9M0r98dM9oUHqoAUif2gocP932Dv7uFYaWNSKujXgeKvRzGjM/BiLtaJZXa/3I4bsyxS9Pgul7W r1s/ln7GgVhqLSbdDh9N9Ij62DnzreU6tGsXeNIBQ/mVHhuRTEG8eqfshj33Vz2i+Ch/wAYj5Yj Co3X5hTErGcq3KjSbK8zmgtE4A5k/AAepUB3vnpAyfDcY= X-Google-Smtp-Source: AGHT+IHHe+FujPafjJdj2bFqV/CZm+SjasixzOvOcVsRDushPbttKyEYUrU+geCNc1IKW1DzU3OQzw== X-Received: by 2002:a05:6808:1d27:b0:45a:769b:2157 with SMTP id 5614622812f47-45a769b2a38mr6340991b6e.26.1768182855469; Sun, 11 Jan 2026 17:54:15 -0800 (PST) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 5614622812f47-45a5e1b0779sm7423502b6e.7.2026.01.11.17.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jan 2026 17:54:14 -0800 (PST) From: Jiasheng Jiang To: Zhu Yanjun , Jason Gunthorpe , Leon Romanovsky , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jiasheng Jiang Subject: [PATCH v2] RDMA/rxe: Fix double free in rxe_srq_from_init Date: Mon, 12 Jan 2026 01:54:12 +0000 Message-Id: <20260112015412.29458-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In rxe_srq_from_init(), the queue pointer 'q' is assigned to 'srq->rq.queue' before copying the SRQ number to user space. If copy_to_user() fails, the function calls rxe_queue_cleanup() to free the queue, but leaves the now-invalid pointer in 'srq->rq.queue'. The caller of rxe_srq_from_init() (rxe_create_srq) eventually calls rxe_srq_cleanup() upon receiving the error, which triggers a second rxe_queue_cleanup() on the same memory, leading to a double free. The call trace looks like this: kmem_cache_free+0x.../0x... rxe_queue_cleanup+0x1a/0x30 [rdma_rxe] rxe_srq_cleanup+0x42/0x60 [rdma_rxe] rxe_elem_release+0x31/0x70 [rdma_rxe] rxe_create_srq+0x12b/0x1a0 [rdma_rxe] ib_create_srq_user+0x9a/0x150 [ib_core] Fix this by moving 'srq->rq.queue =3D q' after copy_to_user. Fixes: aae0484e15f0 ("IB/rxe: avoid srq memory leak") Signed-off-by: Jiasheng Jiang Reviewed-by: Zhu Yanjun --- Changelog: v1 -> v2: 1. Move both 'srq->rq.queue =3D q' and 'init->attr.max_wr =3D srq->rq.max_w= r' after copy_to_user(). 2. Add call trace for better understanding of the issue. --- drivers/infiniband/sw/rxe/rxe_srq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/sw/rxe/rxe_srq.c b/drivers/infiniband/sw/rx= e/rxe_srq.c index 2a234f26ac10..c9a7cd38953d 100644 --- a/drivers/infiniband/sw/rxe/rxe_srq.c +++ b/drivers/infiniband/sw/rxe/rxe_srq.c @@ -77,9 +77,6 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq= *srq, goto err_free; } =20 - srq->rq.queue =3D q; - init->attr.max_wr =3D srq->rq.max_wr; - if (uresp) { if (copy_to_user(&uresp->srq_num, &srq->srq_num, sizeof(uresp->srq_num))) { @@ -88,6 +85,9 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq= *srq, } } =20 + srq->rq.queue =3D q; + init->attr.max_wr =3D srq->rq.max_wr; + return 0; =20 err_free: --=20 2.25.1